From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 809C1C5B549 for ; Wed, 4 Jun 2025 12:47:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20CC78D0019; Wed, 4 Jun 2025 08:47:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E26C8D0007; Wed, 4 Jun 2025 08:47:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D1828D0019; Wed, 4 Jun 2025 08:47:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id DD39C8D0007 for ; Wed, 4 Jun 2025 08:47:37 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7CC19C1483 for ; Wed, 4 Jun 2025 12:47:37 +0000 (UTC) X-FDA: 83517694554.10.A40303C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 0A8CA4000D for ; Wed, 4 Jun 2025 12:47:34 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IemsOEaq; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749041255; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nkl2JIgedI+lh+fHfhg8esoPVeYFJN0tO6EBmBp+OMQ=; b=Ej30IAxTQsQUCUUz2rVq3SIy8rcRY7LIK/G4hjusWG5VlTfFzi7yoJemC3F6dCX6XnfMmU OSbVo+VeZH/F+3NvilbCn9sCf3cU5ehG9iYc2Pwqf1GzvAbNIMQrudK/+iySMenml3x99u sNGBEoRx6KfIDbqVYOmG6qPug/Ww+jY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=IemsOEaq; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749041255; a=rsa-sha256; cv=none; b=0m2gQeTjPG2tRvKqy5GbZL4jxKrdMc1prl7U1mknNGrt3umT5LcsdDIsiGcXERlk06eNK0 ubWJkZ1EtwiZh2Sp8QbgrK6PNiaoJcMUGJk9kcYnQKURnD5KDO3eLDzfDpg6QHHtr2CV/S U1+jsf+hOO7+JcIGgh2lfOzIdeS4ak0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749041254; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nkl2JIgedI+lh+fHfhg8esoPVeYFJN0tO6EBmBp+OMQ=; b=IemsOEaqeriTN18KG5F/ui82OQOgJhj07Cq0jp1HpajiWr0djLROTJgqZCLzLUq7qrwJGT iWPoUTHjiK3X1HdY9baeJAAqMkqBvvkpjQY/37L8wSlrQ0cVqp5Gjf7MYmvQRjyQeTNx7E fsMnFjy9Gy+3ErHpLHxXv1vhEHnYwcA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-556-mL1kRdmeMX-jpHV9Ddy0uw-1; Wed, 04 Jun 2025 08:47:31 -0400 X-MC-Unique: mL1kRdmeMX-jpHV9Ddy0uw-1 X-Mimecast-MFC-AGG-ID: mL1kRdmeMX-jpHV9Ddy0uw_1749041250 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-39ee4b91d1cso477376f8f.0 for ; Wed, 04 Jun 2025 05:47:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749041250; x=1749646050; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=nkl2JIgedI+lh+fHfhg8esoPVeYFJN0tO6EBmBp+OMQ=; b=nkFaNZlZOBNzaARrzfui+YZd5rqziiVOrLIB+xHZJJJ7/0nxr0wVp+JUPDEPuAtc4i ptlJMkwL/YfT+g/krKUVDvRtRG54Q/QBTPoI7PTkGf/oygUCPqrvk4O8e/4QTWNL31n8 wieOfnDp7+wS5AHvdPVNU/R+MZc8e9FakaUg8uEu17DTONHB8Qy3WhZXa3mpIrc831n+ IvOXff4QudmR4EEJqod8q3oJcecR3eub5OrPe//a7eyCScXHfwoUmBVdiEOBshZ46hlN 2UU8zyDK93B3OIM0vWtuhYLBO5rffBMXGmr55iGCTNhNDWXCy7QmrTr3ZdtGwqxE3bXh aopw== X-Forwarded-Encrypted: i=1; AJvYcCWkk9I8d18Pzr8IS05vXQHN5UxIPEdF6LSwn7zVqhBy97l4OgelBxzCERf+yOqoppuc19lPNRIGGg==@kvack.org X-Gm-Message-State: AOJu0YzOWj56+rDAkSDISP9OQjQfIJpRfkFnpKT2Z3ZHx1eC5tfVIHh0 jIqDvGIj02x1g3Bb68E4OPbWk3SzF+jtqdVkmQSslKp7X8cT9Aqu/P3EhRqu0lL/w4pI4KyFNdl aG7H3SYQ8WPaH6gb2nB2BF0dL+N3+2jT+VJMd2MQ8tyYUREPKGxqc X-Gm-Gg: ASbGncukO/fbkJO/SAplxVos2PjTQ4BodIOOSuNWL8Ezpk6hW6TOxzNMcZBdNM6gSui OkoyGlucPywmVuXmbhSY7B3nvkXMMQH5+IRM/dyfvMZgJYjJJCxFwLakjIkRA1OhW2234qczq7m 27m6k9qjI5cg1CTh2kyBY76sH7bQTUZywGaRCaQbMAULBPP4pP54Qt20AAJc6M7KJVWJngsOIjY 1K3T02DKIb0fJnosQctPg+l2Fom4dwAEGXspuoBC9EPU6C3FDyD51M4Ad73qbHK0mH1nrYdI7HQ Su4ghHpwkB+V/iytWmuB2I4lfhLEY51Zu5nK7D6blgaRSw3XiolwdAJYg2iN1TV5bk71Jt9E1yL pQbv5iBBRRNVkZuVmoa1lIq/SCYwTKauIfv597ivS/7ZSiZA1wQ== X-Received: by 2002:a05:6000:208a:b0:3a1:f724:eb15 with SMTP id ffacd0b85a97d-3a51d5071a1mr2456918f8f.2.1749041250085; Wed, 04 Jun 2025 05:47:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2ikj7SNZj+e8kpLXQxObBNug4vHxRmdavde46XRKhzFX4HfEx52ROo2DmOQ3b+1NNGe0NjA== X-Received: by 2002:a05:6000:208a:b0:3a1:f724:eb15 with SMTP id ffacd0b85a97d-3a51d5071a1mr2456890f8f.2.1749041249698; Wed, 04 Jun 2025 05:47:29 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf? (p200300d82f1bb8006fdb1af24fbd1fdf.dip0.t-ipconnect.de. [2003:d8:2f1b:b800:6fdb:1af2:4fbd:1fdf]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a524896574sm561497f8f.56.2025.06.04.05.47.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jun 2025 05:47:29 -0700 (PDT) Message-ID: <9a845c21-5cfb-4535-97bd-0b02f5852457@redhat.com> Date: Wed, 4 Jun 2025 14:47:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] mm,memory_hotplug: Implement numa node notifier To: Oscar Salvador Cc: Andrew Morton , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250603110850.192912-1-osalvador@suse.de> <20250603110850.192912-3-osalvador@suse.de> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dEoelegpqKsQnq3cGNaWmUgHlyEBlM5wh_viNx6Hax0_1749041250 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 0A8CA4000D X-Stat-Signature: e1s9artt6m4bjio7jcts9jbppe5rboy8 X-Rspam-User: X-HE-Tag: 1749041254-148187 X-HE-Meta: U2FsdGVkX1+Mv3zlvBGTFAZ9zIfYBHPK4nE8TdDH/ZtCyYzIEvkabl5WScMm7u7M04KloUBz0XcCp7UuT5jVT9x+KnpwjFeRXMMGoQIgBhTSMt4x03d44RO1m8svNP3lR8pTQV7OjWPu1fYRSPZWZNcYOe7GTTTDNRkC+4b+VpTLhOJ4KzsuLaks9NM8B3n4d8+SVZFq7X4ofOuoVEPBX6g+4J09cPweI6zk1Hf7DbbMpLEw7bWS1HL3fYqNHuJVZMYFMmCYr9+2SJsAQ/TNCAT/QW75Gd9/r77OwVH43imuqJM2c6Ezxjm5B6gijylvMKMrKXjZ+J35iur8yWzXw+IsIw6f8MYlzDhRH7NNcmN9pAm1M5zO518Tq1m2WGc+5dpKe70VXAl5JbL2RPBScEJcfbW5rDcD6hca5IOhrFXBQmerNn20OGqtI1Es4F1wD/lVSiQHqQum989xoVts/6Aqzkx77rVc63GQgMLPlPJzHMyy4qWPdnfELSDnf+oHMDpAFmpbNQuaDcy7iWNhNqMEJxok1lTHQJO1qWpqdm1+82M8yAlIg/70Sug9AFOUTy3m0pYEoBAKudXakB1NqELFhg69dXEnF4uSjipZ87K4cic21T0eLXgdcolcx+3Hw4W0Zu73XEMeZ3dthhaxhuYJKuzXrr+4JuhxYQBnszJddsMOjvuE+4TD+kSm/ALn3n7EHRQnT28HaruJHl+p7YNNbfaJjKKigCCrpn77LCm3UwW38TlR3dkMtA9O0UQHOMDumH5rHTRp0eHN/XUFwqbTJxXchsRegmSfAOOj4HLiH4zuA4dmwf/JNpCMVuMiXrCK6qKtG/5qqUBkQZ/MB2dzxjys848MvxYle3AKYNJkh3Qi2wF//qB4qqvRhMuCqcV28y07Sp92d1cqWXi+wAKrzhHDWntNo9d9baAUDBOs+kJH+s29kqEXu1HIHoTWFkQdWXKsanr2i4HxrQ4 ML1HjobC 0qECGZP71/QJmB6x5pLiBsml+I2rKjbWlk+2wyyN0GckLmvsAcoD8qxnHNyU8cm2+wir7lysFJVfNKlhk5zpkpQANk66oJN1Ox7XVhsz/h/wfh0bDhFlgUAOF1zGIUl9mCj+1dZkFdV8FZEHtTEp5nZH/p2E4VisFjYjPFPtNKig/rNeuJ4MqhJYz6nmghKjWZH3CqzDfNNrJap4ThmrSidhQ5HNShT3yjkYIbaQEBAoMxY4y8P5jXfd4C6BTkg9YX5Atx9JHpHwBDVgvA3O7xUYgtvc8G1KzrzGQMMSWXUSUwEdd1SVau5ry1Q5fppDSZ4mtNJ7ZiaDTrN63SVzj97TAnjDVfcPn4NTCPXhtRVYXuONj1v/5z24/i89bG4Odqc6HAvXdLJnbZuUj+FAxa9GErvqeAHi6iE6T/ra4GtqPf5/2jigvJDkTWG3Sxjd78hJq91t9NdNeWCjQMenQ+IZcJHFcuA54CszuNdZxjRhloHaIH1T8mD4KTrf6p0qA414npcNbl/ifouQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.25 14:38, Oscar Salvador wrote: > On Wed, Jun 04, 2025 at 02:03:23PM +0200, David Hildenbrand wrote: >>> diff --git a/include/linux/memory.h b/include/linux/memory.h >>> index 5ec4e6d209b9..8c5c88eaffb3 100644 >>> --- a/include/linux/memory.h >>> +++ b/include/linux/memory.h >>> @@ -99,6 +99,14 @@ int set_memory_block_size_order(unsigned int order); >>> #define MEM_PREPARE_ONLINE (1<<6) >>> #define MEM_FINISH_OFFLINE (1<<7) >>> +/* These states are used for numa node notifiers */ >>> +#define NODE_BECOMING_MEM_AWARE (1<<0) >>> +#define NODE_BECAME_MEM_AWARE (1<<1) >>> +#define NODE_BECOMING_MEMORYLESS (1<<2) >>> +#define NODE_BECAME_MEMORYLESS (1<<3) >>> +#define NODE_CANCEL_MEM_AWARE (1<<4) >>> +#define NODE_CANCEL_MEMORYLESS (1<<5) >> >> Very nitpicky: MEM vs. MEMORY inconsistency. Also, I am not sure about >> "MEMORYLESS vs. MEMORY AWARE" terminology (opposite of aware is not less) >> and "BECOMING" vs. "CANCEL" ... > > Heh, that is why I'm not in the marketing field :-) > >> There must be something better ... but what is it. :) >> >> NODE_ADDING_FIRST_MEMORY >> NODE_ADDED_FIRST_MEMORY >> NODE_CANCEL_ADDING_FIRST_MEMORY >> >> NODE_REMOVING_LAST_MEMORY >> NODE_REMOVED_LAST_MEMORY >> NODE_CANCEL_REMOVING_LAST_MEMORY >> >> Maybe something like that? I still don't quite like the "CANCEL" stuff. >> >> NODE_ADDING_FIRST_MEMORY >> NODE_ADDED_FIRST_MEMORY >> NODE_NOT_ADDED_FIRST_MEMORY >> >> NODE_REMOVING_LAST_MEMORY >> NODE_REMOVED_LAST_MEMORY >> NODE_NOT_REMOVED_LAST_MEMORY > > If I were to pick one, I'd go with NODE_ADDING_FIRST_MEMORY/NODE_REMOVING_LAST_MEMORY. > I think those make it easier to grasp. Just to clarify, these were the 3 notifiers each that belong together. I was not sure about NODE_CANCEL_ADDING_FIRST_MEMORY vs. NODE_NOT_ADDED_FIRST_MEMORY. > > >> Hm ... >> >>> + >>> struct memory_notify { >>> /* >>> * The altmap_start_pfn and altmap_nr_pages fields are designated for >>> @@ -109,7 +117,10 @@ struct memory_notify { >>> unsigned long altmap_nr_pages; >>> unsigned long start_pfn; >>> unsigned long nr_pages; >>> - int status_change_nid_normal; >>> + int status_change_nid; >>> +}; >> >> Could/should that be a separate patch after patch #1 removed the last user? >> >> Also, I think the sequence should be (this patch is getting hard to review >> for me due to the size): >> >> #1 existing patch 1 >> #2 remove status_change_nid_normal >> #3 introduce node notifier >> #4-#X: convert individual users to node notifier >> #X+1: change status_change_nid to always just indicate the nid, renaming >> it on the way (incl current patch #3) > > When you say #4-#X, you mean a separate patch per converting user? > So, one for memtier, one for cxl, one for hmat, etc.? Yes. -- Cheers, David / dhildenb