From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC553C433EF for ; Fri, 18 Feb 2022 22:20:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 09B546B0074; Fri, 18 Feb 2022 17:20:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 04A096B0075; Fri, 18 Feb 2022 17:20:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E2D116B0078; Fri, 18 Feb 2022 17:20:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0095.hostedemail.com [216.40.44.95]) by kanga.kvack.org (Postfix) with ESMTP id D38246B0074 for ; Fri, 18 Feb 2022 17:20:05 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8CC958249980 for ; Fri, 18 Feb 2022 22:20:05 +0000 (UTC) X-FDA: 79157319570.14.7541FC5 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf06.hostedemail.com (Postfix) with ESMTP id 0327D180008 for ; Fri, 18 Feb 2022 22:20:04 +0000 (UTC) Received: by mail-io1-f54.google.com with SMTP id c23so4533745ioi.4 for ; Fri, 18 Feb 2022 14:20:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ov444w7dABSwi4r2TCRkfeEWs8ZARWwEHZMMyU757uk=; b=Z3thpX4xxbk8lHOctIqVlaL3kQYFY35ABYgj/kfvYgFWCEYmingxv9EVu+rMx/tQjn /ETpDpvcQoOHGLF+Sl/1jHS+e/qmN0bQOrecC4myXALsJnGNfeKuGhUkLtqClspb4ow9 xqUDlWjAEt/kE9D+fSbBABDgo4hHcKtK4Wyqw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ov444w7dABSwi4r2TCRkfeEWs8ZARWwEHZMMyU757uk=; b=PfWf4RHRkK6+J/LaWTxk2T49vBcvyMaRwHobzBin4vbJVAPLht/rB+zkSJlGrrpAq8 rf10u0owA25cNoLXr8KE/r25Pa07rrNYNsTV4M5RHYCJ8C8P2LYL8HX9judepxbIJQTm DesadQlw1euUaLSzFZxNUQAug66O0TFA/ujSV6Sk//6HruxAn/TnxRyRutfBCneAqq+G OZ8Cw/qrSTEQhyXtwiD3nZMHFT2NkIHMiY9In4Te1M8ptgr9jKvYLnsBmu0GXbMrynb/ gOmJMueUOu1NhSWT0jjsuxQBwHYVtR6v6tklKE3/TPSQMIzW28kfS+UGJD8nEet227j2 Cq2g== X-Gm-Message-State: AOAM5313YS1hdqP9c0YKsumFT6aRzGMLwiP4jjUuYDKGFLaxstAgQ7+V UeDSaOQw9dssXCNcu1MjszsOFw== X-Google-Smtp-Source: ABdhPJxfIc4uINefXIIAOEstEqIh0Dcy1b30NNFjDj759s3uMDQv1kPuSO3pBM7A7TTq459Qi+j/Tw== X-Received: by 2002:a05:6602:27cc:b0:5f0:876e:126b with SMTP id l12-20020a05660227cc00b005f0876e126bmr7123973ios.129.1645222804355; Fri, 18 Feb 2022 14:20:04 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id o7sm4372727ilu.83.2022.02.18.14.20.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Feb 2022 14:20:04 -0800 (PST) Subject: Re: [PATCH 2/2] selftests/damon: make selftests executable To: SeongJae Park , Greg KH Cc: Yuanchu Xie , Shuah Khan , Markus Boehme , rientjes@google.com, Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20220218082428.11699-1-sj@kernel.org> From: Shuah Khan Message-ID: <9a7f8d0b-3f0f-8584-6c12-423b0d5a979d@linuxfoundation.org> Date: Fri, 18 Feb 2022 15:20:03 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220218082428.11699-1-sj@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0327D180008 X-Stat-Signature: dszqz53f1i37x99ssexb6pjgigb4qzdq X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=Z3thpX4x; spf=pass (imf06.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.54 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org X-Rspamd-Server: rspam05 X-HE-Tag: 1645222804-492851 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/18/22 1:24 AM, SeongJae Park wrote: > On Fri, 18 Feb 2022 09:01:11 +0100 Greg KH wrote: > >> On Fri, Feb 18, 2022 at 07:52:54AM +0000, SeongJae Park wrote: >>> Hello Yuanchu, >>> >>> Thank you for this patch! >>> >>> On Fri, 18 Feb 2022 00:10:17 +0000 Yuanchu Xie wrote: >>> >>>> The damon selftests do not have the executable bit on. We fix that by >>>> setting the x bits on the .sh files similar to other existing shell >>>> selftests. >>>> >>>> Fixes: 9ab3b0c8ef62 ("selftests/damon: split test cases") >>>> Signed-off-by: Yuanchu Xie >>> >>> Reviewed-by: SeongJae Park >> >> This type of change does not work outside of git, so why not just make >> the tool that calls these scripts not care about the executable bit like >> we do for other scripts? > > Actually, we made kselftest receives scripts having no executable bit[1], > though it still prints warning. I guess Yuanchu wants to remove the warning? > > To remove the warning, simply making kselftest (runner.sh) stop printing the > warning message might make more sense. Nevertheless, it's also true that > letting some scripts have executable bits while others not looks inconsistent > to me. That's why I left the warning message there. Should we remove the > warning from kselftest and remove executable bits from other selftest test > scripts? Or, let the inconsistency be? I have no real opinion here, so just > wanted to hear others' opinion if possible. > I don't recall why we decided to add the check in runner.sh - let's keep them consistent with the rest of the scripts. If we get rid of the check, we can make the change then. thanks, -- Shuah