From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77494C4828D for ; Mon, 5 Feb 2024 18:15:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D52C16B007B; Mon, 5 Feb 2024 13:15:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D02B96B007D; Mon, 5 Feb 2024 13:15:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF26C6B007E; Mon, 5 Feb 2024 13:15:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AEF576B007B for ; Mon, 5 Feb 2024 13:15:31 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 73EC340AF3 for ; Mon, 5 Feb 2024 18:15:31 +0000 (UTC) X-FDA: 81758552862.12.183FB64 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf22.hostedemail.com (Postfix) with ESMTP id 7F596C0017 for ; Mon, 5 Feb 2024 18:15:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KSaB8wyn; spf=pass (imf22.hostedemail.com: domain of rientjes@google.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707156928; a=rsa-sha256; cv=none; b=a87p98Y9251JhCgZ6NX1R7MFzWtI2OgtPuTThTYAvbyzQN+GjgVam376ujPcF11JeU91Dg y6oHH0FV+rBsxeGitBIu4Q0IIhI92Y9rxDRmu1swF7iosadVjVgT6AOL9d4iRvDHVD/0u8 gSwbvo8KY15Qsy6i1OkLFHNqfNQzPKg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KSaB8wyn; spf=pass (imf22.hostedemail.com: domain of rientjes@google.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707156928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hMMhCHPdnY6a53r0AdRn2ZwMuoekqmZTBFnKYjfzR8k=; b=fM3XxJnr18ae+n0Xj+ZnbnRvBk037QCWrtfsAT68uddisN3Sxpi3vE1hjy603bCbjowchu HYxZ2Bh/Y0WWtIjdrIqfZ1FUTM8avTZrLDVBCBXUUv/bIUdovQE39x0IlFMdb0RUyKV8hI F/CaTXkUa4rjlw2Adv4f8ekx7HfLSWk= Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d93b982761so32815ad.0 for ; Mon, 05 Feb 2024 10:15:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1707156927; x=1707761727; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=hMMhCHPdnY6a53r0AdRn2ZwMuoekqmZTBFnKYjfzR8k=; b=KSaB8wynFX1j7tfsRquSfE9Tej3Lkb9wyP8uqDJvD3BH6pYmSANfX1CPhobDBExx9p ePr5yvAW3bt0UbWjjOpRMVEhB2NIl6f3rCGYcEKAxYT3cWXO43HZsQgvcHO3Hxj18NO9 cSej2KMuh0YoEUvscgrs272N4DPRv2ny8CWiG5sHh3j2TGSASW/neBpNqVeWcUDo3XWn Ddx0q2Y5vk6P3N0L5Jvb/CcrTsPYM67/YshZgIS6douNqcKBmoWwI8AVbL0lESl3R+01 uR50gUiWZrOkzdH8hlrwY8nmLzQmSCe4veCQ2Bqei3fPtks3ydtiGBliam73xEIVnYJd B5pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707156927; x=1707761727; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hMMhCHPdnY6a53r0AdRn2ZwMuoekqmZTBFnKYjfzR8k=; b=OnodERpfeE5a6xSUjbaby6xQzAQxtJCbAsn8LtjtTz3cKCw7q9v/Hw3HdU/x7UWYqf n9qary8mSXFcIqtWIRkqJ7EGIeGGPgAepjHoHWI0KzGbirOwM8fql1R9+gnxO/Cjus+J fp4he+Qmxjsz9BUBBtZ4NvGfwkt3FsIulRrooltDgPo1HZ3k8LKBd2ZZdCgiqrUhfU7J /ylM4gySKFpk6w91D/s2UV8bzfco/Fi7fRMn+FYhdjJ80+kiq682MweHiqHMui7HS6lx 8XBSSa1ikzST/YmvSZpkw3b/47rq8LC+7OTvLbjj1wQcMpfb+xKxVjaBhp93UqK5dSJk jiGg== X-Gm-Message-State: AOJu0YyGb5bPpdFqGWFf2UTsngDxoYEyCcx22Z0RHC1g+XKRPQbVwqlj iJS/OUcmHZBWrbXOOoquia9SK4u4l1g5DECl8YxAUwGdlyX25CiDzqSwFfQvZQ== X-Google-Smtp-Source: AGHT+IFmTazqpWxkymD9klp2+KFfWCRx+EupD0mFw2cWZMoCAXLe/HcNB61W1KMXdPfJpDeeBspVlQ== X-Received: by 2002:a17:903:22c4:b0:1d9:7a7a:3cf6 with SMTP id y4-20020a17090322c400b001d97a7a3cf6mr27342plg.12.1707156927140; Mon, 05 Feb 2024 10:15:27 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUpktWhh0NPQ9FcoM14zHXRSVA+RTqr1vPpQx8XPTdbH/a9BsBmFFWsoICE46TUKEz2jnUcs0RApYUBIZO3cT84iftmz8MttslQPRRdCYheYhXIe6a8hD1DwQlwkCsTYZnlHAbBRnlI8tntWDUXpCoiJ4Ken8Pr+/0KjyKOIAhjGiomQTQRlXCWtaCsPPcC+JIrdNOLcNagrcQTtqRKcttUEj55yLcKaYXkHiEgvvcHdB6EAdtODlFokODt1vWmC2pvRz7B0RQhLIpQYdsQbc8WLgjK Received: from [2620:0:1008:15:1e99:232a:d721:3dff] ([2620:0:1008:15:1e99:232a:d721:3dff]) by smtp.gmail.com with ESMTPSA id ka5-20020a170903334500b001d8edfec673sm159673plb.214.2024.02.05.10.15.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 10:15:26 -0800 (PST) Date: Mon, 5 Feb 2024 10:15:25 -0800 (PST) From: David Rientjes To: Robin Murphy cc: joro@8bytes.org, will@kernel.org, pasha.tatashin@soleen.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, yosryahmed@google.com, john.g.garry@oracle.com Subject: Re: [PATCH v3 1/3] iommu/iova: Tidy up iova_cache_get() failure In-Reply-To: Message-ID: <9a779ae8-c965-b2b0-6f94-865f49ed0e9b@google.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 7F596C0017 X-Stat-Signature: ugxewyuk8asaiig93exeboipafqa4e7z X-Rspam-User: X-HE-Tag: 1707156928-491941 X-HE-Meta: U2FsdGVkX1+FwLKFOXR+hTWzwcveyrnVnr7ROG8/jdyzRnUH9s3QnA7G49zC9fAphX5LOzV2jk+wydyycIIS6D/sf4nNtkjdCkpOqraVZPAA8w12fyaD7zQI2zVhDxa8D1fDZlN2vpb8d/mHulbD7A4lpJZSpcIDjjw0RROqer8lYCVhhztieShhvuzhxRcqURFjiJgM+qRkzE3LMXySth7wH4yrsQ+0ayiNViMBReC6wwJ8wlzyXbJRDakGLxrXEt/vqH50ma5bjOBp2eLWdnRydlA0Ols3IdXcOPiPLOrPz98UdUZu3f19TsR75yHF0Wo+D+Q5+aWvSlK5VZEIIYlaa3J8bBtLo9beCn66bdYBdDkGgwO+gaawVsdRn3bk/fK3RCAickLXlm9I7S9cmxcCkLpeYsmGcuoYzgK+kxZm9fLLQj4HKokWP4Dy3yetrcfyABD9O5hY64dZLHrSPI5c6riNbjCeTKguy5lWvuB3rVQ0/valNcpS9tJmOKA3K+APtn1ekvIkm5LNr3MEkFtwROsBf3wapjB5+dQMT1eeRQdMjWwWMtEH0ZedPi8VDLkvQcuHOijWj55oIlSz8pscbmz5qbUw0yr01vnZjT6M/Em+P9VijVDQcLO9xsJLGorwEizgs+eTkAE6s+bwk5bvI+Ag1upRiHwzaPG4OP1ApdL+ep/Ptjz/90u/uLJyyD9NIx3ihyflm8XLnt12fWeL7JyUAIuaeoEadATTORaVfv+DuogdflvD/L63Sh4PbOG+/9/N2FyMd4Zz6LQYxF8ajlkFdBa499XT6jvX59cnaMLxywQd8rLS9NT5DH5foB60GgRjwNj7Y7k+0Yq+W721lH7185dR5BMAq4KjKPkmO+v/uGgld9KgOBNuSFICfeEpe9d18HFS1mFGllkesDveDUyfRB692lANJKK3Z/UTNgde3n38sQiV50iH5w07lWqQ/ccoTjTOD42fFxD 0R+t81jL h1dUvMbJkaWJb4kknUHqEbi5u9Suz3Nyfy3madmLXEYyW53ZRr03ED8aHINMCZtZEKeiE8KvorEvpb5tdJ/G1XsY4MLHDI/fa2gjJnU1YDY6cXfuUGu3EQLCYAFrdxCea1DQjTJlHHbKW8FZ2ZRR/iRb0aacgHWKVGdjpE5gnL1eLVUx2ypqx85LCvMtpg22Z/hWs2kI9Clie8Gs59jrnDcvmBjz8wme40xgBxZAqczKwh1N2b4YJNOM/BAGgTetaMUi+P5hL/CJe50RqtXYFpjz0XTNhxQSWZpbicvN37CIF81vU9fuyPK5zWDKhHA+RpIz2wphy2M/XzjdLu45DcN9lUJs8HRsEwy6kEEP0XrL2dTfHIv83kzX4nBLd+05OelLuPAkeqkaFzcJduUde47HOncfh+wwsCuUvLodOXA9+Yjlk+6ZiYPXpJmBRL9O0EAU0ICKK0N1ukhRB3kV4NZD2NspWVRKQAWY8z9pMC/CPs8BKJ+Jj2HtH1w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 5 Feb 2024, Robin Murphy wrote: > Failure handling in iova_cache_get() is a little messy, and we'd like > to add some more to it, so let's tidy up a bit first. By leaving the > hotplug handler until last we can take advantage of kmem_cache_destroy() > being NULL-safe to have a single cleanup label. We can also improve the > error reporting, noting that kmem_cache_create() already screams if it > fails, so that one is redundant. > > Signed-off-by: Robin Murphy Much easier to follow :) Acked-by: David Rientjes