From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51198D3C533 for ; Thu, 17 Oct 2024 23:43:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE3EC6B0085; Thu, 17 Oct 2024 19:43:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B6C376B0088; Thu, 17 Oct 2024 19:43:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A34A06B0089; Thu, 17 Oct 2024 19:43:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 853726B0085 for ; Thu, 17 Oct 2024 19:43:34 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A2E0F12043C for ; Thu, 17 Oct 2024 23:43:23 +0000 (UTC) X-FDA: 82684722876.17.88671E1 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf13.hostedemail.com (Postfix) with ESMTP id 9EDF420008 for ; Thu, 17 Oct 2024 23:43:19 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=GSM+OHL2; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf13.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729208503; a=rsa-sha256; cv=none; b=KtFAKadFZ5zg4b0r8HGQJ6AR7zxq15FkDYeSXdYxcaa+NBUtuTI04ww7m2GHwXZvCRqC6d 7r6gZNBojNeeKIiDAasvtjN4LjCHFP0Csqo6xb+exJL4lcQSnYMDH008Y9hlA1zHnmuVJT yybp+BrPjQs7oc8PVSfWDI3TPlAq98E= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=GSM+OHL2; dmarc=pass (policy=none) header.from=linux.alibaba.com; spf=pass (imf13.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.131 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729208503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RDj4nTr6XNbe5Did2q3jGXNNdj/6CTLt9n7Mq4fQxEQ=; b=XS5e3HR2jdUyoeYq8pytnLTYpz5xZN39lsk8gakS770vyhKQc78RPYrSr7zCJt5Y7rjjVp jXQAlbsx7UhQ6RM5NXbj2ElVDptgGv/0NEl/WBBFoIWirjPlLX2OSG9vX61eT4nSRmaVhg i77QoHBMUHCgGMU/90Hk6Ca4Ky77jns= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1729208607; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=RDj4nTr6XNbe5Did2q3jGXNNdj/6CTLt9n7Mq4fQxEQ=; b=GSM+OHL2S290XmoALP8KprFxJRgSmtM4DLWIDIvlRKub5eLg12cy1Lj1gpLkOayTK/vUGwbFnrXAor7gmswCQevjc0DC1mDrbpmRf4QJ8Fz/THt8j5xXKCZ4IgRaiEVhlXVYz8GDnhEvlm21e2K4H1bGj0t7YcgSHXVhGYWYtf0= Received: from 30.246.161.56(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WHLxoXR_1729208603 cluster:ay36) by smtp.aliyun-inc.com; Fri, 18 Oct 2024 07:43:25 +0800 Message-ID: <9a66303e-f8fb-4c66-a7ab-d28e03982f32@linux.alibaba.com> Date: Fri, 18 Oct 2024 07:43:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 2/3] mm: memory-failure: move return value documentation to function declaration To: Jonathan Cameron Cc: mark.rutland@arm.com, catalin.marinas@arm.com, mingo@redhat.com, robin.murphy@arm.com, bp@alien8.de, rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20241014084240.18614-3-xueshuai@linux.alibaba.com> <20241017104156.00000f83@Huawei.com> From: Shuai Xue In-Reply-To: <20241017104156.00000f83@Huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 9EDF420008 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: nsrsecxw81swcbgmwgyp3dws8sgy4ge9 X-HE-Tag: 1729208599-186137 X-HE-Meta: U2FsdGVkX1+xxr2bUuXrxVEW3njf2un4YPvxAPgiRiq2fOC0hcq8XUK9qs5AIhKbnzUoqbQ8s/JFxIDIvfBan94rgPL85dcuSBgFIdnfmTzrB1cUNu85OYgH8tmApcf2Ih+qH38GspVjRDX8LXMHhDaVzHwgtr78Hzl7pfkdVRF1IYQF6tDCPeaOWw2dfukpAqJHNRjlLhCZMUxJBDhGykUdmZJpuZfOZ29hMvvbEQKoYggZF5DI/pDrZjTedtCPWBfaebYS9WVDI63EemeMwY/V+vXr9c4ZqPETDi3CK0PYS4voXRggieh6DLv4W18NQfi23OlPFHIW4WQmqOUT0hy1tkLmKR+pTlvHLW17db2YDLVZDcgApZCZCg2sDv7fKEj5ZLj6g+pMi9/XpVdYE3r251R9T0rGJVyqiw2JKerzEffIWIRUMuVm833H6vg+Jl7m2a9U06okv6BeYstXwzeaL2EAIPO7vIz7q/wlMeyoL3UYEcQXYJalrbIhW5QPuwDVrisZSQBBhgLYxR6uMacRUH9Xi0DaCctS7pZ6qZ9ZePdRvm/276+3emtzSA+88zsrkXmF2JAkP/A0UK9M8ZbRorNrdroeOJGrm5LmnuY6VDHoz5xF6p9c7m8H5nQfZEBQOLOpZ4jav83ueE5vKANYXoHDgQBndieuzSxhXfEX4WQQDqqJ+NJZtuyNwmcvLO5jFBEI74OHjVMtaqTNkZRg88FutsMfo0IgWR382eGNrOzypNpEj2iGUV2OTD4IPS9+R8qntoxihp0KYYTXrsNgMeNzmJEUHVgDyc7TqV+WltsM2DJvO+WmJBaeew/pScbmPaXB3lXPYGlu+RfTNYgFq+UXcF0kHg3KNN4YQjgayRBVoLFNNXNTHplWRQa1cIuKjposxjQvU+jXfnBkwnqQgz80r7PpWXNKc330Tqr/8jWt06JFO0CMYAJMPZ3axXNbreM+Kw/215Osq8r gcPlA5zK Mmtj/fXjpOuEayR7v3IECl0H6zLESArqUMGRnedUxSqzITQ7qZ2fgzzZTUj6fRO8THWa5FrQOuIMiDGRtRpLTURGkROm+spQmg8wO7qIoyrajwAvKtSb6yC91yX5tf3QEdSp0k6YnxAa83wgViQ2yK//fMe8bv4Jga1wL23NbTmt4u6oSyVL0t3zyM9if2DmCgAplLJJFwOeD1XMigUssiLYxuL3R096yvLFoW//69gGHN5ZH32srGi7P6sGH8DVn3d4H5+eC3uKMD+KsN9v3DvVBP5vuJpMwVoF9Bq4auWt29FyLAO9BZmsREuJ1AZ87sN6gQlLQBTkU8YekwgeNL03p61ebafWyJbgun1PWd5Q/d02o3hXGtMmRRQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/10/17 17:41, Jonathan Cameron 写道: > On Mon, 14 Oct 2024 16:42:39 +0800 > Shuai Xue wrote: > >> Part of return value comments for memory_failure() were originally >> documented at the call site. Move those comments to the function >> declaration to improve code readability and to provide developers with >> immediate access to function usage and return information. >> >> Signed-off-by: Shuai Xue >> Reviewed-by: Jarkko Sakkinen > Seems sensible. > Reviewed-by: Jonathan Cameron > Thanks. Best Regards, Shuai