From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18498C433FE for ; Mon, 28 Nov 2022 15:59:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96F176B0072; Mon, 28 Nov 2022 10:59:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 91F876B0073; Mon, 28 Nov 2022 10:59:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E7F66B0074; Mon, 28 Nov 2022 10:59:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 70E5B6B0072 for ; Mon, 28 Nov 2022 10:59:08 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 42EF080AD3 for ; Mon, 28 Nov 2022 15:59:08 +0000 (UTC) X-FDA: 80183309976.06.4DCEF2D Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by imf28.hostedemail.com (Postfix) with ESMTP id B3C7AC0009 for ; Mon, 28 Nov 2022 15:59:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669651146; x=1701187146; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=3tU9/Uz/QDW6gglhWujOCtVfQoXZYicKEy0KruTmQC4=; b=O1lGRWuF66U4/LXDkV1sp8l2W9qWafofFwu7Mecii1WyU2CpQWqn7KXO OCDdiBlqSkpZrXUDeG8Si4s1sIMJe4Nb6xQXGcexYBEPrAZvf0BRTyTgt 7YZioeqAA8ys6fvQDto8/WoGgn3JcJCCmzW2UYx8CeSqCoA26ke6O1alL qDUQvmGYINSJJVJbGQOCY+3uuNih3vXipAQmNEWUDxhXDQVWbRVuJgB/i ULKJ/MgsHXuzR8OqAlkOClT18HsiNDCmJdCQ9Hj8grTczN3O7VO8rZzir GysAXgZgGhfP37Sm2jHXHTsRpleICUFb+BiB4biV52STpXBl+A32XAF7N g==; X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="401159352" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="401159352" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2022 07:59:04 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="676088566" X-IronPort-AV: E=Sophos;i="5.96,200,1665471600"; d="scan'208";a="676088566" Received: from nroy-mobl1.amr.corp.intel.com (HELO [10.212.209.4]) ([10.212.209.4]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2022 07:59:03 -0800 Message-ID: <9a653cd2-70df-8c55-ac7d-5ddcb3b18b0c@intel.com> Date: Mon, 28 Nov 2022 07:59:03 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 11/20] x86/virt/tdx: Add placeholder to construct TDMRs to cover all TDX memory regions Content-Language: en-US To: "Huang, Kai" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Cc: "Luck, Tony" , "bagasdotme@gmail.com" , "ak@linux.intel.com" , "Wysocki, Rafael J" , "kirill.shutemov@linux.intel.com" , "Christopherson,, Sean" , "Chatre, Reinette" , "pbonzini@redhat.com" , "linux-mm@kvack.org" , "Yamahata, Isaku" , "peterz@infradead.org" , "Shahar, Sagi" , "imammedo@redhat.com" , "Gao, Chao" , "Brown, Len" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "Huang, Ying" , "Williams, Dan J" References: <32c1968fe34c8cf3cb834e3a9966cd2a201efc5b.1668988357.git.kai.huang@intel.com> <6d4d429a-ade2-771d-0e4c-788bef45041a@intel.com> <35aee96c1bb56322191ae442f3928d7dff064a92.camel@intel.com> From: Dave Hansen In-Reply-To: <35aee96c1bb56322191ae442f3928d7dff064a92.camel@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669651146; a=rsa-sha256; cv=none; b=sl5guUt4jA/PXkOjRcj0CdEyfsb5RZYQaFAo4VKWK0Gv0i+9HnYhD6bZA18reiOxsmCdMZ FK5/uKZwXmhsyss0YARE9kBKTsWrRdHJfdJ2WdX6Z2aFmslFC/NPMZuGrntzQaN16PMcsS IpT7sr19vvzuEvVWbY5TD4mb+hVHuiQ= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=O1lGRWuF; spf=pass (imf28.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669651146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PaQlo6kF1FJ/vES2B3DtmeB4QuaBrthgLkssGsqVCwE=; b=6yF7T7oQxs2OKVTWBhyp1/tah3jcOIoZytOiQRG3UQ67ywnOWiyE3fSeLRbaPsv6hOs98x kKesoYHEuSmGmf3mYLUd8jRyzD9EcZxKs46bq2A1lWJcP9/NydejbhJC/wty1Bg6/laIVV vi575dVSCcCjZFwkPq01ddqzDqBR4sU= X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=O1lGRWuF; spf=pass (imf28.hostedemail.com: domain of dave.hansen@intel.com designates 192.55.52.43 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: eqcbymnroaz1bn6m68xi9od6j7uck3pc X-Rspamd-Queue-Id: B3C7AC0009 X-Rspamd-Server: rspam12 X-HE-Tag: 1669651146-187048 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000124, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/24/22 04:02, Huang, Kai wrote: > On Wed, 2022-11-23 at 14:17 -0800, Dave Hansen wrote: >> First, I think 'tdx_sysinfo' should probably be a local variable in >> init_tdx_module() and have its address passed in here. Having global >> variables always makes it more opaque about who is initializing it. > Sorry I missed to respond this. > > Using local variable for 'tdx_sysinfo' will cause a build warning: > > https://lore.kernel.org/lkml/a6694c81b4e96a22557fd0af70a81bd2c2e4e3e7.camel@intel.com/ Having it be local scope is a lot more important than having it be on stack. Just declare it local to the function but keep it off the stack. No need to dynamically allocate it, even.