From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: akpm@linux-foundation.org, Liam.Howlett@oracle.com,
vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm/vma: check retry_merge only for new vma case
Date: Tue, 19 Nov 2024 10:14:27 +0000 [thread overview]
Message-ID: <9a596e16-03da-49bb-b8b3-2a910de8c8fc@lucifer.local> (raw)
In-Reply-To: <20241119005923.jgaunkxm6od54gil@master>
On Tue, Nov 19, 2024 at 12:59:23AM +0000, Wei Yang wrote:
>
> Thanks for your explanation. This looks neat.
>
> So it hide the reason of deferred merge from user, we would think both two
> cases would lead to a deferred merge. This is what we want to have, right?
>
> >
> >In your proposed code I see:
> >
> >- prepare for mmap
> >- try to merge
> >- if merge failed, create new
> > - if merge failed, created new, and we required a deferred merge, do a deferred merge
>
> Maybe here is
>
> - maybe do a deferred merge
>
> >- mmap complete, do 'after mmap' tasks.
> >
> >It's about humans reading this and being able to understand what is going
> >on.
> >
> --
> Wei Yang
> Help you, Help me
>
With respect Wei, I feel like I've already addressed all this, and I don't
want to go around in circles! :)
prev parent reply other threads:[~2024-11-19 10:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 2:18 Wei Yang
2024-11-18 3:56 ` Liam R. Howlett
2024-11-18 9:31 ` Wei Yang
2024-11-18 10:06 ` Lorenzo Stoakes
2024-11-18 10:04 ` Lorenzo Stoakes
2024-11-18 12:34 ` Wei Yang
2024-11-18 12:52 ` Lorenzo Stoakes
2024-11-19 0:59 ` Wei Yang
2024-11-19 10:14 ` Lorenzo Stoakes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a596e16-03da-49bb-b8b3-2a910de8c8fc@lucifer.local \
--to=lorenzo.stoakes@oracle.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=jannh@google.com \
--cc=linux-mm@kvack.org \
--cc=richard.weiyang@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox