From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14FFC3ABC9 for ; Thu, 15 May 2025 23:43:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 229466B008A; Thu, 15 May 2025 19:42:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D7906B008C; Thu, 15 May 2025 19:42:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0A14B6B0092; Thu, 15 May 2025 19:42:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E12E06B008A for ; Thu, 15 May 2025 19:42:58 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 23CAC5AC7E for ; Thu, 15 May 2025 23:43:00 +0000 (UTC) X-FDA: 83446770120.18.F273662 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 9ACD8140007 for ; Thu, 15 May 2025 23:42:57 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="GXn/HQfl"; spf=pass (imf23.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747352577; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=D543q3muZl4ZTiDO4u6l3P+84dJKDCsQhD2gkZu4SUY=; b=JupT6rbvVsCI7FCdOlcp/f8xpq7bF/UvxK3Zx7eOcxp44cDWoxYuZNUM2kMQvQ8U7Q4MNB hoEsU0mFwq/a3jMsr8pUb5M5M0N9zflXrBozkExhfiOTEY4jSux9KxNy3Yh+JK2sP1p+Uf /0f9Dh9fypgIjdCxDNlxVmcSUy94Ep0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747352577; a=rsa-sha256; cv=none; b=6FMDA1gbmxVUh/imrrviuvA1eGZCshZaMEBIojtnBY7Ro8pjHz7A1fkMoInssxB2baZtvy K86Jrg791J4qkmzWINw/8Lru8Hi0r7wznTQEAJYSuJV+HqsCuZ42VyVtvfaUxALiTKUNvN yovDwqdumD61VYHAvSy4gIvyfuiwmd8= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="GXn/HQfl"; spf=pass (imf23.hostedemail.com: domain of gshan@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=gshan@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747352577; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D543q3muZl4ZTiDO4u6l3P+84dJKDCsQhD2gkZu4SUY=; b=GXn/HQflt5RdUvYGUP6sGFSgQtFe6AgxhC+sy6xT14xLY4VnWffO6pEy6zDY5nxqMBiU/4 TOjpEP4isHdHoaUlANDurKzTp193nCTUwQkuM2lNBlN4zaavA2FUuwMn2Sm55OA1XS/oiM ZdGnJOrIgAONV+aseBI1GLQtm/dv+KE= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-v4mkajpQNhuemfFQboEHAQ-1; Thu, 15 May 2025 19:42:55 -0400 X-MC-Unique: v4mkajpQNhuemfFQboEHAQ-1 X-Mimecast-MFC-AGG-ID: v4mkajpQNhuemfFQboEHAQ_1747352574 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-30e6ccd17d6so1010453a91.1 for ; Thu, 15 May 2025 16:42:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747352574; x=1747957374; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D543q3muZl4ZTiDO4u6l3P+84dJKDCsQhD2gkZu4SUY=; b=ZrkQaxUTnfx7FLypIVLKlUttjOZwZdDQtJpphoJBk0NssPrFMgMGjXBsGZpGmX3qtv 4pvDsDBT09uuyb1R2deVcXH0trDc7HjRYh4lkkjtTwLssYO4ySAD/8LBIl/ZO26yLs7y G+65adOv6W0XklpttW4AA46lhH3QOahDyD0DF3ZYCmvG+Vjvq8f8KZFTdo33ijYriTMV xmOniu3N83/NVx2ImULLW468BvhWUrEYPDl8wrjza6WlRlOc96YBSeXUccYLwdXGV9w8 99bzhhC0/qLSocENXr2QNmsp8X5YCT3V/uy8034JXPCLZd+a5Ny96o2XYnJ9b4ER63Ge JHGg== X-Forwarded-Encrypted: i=1; AJvYcCUJ2jZC7PwZMDhXHFhdKGnL2b2q8HKR7QYb2PYxzqrySsmczJYqJ1yhE10sY+GCM4K0MXcioXO1xw==@kvack.org X-Gm-Message-State: AOJu0YynmEc7rC1FF0qun0XKoJEJo+xNzdilDNmmlO40vmozPudixrM+ 1SdUEk/seWb2zO9pnlYQ16pmNjun6FZ4rsuwnqnKQ66XBfyvQTSoSAUm8PzfmKXDXu42x+mav8v KYxkjshTGI48D2MQrN5OicQoH0i12nUqdqo9ksNl9oIJLTOc9Zxe3 X-Gm-Gg: ASbGncvZJE0ICSkxTIOmjWTtHnjjOk34m5VPmqCCEz3xgMgoz6r9BVb7YIXEvKFVmIy 5av++pAqSefR+8NKFBlQq7KNPFbi7UzWiqgJ43h8/QwmQ4nqZ1z8S25ZImldRT0u0WvPD4HtYp3 +1gbkpVLjSnJSYxYRMe7kVnqj7QIeOGrbiYzN8SrpA4DuU9RMfG2tyQ+4fw0uyYIT4YhRbROT4W aU9EdaJ4qxNScBH4d6wRDkIaXafTPi82+kQgBUsTVgG5AZqQbhlWAlWZr80a+3OdPNZXvNUFx0o EClcA0ryfXg+ X-Received: by 2002:a17:90b:3e8e:b0:2ff:58e1:2bb1 with SMTP id 98e67ed59e1d1-30e7d5bb1e9mr1333517a91.32.1747352574463; Thu, 15 May 2025 16:42:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRL/1O/Rrnq8ioMs+d0i5/D3GPpfrLPajlUsLeikruv+Yje3p8yvM4Ix2Eud3DGPaH1u34zA== X-Received: by 2002:a17:90b:3e8e:b0:2ff:58e1:2bb1 with SMTP id 98e67ed59e1d1-30e7d5bb1e9mr1333477a91.32.1747352574064; Thu, 15 May 2025 16:42:54 -0700 (PDT) Received: from [192.168.68.51] ([180.233.125.65]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30e334016e7sm4069046a91.9.2025.05.15.16.42.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 May 2025 16:42:53 -0700 (PDT) Message-ID: <9a2431e0-252d-41c9-a91d-9e02a8779e8c@redhat.com> Date: Fri, 16 May 2025 09:42:31 +1000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 07/17] KVM: guest_memfd: Allow host to map guest_memfd() pages To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250513163438.3942405-1-tabba@google.com> <20250513163438.3942405-8-tabba@google.com> From: Gavin Shan In-Reply-To: <20250513163438.3942405-8-tabba@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MRyMHyKXOt3Wi1Tv-axNEC55ZDte53pEhwF4xl0K_Uk_1747352574 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: mndwopnzjzzxxqxgm4ra4whwpmwjfmej X-Rspamd-Queue-Id: 9ACD8140007 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747352577-842133 X-HE-Meta: U2FsdGVkX19uamr8CWfeLO+U+73Fkwd04pyA5KpgIyAaUJUYkxWhpgPbV5NMxz8M63J4TZ2eJix5iqfxsicfZp+lgPgpOeGcvk8IaCU1rr/8MTf4lT23MeWHvYCPjo9BBqtdlxjKDcIiOrPckSbHOERQ7CyEzsgWGtsR2UzcOC803L5k+1NeqSsHLaqLAX395a0R5SAsZzYaLsm68ZURyGXuSTslMJx1FgcWb27jnlTcqMI3jMDvysi/V6TSJ3qNXaMSaRXkiBa88Hs8Ud7JHN9mkJxIDTUK7nqTYtLoTefp8QXCQQUebkTsPcxY0dZlOsaYEj7nTVY7Ak9kMeXIjFqRgRcoMb8kI0eIQsH5Th5cMhA+F7bIKJbrdmWpTH4i2LK5WXV51bvRzgOIhWuVWn/Gx+RpjTcaWyM8lzFasfaiQ6j6kgFN3AIMf4Z60ulYjJeI8WaVMziTRgqn3BxXNf88pZNlI7hrhVwqxBpYtll65mNU1yrGXRdeBVSRpBjHXygQ23Z5/6ajmkmTyJk+6x7cBU2SZ3L8xW6oRHmLALVNGcr1euRB+4mJJokrpvrFC/ziR8CsL6JBYkZSnKgnIxyT/k/JwpaWYH6HuCOxXrBb6N/DmgHbbDhw4ymGlOMWNjGvxQB+D4Nc+Iqqh3iyigqy53L+0PBpifPbnj0TYAkMqhGGP0JOwvDgGZcRZeOQ+eBuKYa37HHg4nNC0EbrRnCuUyX7si8s03HzjsodTSxc+26sIiMfHpxtc5SnAGHvqGs5KeBt3EqLZeT3DsSWA0t5BLmp3tMETKasrQ+9FSofPsgFTCCYgJK/b2+QpmcRBgwhkSk9WXR/+6UianbYxd4/mAWEJQ7F/pZr76kSuxR317vWu/KGBtRQ4Hf3ytEa4qreKepmHIBhScCiHw8G0hJuEmOx4DG5Bb4CYjIoMbnSoGzolawFGEQmStxBOMjzTPMdJuGhaTqg/kFhLI7 va8oCG3M 7P59uqULS4OaNIpK9FgWUEJ+u+FZvzPE8f56PkL9rJsnLQo3rXfCDt2VO8WTfnsiaich28LGDxdGmHMW6vRgRwDt+CbpynKU/lNfBp3Gu8oNYSzctxGllLo1seYLxivzp2Xmi0/ncJjyXA206cn6OgzMj+BHXmhtJU2qoeWNfUBTWJc5AZI4KqRJx1ljtw1V92Sx4lxX6+K2FYHvsE9bRNyDCIvxyFnFI4ywdVasPY8ljdQv3idaZVIMt9z43G0J/wthEcs0+MNZV7nKgDfzaB9Qnnc9qvNRrzBTVRyy4Q9hu50vAmLMKbpZKtZWxgD8ryRk4gyMrGcCq7UpAi0HkY60ZxkSaoiICHjDrDnWCZ4Z8/TBQ1B7K7sX9FnCWuszwBS9epGZZWmZCH4xDKwHlhSE4tl8ITpSe6aVAP4YfZBOF3gWy00nKXJSSI4Q9JWTzYrlg3hlKkfDLoDGbgSDHDrn5x+mJNl+ET6SlVmKj3saT2EHs5OQjdbnEZegsTnbVeOZRHb0SJSZKHxfIcVFEVme2qA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Fuad, On 5/14/25 2:34 AM, Fuad Tabba wrote: > This patch enables support for shared memory in guest_memfd, including > mapping that memory at the host userspace. This support is gated by the > configuration option KVM_GMEM_SHARED_MEM, and toggled by the guest_memfd > flag GUEST_MEMFD_FLAG_SUPPORT_SHARED, which can be set when creating a > guest_memfd instance. > > Co-developed-by: Ackerley Tng > Signed-off-by: Ackerley Tng > Signed-off-by: Fuad Tabba > --- > arch/x86/include/asm/kvm_host.h | 10 ++++ > include/linux/kvm_host.h | 13 +++++ > include/uapi/linux/kvm.h | 1 + > virt/kvm/Kconfig | 5 ++ > virt/kvm/guest_memfd.c | 88 +++++++++++++++++++++++++++++++++ > 5 files changed, 117 insertions(+) > [...] > diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h > index b6ae8ad8934b..9857022a0f0c 100644 > --- a/include/uapi/linux/kvm.h > +++ b/include/uapi/linux/kvm.h > @@ -1566,6 +1566,7 @@ struct kvm_memory_attributes { > #define KVM_MEMORY_ATTRIBUTE_PRIVATE (1ULL << 3) > > #define KVM_CREATE_GUEST_MEMFD _IOWR(KVMIO, 0xd4, struct kvm_create_guest_memfd) > +#define GUEST_MEMFD_FLAG_SUPPORT_SHARED (1UL << 0) > This would be (1ULL << 0) to be consistent with '__u64 struct kvm_create_guest_memfd::flags' Thanks, Gavin