From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 404FAC04FFE for ; Wed, 8 May 2024 10:24:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CB5E76B0120; Wed, 8 May 2024 06:24:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C654B6B0121; Wed, 8 May 2024 06:24:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B05B56B0122; Wed, 8 May 2024 06:24:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 926976B0120 for ; Wed, 8 May 2024 06:24:47 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3639F160E5F for ; Wed, 8 May 2024 10:24:47 +0000 (UTC) X-FDA: 82094845014.23.AC2D3F0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 1505040009 for ; Wed, 8 May 2024 10:24:43 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AnGdBAhc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715163884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XnG3psXeBYa/ivD3KAPPTeGItEb7Z4sGj5rmd5cHNeI=; b=j0dH4eKBK4eR+HOHkF2N4npkEcJ64zW7B3YfHI3iSSHpfPABTvrSBxHXEjuKQv9vVy+/JB TUpuGpJKdiD809HnCXHp+U2HuJfvUw6VZF9LzEeV3Pt14BjfoHJZJ4YL/BUM8LUyC7UJ8e Mg3CO637+9nsBfLeI0CP1uETagUZMlI= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AnGdBAhc; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715163884; a=rsa-sha256; cv=none; b=gVWseOfntZGYIMwQbzuR3jBf+aWoA7UurPeXfM1IdxMnsqaGYIFlxdH56FjEbimLCOMDHA OS6RWgSRVEGm0fwP6R3GpvaLKXrIoEUoJDqhqOQ7Ctx7W5KzF/QlyIJcnc+ItsCfpmPQx1 2sOLIP2S5BjKqBANhzciaf9tFAw11IQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715163883; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=XnG3psXeBYa/ivD3KAPPTeGItEb7Z4sGj5rmd5cHNeI=; b=AnGdBAhcPok5pnD0/VOuJp+B5TY9WP4IVbexoJrw0hwiTBnvEV8z2f/6OvzlFhqpQayjXf dznBRpjJZJkr/WwU3srP+g0xeljsU8nDeUZD3/PCnzVtXKMws1blGj2qN4a3YaAv8WsGdJ Q6iPSAdb0UbJbaobbO/6dfv8TPtaMr4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-WzBML-WEMnKlP3rm0whu6w-1; Wed, 08 May 2024 06:24:42 -0400 X-MC-Unique: WzBML-WEMnKlP3rm0whu6w-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-417bf71efb4so3608825e9.0 for ; Wed, 08 May 2024 03:24:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715163881; x=1715768681; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XnG3psXeBYa/ivD3KAPPTeGItEb7Z4sGj5rmd5cHNeI=; b=cQUMDmKFr5WkF1KXTSxlspF/nXGxIA3y7ApWBXikHIjL1el6Fd6Bt/2PMuOaukzluV jPNm5U3gpoRSHJBjqAsDo0gVmbpjIBsnQghrUqCDgjRDk226Rqyo7jH8lH+zp4ISX9tw btVzTDxxtBxAXYl+XU1HxFARUPDKF20vAuKhAAr3U1iOE8E5DDDKjmMTX3Q2nkL5m5Lf NMYvvPff8PDEt++yQrOIOWVTupRODHmTVsqT0bX9Nw2uOjFWh6E8gFyS9oVwNXmhFBwu WHH9LIqNYpYjy4kZOq6rTOFtopogwAHebI3OXqSQtrITK9r7qu2aXMjelK8CtESI3Fqi Id4g== X-Gm-Message-State: AOJu0YwllczKgaMy7uoJyJnk5jVKE1w1qNP+C+neHV9EXy7niJPj8oOC KIBjGrKoq8D1bogffY9SKLcezCWJnfi/IzJrj043XMO4iMwIhhxG/YzGBshSRXs8hCJWpGehWoD HN/LZ2rn4mgUC3kqOp3yIt4pukS06KRdl0bkLAinPMtEjlmQX X-Received: by 2002:a05:600c:3c92:b0:41b:ed36:e055 with SMTP id 5b1f17b1804b1-41f71ad0c4emr21790655e9.7.1715163880957; Wed, 08 May 2024 03:24:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFxh8KFUNfy+USArt4pA1Qz9zzKEyel29xMDCV0k/Z92O0iZ0FrHMCLUzTqlCORPocJeVJsxw== X-Received: by 2002:a05:600c:3c92:b0:41b:ed36:e055 with SMTP id 5b1f17b1804b1-41f71ad0c4emr21790485e9.7.1715163880564; Wed, 08 May 2024 03:24:40 -0700 (PDT) Received: from [192.168.3.108] (p5b0c6bc3.dip0.t-ipconnect.de. [91.12.107.195]) by smtp.gmail.com with ESMTPSA id dh18-20020a0560000a9200b003439d2a5f99sm14988890wrb.55.2024.05.08.03.24.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 May 2024 03:24:40 -0700 (PDT) Message-ID: <9a1fdac7-8bbd-48f4-bf31-86916ddcf4ed@redhat.com> Date: Wed, 8 May 2024 12:24:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/4] mm/ksm: fix some accounting problems To: Chengming Zhou , Andrew Morton , Stefan Roesch , xu xin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com References: <20240508-b4-ksm-counters-v1-0-e2a9b13f70c5@linux.dev> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240508-b4-ksm-counters-v1-0-e2a9b13f70c5@linux.dev> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: a1nw7rmkt6eyuxeyqbo5sf3gngernthi X-Rspam-User: X-Rspamd-Queue-Id: 1505040009 X-HE-Tag: 1715163883-390481 X-HE-Meta: U2FsdGVkX1/dufn98XMeN2MPhsn7W09Jk+xKZYmiWv0jrn4AS1ulN+NAdJlM6M0jKbXYVplfkYAgNliVhhPZMZcC8j00GkFmOSRc3RQcJfBrfK8tp97L3dT4wfG9Y8Sf4MY0n+ogMvO8dZFIxAsEV3iFz6XYGjTFcAE5YEE1l2CVIjZs7JY7j/XOZu3MM0MCARvBkFwkEdciVqYMWcl0+aCljNSM5lpLogdP4uzKgDY5b/pZXVv34nUyIk8NcZYobOZhdTus6m3oV4d/GLe2nPuEYID0GeLf7ChoQEkPpb38qZkhmlgSeLRFliOlUmBRe9gnOAU8elWKDyC4P/nEWNhqlK9QWd/Ewfq49bFqh1GVt4QAnHZkTGyD0Bz43ls9iXpedXiOaUK7CeLf5e6wmBQAx587kzqDfaQVvMIT0hUqUXF/YYHFFvJg9abTH6kynVK+Sa5gIV38+H3ndyDzlggddTN1dZ2Rck4NApTO2yyPukV4dxJ81OXUZtO3j5PL9isuehBXL6RJeWTP+YwhZ+k7asYXm1h96pE9kpV/lo1mPbzSWkeAZEkM+jgc5VEViB+fS9chfXXlv3+DCOpyYOgeDZUHtsuSDfqJ4F4+whVSdalp1BEOKl1uqTTI3HZ3qp2cGJkvPP0Yp2Xu0HI6I7ICmwh8ulxw4IpIzQhtLnEwqLoFh8EeOQW9VRrCrRHR8GRJBhBqjiFA4m5K+oAXIxvhB/2j8IQcvE+yNB7JFnbZbaJ+ZUjhyJfdEphR4Rjq3YkjD4tQp/DvMqpDxH4Wmh9xMbNtQ0lhaoygPOAwamNl5/ptrvdcbrIU6P2lzCm5SXZByZzp2QdwZZ5yEgOC7wKW8cKQN1pruXKiuzWo2u29wI1iSL8hrbz/Hl03GQcAKBuBvapYhkLPqk39oI6VK/o/2MBOGTPZPrUwSJHu9SpuMy1n0w+ZVPfAdzNY8RWl8XCZljSKK5gx2w1lVMA tQdaeYSm 6CIYaLLXLQA/G38yYmqJDtIJIoRbKPvLcjwfKW3ApIrNhkxfiYtZ4CL47El7sDKEeO5ZkPgwU7wWJU6xh6GztDnNlLnw/px3eaTHi/e9CWtygvSZl50r10tPXOoHfGG/uyEqfAU794+XKNZ0D5kRQGbauL1Tp6vXDOPyU8uc20fRWUga79SMteLixlMP8/N2dePvSFmmvxgwVmkXb5TSNzZen/aeUrhjsvnkn5kg55Bdso09qA+rZ1c6qIGqv17YqnuPvTmmnaCHP5hhDARqeDOCl6yR4VQtmigWPK5TMSX63XGiAXifvqCbKqM6/yZqf7UQBaefv6DfLrLN87AA2Oa3xGRzi+oS11A9ItJh8Ia/q0NL7E999qcmdiK5ffURldOjZgEQpEXhVFoLx5PLLwcctoGD1MizR4axJUp6UiR4LTk8CXvuJ/zzI0Df9uQB3Sp4DclV8T+juJ7rpu/vwgY70smGUl3Xz98rsX8m0Pp0zXpQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.05.24 11:55, Chengming Zhou wrote: > We encounter some abnormal ksm_pages_scanned and ksm_zero_pages during > some random tests. > > 1. ksm_pages_scanned unchanged even ksmd scanning has progress. > 2. ksm_zero_pages maybe -1 in some rare cases. > > The first two patches fix these problems and the last two patches Can you find+add "Fixes:" tags for these? They look sane after having a quick peek. -- Cheers, David / dhildenb