From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f72.google.com (mail-pg0-f72.google.com [74.125.83.72]) by kanga.kvack.org (Postfix) with ESMTP id 0BCC46B033C for ; Tue, 20 Jun 2017 12:23:12 -0400 (EDT) Received: by mail-pg0-f72.google.com with SMTP id m5so147948856pgn.1 for ; Tue, 20 Jun 2017 09:23:12 -0700 (PDT) Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0044.outbound.protection.outlook.com. [104.47.36.44]) by mx.google.com with ESMTPS id t69si10798352pfe.252.2017.06.20.09.23.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 20 Jun 2017 09:23:11 -0700 (PDT) Subject: Re: [PATCH v7 11/36] x86/mm: Add SME support for read_cr3_pa() References: <20170616184947.18967.84890.stgit@tlendack-t1.amdoffice.net> <20170616185154.18967.71073.stgit@tlendack-t1.amdoffice.net> From: Tom Lendacky Message-ID: <9a1c0df8-ca12-eebc-5565-ced847989169@amd.com> Date: Tue, 20 Jun 2017 11:23:03 -0500 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andy Lutomirski Cc: linux-arch , "linux-efi@vger.kernel.org" , kvm list , "linux-doc@vger.kernel.org" , X86 ML , kexec@lists.infradead.org, "linux-kernel@vger.kernel.org" , kasan-dev , xen-devel , "linux-mm@kvack.org" , iommu@lists.linux-foundation.org, Brijesh Singh , Toshimitsu Kani , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Matt Fleming , Alexander Potapenko , "H. Peter Anvin" , Larry Woodman , Jonathan Corbet , Joerg Roedel , "Michael S. Tsirkin" , Ingo Molnar , Andrey Ryabinin , Dave Young , Rik van Riel , Arnd Bergmann , Konrad Rzeszutek Wilk , Borislav Petkov , Boris Ostrovsky , Dmitry Vyukov , Juergen Gross , Thomas Gleixner , Paolo Bonzini On 6/20/2017 11:17 AM, Andy Lutomirski wrote: > On Fri, Jun 16, 2017 at 11:51 AM, Tom Lendacky wrote: >> The cr3 register entry can contain the SME encryption mask that indicates >> the PGD is encrypted. The encryption mask should not be used when >> creating a virtual address from the cr3 register, so remove the SME >> encryption mask in the read_cr3_pa() function. >> >> During early boot SME will need to use a native version of read_cr3_pa(), >> so create native_read_cr3_pa(). >> >> Signed-off-by: Tom Lendacky >> --- >> arch/x86/include/asm/processor-flags.h | 3 ++- >> arch/x86/include/asm/processor.h | 5 +++++ >> 2 files changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/arch/x86/include/asm/processor-flags.h b/arch/x86/include/asm/processor-flags.h >> index 79aa2f9..cb6999c 100644 >> --- a/arch/x86/include/asm/processor-flags.h >> +++ b/arch/x86/include/asm/processor-flags.h >> @@ -2,6 +2,7 @@ >> #define _ASM_X86_PROCESSOR_FLAGS_H >> >> #include >> +#include >> >> #ifdef CONFIG_VM86 >> #define X86_VM_MASK X86_EFLAGS_VM >> @@ -33,7 +34,7 @@ >> */ >> #ifdef CONFIG_X86_64 >> /* Mask off the address space ID bits. */ >> -#define CR3_ADDR_MASK 0x7FFFFFFFFFFFF000ull >> +#define CR3_ADDR_MASK __sme_clr(0x7FFFFFFFFFFFF000ull) > > Can you update the comment one line above, too? Yup, will do. Thanks, Tom > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org