From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CF33C021AA for ; Wed, 19 Feb 2025 09:30:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D9F1440151; Wed, 19 Feb 2025 04:30:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 089BC44014A; Wed, 19 Feb 2025 04:30:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E6C15440151; Wed, 19 Feb 2025 04:30:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CA1BB44014A for ; Wed, 19 Feb 2025 04:30:12 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 962151A1417 for ; Wed, 19 Feb 2025 09:30:12 +0000 (UTC) X-FDA: 83136173064.20.C59ECCC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 3F49E40005 for ; Wed, 19 Feb 2025 09:30:10 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cT4wwKf+; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739957410; a=rsa-sha256; cv=none; b=7nj6GcdvW3w7BPQom5JqpJn03SzKraPu5/ZENc3HnneMfnjk7cT78zbd1BX9Fb2Dtdxq4S HQ02KH4NYmY+LFVWkBgjfrJSUHntydEQGYWeFqZipX89qBTY+zSxSnUhXq9vgmZaX44x58 QS/YwOdki2Adxn2eQzeFBz0KH0vM11Q= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cT4wwKf+; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739957410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O6iIs/bRi4LNStonXoF+PjfPP76cxf5o1pRHRm2Ecos=; b=pjwyVtHFMrLcCYp2ceJVuvj16rqlwa/yXDMUy08rvq2xUNFjGiYMvLZLdWfdQyacJ0SG+p NotCSrXxoIB8tr8b5m/5N73+1+s8RLXUmNPCIyXt299bqIFyagtZX59qJ5+d+zXOVV8cZG XFmvQ7gXy6R9vd6VvnPwesil69j5sOM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739957409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O6iIs/bRi4LNStonXoF+PjfPP76cxf5o1pRHRm2Ecos=; b=cT4wwKf+rpUU0wn2RruEF76U1e0fW574P+1KN0TENKUycQ5CqJe/lqLnbOCyBeW1tgi9G+ CZlccq2vxFcTA39fhj+zo+PCgT43nXy/TMV1YPEpS2KS5DuBWe1OYsfzyJLrTuwx1jysLL KkyC7StVdvsuRGR4Ws3c+kcivmey5/o= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-403-YpZdoJY8PwmnXGqby8treQ-1; Wed, 19 Feb 2025 04:30:08 -0500 X-MC-Unique: YpZdoJY8PwmnXGqby8treQ-1 X-Mimecast-MFC-AGG-ID: YpZdoJY8PwmnXGqby8treQ_1739957407 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-438da39bb69so54196945e9.0 for ; Wed, 19 Feb 2025 01:30:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739957407; x=1740562207; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=O6iIs/bRi4LNStonXoF+PjfPP76cxf5o1pRHRm2Ecos=; b=byx4nVx0u1Ta7pfthpQCAAyHy/ai9SIx2OxvGB+fr26qcpw+Rp5o9wz2vSLcZU0kqs fZzsOvkJRGH6c9DDbq9+dca7EBgmrCfKWI8RUTUn18F7dKeAUc3d1NdCEQKE2JWB0sYA gtTnHLNUyaYF5VUROKFHNEJM6A4oVXVLgo2vGGcz4j0rLhR5E+bONeBhRHplzEf8HDg5 e8Apqu8zWz2EWT+Zh+GSICWvI1Qwm0XV+dBCpi+tDcFp1uyssaE86KdjCmN/DvyJ+QFd 8PaMyZCEww40EfPOsH/Dl2GV22FaCg03Us4hmYRS17rdk2jqHAzNnV5A8j9piuxaTFDz Rw1A== X-Gm-Message-State: AOJu0Yx5r1xZ3+TSKuX5afE+84nhzrxP9vvDesm/TBxXgd/LVwVspNH4 m55ZuXKbwL+SUNRjV8Td+I6DkfBd0VS14QCcmnoED2pfCCWR9gNcBCH6WfnpUl+NTeOAT/pcBE6 0BGjFxk60m+IQgyMWRTgHs20T9zmUNZuBkF7PiqfoZCARYoRb X-Gm-Gg: ASbGncv/46GT3QL2ywzZa+pc2oXWO1ZtaH++fdeg4ikB8y1pExOYVae7Up7cNJjbcdV U1feAV4KQLjkrVWN8H92dV6Oj9tV/osm/wAMuykgesOHcDAqAYbKUkVf1jLWLJF9eg6Oip8iyoH 31alwv2FFGpSLKxzdfan27t22QyoB10FIjqlL5N4ppIr0kgMnZIc9isGAWdXDPOFEURyKxkr6Fy Z63fDnLhqNDwjg/Byo54C4HNopW5L/6pHDu0k3M6zW9LEL6CeS7N8ElRIGJrFJtG77vreX28Hc3 Ft2b5hvYbtYZvdXX68+efsI2wyopiB9XujutKE30FO3lbNpjbfYy1mgYJ4M+2z9iZw91CR/Xn6M g9ru7F0E5YuuXYNqCy6XHQjicNkeMm/BO X-Received: by 2002:a05:600c:350b:b0:439:30bd:7df9 with SMTP id 5b1f17b1804b1-43999d8de25mr23617545e9.9.1739957406837; Wed, 19 Feb 2025 01:30:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGcnkciXYFZBMbQtiqRGmrfj7AGbzSt3LRKWsRgsBPbNWJxOgzptCl2hNOgyjgZkRalfiXnQ== X-Received: by 2002:a05:600c:350b:b0:439:30bd:7df9 with SMTP id 5b1f17b1804b1-43999d8de25mr23617315e9.9.1739957406478; Wed, 19 Feb 2025 01:30:06 -0800 (PST) Received: from ?IPV6:2003:cb:c712:8400:50d0:d1c1:90d6:e2e0? (p200300cbc712840050d0d1c190d6e2e0.dip0.t-ipconnect.de. [2003:cb:c712:8400:50d0:d1c1:90d6:e2e0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4399be79d92sm10851015e9.0.2025.02.19.01.30.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Feb 2025 01:30:06 -0800 (PST) Message-ID: <9a1199e0-38ab-4a5c-afc8-c571187f3377@redhat.com> Date: Wed, 19 Feb 2025 10:30:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: run_vmtests.sh: fix half_ufd_size_MB calculation To: Rafael Aquini , linux-kselftest@vger.kernel.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Peter Xu , Shuah Khan References: <20250218192251.53243-1-aquini@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250218192251.53243-1-aquini@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uFOny-ZLyLcw12i7T-U_G9_G-bO0GX9XdvAcmo4B51o_1739957407 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 1bb8o87z6ssqgygrg1hgwpuk51hbxxth X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 3F49E40005 X-Rspam-User: X-HE-Tag: 1739957410-367939 X-HE-Meta: U2FsdGVkX1+ZgKpelUIotO6SyTY/qWOGJZ3dvHijul9G2Ip4sRQC7a7Qj4cFYzRUpyOZfOHHMyisyb5r/16EJJlJBtdsx6wCAsFkRAvNcEB7I3QQZDxrI2KcANMFgkG2ba1VGmhsjOS7f6vAbyqMyoxYS3V+ReS5GsYkGmL9KbDu3dDKG2lbONdK6RnBHk+ozgKyOV4yagwFzUpOZ1k67gy3x7r0TZRxQWUoeex5WPx93hhNpHMF52iTsluWpsjZmnNVMY2Ykv+uss5+cdwYbQy5PhataI2ffJlQCpcYMHenm6P+xfY2FMmkOGZwdoy4wuK5bWUMxEdmzTZLu7Ctyj5yDAYfIyX6stCLSt4dpnnfbwO/qjx3qX8YEfoRsJ4TPvD3cL+7T4Hgk03qv+PnKRU00WASiNQO8RfOvwZT57cr4VtGPnxvaygDKP6ZA1RP+FY5vvGa/1h0JhkOmM5lE3dc51CtqaGTr0LwKH/22bs4DurxZ+Twrd5BIbRR34udflablJA0jCPNfiRP7S3XcwSWuh17EKLkT1vSdXJN1DA6UuMG5RY8A61PEk0kCRcED7oegsEALe9fhIJcveUOqymHtQKM26nyFch9cRwWL2MLneDaUbZZ9SQgU7a5khcx0GL6+8fzB+9wwXtFPnwl9ZGtI9lcg0fHBXlf901pujmasxzqI4wR29E4vhv9Sb1Yp7VqlJI6aCmYSFLmpcLvTBjbUVps8rvL4Bu8GMUZdPCMq771FudOylSPiZmsheReouy0GSv0QeIJIMl3yJisRM7QVN8Xk553+5QB7nLnSaK2xShpkk93HFMR72+X4cK+A6tHSZwh508trQIfuFwaXiOfRhmi65qqs9GYjA8rlrnSBKTqYzoE3MpuxZ0vL+2wsMDO+Vx8HDcUeg/4hq4MZclao4hICmEIo18jzaJBSzE3nMcEbU5LJA/H8ItLfg+xcFb8/4xpDexzMzk8Ygc wCdvJpN1 5d/kkmJxpsPYRzh51SBAOWUUAUe1lZlI0F7fkUPc5TYLYaRbVLdjtSADEdEGoMoWcdlfcPyezZ/Ofj+eWmZw7WTzX/uV4T7EbbhdVxnpH2OCAMLbw+mQraP6me5NpxtOnPoLA7rIMxfgME+7pA86IgjCl0Vpe12hxw1645X9YvJG+vxuanWcbnW2JJ0SUdy7fYMLeGdRuo0dD8rrRKE1XNVPtU0NyqycsO9yjKkQK7lVDGuZZPOxqdWhcMVSv1cOQIHuomPB27IUCe+/N2V4z2acyss/BndTZSgRpv0wFPjgAkIPoIMP/7NvZ/vf94eqLSyFw/tI+zV9ZXDxwBR0KRFC0VWZWb4xr3EtrGfmTIs5LqMUByM72ZBUj4QRRz8HFnGqNI6P/zNi+mg54CdW24PrFy4LxdaopSv1DX2HJyhiQ+g1QBrkQJ+atXkbNHKvxJY/X2Hqvu4+ld8xmG9tMkAmrCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.02.25 20:22, Rafael Aquini wrote: > From: Rafael Aquini > > We noticed that uffd-stress test was always failing to run when invoked > for the hugetlb profiles on x86_64 systems with a processor count of 64 > or bigger: > ... > # ------------------------------------ > # running ./uffd-stress hugetlb 128 32 > # ------------------------------------ > # ERROR: invalid MiB (errno=9, @uffd-stress.c:459) > ... > # [FAIL] > not ok 3 uffd-stress hugetlb 128 32 # exit=1 > ... > > The problem boils down to how run_vmtests.sh (mis)calculates the size > of the region it feeds to uffd-stress. The latter expects to see an > amount of MiB while the former is just giving out the number of free > hugepages halved down. This measurement discrepancy ends up violating > uffd-stress' assertion on number of hugetlb pages allocated per CPU, > causing it to bail out with the error above. > > This commit fixes that issue by adjusting run_vmtests.sh's half_ufd_size_MB > calculation so it properly renders the region size in MiB, as expected, > while maintaining all of its original constraints in place. > > Fixes: 2e47a445d7b3 ("selftests/mm: run_vmtests.sh: fix hugetlb mem size calculation") > Signed-off-by: Rafael Aquini > --- > tools/testing/selftests/mm/run_vmtests.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/run_vmtests.sh b/tools/testing/selftests/mm/run_vmtests.sh > index 333c468c2699..157d07e5aaa3 100755 > --- a/tools/testing/selftests/mm/run_vmtests.sh > +++ b/tools/testing/selftests/mm/run_vmtests.sh > @@ -304,7 +304,9 @@ uffd_stress_bin=./uffd-stress > CATEGORY="userfaultfd" run_test ${uffd_stress_bin} anon 20 16 > # Hugetlb tests require source and destination huge pages. Pass in half > # the size of the free pages we have, which is used for *each*. > -half_ufd_size_MB=$((freepgs / 2)) > +# uffd-stress expects a region expressed in MiB, so we adjust > +# half_ufd_size_MB accordingly. > +half_ufd_size_MB=$(((freepgs * hpgsize_KB) / 1024 / 2)) LGTM Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb