From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D304C71153 for ; Tue, 29 Aug 2023 05:13:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 61C0E280013; Tue, 29 Aug 2023 01:13:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CC808E001E; Tue, 29 Aug 2023 01:13:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4931F280013; Tue, 29 Aug 2023 01:13:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 35B788E001E for ; Tue, 29 Aug 2023 01:13:22 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BB4C51C96B1 for ; Tue, 29 Aug 2023 05:13:21 +0000 (UTC) X-FDA: 81175973802.01.C03C7F2 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP id 8405E80012 for ; Tue, 29 Aug 2023 05:13:19 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1HB3hUuC; dmarc=none; spf=none (imf02.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693286000; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v7yy8KuNyAVC/aJA6ag651RbI8R+xf9nSt8GLFJg/IA=; b=C8OsW1kLHKrBVRq9Vqk6U8factjoSKS7KRjFUCE5V9S079jeOBh3o4oID9wEGjlFP/B6oo m0PhJC4IC3JU531wM3qaHH+Aew+F/tX7ufftf560BQqLUCfJ/z7nyYllPQSnl7bjcx8TjY 3v9woJdXoyemyH0Zipy+l7pycaN8gPY= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=1HB3hUuC; dmarc=none; spf=none (imf02.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=rdunlap@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693286000; a=rsa-sha256; cv=none; b=tjsUDIEZVDGJ/4zId8ckzYjZPjj8BR/2WTCCHrKUgLHkxwGNG0nzw+0maAZTmvQ0jnzcNu wvJNNH2xsc2+2wUBnHKDHCO7e5mfGLf298XO260TnWxjEysZ8FrkazYtO0TIedhiUuTuNp 5ieY0da5/bdmDDHGtagj2PR19y7x/Ac= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=v7yy8KuNyAVC/aJA6ag651RbI8R+xf9nSt8GLFJg/IA=; b=1HB3hUuCNWuPyEv/taD47yOU/N OMMBbTzRgLijiV/at3P8KdHd8BdUIyAMklbIEMXBRVhQQSw7bfiNaVQ2AmvTG02FYVnNjHJsx20hY P18Q3npchkXjDgTxF65LdAIMzRG2QnceKXm9ZG5DlKbgDHrlHJCKSuf7ei89ss8cooCJeLw1cSrCZ 2ujIMF6zBMMU2/+gljEv0LkVrQNM1vnEBRL9PHoP01oFG/kYhKCzH0m1f62qdGi9jrmUPPJw2Qn8B Mz6nYUIXUvAk6kTZluBmqAo3u9g6muCUgPgrwT+H4/W9CZ+F/8Mfsl4O9EjZuQRIGyjnm+PwYc5Hy GQSDQuKw==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qar2L-00AnWf-2V; Tue, 29 Aug 2023 05:13:09 +0000 Message-ID: <9a05d92f-60c5-6ede-2105-829f09c737b7@infradead.org> Date: Mon, 28 Aug 2023 22:13:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key' Content-Language: en-US To: kernel test robot , Christian Brauner Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List References: <202308172003.O1QB7TgB-lkp@intel.com> From: Randy Dunlap In-Reply-To: <202308172003.O1QB7TgB-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8405E80012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: u9fwep13rp3fqxc44higj9hxhhby5jj1 X-HE-Tag: 1693285999-853016 X-HE-Meta: U2FsdGVkX19nQEJ5341+u6qwk7bewPHAPed2Jb8hloShe+Jp6ssuGPvVtFRgi2IQVCsB64ZwRHghIQ4IfFE7XVJdSc7zTcjWX5E+wAaJztmUhmVOn7mJX+CpLNRhPGBVgZtbSNGBf+DRNngS4x2nuW9X7Uf/ppy6ZqD02LNc4/tFi2lImKA9+fMVLVPvmh6rR1MmZ/ahxUvyxnfW/+CQcQCsMvZ44IaJgGoR3Y0a9oX8DVRoE22pmLi14FNR2+12XIzAv2XHA0ES+EH5Acbmi2h/1OjAGGxQcAQJK+blihQ401gLOJ9KTJrP1ld/p/zrlZTomzluY8rebcJ84TrmsbEDw+1amZ/JR3m6NyqCPaY1TX5lXmNDs2prXNGZE+ZAyL1UzIZnfGXxFDWRooKsN6kbTbn4+p9IWhacuWaa9VDZmwL7YDn4SOOhQ8ak0bJ9mKmKbIGucDMw2fvYwSQSyWD3MIOQpJ6cX5HnAmdFHv56LoQEjOJ774DR2WW6JJ+hZAKGI1ZY7QdxwESsrOMMpiznYn55Fj6MRob73Z3nm9HtgCB37i6f8upVNicYYtUeGGK9APMi2mPxDPX85mTq6JqWAjdFtTQ+izvbED1Ki1ap1X7ZRP6N2Rk3HDw+fU7DAO1+Akz0PF0pcGalD8sBj6OH8KOhr0MErTEf1gR2mVDPqUFcUWYQtDrfRlCc8r6YiOgWAbfIhCbEp6/thHcKVsw0WVwm/XT9scb8tggF24GMEbBixns/W5ulsqmkKFqiVKRiIcTYXus/CXR7vIUjZVeHyrOkp/hb6ScLcWdTpAoeVCqw2bKxrl/cLgJusGze/MpGBON49ZDolxIbO9N9Q6XrCpgVHJ95usNKy1VdEWYVKnYZ1nr+CySVJ3LNOoVhex4vQbYlOFtHSPWDQQ3dAe9assiIOx1h+brnBP7MXZtSK1HGtFrNB/yCKVK0YfbqhFLyBAC+ZKWGH9U8UxY MhQx9bTR f3vwSxYqkfiWR9ZpvjdOo/alu1Jnr33BxBrsMCOQ9M2O17gJ3X/3kK7kSeWFjTxb+Nx3nJerp8BGTx4cipNTnVIW5qx1zrhL3EvRIEw/1rjMX700JTVB959ZL1tA2MnK1gF4cmmRMufG7Jp9hCjTFRcpHBnyNZp+YWEmOC9ose0ORjqq/qPzqfiEhBaH78VY3Rax2k7bfjUew40SSmA9ZvMi9Huxfz5AqMtEQtTQN4YChuWv11er4rDLHrWoK9dpoUG1N4CyPEsYNFppglmkWv3+WgDcSyH/q3NgDCRcXkqgfkCXMLfCgxC3rUeXk1WUiGJQSuOONZJs6/vbBVw59ito8PQ05uc1t1QXGTlHDstLJUdliZzHigsXqo/wR4KaMB6ycM9nhnqlYv/ArxzbjLq/XFOMXDABG6WD2HNd4xjd3T38b1ga3Pm06Cj7xYgolP1b3GmvFhlt9pACzx9M5Xj7u9g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Christian, On 8/17/23 05:56, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6 > commit: e227db4d4f125efb1cae2f1337da85bc10b3185e userns: fix a struct's kernel-doc notation > date: 7 months ago > config: parisc64-defconfig (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/config) > compiler: hppa64-linux-gcc (GCC) 12.3.0 > reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202308172003.O1QB7TgB-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > >>> kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key' >>> kernel/user_namespace.c:239: warning: Function parameter or member 'id' not described in 'idmap_key' >>> kernel/user_namespace.c:239: warning: Function parameter or member 'count' not described in 'idmap_key' > kernel/user_namespace.c:246: warning: Function parameter or member 'k' not described in 'cmp_map_id' > kernel/user_namespace.c:246: warning: Function parameter or member 'e' not described in 'cmp_map_id' > kernel/user_namespace.c:277: warning: Function parameter or member 'extents' not described in 'map_id_range_down_max' > kernel/user_namespace.c:277: warning: Function parameter or member 'map' not described in 'map_id_range_down_max' > kernel/user_namespace.c:277: warning: Function parameter or member 'id' not described in 'map_id_range_down_max' > kernel/user_namespace.c:277: warning: Function parameter or member 'count' not described in 'map_id_range_down_max' > kernel/user_namespace.c:295: warning: Function parameter or member 'extents' not described in 'map_id_range_down_base' > kernel/user_namespace.c:295: warning: Function parameter or member 'map' not described in 'map_id_range_down_base' > kernel/user_namespace.c:295: warning: Function parameter or member 'id' not described in 'map_id_range_down_base' > kernel/user_namespace.c:295: warning: Function parameter or member 'count' not described in 'map_id_range_down_base' > kernel/user_namespace.c:344: warning: Function parameter or member 'extents' not described in 'map_id_up_base' > kernel/user_namespace.c:344: warning: Function parameter or member 'map' not described in 'map_id_up_base' > kernel/user_namespace.c:344: warning: Function parameter or member 'id' not described in 'map_id_up_base' > kernel/user_namespace.c:364: warning: Function parameter or member 'extents' not described in 'map_id_up_max' > kernel/user_namespace.c:364: warning: Function parameter or member 'map' not described in 'map_id_up_max' > kernel/user_namespace.c:364: warning: Function parameter or member 'id' not described in 'map_id_up_max' > kernel/user_namespace.c:776: warning: Function parameter or member 'map' not described in 'insert_extent' > kernel/user_namespace.c:776: warning: Function parameter or member 'extent' not described in 'insert_extent' > kernel/user_namespace.c:844: warning: Function parameter or member 'map' not described in 'sort_idmaps' > According to 'git blame', all of these come from additions that you made. What do you think about a patch that converts all of these into non-kernel-doc comments? I.e., change "/**" to "/*" for the functions and struct? > > vim +239 kernel/user_namespace.c > > 5c1469de7545a3 Eric W. Biederman 2010-06-13 230 > 6397fac4915ab3 Christian Brauner 2017-10-25 231 /** > e227db4d4f125e Randy Dunlap 2023-01-07 232 * struct idmap_key - holds the information necessary to find an idmapping in a > 6397fac4915ab3 Christian Brauner 2017-10-25 233 * sorted idmap array. It is passed to cmp_map_id() as first argument. > 6397fac4915ab3 Christian Brauner 2017-10-25 234 */ > 6397fac4915ab3 Christian Brauner 2017-10-25 235 struct idmap_key { > 6397fac4915ab3 Christian Brauner 2017-10-25 236 bool map_up; /* true -> id from kid; false -> kid from id */ > 6397fac4915ab3 Christian Brauner 2017-10-25 237 u32 id; /* id to find */ > 6397fac4915ab3 Christian Brauner 2017-10-25 238 u32 count; /* == 0 unless used with map_id_range_down() */ > 6397fac4915ab3 Christian Brauner 2017-10-25 @239 }; > 6397fac4915ab3 Christian Brauner 2017-10-25 240 > > :::::: The code at line 239 was first introduced by commit > :::::: 6397fac4915ab3002dc15aae751455da1a852f25 userns: bump idmap limits to 340 > > :::::: TO: Christian Brauner > :::::: CC: Eric W. Biederman > thanks. -- ~Randy