From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76937C48260 for ; Sat, 10 Feb 2024 06:20:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 928B46B0072; Sat, 10 Feb 2024 01:20:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B2506B0074; Sat, 10 Feb 2024 01:20:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7523C6B0075; Sat, 10 Feb 2024 01:20:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 62AF66B0072 for ; Sat, 10 Feb 2024 01:20:32 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E22FF80799 for ; Sat, 10 Feb 2024 06:20:31 +0000 (UTC) X-FDA: 81774895062.18.6D9F605 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf14.hostedemail.com (Postfix) with ESMTP id BFC4E10000C for ; Sat, 10 Feb 2024 06:20:29 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HYuse41w; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1707546030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CkM+sqJ+m2B/97iahU/EKMxiPU46JPmdXfXpAy5HK2U=; b=CC7WT7JHMOKHbEdh2NkcZxkGJIYpeUZ/bxWXrQkvnSZHaUcGv3au0AEPZ/LxSWU5WPC18B gC2Kmufj9fkPerHOZ+oXgGzilHkTy+r7vh7IF9BvMHvWKCEEBw5/DGgP+yalDmnNZsV6vw svk4dUw8kGz1Uq79wj2rYYR7PDOWLCQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=HYuse41w; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf14.hostedemail.com: domain of kees@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1707546030; a=rsa-sha256; cv=none; b=dQCJq6QRRrqf3Un3dREs4eRAJB6/ztrSixzRGexMa7L19bpRhU4Y+B9RHtc7kBj4G8o9m1 xEHYUilXCQKth8x7o90rwy9gWsrgrBQgTO0axlUFSjSecKzjoPXwt7RqT8CpXB2RoueM84 OEZdmdW+yCHwdpjccxZhmeOR+T6LEVc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id A7EA4CE1C1D; Sat, 10 Feb 2024 06:20:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D013AC433F1; Sat, 10 Feb 2024 06:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707546023; bh=1Ze5VEPfD5vhZYQmXIpz7v4I8v5CLbO0cbP1JVjlVA0=; h=Date:From:To:CC:Subject:In-Reply-To:References:From; b=HYuse41w6uCewE/PnPkzXazcAz/wThGf7m58t9dGnuRqD5IQSZFVa/6/5P4IC5WKP uJu84TY6zqt/spjV+HwipurymdhpvxxEQyvDyCwnSy1QrdCPijt16SVUYT94wOrHJ+ 1YsFpEj6FnCul09I37BeSLq/oShjwS2XONlU+1oBLrRzwPnCdd5FiA9wHrkr6j1+xf TbWaSFvDH5GhO9zbuuYo6yrlosdF4jwT2JJEzekHsIiLm3fSJ4SGl7CLZbwZJhtven jvHNQJxurXTP90WREQ9DQbJ4+dSnZWDQizOZNtmQY0suTWReVo3IzJMSTEdMakfQNj +j4aBPXwORtXA== Date: Fri, 09 Feb 2024 22:20:22 -0800 From: Kees Cook To: Alice Ryhl , Greg Kroah-Hartman CC: Trevor Gross , Miguel Ojeda , Alex Gaynor , Wedson Almeida Filho , Boqun Feng , Gary Guo , =?ISO-8859-1?Q?Bj=F6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Kees Cook , Al Viro , Andrew Morton , =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Arnd Bergmann , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, Christian Brauner Subject: Re: [PATCH 1/3] rust: add userspace pointers User-Agent: K-9 Mail for Android In-Reply-To: References: <20240124-alice-mm-v1-0-d1abcec83c44@google.com> <20240124-alice-mm-v1-1-d1abcec83c44@google.com> <2024020859-lusty-ladylike-29d4@gregkh> Message-ID: <9FD5FF49-6C8D-4073-9CE5-EA19C607FAD2@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: zh55wbfjbam55z99q5cezcrp94berm7g X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: BFC4E10000C X-HE-Tag: 1707546029-545395 X-HE-Meta: U2FsdGVkX18I4YqZQWyu/amtN98+kHSmgmtGzdVeIbFw529Nv3OW3fNf217yqeSx0Y51uwLbo4FiX09C7FWdBNC7AztgtUUXknH0cuxrq3Ef07lpAp4/np1alMi5bT/hfpjobEOXLpa8V6m94z04RAW9bWp53mOYSYqJ9HB4wJeGbWXJMHdD5d7+z1IdIUzesKQ9NkTMOyuUwwIKkCC6CbpfkXLkZn8q8sSnLZ3cvImMeWVC63bJeSoFYMnPZxnKQP1Y7+UERzsE4qx8LoWEhQJiQgH36XsuRr7izOHuCVioRBYM2VvjNBnIBP4uX9sq3+RlRjQ72+ARaOW2saz6O/amVBwOYNF4xK1rcvqFq4Zc9X8gCGt2kpMqmNyFdED6BTbcJYeoD/3nUyG04DJY3M9ln3v4Yw8jxNTHKuTING5gcclDS6D1xl71sdS396g9PCt/l7XvCYXYO9WZwepMRJ4CMz02WM+GYryelabyxEuD1AsrFZb8LpkrJFgqIFRmWFszFuFaXGzafs2C8VVI5sbnTO8t2/hji87uHXNW8QNPUHc8/Ez2oO3CCIXBaWY0TgOSz/s4wz/oPEOqld1ed5dWpBa09Pz++ljlPZiIf/Y+WNRJeKZwPYz3Om0QeVsdS9bSmM8u60k2i57ZDQcQuuLfT96493Vp55zOAFGquYf12Z66IxE+DS5IxA22NiL7lwNOJ1ebSNLM8+Zew3sq5NWvyZA+KJDGbkhykBIY+S/2xEPfPCKcxe0berSKGy5nfLyENPKbIuTQ1f/ktDInJ8wxNRO9IWftZlMI7GUrqEFpSQ44nADFe2sb8DaLxzVQrnXppdYcTU7lp8WkkU3u/g7i+u6w4ZojH/YTx46Hx+jY5ALAGnfD/FRuqdgXLqtxK0BX/eF+dkJRkDbFjXJGsj1pMeH6Wt+A4NP5rwSHkbUSGUx3k1UA40Ro+WhSF54o8tRQhl1JXHFCqJB3YAT hdQWkLEp 6eRUUQSX0Mn6PqcRZyys8T3bB19tuuo+w/QFszMHHHvnDwm6wng4k3GNtiEmRZfscu4oel/QL0wmQydsFDkLeWVUoyiwCfpExEZoNhOAyDtgzP4X1tOFahgjrawgtXtDQJKHNSASbrEQq80o7C0Qjo9tAQ6rIq5UnmynDSTJf3G75MArUfJuCKTLwbVJH5ZSjJ4vdnXqsA+AWtnT1c8s8+C7Nxlg3svNiP8T07gbM+V8CAxEsmlmblY8myNuPE8OR5ScEEnC7UNtIzl93VA05Vw93rQI5Gh7e2zx7JiR4NiPaigDPjqBgBPstta13nGZXz6EGvCtOaUR6yU4Mk5KoDlLNoT2yqmlW7E4s8g8rQDcf8lYwQN38Js+Yu/oLq9wrjiyA9/DMG5bJaQEZq3vvls1lzZb/NpJu7FFWwXSlF/rHKsOhVjhSWTtFiVbwYswW3cKFvXcjdkIEi9I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On February 8, 2024 7:41:52 AM PST, Alice Ryhl wr= ote: >On Thu, Feb 8, 2024 at 4:35=E2=80=AFPM Greg Kroah-Hartman > wrote: >> >> On Thu, Feb 08, 2024 at 01:53:20PM +0100, Alice Ryhl wrote: >> > > Is some sort of `Debug` implementation useful? >> > >> > Leaking pointer addresses in logs is frowned upon in the kernel, so I >> > don't think we should include that=2E >> >> s/frowned upon/forbidden/ :) > >:) > >> Along those lines, you all are tieing in the "I want to print a pointer= , >> so hash it properly before I do so" logic from rust like we have in c, >> right? Ideally you'd use the same logic if at all possible=2E >> >> If not, that probably needs to be done so that you don't accidentally >> start leaking things=2E > >I don't know what the status of this is=2E For anything I've added, I've >just made it entirely impossible to print addresses, hashed or not=2E Thank you! That is certainly the preferred[1] approach=2E :) -Kees [1] https://www=2Ekernel=2Eorg/doc/html/next/process/deprecated=2Ehtml#p-f= ormat-specifier --=20 Kees Cook