From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9018ECE7A89 for ; Mon, 25 Sep 2023 06:44:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 900A46B013F; Mon, 25 Sep 2023 02:44:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B0B16B0140; Mon, 25 Sep 2023 02:44:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79F206B017F; Mon, 25 Sep 2023 02:44:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6B1876B013F for ; Mon, 25 Sep 2023 02:44:42 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F3313120ACE for ; Mon, 25 Sep 2023 06:44:41 +0000 (UTC) X-FDA: 81274181562.28.235802E Received: from smtpbgeu2.qq.com (smtpbgeu2.qq.com [18.194.254.142]) by imf23.hostedemail.com (Postfix) with ESMTP id 84933140013 for ; Mon, 25 Sep 2023 06:44:37 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=bilibili.com; spf=pass (imf23.hostedemail.com: domain of wenyuli@ex.bilibili.com designates 18.194.254.142 as permitted sender) smtp.mailfrom=wenyuli@ex.bilibili.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695624280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k4+TJvd5R3vURZB/0m1ZTuo5pDtSMoskkl1msfej0do=; b=ojvYhXZBoV+3rgBDXJIRz01iEwEVzgTIZ/eGVIrm19TbwjVolIEdENvJENp0EgWrVp+/vH f33K4WhToap5KniADxQFwaiaSJUXUtl5ybqP8LGJCqbCphMID7x4z+GasNViE1wCdov6dF HTetynYOQxs7Sj1PYRUnX6kGn1BuJFo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=bilibili.com; spf=pass (imf23.hostedemail.com: domain of wenyuli@ex.bilibili.com designates 18.194.254.142 as permitted sender) smtp.mailfrom=wenyuli@ex.bilibili.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695624280; a=rsa-sha256; cv=none; b=XNKiXf6KHDgycK06qm7LDuq2ItFmtrld9RODQuQIDcps3iAB2795lLDx8vQlPU4T15uxu4 I0897wL2WjDXcyWEQmZGL5zwZJSMqwFzg5W6mtMhuu+MvXpF330gijVRpKBspJg7N/rPWU lnEN9M7EZ+qRJ1N++dWh3U2UzkGSGgk= X-QQ-mid: bizesmtp76t1695624220t68d2x3u Received: from [10.23.230.53] ( [121.46.247.130]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 25 Sep 2023 14:43:39 +0800 (CST) X-QQ-SSF: 01400000000000101000000A0000000 X-QQ-FEAT: +ynUkgUhZJk84fOipIi/2HdQZgDrTnTIerD1SV/Lf/3gYa4TqxXz++evuB29B ZjbEjpNBNQA79wlcoPqcWMhudT348Ei1rNemso+PZ9DRuU1TwHG1AprAaR7Bq75F3JulbA+ GH6LjCpAUdhfZtQJJjqE53EJGKl4aGd3EFLtvv349ITaGyosLv8+wkRj8M9bmYqcrBIr6DS 3etcOoNwjgAsWoJEXeK8h6TIOaNXQI/2gwUdPIrqqLE3e+cOYIcodfnGadrpKQ3iLZLLT6h C1xaZs1tbjmQVv1ZqvouwZ0brFOUi28bbxD03OyDAcLIsG87gJjEq/LNZa5PDkw3uiJiGE8 H5M8P6OEU62oD2FBbsByIJ15BKfNQi8or2Nmh/3lpfYz/vQouQ= X-QQ-GoodBg: 2 X-BIZMAIL-ID: 17299434549104365918 Message-ID: <9F7DFA20B598B0C4+7dc938b0-67f9-422a-8051-3a7c1fd7a6bf@ex.bilibili.com> Date: Mon, 25 Sep 2023 14:43:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] delayacct: add memory reclaim delay in get_page_from_freelist To: Andrew Morton Cc: bsingharora@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangyun@bilibili.com References: <181C946095F0252B+7cc60eca-1abf-4502-aad3-ffd8ef89d910@ex.bilibili.com> <20230920090711.ecc2d84cc29bb0fa540f1999@linux-foundation.org> From: liwenyu Organization: bilibili In-Reply-To: <20230920090711.ecc2d84cc29bb0fa540f1999@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:ex.bilibili.com:qybglogicsvrsz:qybglogicsvrsz3a-0 X-Rspamd-Queue-Id: 84933140013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: hgycxqbmjj94d5zoxbgoeficgpd3i995 X-HE-Tag: 1695624277-678318 X-HE-Meta: U2FsdGVkX190+BMPyIN8rOQQnXlvO5T3c/Tl8b5xAPComXf2hwIhhaOVJdihkuJEqIGTf4p7w36LOrmMR+iTt3xDf+dIyn6xR613SGu22gx6uYJHQ5Jlq58V0F/1DsTYtzRji7lfiObt8d6wuWzHVuOL3/9czguEI4x1ZhHgsBWuaqjL3TT5zTLx2tIOomy+MIdgxut4J6HBA6MspQEuQo1JpL+QbVdlSwqT4Iz+czK3FY4cku5AEf/xfdBTY1nVt6dEdl1sRpJrzXY9KM1llvkd72rjzmGK5y0G1yYPb+vOPBGojvwpk2XS/8YQ1DHfIPD5S7WRHv4GifxdmMML9aysK60o5m5q2BN7m0r4iXQ+vSqSINNmdgZX62ycmigmW4cHtLy1JPdcgjF+nLS7navt7v6NRYyH4VvqqvY1pw20NgUhZtyA1mI+zHrzNi9MUu7ozJ5SF/ERjrcv3KvdQ0kORnn+eJcuh8rVR1lWIafjlxE1tIjDAVjA7tLmFZyT7USn2/vJjSMNxU7ZUE71DgH8F01S3B/Q0vqx5GhR8CfCiodTVNniWxPSCHFPI+H3bFL0gYH5h5Ub1+A4JqG+6A7oTuru6mcCW0O3xhLZL3ncGDLUX7sf3Y91Ob2+SwFYbws4iN3PXKKz71hUMh5b0Kap0YPsptXGGd9CEoW4/KFbAS0YJyAbzFg5tMwIKaGQ2mGqUbRGRi3IkWNOfTD2lyZ9EHHgV68fdhKMzsIyaP5Z4vEYXXKi3QL0b8lXv+FtZUrRAvIDRZzgbcl61Y0Ya3TOUUUFrMWD2d2rBqDAHJT7wVdN4TFELYYZmWxQEDtjOHQebPaOO8iTeGUo9G0xePTNLqkpMzyoR28aDLUXtA513jleNIZLfPCqct5FAyukSOECr3efdK3iA/fWoeZee4HIj0hEzya8N74w8V46CutwWXLWrTNaaeYxC5PG9wcJm/lDIA4zgoHhpzsVC72 sSHoSboP 8E1wbiaWEEsTbW0EupgYL3cnLcQcJq0/ooGmt1SKfhzAWMET3P51iGuiS9yXLBroiuqH4woRITaxgW0uhRJkeOziu6fgJnSsLYRhWKfo8eC/229ezb/S8k07+j9cC7yK/eLq/ACQtOIMFY5oZNMyWuxnGc2EXz+FYGrChYV6xeyjwgEoA+BbGgPm8EjDrQvy/u7lv1bc3wFU1+CnME4pW1MUuMmZ1GTn0qI3gDQj63z8Pkg4aq+XV474tj4QR01NKEl3Qf9z2DJ55f9USCj3kpe2toSnTN+23qCAOoNDLgjtrwUlGQ0oz5AZ9rYRxiSyurTGInZANTd4GLFi2swFW6ngaM6owZDdcLGGL/PBc+AQcokW4VBg+/qApb34g9ta4JL/rEZZDX9ccly1j2OBplT5P0MKgHNJpI9anRSqOAKvQRsU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Wed, 20 Sep 2023 17:38:49 +0800 liwenyu wrote: > >> The current memory reclaim delay statistics only count the direct memory >> reclaim of the task in do_try_to_free_pages(). In systems with NUMA >> open, some tasks occasionally experience slower response times, but the >> total count of reclaim does not increase, using ftrace can show that >> node_reclaim has occurred. >> >> The memory reclaim occurring in get_page_from_freelist() is also due to >> heavy memory load. To get the impact of tasks in memory reclaim, this >> patch adds the statistics of the memory reclaim delay statistics for >> __node_reclaim(). > > Please review Documentation/accounting/delay-accounting.rst, see if > there is some change we can make to reflect this patch. > > Your email client is wordwrapping the patches - please check that for > next time. > There is no need to change the Documentation/accounting/delay-accounting.rst, because this patch is only an expansion of memory reclaim delayacct. Thanks!