linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Dike, Jeffrey G" <jeffrey.g.dike@intel.com>
To: "Wu, Fengguang" <fengguang.wu@intel.com>
Cc: Rik van Riel <riel@redhat.com>,
	Johannes Weiner <hannes@cmpxchg.org>, Avi Kivity <avi@redhat.com>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	"Yu, Wilfred" <wilfred.yu@intel.com>,
	"Kleen, Andi" <andi.kleen@intel.com>,
	Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Lameter <cl@linux-foundation.org>,
	Mel Gorman <mel@csn.ul.ie>, LKML <linux-kernel@vger.kernel.org>,
	linux-mm <linux-mm@kvack.org>
Subject: RE: [RFC] respect the referenced bit of KVM guest pages?
Date: Wed, 2 Sep 2009 12:30:59 -0700	[thread overview]
Message-ID: <9EECC02A4CC333418C00A85D21E893260184184010@azsmsx502.amr.corp.intel.com> (raw)
In-Reply-To: <20090818022609.GA7958@localhost>

I'm trying to better understand the motivation for your make-mapped-exec-pages-first-class-citizens patch.  As I read your (very detailed!) description, you are diagnosing a threshold effect from Rik's evict-use-once-pages-first patch where if the inactive list is slightly smaller than the active list, the active list will start being scanned, pushing text (and other) pages onto the inactive list where they will be quickly kicked out to swap.

As I read Rik's patch, if the active list is one page larger than the inactive list, then a batch of pages will get moved from one to the other.  For this to have a noticeable effect on the system once the streaming is done, there must be something continuing to keep the active list larger than the inactive list.  Maybe there is a consistent percentage of the streamed pages which are use-twice. 

So, we a threshold effect where a small change in input (the size of the streaming file vs the number of active pages) causes a large change in output (lots of text pages suddenly start getting thrown out).   My immediate reaction to that is that there shouldn't be this sudden change in behavior, and that maybe there should only be enough scanning in shink_active_list to bring the two lists back to parity.  However, if there's something keeping the active list bigger than the inactive list, this will just put off the inevitable required scanning.

As for your patch, it seems like we have a problem with scanning I/O, and instead of looking at those pages, you are looking to protect some other set of pages (mapped text).  That, in turn, increases pressure on anonymous pages (which is where I came in).  Wouldn't it be a better idea to keep looking at those streaming pages and figure out how to get them out of memory quickly?

						Jeff


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-09-02 19:31 UTC|newest]

Thread overview: 122+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-05  2:40 Wu Fengguang
2009-08-05  4:15 ` KOSAKI Motohiro
2009-08-05  4:41   ` Wu Fengguang
2009-08-05  7:58 ` Avi Kivity
2009-08-05  8:17   ` Avi Kivity
2009-08-05 14:33     ` Rik van Riel
2009-08-05 15:37       ` Avi Kivity
2009-08-05 14:15   ` Rik van Riel
2009-08-05 15:12     ` Avi Kivity
2009-08-05 15:15       ` Rik van Riel
2009-08-05 15:25         ` Avi Kivity
2009-08-05 16:35           ` Andrea Arcangeli
2009-08-05 16:31     ` Andrea Arcangeli
2009-08-05 17:25       ` Rik van Riel
2009-08-05 15:45   ` Dike, Jeffrey G
2009-08-05 16:05   ` Andrea Arcangeli
2009-08-05 16:12     ` Dike, Jeffrey G
2009-08-05 16:19       ` Andrea Arcangeli
2009-08-05 15:58 ` Andrea Arcangeli
2009-08-05 17:20   ` Rik van Riel
2009-08-05 17:42   ` Rik van Riel
2009-08-06 10:15     ` Andrea Arcangeli
2009-08-06 10:08   ` Andrea Arcangeli
2009-08-06 10:18     ` Avi Kivity
2009-08-06 10:20       ` Andrea Arcangeli
2009-08-06 10:59         ` Wu Fengguang
2009-08-06 11:44           ` Avi Kivity
2009-08-06 13:06             ` Wu Fengguang
2009-08-06 13:16               ` Rik van Riel
2009-08-16  3:28                 ` Wu Fengguang
2009-08-16  3:56                   ` Rik van Riel
2009-08-16  4:43                     ` Balbir Singh
2009-08-16  4:55                     ` Wu Fengguang
2009-08-16  5:59                       ` Balbir Singh
2009-08-17 19:47                       ` Dike, Jeffrey G
2009-08-21 18:24                         ` Balbir Singh
2009-08-31 19:43                           ` Dike, Jeffrey G
2009-08-31 19:52                             ` Rik van Riel
2009-08-31 20:06                               ` Dike, Jeffrey G
2009-08-31 20:09                                 ` Rik van Riel
2009-08-31 20:11                                   ` Dike, Jeffrey G
2009-08-31 20:42                                     ` Balbir Singh
2009-08-06 13:46               ` Avi Kivity
2009-08-06 21:09               ` Jeff Dike
2009-08-16  3:18                 ` Wu Fengguang
2009-08-16  3:53                   ` Rik van Riel
2009-08-16  5:15                     ` Wu Fengguang
2009-08-16 11:29                       ` Wu Fengguang
2009-08-17 14:33                         ` Minchan Kim
2009-08-18  2:34                           ` Wu Fengguang
2009-08-18  4:17                             ` Minchan Kim
2009-08-18  9:31                               ` Wu Fengguang
2009-08-18  9:52                                 ` Minchan Kim
2009-08-18 10:00                                   ` Wu Fengguang
2009-08-18 11:00                                     ` Minchan Kim
2009-08-18 11:11                                       ` Wu Fengguang
2009-08-18 14:03                                         ` Minchan Kim
2009-08-18 16:27                                         ` KOSAKI Motohiro
2009-08-18 15:57                         ` KOSAKI Motohiro
2009-08-19 12:01                           ` Wu Fengguang
2009-08-19 12:05                             ` KOSAKI Motohiro
2009-08-19 12:10                               ` Wu Fengguang
2009-08-19 12:25                                 ` Minchan Kim
2009-08-19 13:19                                   ` KOSAKI Motohiro
2009-08-19 13:28                                     ` Minchan Kim
2009-08-21 11:17                                       ` KOSAKI Motohiro
2009-08-19 13:24                                   ` Wu Fengguang
2009-08-19 13:38                                     ` Minchan Kim
2009-08-19 14:00                                       ` Wu Fengguang
2009-08-06 13:13             ` Rik van Riel
2009-08-06 13:49               ` Avi Kivity
2009-08-07  3:11               ` KOSAKI Motohiro
2009-08-07  7:54                 ` Balbir Singh
2009-08-07  8:24                   ` KAMEZAWA Hiroyuki
2009-08-06 13:11           ` Rik van Riel
2009-08-06 13:08     ` Rik van Riel
2009-08-07  3:17       ` KOSAKI Motohiro
2009-08-12  7:48         ` Wu Fengguang
2009-08-12 14:31           ` Rik van Riel
2009-08-13  1:03             ` Wu Fengguang
2009-08-13 15:46               ` Rik van Riel
2009-08-13 16:12                 ` Avi Kivity
2009-08-13 16:26                   ` Rik van Riel
2009-08-13 19:12                     ` Avi Kivity
2009-08-13 21:16                       ` Johannes Weiner
2009-08-14  7:16                         ` Avi Kivity
2009-08-14  9:10                           ` Johannes Weiner
2009-08-14  9:51                             ` Wu Fengguang
2009-08-14 13:19                               ` Rik van Riel
2009-08-15  5:45                                 ` Wu Fengguang
2009-08-16  5:09                                   ` Balbir Singh
2009-08-16  5:41                                     ` Wu Fengguang
2009-08-16  5:50                                     ` Wu Fengguang
2009-08-18 15:57                                     ` KOSAKI Motohiro
2009-08-17 18:04                                   ` Dike, Jeffrey G
2009-08-18  2:26                                     ` Wu Fengguang
2009-09-02 19:30                                       ` Dike, Jeffrey G [this message]
2009-09-03  2:04                                         ` Wu Fengguang
2009-09-04 20:06                                           ` Dike, Jeffrey G
2009-09-04 20:57                                             ` Rik van Riel
2009-08-18 15:57                                   ` KOSAKI Motohiro
2009-08-19 12:08                                     ` Wu Fengguang
2009-08-19 13:40                                     ` [RFC] memcg: move definitions to .h and inline some functions Wu Fengguang
2009-08-19 14:18                                       ` KAMEZAWA Hiroyuki
2009-08-19 14:27                                         ` Balbir Singh
2009-08-20  1:34                                           ` Wu Fengguang
2009-08-14 21:42                               ` [RFC] respect the referenced bit of KVM guest pages? Dike, Jeffrey G
2009-08-14 22:37                                 ` Rik van Riel
2009-08-15  5:32                                   ` Wu Fengguang
2009-09-13 16:23                                 ` KOSAKI Motohiro
2009-08-05 17:53 ` Rik van Riel
2009-08-05 19:00   ` Dike, Jeffrey G
2009-08-05 19:07     ` Rik van Riel
2009-08-05 19:18       ` Dike, Jeffrey G
2009-08-06  9:22         ` Avi Kivity
2009-08-06  9:25           ` Wu Fengguang
2009-08-06  9:35             ` Avi Kivity
2009-08-06  9:35               ` Wu Fengguang
2009-08-06  9:59                 ` Avi Kivity
2009-08-06  9:59                   ` Wu Fengguang
2009-08-06 10:14                     ` Avi Kivity
2009-08-07  1:25                       ` KAMEZAWA Hiroyuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9EECC02A4CC333418C00A85D21E893260184184010@azsmsx502.amr.corp.intel.com \
    --to=jeffrey.g.dike@intel.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi.kleen@intel.com \
    --cc=avi@redhat.com \
    --cc=cl@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=hannes@cmpxchg.org \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=riel@redhat.com \
    --cc=wilfred.yu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox