From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EEDCCE7A81 for ; Mon, 25 Sep 2023 08:56:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D6DF8D001C; Mon, 25 Sep 2023 04:56:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9872F8D0001; Mon, 25 Sep 2023 04:56:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8753A8D001C; Mon, 25 Sep 2023 04:56:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7C1F68D0001 for ; Mon, 25 Sep 2023 04:56:53 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 550DEA06A8 for ; Mon, 25 Sep 2023 08:56:53 +0000 (UTC) X-FDA: 81274514706.30.1885E10 Received: from out-190.mta0.migadu.com (out-190.mta0.migadu.com [91.218.175.190]) by imf21.hostedemail.com (Postfix) with ESMTP id 877E31C0014 for ; Mon, 25 Sep 2023 08:56:50 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZCi899+4; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.190 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695632210; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kyckiC55caP9KWh/3WatOnX5yiAYCuwEaRClig5LT6Y=; b=H9ViJSF+jrd7VneWKlFc0zFZqLpN9fuTL4+KMMy8Po+ftBQ6eZ0mNdt8kTFVEWM7whde/t ENFCOv7zEVyauF7NygADEgd/Bz3xDYwZJo5R9Z0UGyUw+GPYdyuYxJjvGVttLj2wS6n9Sv gFzBLkpQsCY5vAGLzdomftDGL7G0Hz4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=ZCi899+4; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf21.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.190 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695632210; a=rsa-sha256; cv=none; b=3b2ZGWnqTnNxyuqbmmTWjVUuZG6jSd7n50KPUBlhYHv87YMxWdSItj0XBwHLYMlJ5VSmAv VGs/VmHV+oDjKmHbVojwuGcj7BH4Sr15xC31EEzBA43KQWgxzrXne2GuBK0O3muCZ3+QuT ciYT1eeSJaz2uZWD5QJJlst1MAqTmck= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1695632208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kyckiC55caP9KWh/3WatOnX5yiAYCuwEaRClig5LT6Y=; b=ZCi899+4Hxeiwo5hoDEXrXPS765wHNZlDs5vt+ZMbQoCuu3P3uUqcWgF30jTKCbMA9+WtP cEe40Ea8WIWQ5jrUh5it9uKUqewGRRGVZ8BW0ZdfGrz2H98vcgVSNh9sYyDxs5/fvrSxe4 ZwqN9uppcIv1uYipsp++zO5A8YMyUcI= Mime-Version: 1.0 Subject: Re: [PATCH v5 2/8] hugetlb: restructure pool allocations X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230925003953.142620-3-mike.kravetz@oracle.com> Date: Mon, 25 Sep 2023 16:56:03 +0800 Cc: Linux-MM , LKML , Muchun Song , Joao Martins , Oscar Salvador , David Hildenbrand , Miaohe Lin , David Rientjes , Anshuman Khandual , Naoya Horiguchi , Barry Song <21cnbao@gmail.com>, Michal Hocko , Matthew Wilcox , Xiongchun Duan , Andrew Morton Content-Transfer-Encoding: 7bit Message-Id: <9D82738C-AF1D-44E6-8982-8A5A13F04687@linux.dev> References: <20230925003953.142620-1-mike.kravetz@oracle.com> <20230925003953.142620-3-mike.kravetz@oracle.com> To: Mike Kravetz X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 877E31C0014 X-Stat-Signature: ts1acaose78qahdkwaa7ae193yx97am3 X-HE-Tag: 1695632210-176609 X-HE-Meta: U2FsdGVkX1/BwtDikXDFA8rY1eSbVYqp5cQIa/vUsIk2BgWo33adB59DkpA+apDUUFKOjrF8uGq23QM7QDjyr7lzn1gslfmU+XJ88oRKqQerofn7S2azQCWr2F6RP8Y+8LsOmB3WNS2/6kJFHi3EDDvqM6ZOStg99WyRf6qsWdDFU0Q5bMyKK0ZFc7J8vq3Cil9u3HrRaFTsNGeF40hZP+rJT/vpp1ewdxCKdtnzAfC1l76fkoZNYycEmx7RMKXoGIS1DH/Pz7cLkfvAk8GEznCvFTgZTxULyOxvZDTfS0HHusqYwaJcutW495jFKvDqEjA0SuOhR0kfjNmd7s9Pb/EsdHMljd8i0LfjPyLS++RluRZvgwrtbzBWvBNsE1iVJKG6NJ+TIdsysY4u8rBW98rqLNuB+7E6Ono4BUYh4UEp+jJM24qoSZ+HpsncqyUZk80dNbrvVv9oYJw6hpaksKtGbb0foNRnzQ9mtRDMtMKakW2XRYKa7sce7s0k8AeF3goW0vykqC+NEF9TijEP+5/1cnowOJZzFLsowGUY6rOOCmJT31EXQYWktcarUNLuX5hZ82hgGwUSMGf7BtJrSRSb3TQkjvonziywkmcc+FmVLA/NmfCPWtLa+z7G6x+FCSCMVgBr52NP+Z6W87icz1qPJfDQi6y1NSvymbQsG5fUXDIuKYYBg0KL7/Bx8fUJDfxBQVeBBm0e7liRb9BZTrgjEyr6DAAQewbDBGSu9f4q5M6QdL8/l4wrfkPsOWpse4kmjnHoFsJ4m51RyY2CmZ+T2XkV4mERpLgLoq7FUqkAeq00qoDWkfDCzvI7RhbCFrOtE2pEG/7unyvN6lI5e2UEn6TF9MckIhgcU2GUs+knWSDH6INUDQhRueHlGgkWE++OuNWj7j4I3O4cmSagi5+m0eKZmNvGR14T368N7GxvvcyFNONWXnjeAeEKxDUFY4Mk77jkwwEswL+jKdw ktnei3RI xuNHrx/Fkq0DoqKC4waWGGHYJf7ZZQ2d8TbxTuB9ZNSvKE4COzq0WtGQdlJhq+NzqVRIhKohrQiknADEybA+NgFHMO1mw6AAk7caDRvGI4GuzRPYvAV3k97+08s5kGS1tBxnplaN2+iQGDo/xtFhsRnXmQJZAMiK3IYbQIHaHBRkvqPv+2UpGlN/0BJtBSwAgXhLNgcEo2mWoQ/BrvCWK1sVjVQEOiRDBdGaLj+loDAaQx8M1tzrZrPbiabG2zXCrEmlBu+j3uIcP/x1aDeXCfL5GfgqUJ7RsprGJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Sep 25, 2023, at 08:39, Mike Kravetz wrote: > > Allocation of a hugetlb page for the hugetlb pool is done by the routine > alloc_pool_huge_page. This routine will allocate contiguous pages from > a low level allocator, prep the pages for usage as a hugetlb page and > then add the resulting hugetlb page to the pool. > > In the 'prep' stage, optional vmemmap optimization is done. For > performance reasons we want to perform vmemmap optimization on multiple > hugetlb pages at once. To do this, restructure the hugetlb pool > allocation code such that vmemmap optimization can be isolated and later > batched. > > The code to allocate hugetlb pages from bootmem was also modified to > allow batching. > > No functional changes, only code restructure. > > Signed-off-by: Mike Kravetz Reviewed-by: Muchun Song Thanks.