From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11C15D729E9 for ; Fri, 29 Nov 2024 15:45:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7E4F16B0085; Fri, 29 Nov 2024 10:45:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 794616B0089; Fri, 29 Nov 2024 10:45:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65C466B008C; Fri, 29 Nov 2024 10:45:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 47B896B0085 for ; Fri, 29 Nov 2024 10:45:29 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D7FE48124E for ; Fri, 29 Nov 2024 15:45:28 +0000 (UTC) X-FDA: 82839557010.11.A23CE8D Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf25.hostedemail.com (Postfix) with ESMTP id B0521A0014 for ; Fri, 29 Nov 2024 15:45:20 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JxNOJ7Qv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732895119; a=rsa-sha256; cv=none; b=Lsv5Lgqyi8vz1KHdIQKXHk0TeQ524E3afGBVSa2UQJ52t5yZ0BaSLzMQHWbq488GBryBG2 I9YKoURO82diCo2u5X6f+Xhzm0dHm7YoLZDNISVMKh2zbtEUp1n2tax9RzZrYxnOYSDdZR ucifCCJi1k7Jr1ioXGkZNaggXrsEWAY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JxNOJ7Qv; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of nadav.amit@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=nadav.amit@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732895119; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i4Y/6YsRynhUQI3gi/feAQN5R86FvfIbQOixX2P5uMg=; b=LWS6L/OMBzTW8Ou+L9iGgAY4eSWjLj1Hr+F2BkSyY+03ZsqlLDc1kpWdLK4UIT10vqfohb v+GBafPKoGtAiphcuLU+aG0IkrApb4I00Q5rShsKolkQfc7MIrF1MwAx3Ldx/WWY6OIQc5 N0fV93OFXLsOmGC2nh4Qm5iKialNpVY= Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2ffc80318c9so22873111fa.2 for ; Fri, 29 Nov 2024 07:45:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732895125; x=1733499925; darn=kvack.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=i4Y/6YsRynhUQI3gi/feAQN5R86FvfIbQOixX2P5uMg=; b=JxNOJ7QvfD0A7Kskf4fZehIZ3MVlqKZDvl3zJTjKMDGraBafYC94+/2F8iJ3GXha8I 3Hbe1QoshhOFireU1bK1Qhfkm6Hd4cS89b7tdB0YghqnEMcxgSkdQAkQ4nNEAQ20f64m EjGCC2A7Ni2VDBv3BzPnWEHVX0/5FeveJ/cgkPzrhrgqnoravz7rvp3xKraknCJc2Fmw xekiOl3FWN0ohXjFu5WIdVkBlZ9QSGH9UFJsNWAsFcDTRwZ8YtwXd8uQAIf/5sX73B6H /gg0dX/C2FXj7/EnIjJ4E2Smue6W4/J5Y/FjKsXKeXNU7lg3UVcUNpDGq6tEUz7HEd9o tZ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732895125; x=1733499925; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i4Y/6YsRynhUQI3gi/feAQN5R86FvfIbQOixX2P5uMg=; b=njtWARqsG1Pb/lX8nAjjh2q9Ot0akKKgGgRCmd6AiPMi2YigazD7JbEKj4VWCpojQ2 xqA404L/dMQsrumPW7bvlekqiLYMl5rLhIc7tXQSzK9Kn1VmpGFAxFF7qTtAf4GkF9p2 YDtwsTxLbsFYBzErDePCT4q2bYyD0HoKgWEXSa/CZbziiw7HOd7+4sxUcDifojIhO+Y7 GYbAAQF0G0S0//DJKCmj2ni69snTnqy5+Gb7YAnHBaRZ3H1OPTtEXtH5819bV0Ll/h/w Uu3gP4tqoBK73k/H34c4ZsTLXvBenJpLTwHfX4gfQ1XJYJ7Z3QvuAKLvlQMLrpnG1zC6 HIiA== X-Forwarded-Encrypted: i=1; AJvYcCX4Fw/peg0vOugU2Kc6oecfUIzacjfy2QYKHNQ8AbFHe9ltdGLai+YvNXEDSSgqMCLZ3gBiBNivVg==@kvack.org X-Gm-Message-State: AOJu0YzSe7gv+8BSkGGzBfWMs2gg2KlnGllIVeY5zu2fBuOJw5HHJOrH JH4NLAoVDrKCGBsaxhKkqou5ZGlVIr0l/MyCw3mCNjIq/p7AfCYt X-Gm-Gg: ASbGnct/wV1MiuqNGJyVIuByiMobHIO8K+oGu+e48S3FtG0dkdX3vfnN652ETQAggBm jlg70zKVVch28TOIl5K7mK2INUkAlYjkH6SbkOH8J9ZpGM7LDzPPpKknMOMykNriC8UmHf+TcMn fVZo8oJK3d3t01pS1sHMEp5Z5GAXwYy78Ng+h/ruCGwMhCxSNYWW14cbWKjUOMtWM6n8X4vwcLf HKRkW3LrNvPKwY30hD29tKlJSR/dENn3UE9IZSTXsBDjglfWlopfjPLdx50cceGZvg= X-Google-Smtp-Source: AGHT+IGdf09ewurCXHG4aOkkaYVMwJ5lfvxLKfHbX3YBVf0cJU8E7jTdYjT8obhGs9IkbVrmTkJl6A== X-Received: by 2002:a2e:be0d:0:b0:2ff:ce6d:8433 with SMTP id 38308e7fff4ca-2ffd604a03amr86985111fa.8.1732895124540; Fri, 29 Nov 2024 07:45:24 -0800 (PST) Received: from smtpclient.apple ([132.69.243.50]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d0ae0cfc3asm992257a12.18.2024.11.29.07.45.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Nov 2024 07:45:23 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.200.121\)) Subject: Re: [PATCH 6/6] percpu/x86: Enable strict percpu checks via named AS qualifiers From: Nadav Amit In-Reply-To: <20241126172332.112212-7-ubizjak@gmail.com> Date: Fri, 29 Nov 2024 17:45:09 +0200 Cc: the arch/x86 maintainers , linux-sparse@vger.kernel.org, "open list:MEMORY MANAGEMENT" , Linux Kernel Mailing List , linux-bcachefs@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, Dennis Zhou , Tejun Heo , Christoph Lameter , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Linus Torvalds , Andy Lutomirski , Luc Van Oostenryck , Brian Gerst , Peter Zijlstra Content-Transfer-Encoding: 7bit Message-Id: <9CECB9F7-E700-4A92-98B9-6FD027F9CE65@gmail.com> References: <20241126172332.112212-1-ubizjak@gmail.com> <20241126172332.112212-7-ubizjak@gmail.com> To: Uros Bizjak X-Mailer: Apple Mail (2.3826.200.121) X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B0521A0014 X-Stat-Signature: nj1nk1zcfaprwrhtzt4bdm7n5c6rd4gd X-Rspam-User: X-HE-Tag: 1732895120-184004 X-HE-Meta: U2FsdGVkX18+QulUpe6X9SvDI/Jikc/OlWPjFETdNnV4TR8iZJi/TiYIgMB2js/TMxCkoHmhuvBNSHHxJ9FIWkoaTeWUsEUrayttajkH3AIZKlZm2/YmNT4LHwzuYOHdKiAU2R1Pr5HAj451M4gql9upHFdyWtSM5y84/PjT/2/4TnJMmv/dopb0fOyFtq3ZeUkF/JK/t1ORxWvG1kktojQxHyXxIvSkA2Ha8GIwzxavGUAksEETI+4MoIrWccoMP8GogTvlDw8GaERVf6i/dLIiY3jW8wqR9MufCkaa3xXSX74hxsW3OgbuaBtnXbVM3MQ/u1mS3F+tldIxIYP7KsBIx1oSescNo5VKk0FjF8QWV5To0toxg26HLwW/YzmIH3NF3Nx2j+2frPE5QX7kJoW6IL3c4wk0MX+Zj3dFUoFtEc2dOQxfXpi7qnVtRZzGfUAhHw7J2sQcOfKBXa0s1lMbAIq25mzf317e5luHlLEl7ZuUH+DWTurAKjl8j/aFfvJLFKOa2+YSScWU3edIgvFA65g6aJ86ZE7lqPh+PCwYsnzE1uDYfiGiBWe7KYtKIsSHnhl467xlkD/3YaCn/u7di1VZAwdPMJyFUH4M8j0Sxag7RbbEazS4hOanJFlq1FWfuFtPwjZd1dQ6MWHaFvHSZC2jLqvbBSeMyiRz/eYDfH5sTur9GwvDb1vHAWXvgfi0tSRevfar/AamOfxB5e1OUzgxm7Jgiy4H47vDMLWM+S6k/ns8CMvqVB1aOpga/mw4t2cAZ3sV33JihhUVduveMqt/1pIZqoGw4PnELmHDRZ4ORhHhiNsXi999E6qx+NBaH/8a/pfG1vSQGn/VuIBxSxFK1X+htQeuLzjlN4IIclmUQdPTcpKyJq/tvEo0y8Z+0EMPhDLEKe4V/4VOTlFlB6ImqwRhhyUBbgZ1lsKQ/tE6jx8dDmRTgJiAb9i+DkLNlKT2098NIVdGiub uyV13+Sf UUcLsyS7apJDGRhB+Eggqz++fjCEwt+E+7n57W2guGx3m8t9Kj9BPa0eSbSXmAIR3NfaFJWy6JUFe8NolGfQW1nJTXFTGC6kAXHe2aUHk+JzZB2km6kHxzsWR7Mxv7/YvhXVbpzssSVZJirUr4Jy1JQPXsFTb+tplmkRO/3ye8nRENQjj7daxt4s4dPB+8jgavgDtGS7bk2pDoLZ/1m/1YkreGMCJedr80coD069jMyOSABpcJoo/DiI/kvBtFi2XZv8SccDAR1V6GX0amn9OjIJ9PxtwoQKO7N3GaHGm1yN8R5B7hQn+ifmM1YhDc0CXSzg7wcAq8vGdS7o1ieFvD63l2bds1G1Vb2A6by2s1X59Tc9nKQO9k6mLdkyosR2mymtBSVEfq1cE/bLimQa/AaqwM24hlL+DwhTYeMq8ZRiB0gj29b3UgZ/ovbW7RtcxP6NmScZejzBDiDA60x3M/yNagqVeDUCnNJCfsZhT7r9Tbfw7tcmeSbzUsOenYfEV9mFRRnA1LgBItCxHZiYLCmM27NizZWpW2Qi+ncBcpbfsUEg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On 26 Nov 2024, at 19:21, Uros Bizjak wrote: > > This patch declares percpu variables in __seg_gs/__seg_fs named AS > and keeps them named AS qualified until they are dereferenced with > percpu accessor. This approach enables various compiler check > for cross-namespace variable assignments. [snip] > @@ -95,9 +95,19 @@ > > #endif /* CONFIG_SMP */ > > -#define __my_cpu_type(var) typeof(var) __percpu_seg_override > -#define __my_cpu_ptr(ptr) (__my_cpu_type(*(ptr))*)(__force uintptr_t)(ptr) > -#define __my_cpu_var(var) (*__my_cpu_ptr(&(var))) > +#if defined(CONFIG_USE_X86_SEG_SUPPORT) && \ > + defined(CONFIG_CC_HAS_TYPEOF_UNQUAL) && !defined(__CHECKER__) Is the __CHECKER__ check because of sparse, as in patch 2/6 ? If so, do you want to add a similar comment here? Other than that, I went over the different patches and it looks good as much as I can tell. If it means anything, you have for the series Acked-by: Nadav Amit >