From: "H. Peter Anvin" <hpa@zytor.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-mm@kvack.org
Cc: Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Naveen N Rao <naveen@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h
Date: Mon, 07 Oct 2024 09:05:58 -0700 [thread overview]
Message-ID: <9C51DD25-3BEE-4E95-8E2C-F94C1B75F95B@zytor.com> (raw)
In-Reply-To: <6d79c86d-601b-46b9-a06e-6ab78b6d3e8a@arm.com>
On October 7, 2024 4:20:23 AM PDT, Vincenzo Frascino <vincenzo.frascino@arm.com> wrote:
>
>
>On 07/10/2024 12:06, Arnd Bergmann wrote:
>> On Mon, Oct 7, 2024, at 11:01, Vincenzo Frascino wrote:
>>> On 04/10/2024 14:13, Arnd Bergmann wrote:
>>
>>>
>>> It seemed harmless from the tests I did. But adding an '&&
>>> defined(CONFIG_32BIT)' makes it logically correct. I will add a comment as well
>>> in the next version.
>>
>> To clarify: this has to be "!defined(CONFIG_64BIT)", as most
>> 32-bit architectures don't define the CONFIG_32BIT symbol
>> (but all 64-bit ones define CONFIG_64BIT).
>>
>
>You are right, it seemed that every 32-bit architectures with a
>64-bit phys_addr_t had CONFIG_32BIT but this is not the case.
>
>> Arnd
>
Maybe we should have CONFIG_32BIT as a global?
next prev parent reply other threads:[~2024-10-07 16:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-03 15:29 [PATCH v3 0/2] vdso: Use only headers from the vdso/ namespace Vincenzo Frascino
2024-10-03 15:29 ` [PATCH v3 1/2] drm: Fix fault format Vincenzo Frascino
2024-10-04 13:21 ` Arnd Bergmann
2024-10-07 6:10 ` Christophe Leroy
2024-10-03 15:29 ` [PATCH v3 2/2] vdso: Introduce vdso/page.h Vincenzo Frascino
2024-10-04 9:07 ` Geert Uytterhoeven
2024-10-04 13:13 ` Arnd Bergmann
2024-10-07 11:01 ` Vincenzo Frascino
2024-10-07 11:06 ` Arnd Bergmann
2024-10-07 11:20 ` Vincenzo Frascino
2024-10-07 16:05 ` H. Peter Anvin [this message]
2024-10-07 16:23 ` Thomas Gleixner
2024-10-08 13:11 ` Arnd Bergmann
2024-10-08 14:20 ` Vincenzo Frascino
2024-10-09 9:53 ` Thomas Gleixner
2024-10-09 10:04 ` Thomas Gleixner
2024-10-09 23:58 ` Michael Ellerman
2024-10-10 12:37 ` Vincenzo Frascino
2024-10-10 12:36 ` Vincenzo Frascino
2024-10-10 12:35 ` Vincenzo Frascino
2024-10-03 16:25 ` [PATCH v3 0/2] vdso: Use only headers from the vdso/ namespace Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9C51DD25-3BEE-4E95-8E2C-F94C1B75F95B@zytor.com \
--to=hpa@zytor.com \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tytso@mit.edu \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox