From: Zi Yan <ziy@nvidia.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
David Hildenbrand <david@redhat.com>,
Uladzislau Rezki <urezki@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jason Gunthorpe <jgg@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>, Peter Xu <peterx@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MAINTAINERS: add mm GUP section
Date: Mon, 12 May 2025 08:54:53 -0400 [thread overview]
Message-ID: <9AF9CF7D-D4A3-4D97-9B7D-F259E33E982C@nvidia.com> (raw)
In-Reply-To: <eb2b0bce-6012-4019-8ff7-c35c24ba7aa1@suse.cz>
On 12 May 2025, at 3:38, Vlastimil Babka wrote:
> On 5/8/25 14:23, Lorenzo Stoakes wrote:
>>>
>>> M for "PAGE ALLOCATOR", hmmm ..., I was hoping that Vlastimil might have
>>> capacity for that? :)
>>
>> Vlastimil? ;)
>>
>> I'd certainly support this.
>
> OK, can do, thanks.
>
>>>
>>>
>>>
>>> Not 100% sure what to do with
>>>
>>> * include/linux/page_isolation.h
>>> * mm/page_isolation.c
>>>
>>> (I hate the word "page isolation")
>>>
>>> They are mostly about page migration (either for alloc_contig... or memory
>>> hotunplug). Likely they should either go to the MIGRATION section or to the
>>> PAGE ALLOCATOR? Maybe MIGRATION makes more sense. Thoughts?
>>
>> I mean it explicitly relates to migrate type and migration so seems to me
>> it ought to be in migration.
>>
>> Though migrate type + the machinary around it is a product of the physical
>> page allocator (I even cover it in the 'physical memory' section of the
>> book).
>>
>> I wonder if our soon-to-be page allocator maintainer Vlastimil has
>> thoughts? ;)
>>
>> I'd vote for migration though to be honest.
>
> I checked the code briefly and although migratetypes are related to
> migration, it seems rather page allocator code to me.
>
> In fact if I didn't miss these files, I would have included them when
> proposing the PAGE ALLOCATOR section.
> Zi Yan has a series on that topic now and is one of the R: in PAGE
> ALLOCATOR. What do you think?
I agree with Vlastimil that these two files belong to PAGE ALLOCATOR
section. Page isolation (actually should be pageblock isolation) is
doing work on pageblock migratetype, which IMHO is an important part
of anti-fragmentation mechanism for page allocation.
--
Best Regards,
Yan, Zi
next prev parent reply other threads:[~2025-05-12 12:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 17:36 Lorenzo Stoakes
2025-05-06 17:41 ` John Hubbard
2025-05-06 23:21 ` Andrew Morton
2025-05-07 8:05 ` David Hildenbrand
2025-05-07 9:02 ` Uladzislau Rezki
2025-05-07 9:23 ` Lorenzo Stoakes
2025-05-07 9:59 ` Uladzislau Rezki
2025-05-08 8:53 ` David Hildenbrand
2025-05-08 12:23 ` Lorenzo Stoakes
[not found] ` <6050270f-1556-4df3-beab-63e907b28d82@lucifer.local>
2025-05-08 17:43 ` David Hildenbrand
2025-05-08 18:50 ` Lorenzo Stoakes
2025-05-12 7:38 ` Vlastimil Babka
2025-05-12 12:54 ` Zi Yan [this message]
2025-05-12 13:01 ` David Hildenbrand
2025-05-12 13:10 ` Lorenzo Stoakes
2025-05-12 13:06 ` Lorenzo Stoakes
2025-05-13 6:23 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9AF9CF7D-D4A3-4D97-9B7D-F259E33E982C@nvidia.com \
--to=ziy@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jgg@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=peterx@redhat.com \
--cc=urezki@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox