From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 044C4C433E0 for ; Wed, 3 Feb 2021 01:42:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A0E3464F67 for ; Wed, 3 Feb 2021 01:42:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0E3464F67 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=icloud.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 253AE6B006C; Tue, 2 Feb 2021 20:42:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2040C6B006E; Tue, 2 Feb 2021 20:42:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11B8F6B0070; Tue, 2 Feb 2021 20:42:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0115.hostedemail.com [216.40.44.115]) by kanga.kvack.org (Postfix) with ESMTP id F088B6B006C for ; Tue, 2 Feb 2021 20:42:36 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B73793634 for ; Wed, 3 Feb 2021 01:42:36 +0000 (UTC) X-FDA: 77775257112.27.toe50_4c1524f275cf Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id A44413D669 for ; Wed, 3 Feb 2021 01:42:36 +0000 (UTC) X-HE-Tag: toe50_4c1524f275cf X-Filterd-Recvd-Size: 2921 Received: from pv50p00im-tydg10011801.me.com (pv50p00im-tydg10011801.me.com [17.58.6.52]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 3 Feb 2021 01:42:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1612316554; bh=6t1RFU17SOePPL6+ZA76bZtVpmVDB9u2nd5fGo71KuE=; h=Content-Type:Mime-Version:Subject:From:Date:Message-Id:To; b=ry7pyJsU1trJcwpLP98ZhCHb6nDA/p+5VfUqj1qxa908XEqGkrH4XQmgYf6vA6RjS qB6Alak7z9ag2TLIeGJBGdsHFgeGQDkcp0bQvcHFzwevd8aurzFvCzsKz9Se3Fwa9h XiCWor8/oS130ZKwvuwDyPthdXzn3aUVGceEoj/BKU3KPuPaPVmcPttq1LuJrlcCdp f9oslEQUizRxXY8CzmU9CW5DWh/SyZuNmSC/zxIeY8IAFRoQZahw9acNESEvb9iKBy flMqG0tGR2CyyPcy+WmqkKQMRS3dknathaazDdWDY5C1DubHr66BgeqDjxXaOqyej6 TSzncdlSnC7Sg== Received: from [11.240.15.70] (unknown [119.3.119.19]) by pv50p00im-tydg10011801.me.com (Postfix) with ESMTPSA id D77EE66053D; Wed, 3 Feb 2021 01:42:31 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.40.0.2.32\)) Subject: Re: [PATCH] mm/slub: embed __slab_alloc to its caller From: Abel Wu In-Reply-To: Date: Wed, 3 Feb 2021 09:41:58 +0800 Cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , hewenliang4@huawei.com, wuyun.wu@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <9A811B32-6E3D-4FE1-98A5-A7922C32CDB4@icloud.com> References: <20210202080515.2689-1-abel.w@icloud.com> To: Christoph Lameter X-Mailer: Apple Mail (2.3654.40.0.2.32) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-02_13:2021-02-02,2021-02-02 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 mlxscore=0 mlxlogscore=633 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2006250000 definitions=main-2102030005 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Feb 2, 2021, at 6:11 PM, Christoph Lameter wrote: > > On Tue, 2 Feb 2021, Abel Wu wrote: > >> Since slab_alloc_node() is the only caller of __slab_alloc(), embed >> __slab_alloc() to its caller to save function call overhead. This >> will also expand the caller's code block size a bit, but hackbench >> tests on both host and guest didn't show a difference w/ or w/o >> this patch. > > slab_alloc_node is an always_inline function. It is intentional that only > the fast path was inlined and not the slow path. Oh I got it. Thanks for your excellent explanation. Best Regards, Abel