From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49A40C433DF for ; Thu, 9 Jul 2020 20:55:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0A9C420672 for ; Thu, 9 Jul 2020 20:55:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="HiOXR57s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A9C420672 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6CC686B0003; Thu, 9 Jul 2020 16:55:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67D3A6B0005; Thu, 9 Jul 2020 16:55:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 593F16B0006; Thu, 9 Jul 2020 16:55:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0236.hostedemail.com [216.40.44.236]) by kanga.kvack.org (Postfix) with ESMTP id 426C76B0003 for ; Thu, 9 Jul 2020 16:55:12 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F0E39181AC553 for ; Thu, 9 Jul 2020 20:55:11 +0000 (UTC) X-FDA: 77019742422.27.badge58_290700e26ec8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id BD0063D663 for ; Thu, 9 Jul 2020 20:55:11 +0000 (UTC) X-HE-Tag: badge58_290700e26ec8 X-Filterd-Recvd-Size: 6338 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Thu, 9 Jul 2020 20:55:11 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 069Klo6B129317; Thu, 9 Jul 2020 20:55:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=content-type : mime-version : subject : from : in-reply-to : date : cc : content-transfer-encoding : message-id : references : to; s=corp-2020-01-29; bh=yTM7ZN0hE4N0rG66+SrzWWOp5RSaxRPDr6gARva89Ss=; b=HiOXR57sB4vrzNSamIqby84acE82bLfVX+6Do6BUZY6rVWY2CzGMlELLNzjifS2royGs bz36AG+JKLAMkrLE3f0HesmYgaNjJs/AqM97X2lf4Ahn4S0Ogl1Xsq/q8UZ/iC9KuOz0 sWwo6RxPcMYPmPxspGwOnjgKCJDKHwqwDnscnMg7IpRS6FcAtL3tUKlw/LqOsMyCVxIR 2OqJrbxogTyKHqfChMvyWZcGO2C/oZqxqTqTny+zrW8wXDMdeRFoyxqOsQ/lkfMiV78s 3Ruf5LxJDpxXvQsERUJTntdOxuWPEqYlqdDQcpcvZtTOaBE0iEucTuNP2B1LxwkIAX8b Iw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 325y0am43p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 09 Jul 2020 20:55:03 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 069KrHc3191963; Thu, 9 Jul 2020 20:55:03 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 325k3j0cd7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Jul 2020 20:55:02 +0000 Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 069KssNO012009; Thu, 9 Jul 2020 20:54:55 GMT Received: from [192.168.0.110] (/73.243.10.6) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 09 Jul 2020 13:54:54 -0700 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3645.0.6.2.4\)) Subject: Re: [PATCH v2 0/6] Improvements for dump_page() From: William Kucharski In-Reply-To: <20200709202117.7216-1-willy@infradead.org> Date: Thu, 9 Jul 2020 14:54:53 -0600 Cc: linux-mm , Andrew Morton , Vlastimil Babka , John Hubbard , "Kirill A. Shutemov" , Mike Rapoport Content-Transfer-Encoding: quoted-printable Message-Id: <9A372D8D-73B5-4B6F-82BB-07926E39E555@oracle.com> References: <20200709202117.7216-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" X-Mailer: Apple Mail (2.3645.0.6.2.4) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9677 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 adultscore=0 suspectscore=0 malwarescore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007090142 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9677 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 priorityscore=1501 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007090141 X-Rspamd-Queue-Id: BD0063D663 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Just a formatting suggestion: > On Jul 9, 2020, at 2:21 PM, Matthew Wilcox (Oracle) = wrote: >=20 > Thanks to everyone for your feedback on v1. I haven't added any acks > from v1 because most of the patches have changed substantially from = v1. >=20 > Here's a sample dump of a pagecache tail page with all of the patches = applied: >=20 > page:000000006d1c49ca refcount:6 mapcount:0 mapping:00000000136b8d90 = index:0x109 pfn:0x6c645 > head:000000008bd38076 order:2 compound_mapcount:0 compound_pincount:0 > aops:xfs_address_space_operations ino:800042 dentry name:"fd" > flags: 0x4000000000012014(uptodate|lru|private|head) > raw: 4000000000000000 ffffd46ac1b19101 ffffffff00000202 = dead000000000004 > raw: 0000000000000001 0000000000000000 00000000ffffffff = 0000000000000000 > head: 4000000000012014 ffffd46ac1b1bbc8 ffffd46ac1b1bc08 = ffff91976f659560 > head: 0000000000000108 ffff919773220680 00000006ffffffff = 0000000000000000 > page dumped because: testing >=20 > Matthew Wilcox (Oracle) (6): > mm: Handle page->mapping better in dump_page > mm: Dump compound page information on a second line > mm: Print head flags in dump_page > mm: Switch dump_page to get_kernel_nofault > mm: Print the inode number in dump_page > mm: Print hashed address of struct page >=20 > mm/debug.c | 75 +++++++++++++++++++++++++----------------------------- > 1 file changed, 35 insertions(+), 40 deletions(-) As this output is meant to be taken as a block, it might be more legible if each line after the first was indented by a space to make that = instantly clear by sight (as git does when generating the list of changed files = above) and perhaps add a prefix/suffix to make the "dumped because" line stand = out a bit more. A space between the value and flags in the "flags:" would also be nice. This would then look something like: page:000000006d1c49ca refcount:6 mapcount:0 mapping:00000000136b8d90 = index:0x109 pfn:0x6c645 head:000000008bd38076 order:2 compound_mapcount:0 compound_pincount:0 aops:xfs_address_space_operations ino:800042 dentry name:"fd" flags: 0x4000000000012014 (uptodate|lru|private|head) raw: 4000000000000000 ffffd46ac1b19101 ffffffff00000202 = dead000000000004 raw: 0000000000000001 0000000000000000 00000000ffffffff = 0000000000000000 head: 4000000000012014 ffffd46ac1b1bbc8 ffffd46ac1b1bc08 = ffff91976f659560 head: 0000000000000108 ffff919773220680 00000006ffffffff = 0000000000000000 >> page dumped because: testing << However I realize this would mean making changes to things you haven't = modified as part of this patch, so feel free to put my suggestion on the back = burner for now if you like.=