From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F8DC54FB3 for ; Mon, 2 Jun 2025 15:50:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F0E46B02E6; Mon, 2 Jun 2025 11:50:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C9A16B02E7; Mon, 2 Jun 2025 11:50:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B9716B02E8; Mon, 2 Jun 2025 11:50:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id F2BC46B02E6 for ; Mon, 2 Jun 2025 11:50:57 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ABE38160AF3 for ; Mon, 2 Jun 2025 15:50:57 +0000 (UTC) X-FDA: 83510898954.22.531BFDF Received: from flow-a6-smtp.messagingengine.com (flow-a6-smtp.messagingengine.com [103.168.172.141]) by imf03.hostedemail.com (Postfix) with ESMTP id 8318D20010 for ; Mon, 2 Jun 2025 15:50:55 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=bsbernd.com header.s=fm2 header.b=YCpnVtE0; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="q emG5ls"; dmarc=pass (policy=none) header.from=bsbernd.com; spf=pass (imf03.hostedemail.com: domain of bernd@bsbernd.com designates 103.168.172.141 as permitted sender) smtp.mailfrom=bernd@bsbernd.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748879455; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ECtcKLbK8c4DaaUNIeCZvRoLrnqb0sjqKj+TVBnd5MM=; b=YizOFGE4BseUwPn5VAivx8oDh1M205c4FLToQfe2+xFHJGwuiockx56cg/Vc0dSLEPvkZk kfHBtXEf7gZWMYdBXa/ja9wldUhAHitSjsCr/JaD98aLk8orUJX0PTSMzisiRwrasmv/Ef CmQChp3sB3UMO1QUyB0cGLSO4Hiw3t4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748879455; a=rsa-sha256; cv=none; b=BbjzYfKkdz+9tVOqp9pXwtu3fTAO7mkbfOTMRVhq+budgEmwKZsffcmEYsGTI+2O3qvFU6 cgERM3NWk7HYFj8XyiUYd+4y6Ubm5MoTSG6A1KX9k16qOSjmJQpO4gKAlIJk8OkO7xLp/a 9Rp7Yx6JPTBXyVq6/a7+LU1DJbwF9ZE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=bsbernd.com header.s=fm2 header.b=YCpnVtE0; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="q emG5ls"; dmarc=pass (policy=none) header.from=bsbernd.com; spf=pass (imf03.hostedemail.com: domain of bernd@bsbernd.com designates 103.168.172.141 as permitted sender) smtp.mailfrom=bernd@bsbernd.com Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailflow.phl.internal (Postfix) with ESMTP id BFAAC2005B9; Mon, 2 Jun 2025 11:50:54 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Mon, 02 Jun 2025 11:50:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsbernd.com; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1748879454; x=1748886654; bh=ECtcKLbK8c4DaaUNIeCZvRoLrnqb0sjqKj+TVBnd5MM=; b= YCpnVtE0/pyuTPAo2dUvlNHyIRQp7CHCmumKiV4wfwZrMpKynIqCRMi+p1/fH5ki dj4E9tYR3TXOZPU5t4o4uq231s9oha8SLHh8CQyqQyBALR8a/A2n+Vx+H7X+Q9Sn 4ViHCvQ+jDpY1ADZJhYZOd0rga8bV2PNb5l8i5cQHJI++ZlV7jX97e503FVyTCD7 j9a5w/cvUwsafKwtV/zrt1Q3kf750UNmYz8ITYWJf+FB1ExoeN4skydEd3q7rxoR feKziDyh97pABpZ5fLlQXcFoXsgxnfaICi7zMZ2D8toOxbS61HHSS6p8FLxbe4J6 MhejaeOuGfov8wiSRSgi0Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1748879454; x= 1748886654; bh=ECtcKLbK8c4DaaUNIeCZvRoLrnqb0sjqKj+TVBnd5MM=; b=q emG5lsW68M9FqVhhIEhFON2CaL0suvIwrG82ESHJpVIu1h3F/i191l9hV+Dbzq2K 6XbF2zYr9jTBC1UrwkB3ellb0/A+EYiudo0Eb/FvWwMOlm5klcdWq7LCWxNije/t mxfhG+dmqTcPiclnja7pOoXEAWSEZbgBHjFyfwNoMVSgyHOQYgQmOOTE4O+oZgSC laHY3LCBhpMnCsw39vPQujbi3SoZggk0SN27jw1FE2mQRTc2OH+q6fTfh9ZFVEEw PFsDIa8JF1LBia8YhzqwxFRv9h09aCTenlxMHU+Kw1W4v5MBfwjJBsYThMYAC0if jZoJMt5/e30D8q85LL4lQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgdefkedtjeculddtuddrgeefvddrtd dtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggft fghnshhusghstghrihgsvgdpuffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftd dtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkffggfgfuvfev fhfhjggtgfesthejredttddvjeenucfhrhhomhepuegvrhhnugcuufgthhhusggvrhhtuc eosggvrhhnugessghssggvrhhnugdrtghomheqnecuggftrfgrthhtvghrnhephefhjeeu jeelhedtheetfedvgfdtleffuedujefhheegudefvdfhheeuveduueegnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepsggvrhhnugessghssggv rhhnugdrtghomhdpnhgspghrtghpthhtohepfedupdhmohguvgepshhmthhpohhuthdprh gtphhtthhopehhtghhsehlshhtrdguvgdprhgtphhtthhopehkuhhnuggrnhdrkhhumhgr rhesshgrmhhsuhhnghdrtghomhdprhgtphhtthhopehjrggvghgvuhhksehkvghrnhgvlh drohhrghdprhgtphhtthhopegthhgroheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohep vhhirhhoseiivghnihhvrdhlihhnuhigrdhorhhgrdhukhdprhgtphhtthhopegsrhgruh hnvghrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehjrggtkhesshhushgvrdgtiidp rhgtphhtthhopehmihhklhhoshesshiivghrvgguihdrhhhupdhrtghpthhtoheprghgrh huvghnsggrsehrvgguhhgrthdrtghomh X-ME-Proxy: Feedback-ID: i5c2e48a5:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 2 Jun 2025 11:50:50 -0400 (EDT) Message-ID: <99f79383-479e-4df1-9650-61fa3c600171@bsbernd.com> Date: Mon, 2 Jun 2025 17:50:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/13] fuse: add support for multiple writeback contexts in fuse To: Christoph Hellwig , Kundan Kumar Cc: jaegeuk@kernel.org, chao@kernel.org, viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, miklos@szeredi.hu, agruenba@redhat.com, trondmy@kernel.org, anna@kernel.org, akpm@linux-foundation.org, willy@infradead.org, mcgrof@kernel.org, clm@meta.com, david@fromorbit.com, amir73il@gmail.com, axboe@kernel.dk, ritesh.list@gmail.com, djwong@kernel.org, dave@stgolabs.net, p.raghav@samsung.com, da.gomez@samsung.com, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, gfs2@lists.linux.dev, linux-nfs@vger.kernel.org, linux-mm@kvack.org, gost.dev@samsung.com, Anuj Gupta , Joanne Koong References: <20250529111504.89912-1-kundan.kumar@samsung.com> <20250529111504.89912-11-kundan.kumar@samsung.com> <20250602142157.GC21996@lst.de> From: Bernd Schubert Content-Language: en-US, de-DE, fr In-Reply-To: <20250602142157.GC21996@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8318D20010 X-Stat-Signature: jjg4nuhymeq65xyb336rz6kxqqbh9sqb X-Rspam-User: X-HE-Tag: 1748879455-115189 X-HE-Meta: U2FsdGVkX1+UsWmvStDuOe+qb/IlRAW6N71RjPzdaG0qN3rN+RLloJG3GdJNpgqn8PSUwo8yP1eqsLzPNzZjqYLTqYmZqJYbNHITlQeRp7t1yLXoHQBdUiDQcdlVJRcpRkF2iKgLxlBITvzexkLYnFWdyp7RqiN2VEvVqzT7kkZ1O+VTIrLBRvVAN9eAT4EjkbKBlrD4i1WM8TJMGED+KPSvjP8pW5GSg7mKUAb39N6xtcVJzgv6/OeIyAsLWEoh8vyRemJGaBcrZvh7H17aSy1/sP4bBbya77aVP1VRCP0SPqEoJLPPvn3V4o1kOzf3LoicJy6h1fazqmpy5gcCSCQNnzFLSS8Tp5BwjRW2TnT0fJSV2u8gHjO3petRpwr7En40JdnX/gJkCC266Z6iSTQ/incBsztxx6Qxsvg1YGUtlUyeK4HoDs1ykIY1v4jecA4fmELE/XlVmtXHMy/1tg6ij7opLlmrPZWy/DFkHShxwViqTUwW+WS7V80F78eemcBRODHsIKDw3eVMTWOYpcH3g8gpRhS7K6aNzr6QSVz33w5Izx76Sf6C0L3QoaBUtAxzUcxDq+Bo8DdncJVeoGowPa+beRLe12jz4NMrf/TqxIYFeEPOslJj/KGsMd/TxPh1DR0emf/9foj8KnF0eqFBHHm6GuH7qfdK3adoGzCUnzLdV5MJRISWSDnuXUEbYY5JThRBNOWZ0oVNFxzKjbPELdhDfQ9X/pCOhZmW3NOnRlyF7EEpO+PtbrMEkPvc1nRiN7DlmTQAp84+hmND5bELqI4Vx+7bicqMLoPZ4LBhlm89O6Y1RWPQiZb8sNsAfxAkey9VBVUlqPPAOXsDuvnnKln03yrNes9o8sFWpaylNyW0BKlI228+oNkVbWGQpHQBh/IJ48aWL0trBMEHq6knSWnRWEMYcq8oAuy7tO0m1UutWEpuVxu77SagJzww8V6Iep9Z4bI/TS7lUC2 GgZSMUaM M0XXcyQbTlF6+am7VgMEyy9+sEEGUQeohHrJu/h048OnNjOr7eYTQAQ3Y/H2eOvSSY9sNLyPmmwU4EJyLV7fvRM4DO4vveC1neUbHYdqHgsATfAjpqNeNjUjRxq8oKw7gPLluXUMpgahurApAgNWUuLs36UBLiKhUC1pzcFBHIvjTPnOXDOqSyQqs2InxEDjX+BunXvpdJV6E9+3iXAyOsI2YztDjqMdm/pzSwbKxuJWx60W1zyfHMM/YWfC0rBXBYZE6Z4z/BQ8yBLV7yAmoqtcQ+gTPY5O1yhGiNDvpV0XroOeZ/0fbsPfQEa/8WToJu5KvIf2hLS/aAyADuCwQ9G7y56Bq8O68IyeAjFIZDc5E1Wh/qX3TLdmTaUxI6wlDKLmwznUppT7e9nXHNKc+FLbFZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/2/25 16:21, Christoph Hellwig wrote: >> static void fuse_writepage_finish_stat(struct inode *inode, struct folio *folio) >> { >> - struct backing_dev_info *bdi = inode_to_bdi(inode); >> + struct bdi_writeback_ctx *bdi_wb_ctx = fetch_bdi_writeback_ctx(inode); >> >> - dec_wb_stat(&bdi->wb_ctx_arr[0]->wb, WB_WRITEBACK); >> + dec_wb_stat(&bdi_wb_ctx->wb, WB_WRITEBACK); >> node_stat_sub_folio(folio, NR_WRITEBACK_TEMP); >> - wb_writeout_inc(&bdi->wb_ctx_arr[0]->wb); >> + wb_writeout_inc(&bdi_wb_ctx->wb); >> } > > There's nothing fuse-specific here except that nothing but fuse uses > NR_WRITEBACK_TEMP. Can we try to move this into the core first so that > the patches don't have to touch file system code? > >> - inc_wb_stat(&inode_to_bdi(inode)->wb_ctx_arr[0]->wb, WB_WRITEBACK); >> + inc_wb_stat(&bdi_wb_ctx->wb, WB_WRITEBACK); >> node_stat_add_folio(tmp_folio, NR_WRITEBACK_TEMP); > > Same here. On pattern is that fuse and nfs both touch the node stat > and the web stat, and having a common helper doing both would probably > also be very helpful. > > Note that Miklos' PR for 6.16 removes NR_WRITEBACK_TEMP through patches from Joanne, i.e. only dec_wb_stat(&bdi->wb, WB_WRITEBACK); is left over. Thanks, Bernd