From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78783C433FE for ; Mon, 3 Jan 2022 01:30:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B46C36B0071; Sun, 2 Jan 2022 20:30:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF72F6B0073; Sun, 2 Jan 2022 20:30:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 997A16B0074; Sun, 2 Jan 2022 20:30:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 88FD46B0071 for ; Sun, 2 Jan 2022 20:30:07 -0500 (EST) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 4C9F78DF9A for ; Mon, 3 Jan 2022 01:30:07 +0000 (UTC) X-FDA: 78987244854.24.256B85A Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by imf16.hostedemail.com (Postfix) with ESMTP id ED980180006 for ; Mon, 3 Jan 2022 01:30:06 +0000 (UTC) Received: by mail-qt1-f182.google.com with SMTP id z9so29071990qtj.9 for ; Sun, 02 Jan 2022 17:30:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=dJmlpeHSzmfPJzpdR8dElrYeKtTVZ8FFq7eOaPLKW50=; b=iEl8PTw5kxW9uQMR2htcKzRV7nuyoMH8TpFXVbLKnB/KaIGhkMcYarLoKVcz94oSWj dibvuEi1RGHrhu82DbFNanrdapY++qC1xeFYCi2amTLl8NKB/Jzhk/RfmdIeEl7Y8hi2 te1tKtO51yPigpEgTWlZbvpFBlMh84mX2r7YebmOayfhPkGaok7lErBVmkEpkdGf0lHn Ry4iJxRVWheFObEkKqqWJPsANxhEUnqCTg4WYI6vnkcB9CIgsiFrOWNNdXo27l1TRvqT eY2Mj/Gj2ihJ1xrFTBTazvMgR7lXktPza4fQx6DUv8ktoTqaHGhAW+SfHiBDpSXSbqKa QECA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=dJmlpeHSzmfPJzpdR8dElrYeKtTVZ8FFq7eOaPLKW50=; b=uMpnQaHC/VqwC83AlIrrZzOrQMYUv7cTAWNRHdo2UUXfC61l8AxIz4KT41na9GYOBt RkCi0Z6UD+1Gx1b9m0GWFaotfMUrq+1CnHoGyjVJDM/A4m4gBsi9/BSBQDZJsWZZZPeg sme0kN94BoQmFWChOCs4otVvt7SscMvWommcBhY3W1ePgL7aSwu/43OlyU1WYUMUpRJQ B6V2V3s2yV51X5dfRz8ozDuC+CmfllVQT2ok7/svKgWd8WHnDunNZSYkYkeN9psbvOv3 0nvqz36SW79FstQYCt7pywCAa2AjXiLStfk+JzwQw0UWvyQqotbBLMr0wN1jOGgnWAnM 6HGg== X-Gm-Message-State: AOAM533UcC6DAzcZoy+fY7C7KGId82C+z+a60bGMqV7FFuqbc8Ts5o9q d/Q+h+t3gIQfsKVMwjMuWWCplQ== X-Google-Smtp-Source: ABdhPJy9i777qv46jr1hDVhdfsWKo7Ysd8uFrVYPh+XwMsYq08qLvk3ooVii0C7GvNqADjWWevLtfg== X-Received: by 2002:a05:622a:14:: with SMTP id x20mr37442474qtw.671.1641173406157; Sun, 02 Jan 2022 17:30:06 -0800 (PST) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d17sm27315032qtb.71.2022.01.02.17.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jan 2022 17:30:05 -0800 (PST) Date: Sun, 2 Jan 2022 17:29:54 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@ripple.anvils To: Matthew Wilcox cc: Andrew Morton , Christoph Hellwig , Jan Kara , William Kucharski , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 00/48] Folios for 5.17 In-Reply-To: Message-ID: <99f710fa-e5c3-18b3-51dc-bef89c989ed8@google.com> References: <20211208042256.1923824-1-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: ED980180006 X-Stat-Signature: 7sbcngbj1pqm7x3eipokgcupaj1ga8u9 Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=iEl8PTw5; spf=pass (imf16.hostedemail.com: domain of hughd@google.com designates 209.85.160.182 as permitted sender) smtp.mailfrom=hughd@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam10 X-HE-Tag: 1641173406-754235 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 2 Jan 2022, Matthew Wilcox wrote: > On Wed, Dec 08, 2021 at 04:22:08AM +0000, Matthew Wilcox (Oracle) wrote: > > This all passes xfstests with no new failures on both xfs and tmpfs. > > I intend to put all this into for-next tomorrow. > > As a result of Christoph's review, here's the diff. I don't > think it's worth re-posting the entire patch series. Yes, please don't re-post. I've just spent a few days testing and fixing the shmem end of it (as I did in Nov 2020 - but I've kept closer to your intent this time), three patches follow: mm/shmem.c | 58 ++++++++++++++++++++++++++------------------------ mm/truncate.c | 15 ++++++------ 2 files changed, 38 insertions(+), 35 deletions(-) Those patches are against next-20211224, not based on your latest diff; but I think your shmem.c and truncate.c updates can just be replaced by mine (yes, I too changed "same_page" to "same_folio"). Hugh