From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E25C3ABBE for ; Thu, 8 May 2025 15:03:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F5126B000A; Thu, 8 May 2025 11:03:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A2036B0082; Thu, 8 May 2025 11:03:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11A796B0083; Thu, 8 May 2025 11:03:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E9FE66B000A for ; Thu, 8 May 2025 11:03:53 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 6068D1CCF6D for ; Thu, 8 May 2025 15:03:54 +0000 (UTC) X-FDA: 83420060388.09.C8786EF Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id E60ACC0014 for ; Thu, 8 May 2025 15:03:51 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XU4oLeqQ; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746716632; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0A3k4r7gW5UVXrE6QQjqPyS0bUfFQ+JNzCXgzNYHnZo=; b=qjRVjBFXae+YgUoikE8WdeAK6of/81xhLFljWwbRg1v19e2MNMDykGh7sW6/Bv58LY/9NM cQ6aqUQvzKIL/45OIrLo5HY90do4rH6sxXaN4SYnmKTEnRfqGiknIuuc2XfLPP0vM7pgBC o6aE3QJCAEbVTxmg7urWg6xnBlyf88w= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XU4oLeqQ; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746716632; a=rsa-sha256; cv=none; b=ygqu4KwlYB0cVSYMWpOtq6ILz3fxWFdBU6vO8m3opKJRYkfN5qDBcN3OIYHhnGCff2pR8h Lfb3f0kHce8B0L01/6o2p2Aa8rvOya4U6NCGcxTnUsnfz652h8bP1VJCxezbcS+mKelEgy VC7URvgv9zGUQVKLi1ddG2qLmh8vp8c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746716631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0A3k4r7gW5UVXrE6QQjqPyS0bUfFQ+JNzCXgzNYHnZo=; b=XU4oLeqQ/ZhIdGDDOX+NYkkwq5muKvTmPThv/snaR4dROBnXXDexhj33RPnCjtrghYBVTU dPWkytPH4GMieRN9YY+ddLRVPZ4ILF9bN9Li4WcDHwaRyuFNWoUNj4wXy0gTFn2HgEbwvl jg+qf0CbsYQ+bnruDLybms5juL8uJfA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-3VawiMskNIma1udXHMS8Jw-1; Thu, 08 May 2025 11:03:50 -0400 X-MC-Unique: 3VawiMskNIma1udXHMS8Jw-1 X-Mimecast-MFC-AGG-ID: 3VawiMskNIma1udXHMS8Jw_1746716629 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a0b394504cso947142f8f.1 for ; Thu, 08 May 2025 08:03:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746716629; x=1747321429; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=0A3k4r7gW5UVXrE6QQjqPyS0bUfFQ+JNzCXgzNYHnZo=; b=Lw/Io2gKcRL4TACRqG8oYEro4Ml3DF1qXI5r8mDi9vQD9jsy+0YjXjkWb6uj/2hzTP yfo83aMAkzWdyOL9G125Fp75Rafa1tK3RcOYJVwOZbOtR6jfkHIUMZaLwLjd35UvckA1 KyZqhr7Em67YBFfX4k09sB7CLkWk9YSUBEzOMuO6cHuEMA9do5HN0gyl22KsC9Op2Ak/ L9r62Rxi0CAP+uALyTuR2QFVXPEQvOeImWaIAcjqveyR3Hb3l9LQX0d4GXIOuXG7zHY5 FEx9E6SuvQlSo8otRP+ZaUzrher2ItL08jqyd5UM71cv/tpIwAcaBd6u9XJ672G8JWt+ MN3A== X-Forwarded-Encrypted: i=1; AJvYcCXb0wcJYiUx9EmUbDfAwH78GEKfnZ6M4HIeSVz2g+J8Kj6Za8Ba8TtNAfMdubOEnc7WXPWdX6PaiQ==@kvack.org X-Gm-Message-State: AOJu0Ywsg/Gh+iEkIaGTm4hfOpdBX2J010X+jo1qXbpXFq/8U6Wqtel/ KKvIDeLQMcs7LbZkUx5gMJGMejjc4zwcDFC+jyNW1GSr61jhjKtkYzFslwx3gs3sSABHSRGqbX/ e+AxCt+Y7mCofrFllJmJj+M3tY05aYLg0qDHN2BzcH1qkljPA X-Gm-Gg: ASbGnctfGp9wFXoxGCvdt3OVMB1fzxY+ctUQuBaJj/R04KlTr/ClWt2QvCGYH+GSmHf LnBLZi619izifJojwj+PlxfFdRr0OzpapY+wZ5kxIbNO134xAUQA2dODCSJHeJ85j4abxv1RADM G6MegtCyjGkYGSU/Lk838GdI+Q8DsRtxJREMcuDFCxTGvljKaL5pYqrOW2jgtfNQOb1EAKawSXt N7jrQfLOifMMWhFUT6onBSAxO0jNg2CztJQLPSKkg2X9nNlMKHex3zR9o/0gp5gTVGzOGeIvWwC ezbl8sBx+Xtcpgq1LlBW46koBwZOKiMTwtSh/PDP243hZAMucdHEy6c/XGkP/SL8H3zBr7V8Ly7 EHEGu+o1sj0ZAFXK3XKPdu945CzL/zRRXkLiDv0Y= X-Received: by 2002:a05:6000:2a7:b0:3a0:8c01:d463 with SMTP id ffacd0b85a97d-3a0b990e2b2mr3562900f8f.9.1746716628724; Thu, 08 May 2025 08:03:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGx8yXNIhT1hUz4xWiwQQ29Va0Sgz3iLNOyvxn9tuUzOatsvNXpRv8L6O8svQ44smramfRUxQ== X-Received: by 2002:a05:6000:2a7:b0:3a0:8c01:d463 with SMTP id ffacd0b85a97d-3a0b990e2b2mr3562840f8f.9.1746716628057; Thu, 08 May 2025 08:03:48 -0700 (PDT) Received: from ?IPV6:2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c? (p200300d82f3e590027aa5f4ab65c3d3c.dip0.t-ipconnect.de. [2003:d8:2f3e:5900:27aa:5f4a:b65c:3d3c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a1f58f2f58sm215860f8f.49.2025.05.08.08.03.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 May 2025 08:03:47 -0700 (PDT) Message-ID: <99ed92b7-c1b2-4e12-a7ee-776a7f890b47@redhat.com> Date: Thu, 8 May 2025 17:03:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] Fix zero copy I/O on __get_user_pages allocated pages To: Pantelis Antoniou , Andrew Morton , linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Artem Krupotkin , Charles Briere , Wade Farnsworth , Peter Xu References: <20250507154105.763088-1-p.antoniou@partner.samsung.com> <20250507154105.763088-2-p.antoniou@partner.samsung.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250507154105.763088-2-p.antoniou@partner.samsung.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cJj5cJNClbqbDGxlNFjPOvZo477JN5_A1rtcGoZi4-g_1746716629 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E60ACC0014 X-Stat-Signature: bi3qera4419dcftr1b9gpns554zpk778 X-HE-Tag: 1746716631-209586 X-HE-Meta: U2FsdGVkX19r0DBVHeez8Lc/xCH+Ms55pb+SwyzCgpRmJCEbMQfDbDK+b71DKZYVHz6kVDuH+8ZEygD0ZBvZNUbbiVOu3juENDQi/Q/EweYvNDJIToLrvi661Jd+yaMpifw5kbGMBz4v4aAAT2ZsxstoFIRT09N/HiQdoz81a/KT4PRaG7r215hbVZAHHr5vDR22xyGK2Pf0CBDQWrXs27JCN9RjjCD4mZrPOPFq2XPRk6nq1hCv5Bos1PX2bZRykvAg6HCaiVNJChI4hIN7dCiVkXJ8kwItv8pgmTc8Qg7QSigL5c+D79gvhg4+i6UN4VQYYX6JCTen2+ookjn0TpkpVbSeIly5DlF3dNEzc3u5A64Pm4/MMKKQyzaapMBZRDE50Ke6Ity/znY7lv7XuWOZIqYcQllcrZj2loMVnWCmCKROTESyUB/Q3IlXynMoLLHI3lU+DxtQkn7kB7984+UfbCeH8gp/0lKEL2kK/+Oy8poZIeOwzrABik4vhRoDWp0t8EQ5n3LGkb7I6/AiICzaVNbFdmAHw6Ut/QnGkoZGIW70mZKLjIPCGLdhTRVIepWv944d7t+JvLXzZKk7FOwTt7NF4Lsp94bMklWFg3Wb30/tQJDGpUqATkC91+V9g+tEv6ShZL/5tIxcxfk6P/tR6isGV6xmXeIuK58sE3i/30s56//RUyzhE8JXNOq/Wnz75oNZilXh3Z4aSSNtPJrYqpvkna7mhWS0bf5FlglPpPIDYSFirtxIBdNMck0g3+R+ofrziKZ9kRp0SpZH9McrvBCC7AUdKCioNDrHC1g9RFU1DCUc5Z6GsaNl0nL4n6hKpsMyMnflSN5xcMjNiqdXHwZrSWTlrod1XEhVv2JWtoHmonsvV+bt9XklRA1M/c7+8OQUh4WGYHhh3iKg57WiuS+/zdcMhuUsYoU7ENKLzrbti5RNglUp495BBepEFxlS34yve7WWfXBaEa9 LG3jkipD hlMr3kxUD2/5o1tw3tjtV67Nt2vVqlA3/o/Oq8TeOWoCb462+OWayHADCn4LLjd2eSqtnBQUythcoSfqplAX1xu4CBwIpp27rYfP7DU6q2UocwZlMjeU7++POM0H2Nb3uT6X/zY5ZZ+Xx6kXYHhQi4KsDwnnw/61eGc0ahD1BIc9dG3jBLhsQrGK4VNLERwwel0HX+r2Vgm5a3/V0J2S4LJtYZHctI91vqEIlyamEB9jwFY4esPR0MTmkqoJAxeLO7NaFsVEPTooaCLPGVmLkuNjj/3rTAUFJ66CjIk0x3OO45VZtND833bVOMK16ffWB5ABGNfntagzxtu8UgOznzxr4Ua2Cjk8if2s4HUPmM4tkOEf4HJJaDAW9Aauc8iWSdfANUDg9SooP3j4oZD9N70SgyyfFCTEAImfYMc1UAaIthWz5nvlH95bPH43ANyooaw8AITYj+0Z3kgQ8AUJ1TjqBYdvtB6N7oZr8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 07.05.25 17:41, Pantelis Antoniou wrote: Hi, > Recent updates to net filesystems enabled zero copy operations, > which require getting a user space page pinned. > > This does not work for pages that were allocated via __get_user_pages > and then mapped to user-space via remap_pfn_rage. Right. Because the struct page of a VM_PFNMAP *must not be touched*. It has to be treated like it doesn't exist. > > remap_pfn_range_internal() will turn on VM_IO | VM_PFNMAP vma bits. > VM_PFNMAP in particular mark the pages as not having struct_page > associated with them, which is not the case for __get_user_pages() > > This in turn makes any attempt to lock a page fail, and breaking > I/O from that address range. > > This patch address it by special casing pages in those VMAs and not > calling vm_normal_page() for them. > > Signed-off-by: Pantelis Antoniou > --- > mm/gup.c | 22 ++++++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 84461d384ae2..e185c18c0c81 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -833,6 +833,20 @@ static inline bool can_follow_write_pte(pte_t pte, struct page *page, > return !userfaultfd_pte_wp(vma, pte); > } > > +static struct page *gup_normal_page(struct vm_area_struct *vma, > + unsigned long address, pte_t pte) > +{ > + unsigned long pfn; > + > + if (vma->vm_flags & (VM_MIXEDMAP | VM_PFNMAP)) { > + pfn = pte_pfn(pte); > + if (!pfn_valid(pfn) || is_zero_pfn(pfn) || pfn > highest_memmap_pfn) > + return NULL; > + return pfn_to_page(pfn); > + } > + return vm_normal_page(vma, address, pte); I enjoy seeing vm_normal_page() checks in GUP code. I don't enjoy seeing what you added before that :) If vm_normal_page() tells you "this is not a normal", then we should not touch it. There is one exception: the shared zeropage. So, unfortunately, this is wrong. -- Cheers, David / dhildenb