From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B03C433B4 for ; Fri, 14 May 2021 09:57:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9FEAA613BC for ; Fri, 14 May 2021 09:57:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FEAA613BC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 374DE6B0036; Fri, 14 May 2021 05:57:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FDBB6B006E; Fri, 14 May 2021 05:57:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12B906B0070; Fri, 14 May 2021 05:57:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0218.hostedemail.com [216.40.44.218]) by kanga.kvack.org (Postfix) with ESMTP id D175F6B0036 for ; Fri, 14 May 2021 05:57:31 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 576702490 for ; Fri, 14 May 2021 09:57:31 +0000 (UTC) X-FDA: 78139384302.22.3487461 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 0EE70DD for ; Fri, 14 May 2021 09:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620986250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8rzJBsGwhabN6jmugEogWwENANkkfJK8/J4mWGWKpXU=; b=WbHpA5Qp7iSepViXgW5hsyY6DLRSYzaUxmAk+inLG/zaMHIxnAsqruNtZsbsv50vX3xEuF Z4BzTt0IHe202Np1aM/Rr3sOpRhGedMjhatrq09qCbyxNF4xkgI4EfiieOLjRJi0C+jAAb Gd+u7Bv90fR3kWttAgt8FmYkhDOqeaI= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-6-GlEwIT9NO1CORgJ6JaUang-1; Fri, 14 May 2021 05:57:28 -0400 X-MC-Unique: GlEwIT9NO1CORgJ6JaUang-1 Received: by mail-ed1-f70.google.com with SMTP id p8-20020aa7c8880000b029038ce714c8d6so1753111eds.10 for ; Fri, 14 May 2021 02:57:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=8rzJBsGwhabN6jmugEogWwENANkkfJK8/J4mWGWKpXU=; b=lii3gab0Uziah2oddDaICcmfS4Gc5PBuIRMCNAYPj8209iz/jlh14XekD2aAwgdRRY 8pQrAcN7pTx/bkg+UL1q/aPtIdZEw0HCIToO4ONEoRpXilMfjczW7UZSYvWBtvJMBjW8 QBa3sCvSaxLJDAJOvMLhPFtk6gKmxSIFBoP/XAD9jNEc41gAZUHjJ5HE5wgAPAyoDhLV ScvDRxWBemPTlsi8IlLey9zir/T62NglJEpCJV9FyePdNdELWDDblklZPa2nORHKn6pu jSh7R/jzh0ekfrbogAl1o37U7GEgr56f+lySBXHDkUpKT7RLloOGc5BfQy072zbRMHFu UCFg== X-Gm-Message-State: AOAM532+q8uctsBeqZsOEVb/fTZuylX/fAjuD7L6eHiX/iXqY36VsFjU +y+m/L4mabsPgHAqtVpN80phkQQizH9qlxGL/k91Ofju64KGa/YwFL0fWlyYSbQkEoYPj+kV56b JmbWz/N5R/g8= X-Received: by 2002:a17:907:7747:: with SMTP id kx7mr31478197ejc.400.1620986247244; Fri, 14 May 2021 02:57:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyrSoRF79fxMuEqrHhj6EHjL5Zsyke7AE/1JPBWbafFqeSeIeeKtVnbLG/x5jm0octAFZwKQQ== X-Received: by 2002:a17:907:7747:: with SMTP id kx7mr31478183ejc.400.1620986247091; Fri, 14 May 2021 02:57:27 -0700 (PDT) Received: from [192.168.3.132] (p5b0c6501.dip0.t-ipconnect.de. [91.12.101.1]) by smtp.gmail.com with ESMTPSA id ju17sm3413760ejc.72.2021.05.14.02.57.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 May 2021 02:57:26 -0700 (PDT) Subject: Re: [PATCH 01/22] mm: Add vma_lookup() To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton Cc: Song Liu , Davidlohr Bueso , "Paul E . McKenney" , Matthew Wilcox , Laurent Dufour , David Rientjes , Axel Rasmussen , Suren Baghdasaryan , Vlastimil Babka , Rik van Riel , Peter Zijlstra , Michel Lespinasse References: <20210510165839.2692974-1-Liam.Howlett@Oracle.com> <20210510165839.2692974-2-Liam.Howlett@Oracle.com> From: David Hildenbrand Organization: Red Hat Message-ID: <99e04b50-7210-8a2f-4eda-08747b8570fb@redhat.com> Date: Fri, 14 May 2021 11:57:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210510165839.2692974-2-Liam.Howlett@Oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WbHpA5Qp; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf12.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: ywmsm9pb6z8f3omdt7sx58gdu41s6uox X-Rspamd-Queue-Id: 0EE70DD X-Rspamd-Server: rspam02 X-HE-Tag: 1620986249-760019 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.05.21 18:58, Liam Howlett wrote: > he third use of find_vma() is by developers who do not know that the > function starts searching at the provided address upwards for the next > vma. This results in a bug that is often overlooked for a long time. > > Adding the new vma_lookup() function will allow for cleaner code by Sounds helpful to me Acked-by: David Hildenbrand -- Thanks, David / dhildenb