From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA3D0C4332F for ; Fri, 18 Mar 2022 00:10:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16A6B8D0002; Thu, 17 Mar 2022 20:10:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 11DFE8D0001; Thu, 17 Mar 2022 20:10:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F25408D0002; Thu, 17 Mar 2022 20:10:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id DEA388D0001 for ; Thu, 17 Mar 2022 20:10:55 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9DC058249980 for ; Fri, 18 Mar 2022 00:10:55 +0000 (UTC) X-FDA: 79255576470.26.E154DAD Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 5353540020 for ; Fri, 18 Mar 2022 00:10:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description; bh=UOOQMXKnC3EL2rzumcle1jcblKs+Qj46u7I1wgq3BX8=; b=ohfbQ4+XpS70ZtH4DYm373Ug5c 7SsD8IcKE5B7pJ4NnHkJMEW2kvq6T20I7X+bEW8Xp36helbB+dpPdnNpHEy4fY/ny/o35QCLaPXn4 KaSjDMO3bdX94U5UNZEPsp22HLkzAHRnbJCfHqDHY9erDhNQ66EbREQEpD1T+kg8hcUXZXvy1VPcQ Zu2ujJzNGoZ9QHEIfPOTgatfGHmz+WN+QRvGfTBRA3S/Itch7K6T1w0lJzCrE+CIa0Ev/eGWv+jLO PDQ7HAtLNe0SutdkdzN9nwVLEtHvvOMTVqsO4Ifyq9taLXV52HUUcC1qUZ1QtsbL5lELvJt+81/zI kCw0J/nA==; Received: from [2601:1c0:6280:3f0::aa0b] by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nV0CR-007SBE-Rt; Fri, 18 Mar 2022 00:10:36 +0000 Message-ID: <99d45fe4-53ca-b966-e140-cd68b731292a@infradead.org> Date: Thu, 17 Mar 2022 17:10:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: mmotm 2022-03-16-17-42 uploaded (uml sub-x86_64, sched/fair, RCU) Content-Language: en-US To: Andrew Morton Cc: broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org, linux-um , paulmck@kernel.org, Richard Weinberger , Johannes Berg References: <20220317004304.95F89C340E9@smtp.kernel.org> <0f622499-36e1-ea43-ddc3-a8b3bb08d34b@infradead.org> <20220316213011.8cac447e692283a4b5d97f3d@linux-foundation.org> <917e9ce0-c8cf-61b2-d1ba-ebf25bbd979d@infradead.org> <20220317165100.2755c5ae6a3a08b7ecb06181@linux-foundation.org> From: Randy Dunlap In-Reply-To: <20220317165100.2755c5ae6a3a08b7ecb06181@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 5353540020 Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=ohfbQ4+X; spf=none (imf01.hostedemail.com: domain of rdunlap@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=rdunlap@infradead.org; dmarc=none X-Rspam-User: X-Stat-Signature: z6suejhpr58k6tf5wznyakacfc5fiz87 X-HE-Tag: 1647562254-870934 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/17/22 16:51, Andrew Morton wrote: > On Wed, 16 Mar 2022 21:52:44 -0700 Randy Dunlap = wrote: >=20 >>>> In file included from ./arch/x86/include/generated/asm/rwonce.h:1:0, >>>> from ../include/linux/compiler.h:248, >>>> from ../include/linux/kernel.h:20, >>>> from ../include/linux/cpumask.h:10, >>>> from ../include/linux/energy_model.h:4, >>>> from ../kernel/sched/fair.c:23: >>>> ../include/linux/psi.h: In function =E2=80=98cgroup_move_task=E2=80=99= : >>>> ../include/linux/rcupdate.h:414:36: error: dereferencing pointer to = incomplete type =E2=80=98struct css_set=E2=80=99 >>>> #define RCU_INITIALIZER(v) (typeof(*(v)) __force __rcu *)(v) >>>> ^~~~ >>> >>> Works For Me. I tried `make x86_64_defconfig' and `make i386_defconf= ig' too. >>> >>> Can you please share that .config, or debug a bit? >> >> $ make ARCH=3Dum SUBARCH=3Dx86_64 defconfig >> >=20 > I still can't reproduce this :( >=20 >> This fixes the build error for me when CONFIG_PSI=3Dn. >=20 > I have CONFIG_PSI=3Dn There was also this report about linux-next, also with CONFIG_PSI=3Dn: https://lore.kernel.org/all/EF33D230-9A8F-41C5-A38D-95128603224F@linux.ib= m.com/ but I just tried to build with the .config file supplied there and didn't have any build errors... If it was just me & mmotm, I could see it being a problem with applying patches, but this other report looks the same as my initial report. I dunno. If it persists, we will track it down and quash it. >> --- >> include/linux/psi.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> --- mmotm-2022-0316-1742.orig/include/linux/psi.h >> +++ mmotm-2022-0316-1742/include/linux/psi.h >> @@ -53,6 +53,9 @@ static inline int psi_cgroup_alloc(struc >> static inline void psi_cgroup_free(struct cgroup *cgrp) >> { >> } >> + >> +#include >> + >> static inline void cgroup_move_task(struct task_struct *p, struct css= _set *to) >> { >> rcu_assign_pointer(p->cgroups, to); >=20 > Nothing in -next touches psi.h so I am unable to determine which patch > needs fixing :( --=20 ~Randy