From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A66C4C0015E for ; Fri, 28 Jul 2023 08:19:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39BD18D0003; Fri, 28 Jul 2023 04:19:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 325DA6B0074; Fri, 28 Jul 2023 04:19:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 19F698D0003; Fri, 28 Jul 2023 04:19:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0AA4B6B0072 for ; Fri, 28 Jul 2023 04:19:20 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D81361C9768 for ; Fri, 28 Jul 2023 08:19:19 +0000 (UTC) X-FDA: 81060320838.25.4BD9561 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf20.hostedemail.com (Postfix) with ESMTP id 825FF1C0011 for ; Fri, 28 Jul 2023 08:19:16 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=L2+elQ31; spf=pass (imf20.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690532358; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0Vz5i3f1KwBqEHtOj3kkD+u+idA4hMEDLOXYQ/Zmb7I=; b=23zEcL0yYEVKya4vk4+pw1Hj9AWX7ZMz0WXnP/PNc8qVA8C5Q6DXaYxSEd4Y/2epvDpVt4 EAU8sRgK4zT18UfQBl7qj4mLJsxqA7RDRwIuUkSvGMFD7L2aFqfksLCGZaURoYIV7efyin xTRrm3nvfVUfL2egh8Hp3fJd1hQtcDg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690532358; a=rsa-sha256; cv=none; b=FmZIE4gNJ3foVxt5m5NNNo4EsnXDBctjANvEXL3nYVbwrk3vA7wxuRDPSdFGj6WsQzgbKX G19df0mQ2GrTKSY4uUBgfLnUMP5Fmv6PECSb2VPb5votniWR0mJ1sH4zSFYai+iVQxe9bV kqDFgnw7oXZgId75zsLBA5sGnh26ocU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=L2+elQ31; spf=pass (imf20.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6748a616e17so437600b3a.1 for ; Fri, 28 Jul 2023 01:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690532355; x=1691137155; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=0Vz5i3f1KwBqEHtOj3kkD+u+idA4hMEDLOXYQ/Zmb7I=; b=L2+elQ31DoTndDMbULUpYhAiCoRfDRGWwRsLhePlw7WW3kXFI6RoGNteAO7MNCCxPK FYWrT0NCxgniYdOvtk354oC7lAaEYLaI5+6nbBgCsJS7Z9F7PQNW+ZUGwlLgRq4XIWCd IlyzJlPUeNX37jF32KJvYLJePzYsZ7ze/fbSuG8EqYw256JXY3KCKzS1wluS9KcnHJgS wVJn5VLovDZDoJav6s/8z2Nev3fZMa4BKzS6r7L/dPmXUhh82k37p3M1JnHGLMc145hK MLBcl9i8u/Uj6MSDKzSJ+fdKEdHQ4PpsFlNhyTOhfKom9VA3y6JlxMc/+2lHqKKi6hTK U83g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690532355; x=1691137155; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Vz5i3f1KwBqEHtOj3kkD+u+idA4hMEDLOXYQ/Zmb7I=; b=NqQKv3qDEzuaG6bGCE4CZbPNPKEtJsWbpHsqYhdpsOsXJZNHbs9Y1UlTkcQ3wQHoNp er7wre1U9DioPYYPpELdUEB0uAN0G6/BwFe3j32qM7onW28CSho13jLCJQD4rKg4ZfFI bAe87mvQaKH+a0V/DXU9YTvXfQcENNk+Y7snNSPmyWLdeJaLVdSmetuRQhrkAEr0lC6i B6Vb+lYdT4mBJmyFHnFnhC4YsjMToQ1P1Hcd7nWmzvpywvPj+CE25LrNEeOCd18ZwDuN CYmxQyJGKP4OMmIOL+B8ozq8RjpHJvUsNqienFvxru9Xu40zcJYlc3yIU9KW1z64DCZ5 PDEA== X-Gm-Message-State: ABy/qLaxM4f0N64QnXkJ2T4HpxSu0SzFxfGGTTiVQfRVpTxm4P5kYgOb DNZTRY/rQf0S6b0LffyZ2K797w== X-Google-Smtp-Source: APBJJlFUUUMvBrf6ibd1LKjgOpEN2XEkSNdXdEqaA3c50PeJDSflhjqiMTE27IMY1LDD8QpZTvY8yg== X-Received: by 2002:a05:6a21:329f:b0:134:76d6:7f7 with SMTP id yt31-20020a056a21329f00b0013476d607f7mr2068612pzb.4.1690532355159; Fri, 28 Jul 2023 01:19:15 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id j63-20020a638b42000000b005637030d00csm2862658pge.30.2023.07.28.01.19.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 01:19:14 -0700 (PDT) Message-ID: <99d0958d-8446-6fe9-a0fb-f562cb04c7c8@bytedance.com> Date: Fri, 28 Jul 2023 16:19:01 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 04/49] mm: shrinker: remove redundant shrinker_rwsem in debugfs operations Content-Language: en-US To: Simon Horman Cc: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song References: <20230727080502.77895-1-zhengqi.arch@bytedance.com> <20230727080502.77895-5-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: pdo96s93uxi3p7h9g4dkdkreczrz7zyt X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 825FF1C0011 X-Rspam-User: X-HE-Tag: 1690532356-684163 X-HE-Meta: U2FsdGVkX19CMiSNCec72OCASIywGrQVeoQ23tMThYVbFSQpeHGZ1v/cmfKc28Y7u/ly5FJ7mD6zoJFjNz6CAvtcxZrznmIpzBdi3vu3NymJT4OAQLrr5xI+divtcZeOKOsgyakBYVXckWoQxxeNKn5SgVjSmKM9wxoCuUqg35a8zHtSCsO9vpmJqm5+49gSzKiJq5c392O4G49w7R1QixkdOtrD4oRAX5jvqoRznmaCYpl//e5kxSONsY9Z5G6pKoXBfnAlrLixTB1rO0q7d6H4EyHrSOGvCdyAl4/YwZSYnd6A1a157wnr8T745fuF1RujBZ113cueN6tu4uWjgopoqgypu3Nz5mPsi3MdF8T8O+1kpJ5mQacTyw/HeWxmSTvKRp/BmZvT9jTiNxu4XWN5AqOhkKwh8Q/YDVkcus61hBnrpD4DQXEuZ1JFFhMDP9DKgklTJzEjGWID4y2Lt9ZdW/qRG/qstWQFk0hbDPyKUA7pIvMvC3N9wGzrXcSlhz2E3jclLPv61OSoDp9FnBrLf70uQGarKiaNraT2Ke+voIN/o5q/Ap9gyposWPip1z2NfL1hZ4uvSuUgnDprM7etkn//5vOlcpnCMe7YnRB+9H+y2spgzXB9Xm2r+txMEPp3JGCNCjJqlWe/IfyypUfZlwsll4s0Sv6AEfZZHsU0o3sVQ67QvvAbhMwIYpVXYvnIL1c518UmCZyAJBX72/55UWPjfWy1jlwZlrfdjMVb1wmw7xhFbW1kW7s0HabSJ1Yw16a/BQd+fj4V61TPXfGvwFV+If/rJaR7L0dz++5vvvvg+AJIfWm5qHE3ewbZv6IuAgwj7xiIeeBIvIleV/f/dv0hQuwu6IN8458e1sDmmKqmhzbdb9W2hmuRnXoMRHHlUQYR32aSdWA4AcWU8BU3HNW1X7XVqrTvooB6Y9jYcp2HTfd/fm+uQo946ww+JFMHXa//TlQZOlY0fRU YkwkcLAY VR/0S8/207KABWDJo5B1P0ngNe4OIXtV3dEQFYelnvd4nMHLaD4Ccp9T6zstAlPWZBtxxJwv+rqsvGIZZkoU+pZozCjgSctRiuHNuANgza3v4vqFSkqovBp1OBI+JSVsuKmIZnLZCuk7BQZwIhk5nt0PUS+Fr0G30D6MuKl+CnsP1BqVBdTXmZz+VSW1+vfDwm7Rbz1DcwCKXExVfpCjCgR7vDWLAe3H75LAWdKF7sm5f5Mj/czyjB3M9nXpDT8hCQK0ybTEreZnxm7GbFoIcMjJ8Jt/n0R6KhTtlTExO0HGQNcpkUFOVroIO7lRAXleyjpkbftJa942DEfuH3LPpLyN4ywKP4T/cKD3VvvJTYLxgjsJKwQ3hb6p9mI3g7Lwtg3FSKRK9e3WybohsRjhTZjhVoBqNm47DK6CzEtM9C72AH7r11wZ4DyJfVAe5sZswdLDAXCRoqVstXIrnb24LUauw1LMM0unJAaOl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Simon, On 2023/7/28 16:13, Simon Horman wrote: > On Thu, Jul 27, 2023 at 04:04:17PM +0800, Qi Zheng wrote: >> The debugfs_remove_recursive() will wait for debugfs_file_put() to return, >> so the shrinker will not be freed when doing debugfs operations (such as >> shrinker_debugfs_count_show() and shrinker_debugfs_scan_write()), so there >> is no need to hold shrinker_rwsem during debugfs operations. >> >> Signed-off-by: Qi Zheng >> Reviewed-by: Muchun Song >> --- >> mm/shrinker_debug.c | 14 -------------- >> 1 file changed, 14 deletions(-) >> >> diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c >> index 3ab53fad8876..f1becfd45853 100644 >> --- a/mm/shrinker_debug.c >> +++ b/mm/shrinker_debug.c >> @@ -55,11 +55,6 @@ static int shrinker_debugfs_count_show(struct seq_file *m, void *v) >> if (!count_per_node) >> return -ENOMEM; >> >> - ret = down_read_killable(&shrinker_rwsem); >> - if (ret) { >> - kfree(count_per_node); >> - return ret; >> - } >> rcu_read_lock(); > > Hi Qi Zheng, > > As can be seen in the next hunk, this function returns 'ret'. > However, with this change 'ret' is uninitialised unless > signal_pending() returns non-zero in the while loop below. Thanks for your feedback, the 'ret' should be initialized to 0, will fix it. Thanks, Qi > > This is flagged in a clan-16 W=1 build. > > mm/shrinker_debug.c:87:11: warning: variable 'ret' is used uninitialized whenever 'do' loop exits because its condition is false [-Wsometimes-uninitialized] > } while ((memcg = mem_cgroup_iter(NULL, memcg, NULL)) != NULL); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > mm/shrinker_debug.c:92:9: note: uninitialized use occurs here > return ret; > ^~~ > mm/shrinker_debug.c:87:11: note: remove the condition if it is always true > } while ((memcg = mem_cgroup_iter(NULL, memcg, NULL)) != NULL); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 1 > mm/shrinker_debug.c:77:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] > if (!memcg_aware) { > ^~~~~~~~~~~~ > mm/shrinker_debug.c:92:9: note: uninitialized use occurs here > return ret; > ^~~ > mm/shrinker_debug.c:77:3: note: remove the 'if' if its condition is always false > if (!memcg_aware) { > ^~~~~~~~~~~~~~~~~~~ > mm/shrinker_debug.c:52:9: note: initialize the variable 'ret' to silence this warning > int ret, nid; > ^ > = 0 > >> >> memcg_aware = shrinker->flags & SHRINKER_MEMCG_AWARE; >> @@ -92,7 +87,6 @@ static int shrinker_debugfs_count_show(struct seq_file *m, void *v) >> } while ((memcg = mem_cgroup_iter(NULL, memcg, NULL)) != NULL); >> >> rcu_read_unlock(); >> - up_read(&shrinker_rwsem); >> >> kfree(count_per_node); >> return ret; > > ...