From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24A80C433E0 for ; Thu, 21 Jan 2021 20:39:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 791152389B for ; Thu, 21 Jan 2021 20:39:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 791152389B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B59786B0006; Thu, 21 Jan 2021 15:39:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0B1C6B0007; Thu, 21 Jan 2021 15:39:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A20EE6B0008; Thu, 21 Jan 2021 15:39:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0178.hostedemail.com [216.40.44.178]) by kanga.kvack.org (Postfix) with ESMTP id 8D3086B0006 for ; Thu, 21 Jan 2021 15:39:44 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 52AEE181AF5D3 for ; Thu, 21 Jan 2021 20:39:44 +0000 (UTC) X-FDA: 77730948288.14.rifle80_200f93927566 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 2D71718229835 for ; Thu, 21 Jan 2021 20:39:44 +0000 (UTC) X-HE-Tag: rifle80_200f93927566 X-Filterd-Recvd-Size: 5747 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Thu, 21 Jan 2021 20:39:42 +0000 (UTC) Received: by mail-wm1-f44.google.com with SMTP id c127so2613884wmf.5 for ; Thu, 21 Jan 2021 12:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Xayxyu0fFQJrTg31QncwBsdYtRLwkVs0VoYzDdqVhX4=; b=o0sMq3fT9e4YSTYIY2l5VuqpueCXe0rnYJvOmqtdyrcRS9/cB2D3Ns6ENbWbFKsLer +hAiH+We4B2gizqtx6LxbfSJslYevSZzgbZoIRxeNGIjWtT70bIp0DAk80Q43vvSQdwd 7dneBNgcZHjF5PXR9/81BtHoCd8dPHTO6ht8VgkUlPJy9E/iE92MYRrgnt1CPvVQyFX3 gT7ps41pFrRruheAooxE+HMU1M7fgf0GJk8KEcwNlTGAvh0dxrudAeTgghVCKkYpdZIA UTWQXZjNVumz0YHHt+aVpS4XF6B5FclaX6VCmetG0+h7cuKrviw7gwu6FuKQwMz6S3j0 6G5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Xayxyu0fFQJrTg31QncwBsdYtRLwkVs0VoYzDdqVhX4=; b=XwB5a2Qyr7Hkls+v+472+DWAsK8LkQnSR0H84APNQbSynP7kk+Afn1h4MeqOyVUDW1 0Yr7pXn089l1M3AofLj3hbSH8diYMrxFWUCoudN5uvlObt8gZM31H3qLumXgu6RYj7WW fVMj5BEUq+PStFy6IpcOP+JGgXqttCJRkNFtOnDu3C3eQE88WxqMr6wlKj14inQIdfhu 2EagZCJgwO8wsss0KvvgXpJWXwTXFnfRzvMX1IGStE3mz26LitTn6qCTMwGbqBbdvqEx ed24HBwVr7tBb7MAmm5ara0IKDeE5cs+UJQxLz+hTQPcyjOBunDHby64jkKkxf9fxC4J be1g== X-Gm-Message-State: AOAM531BS4RjbPNNfr/iRgiiY8Kqdkc2q8k+VUpvSA5iLwys1MqNrSEY RkEVzCJG0sULUsitVWxDjmE= X-Google-Smtp-Source: ABdhPJwAvjvv7mqDZ3SsZ3LCUqrKyOah2ikRyjvnwEOfHPcnOK1XtxlUJHi2e05Q1JAo0XillVwxzw== X-Received: by 2002:a7b:cb54:: with SMTP id v20mr1013794wmj.148.1611261581596; Thu, 21 Jan 2021 12:39:41 -0800 (PST) Received: from [192.168.0.160] ([170.253.49.0]) by smtp.gmail.com with ESMTPSA id l5sm9479286wrv.44.2021.01.21.12.39.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Jan 2021 12:39:41 -0800 (PST) Subject: Re: [PATCH -V9 2/3] NOT kernel/man2/set_mempolicy.2: Add mode flag MPOL_F_NUMA_BALANCING To: Huang Ying , Andrew Morton , Mel Gorman , "Michael Kerrisk (man-pages)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210120061235.148637-1-ying.huang@intel.com> <20210120061235.148637-3-ying.huang@intel.com> From: "Alejandro Colomar (man-pages)" Message-ID: <99b71573-714f-5ec6-37e5-3e6e080432fc@gmail.com> Date: Thu, 21 Jan 2021 21:39:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210120061235.148637-3-ying.huang@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Huang Ying, On 1/20/21 7:12 AM, Huang Ying wrote: > Signed-off-by: "Huang, Ying" > Cc: "Alejandro Colomar" Sorry, for the confusion. I have a different email for reading lists. I use alx.manpages@ for everything, and alx.mailinglists@ just for reading lists, but sometimes, when I answer emails not sent to me, I forget to change the reply address, and you see that address (which I intended to be readonly). Please, use alx.manpages@gmail.com, or your mail might get lost between many list emails ;) > --- > man2/set_mempolicy.2 | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) >=20 > diff --git a/man2/set_mempolicy.2 b/man2/set_mempolicy.2 > index 68011eecb..fa64a1820 100644 > --- a/man2/set_mempolicy.2 > +++ b/man2/set_mempolicy.2 > @@ -113,6 +113,22 @@ A nonempty > .I nodemask > specifies node IDs that are relative to the set of > node IDs allowed by the process's current cpuset. > +.TP > +.BR MPOL_F_NUMA_BALANCING " (since Linux 5.12)" > +When > +.I mode > +is > +.BR MPOL_BIND , > +enable the kernel NUMA balancing for the task if it is supported by > +the kernel. > +If the flag isn't supported by the kernel, or is used with > +.I mode > +other than > +.BR MPOL_BIND , > +return \-1 and > +.I errno > +is set to > +.BR EINVAL . The wording here is a bit weird: [return // is set]. It would be better as [return // set] or [returns // sets] or [is returned // is set]. The same page, has: [ RETURN VALUE On success, set_mempolicy() returns 0; on error, -1 is re=E2=80=90 turned and errno is set to indicate the error. ] so I'd use the latter for consistency. > .PP > .I nodemask > points to a bit mask of node IDs that contains up to > @@ -293,6 +309,12 @@ argument specified both > .B MPOL_F_STATIC_NODES > and > .BR MPOL_F_RELATIVE_NODES . > +Or, the > +.B MPOL_F_NUMA_BALANCING > +isn't supported by the kernel, or is used with > +.I mode > +other than > +.BR MPOL_BIND . > .TP > .B ENOMEM > Insufficient kernel memory was available. >=20 Other than that, it's good for me. Thanks, Alex Just a reminder for myself (please ignore it): - Break EINVAL into multiple paragraphs. - (Maybe) reorder lists to be in alphabetical order. --=20 Alejandro Colomar Linux man-pages comaintainer; https://www.kernel.org/doc/man-pages/ http://www.alejandro-colomar.es/