From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEC9EEB64D8 for ; Thu, 22 Jun 2023 00:46:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDBE28D0002; Wed, 21 Jun 2023 20:46:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E650F8D0001; Wed, 21 Jun 2023 20:46:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C69C48D0002; Wed, 21 Jun 2023 20:46:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B3E0C8D0001 for ; Wed, 21 Jun 2023 20:46:39 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 80D5716021D for ; Thu, 22 Jun 2023 00:46:39 +0000 (UTC) X-FDA: 80928543318.24.57B501D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf29.hostedemail.com (Postfix) with ESMTP id AA831120002 for ; Thu, 22 Jun 2023 00:46:37 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OKJ2boTq; spf=pass (imf29.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687394797; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pmhiVXncviVqsn3wpRHxbelBhB6YgCHtE5DYwQktKNU=; b=jYTReQ4GyC7vHiAibgIHylnTSRC0lm+jm90OCblOVC35NllU6erx666w/3XoAkqUbxhv6y EQf72CFnZo9swQFYk2KfVPgkNdD1H6mwamAwGSbQxSRpE8a4ahybBaycuwtycciLoSFRF3 n/13j+TLvhuAWkWprAmt/+dHym+nHFM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687394797; a=rsa-sha256; cv=none; b=rso2gzvkse1j7Nh4C4IA0SqjnNe4ecz4wVH4oiJ9YckMWpKoUsLzUeP3sTJ33A4XWZ7YFH gR9bZUGL8Sj9Wz6Qo4kM8LTYI3fEmpXW1eq2F/dHhZR+ZB/mO1v4Uxc8DcilPbw6G9MhUM s/yo6kVdwUr/av2rwwuhuwE2UJ5Em4c= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OKJ2boTq; spf=pass (imf29.hostedemail.com: domain of dlemoal@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=dlemoal@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0CA2B6171F; Thu, 22 Jun 2023 00:46:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A7C8C433C0; Thu, 22 Jun 2023 00:46:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1687394795; bh=rnAvPLn1sCs7GGwULNlh7vfJWhCgmoE6J+kuAdW07eg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=OKJ2boTqeHZMsToMs1/n2lzwwGVbU+I2GYoijjuRh9SVeHfTSB1H+xyFQwyAFX7gH /vyxfg2IKPw1xJaHjaP8DFfddUEEk8PpeVXJ0+PVhDflO3qbvKQQI9gg2+QYLwO5s8 7RdM/94Dzx+hUObnhR05qpfqd0np7iM7DbNnG1PYspXU6CzNR2GHI+w68+F/UNiAvI xFMWzHCJLXizYOftbvGh5G8E/rfFzaZBSJhjqQBlrMVQgwlWHoRl/ilVMdm4h9iQIc xbVrb5SDTY2AyvfHzces3r+mtB2lxqGprTaDvGj1GvW5UryRveoRMwl/iNrb8xoLWk lKxccXW186khg== Message-ID: <99b3c749-23d9-6f09-fb75-6a84f3d1b066@kernel.org> Date: Thu, 22 Jun 2023 09:46:12 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 01/79] fs: add ctime accessors infrastructure To: Jeff Layton , Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Greg Kroah-Hartman , =?UTF-8?Q?Arve_Hj=c3=b8nnev=c3=a5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Christian Brauner , Carlos Llamas , Suren Baghdasaryan , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Brad Warrum , Ritu Agarwal , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Alexander Viro , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Eric Biederman , Kees Cook , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Joel Becker , Christoph Hellwig , Nicolas Pitre , "Rafael J. Wysocki" , Tyler Hicks , Ard Biesheuvel , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , Mike Kravetz , Muchun Song , David Woodhouse , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Chuck Lever , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Mark Fasheh , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Iurii Zaikin , Tony Luck , "Guilherme G. Piccoli" , Anders Larsen , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Sergey Senozhatsky , Phillip Lougher , Steven Rostedt , Masami Hiramatsu , Evgeniy Dushistov , Hans de Goede , "Darrick J. Wong" , Naohiro Aota , Johannes Thumshirn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Hugh Dickins , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , Juergen Gross , Ruihan Li , Laurent Pinchart , Wolfram Sang , Udipto Goswami , Linyu Yuan , John Keeping , Andrzej Pietrasiewicz , Dan Carpenter , Yuta Hayama , Jozef Martiniak , Jens Axboe , Alan Stern , Sandeep Dhavale , Dave Chinner , Johannes Weiner , ZhangPeng , Viacheslav Dubeyko , Tetsuo Handa , Aditya Garg , Erez Zadok , Yifei Liu , Yu Zhe , "Matthew Wilcox (Oracle)" , Oleg Kanatov , "Dr. David Alan Gilbert" , Jiangshan Yi , xu xin , Stefan Roesch , Zhihao Cheng , "Liam R. Howlett" , Alexey Dobriyan , Minghao Chi , Seth Forshee , Zeng Jingxiang , Bart Van Assche , Mimi Zohar , Roberto Sassu , Zhang Yi , Tom Rix , "Fabio M. De Francesco" , Chen Zhongjin , Zhengchao Shao , Rik van Riel , Jingyu Wang , Hangyu Hua , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-mm@kvack.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org References: <20230621144507.55591-1-jlayton@kernel.org> <20230621144507.55591-2-jlayton@kernel.org> Content-Language: en-US From: Damien Le Moal Organization: Western Digital Research In-Reply-To: <20230621144507.55591-2-jlayton@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AA831120002 X-Rspam-User: X-Stat-Signature: dp9sa1zweawdjf98ebsp9kttj1s3o4tb X-Rspamd-Server: rspam03 X-HE-Tag: 1687394797-751066 X-HE-Meta: U2FsdGVkX19tCq0dUUIdt2FnUGjJ1Oz6q12geDhkwBdiGg3jXo9vPMwhKJXgU7eyE2IcgWRZHPiEew0DDKlVuQPbkdTxvTJoVKFzdiAM0e8aZn1H8wfUIphEKauwKUszU6EmjlQiTVFXcYuIAxlRB0Y362Tw4RONARbl10bjsLwlsXaI7mw23XQ4pe0NRgMW8tPhTMW9KtdrWOmwZtijrtCFqD/pBgtrS7lweCufik6BCEexi7js9M5++GopNQhZJmVIqKLOlbI4XROO4Ryy7tSy4tdKcUohwjnaexkuXizZ/tP9dhkj2K5CjN5TVx0JsIOysWlDn12qd461j3//SpLu0Bz3STx3X/Si4mZjNH0INhvSeYTTTsu44/VmUKXKpwdMukiQmuZjw6U4N7lmOt2bW/ip8hzYah/qfeqnq/p3QjDWSspYfsPi0+wDOVMdoff6XM4zJlaS1gMvU422lTyd8yXo+UCvKvOxleOfNb0bmJBfXNsKcIjCPf6qpwZ6gM6EorRmdZf1AlkVPLeCQfTb7UaBNxaJZIX4uo5oc4IsfRhgZNVzZ338s0O9wmnykTxYJf+e5SIfLx+r4k9YVSOy4ooG4Fi28vxhlVSYaXMzKQ6yH3TithHSl80QXWk9xTaHFxvAXk77kZj1y1MuxW8D2YVSV7tmZxFFdMwFr6/KrknZbCBIdDjZF5DhNidwJR8iBdbsT1YIJ6nKDt3BSV6xee1yoxHHj93zCFMKjJoeCVHVoQs8QkmKfFanNrKpGAjlIzmnmjWOhyVQK6M4v+6jXGp1uws4K/J3yDCfev+ybRTBXrSpDKhDfMg/m9diQeoueIgZEjM5darXPPRG9DUTHvo2MJHOIntG0RnowZ/wsr9VpM7cKQPr1p4W+wDZdcSfqmB9PU9t2sea5+3jo21+Ievt70CwalXHuVZohQUtWxDZdb0KGLnQsDIXjrAMyWrmr60bCNIEwtndp9v 6UuFOTSZ AvlQrQ0Z0B1p5QMdIeAxSTw3szsQE7Om6zlSPxmEa249sFG925Mfk4PcxDgtT5cQYm8CnDuqTS6yn9RVuacUy0MVJYGuehXqzbW/MFV5U8gQYO0q/VYxLz1PeT4zLTCnr2rYCs7g9je7zuOpvg8FWM26sGFULVjRwd0OjikiGvg5SvULBV2vEmAXTkJc4KJACaSLeHSSdNzD3wwTx1YRqsPk1PNMa9nQnRMuAsvbns1HRElMJLy7A8BQSPh0ycHdv/xeZLLxN5mtZZ/P7R82hJ6kyTE962ieh+47nPHUeoEJXclIeBpDnqXfSBP2/RASHJlrTMXkRvNNkMn7Fw75DavN4YoDy9fmZ0vAdjIjPlDu4XXJ3UDR4vMYZZEOdDrtd/+eX6YnGR07bx9gflog0abOXNZWrDKQ4NYGmqgBaoKvkWvL1NZP3iQXnSdnplXeHqsII2IB8Wj5zlyO8eYgjziRPKoPJXbFZbV4yg+CbCoXQn8fuI6oad1XRpx2UUdVS8asiVGoLm5dgXm75238nEoDRH+EgY++0hJ9lvkMhh6qJs53W/KfisgeIVN4HXuG45vTNANTdH5Xa1vWMWLF/8jtm7UTtmRkan09k18zVU91sTCWRmq8DiZ9So+CJ1xu4Bc/4lqnXGiwfePi1tifkAsmrLtvCXRVTX2R6NSjVHp019ABT4rYoBTzkF+NcyI1op94UUzj9KOCG++qYjOSu/OV5jy68Iw8o1HueHY9NU3n6c8oob4BSAMSTNmpbCzl5bd7Gqh+IgOHNcVtTgwjLE83DmHBBk3fQ/Ni/5ADeOuugWPx05zkk/o0HO6AcwOMtjuHArSfx0nefDhPXsRbmSZ1yiAzEknZynwCF9djJQ4mnLKlNIgBCuszZtMEUe6+jiXZ3RS2uVEhDI9+BzeMW7ANB4d4RnLEALDDnZ11Ix5INin0JodRxahgjqgFq3Qg2e9zcbr2yqDgMA7zaGZJlciC23okf sbNBXKbj WikunOoFKaQjJeaN6r9R5Dh/QmUsUsvK4t8c0c+PCLMOJkvy2zPp1f6A5WAQECYnAytMRpfz9huVN9S3kfnnH0IC8OSFkIy9U0cM9F5kY5aNYU+KZuwTKDp3MOXVWA9pl94LOz/79uh3zVvm37LL9s4BO67qE7RqWWFZDnOvyK08l0jOnDfuDS+AAn6lVY2DoYSQNdP7GSf/n+q5+xpwlXEhg/u95tVPA2TapgCTfZFbv1LDTGQXdQ9JmK7y19dW+a3kT4ICp9ysF8G9DCkoaP5oYB2mtj1z0A6qk6/p8i2S7pR/9RTJN3LIpybxNznEEXYvlmPsN4uFk52cUvkVbNKGuU1U9DGcrAFEksULdvmUXDBSPdh8dpfdEr5/EHAKr6kqE8otlLBXxLCXwbf6yh1MwnUqbJTPhPx9wf4O+LiCpV2/q58SydzlyeY63ni59FJQg8Vfj1vKOrXOhHY6dT38iZtdkwZ9V9V4OzFNMh+3ZF7yZZpxMIPx1ucPS8J0xkIGl1T4Np1DfwmWPISr2z1OSIya84iSlV5vEaJA58Vlguca5B5UYs3nme2bwp2ie4VfRwj13Ten81sG2YhlumjcvYZ35p+xO7BA6YFs+2c2ofIgNELTrqQ/j40kisg1cpria43si6+/JjJeF1EKZyQBxBrPCxvvIMBGTzm4GFOl6oZLwQvsXWrMOtPuviZlxrroImEYYJuQHRgH06jkUqvX6h/xq3w12xaCPI+6xvaL6zXg2b8pe9VYWQNsNMnQvrmlq1ovNNKbxMlyVhp3uRI80pkd8jwVjofMyiZq0u8pquNGYuhjNPAD64SaIzQNMWb49sruncDK+fDXomuXPoVjC5s+j8ja6YLrSM2HM4D8v8TtoC/JQkGKFTxlASD2VfLg5hd27ire8LScnjj3B2OJC8I1JC/yE97tL0uYLzYGUGZJ2raUledzOoYGigeqTESGnrNAz4omE68UdVdDFz+VIv5dU CnIkKv+Y NGmZQtyJuFP/oSSyfQitzcXrGmysGinslDNWYkJGqIHkhb0kVjToF7wGNHlK+YrrxSce6gC3mdnaU5eE72tMANePML5qVLvSlqCipiXe2UAZeyHQUpTCM0qjr5d7otxV7rcczhrR7F0xJy5DoT8w7Y5WPqQcDSTcyWTyV4UkswDqOTjC8ATudkZAQ61CyRyJhgxOFK3l8oyEvYTF4o12GGisTYVQWEChMyiPpPmQ+AHGt7jiWGQf0oj04I6xxWYyf4oYqofq1GMYo8agXeFvoLnQRrtgbeBnBl2OPVBzEpM5bCPYkfTQYFz8D0JfbUulJ13pceAbEyy+kslp9kwdEdZUwN/Tdqk6MTKLhv7yiXKy9pgpLqEH9O74wG/Iu37Wn/bPwfFxAYngoCo3B558Kvkdx2m70F+yHknuOl0H5aF4FtSloO8eFFJYEWkwOwibQdVETrmuQT8/edOxZ9pyMCGzejq0oAlFuCVJ3wNb6o4hxiIygPD3KIFgP1b64eglNbcaAHV2eL3jr7CDyMEs8seWfNDYnENy1OA7ZcmlTh6JJeleXk4g2W/lLRqVNnTsD3flDMAaaEAqai0DHMNxwGd06S5QtbrZSj107b14gPxaTV3O+8dsDQBxFlKwxAitq4cUXhfpWCRk4zBDlGi6kCHMfIttKvX0in/r+JpGVuBbzpZmBrNbp14Ro5EC6UJO63mwpG0WmaxCnApXBdWMpj/FXbmOMH+ykFf2Xjeg8JjueEZ1/xVNQNes1uReJ6l+i9Kqh18H68TEZhqf3+6DmsQhKYd7MrnN4um1ZKvpzvvUcOvmu/krY522EiHkjUrMXptG4zlh0sikvliCJkv469OGCKBGWiJyPbJHeESW9A8xg8sXsXJsG4l96OdZa5AmsDuYIrL7BzGGZnLP/B4sq/8h+t/7yf83qYUFk6+0dip0qC4h42zUG8RZggPZ9FlEQ4DOwduaL4s0sZGH3jRtXdFeFlD8u 1iDngZ86 kHHKiVOAT1q+8GgtbTRj7a0/8nzn0wGZjzrnB8gziIQD93gZ0BZZTCJTtpRWQPDmOy3tQBC88/r816+0W6YvTvfggIVKwvDtsjGvkBptO81whsZE6UHl2EnhgopLi0jvwM/deg3nDhE8V+Vx9EhTzhh3b8FmmsLAfrvHuF5JNlbm21NTBoJ7yFOSlznupm1pJXmoZmVwJ7QXiBi7mGsUuZVrttVaVBDPhh4PnjECSBsJd4lmyyXfZ4ZnWBR1f+p5J3RLDGiI0faolQ+Q5KUcljFtQ286whp3QhbhBJSCH4uBp5pxBhCEr/ZRbL4gDsVMfr/VJBp0TFEudAV4hcND+TSWC3hS2ZVpM3HfJAsyHfayLHQ5HMf3rylQWOHQwzUqzd3Wc8K6R8QFjoFW7Z/1YGwXTuyAitfURVjZgBHwMtzp8TMNln+3HFFUkSZjz65GiL4NUiTGsmuBhEkIPwPxsQaDv8Ep1+QCUiRxoGGMqMldu3Bqqsb1U/Dg7Uwu5jsI4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/21/23 23:45, Jeff Layton wrote: > struct timespec64 has unused bits in the tv_nsec field that can be used > for other purposes. In future patches, we're going to change how the > inode->i_ctime is accessed in certain inodes in order to make use of > them. In order to do that safely though, we'll need to eradicate raw > accesses of the inode->i_ctime field from the kernel. > > Add new accessor functions for the ctime that we can use to replace them. > > Signed-off-by: Jeff Layton [...] > +/** > + * inode_ctime_peek - fetch the current ctime from the inode > + * @inode: inode from which to fetch ctime > + * > + * Grab the current ctime from the inode and return it. > + */ > +static inline struct timespec64 inode_ctime_peek(const struct inode *inode) To be consistent with inode_ctime_set(), why not call this one inode_ctime_get() ? Also, inode_set_ctime() & inode_get_ctime() may be a little more natural. But no strong opinion about that though. -- Damien Le Moal Western Digital Research