From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2790AC02198 for ; Tue, 11 Feb 2025 02:40:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E1A828000B; Mon, 10 Feb 2025 21:40:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 390D128000A; Mon, 10 Feb 2025 21:40:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2585328000B; Mon, 10 Feb 2025 21:40:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 064DA28000A for ; Mon, 10 Feb 2025 21:40:16 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7EC30140B83 for ; Tue, 11 Feb 2025 02:40:16 +0000 (UTC) X-FDA: 83106109632.19.5F45A01 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf15.hostedemail.com (Postfix) with ESMTP id 8B220A0002 for ; Tue, 11 Feb 2025 02:40:13 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eVDa9OLN; spf=pass (imf15.hostedemail.com: domain of dave.jiang@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739241614; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6qFUSlT7nZKVJqFw/ffAbGd2y+ist8F07qeFYOSvJ6Y=; b=nAM+jbni6zB4En6Um5m/f8Ur5Qaj5cTTTEPE2nEgwD3IlBF0whQz4xJuyel3dDP90zVIdI v9b9F7iQiKcjPDsKHPjWhi6ZDIaMktQuPbeWr9e1e5yjAzJUMSVFyvhnbyMb+3WluVYjMr 1c6CWz0is7TRAbhLKYuh88SGTcT6zeM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=eVDa9OLN; spf=pass (imf15.hostedemail.com: domain of dave.jiang@intel.com designates 192.198.163.12 as permitted sender) smtp.mailfrom=dave.jiang@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739241614; a=rsa-sha256; cv=none; b=haa3FLEe8vPHv+sGZCbIUTjd1LdvREbZ+kHP0DAQYbd9cnWs01yUJ8YoZBQxxj32CBcHtY TlmlRyPNgis5DWXiq2sI3QTxToAN01GTtHqC3dkLlWIn+um07Ppe7uZEtX4IuXPHFse3ta kB7V21MTKP+eYLQZgfrpu5ppjRLka14= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739241612; x=1770777612; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=n2oinbXtGGE6y9EV6Pn/imw8Ob/8ITCtlHNl/OvbJDc=; b=eVDa9OLNX8svr/8CEDFqaDruQ7HGVqQHlZPVIt2jY96fVcPgHPmK1m+2 Q3o2WbDSdxZ2uS0t9O38hCYH6Rrkq8IqbRD9NIcMHd/EnqrU6T1iWOGXl e5l5SKULteLU0wuwE2mlCkvON7ddpHhUOTLkenx+JQwwrUYx0542i1nwZ /r+EF9bIaA8/ca/l5kCrHpM7SHF8xWvcSRSuACveXN7TqfRS/ThCZXcp8 P8x2p2Y5u3u6j4mmn3sqL+fCtCKkqurXKYEQ6TTB9L82qGhkFo7TxzT2g 5TA/UeN9HihS//QXY4ahEGNHxKen2DHMIZkuPs+MubhGXXIiekbHofJe2 Q==; X-CSE-ConnectionGUID: ShBokDL0S2yXUFPer2IIIQ== X-CSE-MsgGUID: VZsK+xrnRe6nbQr7J3+5VA== X-IronPort-AV: E=McAfee;i="6700,10204,11341"; a="43775066" X-IronPort-AV: E=Sophos;i="6.13,276,1732608000"; d="scan'208";a="43775066" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2025 18:40:10 -0800 X-CSE-ConnectionGUID: QNak6SWmRKSj3idvZIkL7w== X-CSE-MsgGUID: zv89mSVRRJq8wFJvqtbxwg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,276,1732608000"; d="scan'208";a="143229130" Received: from aschofie-mobl2.amr.corp.intel.com (HELO [10.125.111.192]) ([10.125.111.192]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2025 18:39:52 -0800 Message-ID: <99a80c40-4c1d-4dc6-8b44-397f49460501@intel.com> Date: Mon, 10 Feb 2025 19:39:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v19 07/15] cxl: Add helper function to retrieve a feature entry To: shiju.jose@huawei.com, linux-edac@vger.kernel.org, linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: linux-doc@vger.kernel.org, bp@alien8.de, tony.luck@intel.com, rafael@kernel.org, lenb@kernel.org, mchehab@kernel.org, dan.j.williams@intel.com, dave@stgolabs.net, jonathan.cameron@huawei.com, alison.schofield@intel.com, vishal.l.verma@intel.com, ira.weiny@intel.com, david@redhat.com, Vilas.Sridharan@amd.com, leo.duran@amd.com, Yazen.Ghannam@amd.com, rientjes@google.com, jiaqiyan@google.com, Jon.Grimm@amd.com, dave.hansen@linux.intel.com, naoya.horiguchi@nec.com, james.morse@arm.com, jthoughton@google.com, somasundaram.a@hpe.com, erdemaktas@google.com, pgonda@google.com, duenwen@google.com, gthelen@google.com, wschwartz@amperecomputing.com, dferguson@amperecomputing.com, wbs@os.amperecomputing.com, nifan.cxl@gmail.com, tanxiaofei@huawei.com, prime.zeng@hisilicon.com, roberto.sassu@huawei.com, kangkang.shen@futurewei.com, wanghuiqiang@huawei.com, linuxarm@huawei.com References: <20250207144445.1879-1-shiju.jose@huawei.com> <20250207144445.1879-8-shiju.jose@huawei.com> Content-Language: en-US From: Dave Jiang In-Reply-To: <20250207144445.1879-8-shiju.jose@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 8B220A0002 X-Stat-Signature: 9cw5grw41bku4p89pyyq4mur6hgy63om X-HE-Tag: 1739241613-75261 X-HE-Meta: U2FsdGVkX18oLVR778zF2StboCbaPbsQFsNdRVPsAIamJYfCfd4eE8/mDARsJ5UQgW4QkW8EmflQYexjoKqf4hEZEyXD8VpuZE4mhSU0hQIuDVpWcBZi39gn2m0lWqvPX5JaGee370zePmgvTb7sP0WSeF91dLec+/VHrYVkqfyrJR9+Wy72igoZUCuyjtj52qje3NzDtyZ57rceIx9B3pDE66MMB0/ntVSVKeMS26pxxR2VQp9vPrLLS5sOqybLKfnRnL0avlAVqLLoLRCXI5H00e89zp48LcnJ6yyIR1/2B9FTvAZokHyFgcejObeyKVXctlYtAAq0n84QkgMSZO9+5bsLRofgkLSeC9XFjDX2ItIrEQq58R32F4x7+QC8Y78DgyWL2w/KU7l4ISt87CuU31+fZFauz/T/73lnsHUsS6lGqHdy+PkJO4PSgKbLCxc3j2CM8vonynqxjaBfjokF/2EVbQLlfdbg6Thwd6ZwPrU8dcMDIWF75ur3+X/VVdsum5U5qjY3ud7mGmZEko922T2RFsWgn1fmEoy16XQbctsUyxc4TCxL3KEUscxpe1lmUEiMIra99snzZttvmcU0Zd2gCgLXIJgiQQBSuOIASWrjpfEtKr7Jw7SW9bHo5M8k7KVcbYLEoRCEKfS6WKVAPEGDK7NLoB0j89IHKOkMjqVOhvgeF80ah3F6VR/D27M97qHKGolT4gmpMdb440axP7HsqdFqFA24fiO1S5DGzB5aSEGIHz0kCNZ0iRvmaKZ8m6AthFk+yuQk01KbkCgiNKQmyv7tfWbRbyrv+Go7GK5gF/S8hdvcAdJinaH/awZeERFzu2zZ1Cp4QhX2mAUfbbTLDz+yESQFgFqfNtQ24+pwYKyl11dMFmfjE76VREdIoZbCOnuq59aCDH3UhDw4TyXgnyzUImoHwePXxWxCHQX7xSeGfCEQ525pptSkNm8RO5K+3l+3E//5+cY D+/lU3bp kHOvmwIyZXacOrDQka5vs17KEZsDC9Lt4n2EhtgEAb545EB7P/YuWR9oh9yCRPg0JH7K36D/OS3uVsrFQhABMPnwyeERWPeVdlYISch0gPVRVFH2pBvIIn7AxJclCvNdAn0wyv+JPmwdhTGcDiZy8M9s5aWk7VUi4P5BWcwFd1k+FIY8Rafi/ZM0jp55UwgOpecMInZ0NHfA0TaPTtwAhFKyi3Gp3J9/S3K3avM6Tcwv8aIAJlzlqbsHHZG3A6oZ80yu1c4dn8CzKxC9/1jXrQzTUDDMbddKDeDDFRSbGRas2v1w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/7/25 7:44 AM, shiju.jose@huawei.com wrote: > From: Shiju Jose > > Add helper function to retrieve a feature entry from the supported > features list, if supported. > > Signed-off-by: Shiju Jose > --- > drivers/cxl/core/features.c | 21 +++++++++++++++++++++ > include/cxl/features.h | 2 ++ > 2 files changed, 23 insertions(+) > > diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c > index 5f64185a5c7a..bf175e69cda1 100644 > --- a/drivers/cxl/core/features.c > +++ b/drivers/cxl/core/features.c > @@ -43,6 +43,27 @@ bool is_cxl_feature_exclusive(struct cxl_feat_entry *entry) > } > EXPORT_SYMBOL_NS_GPL(is_cxl_feature_exclusive, "CXL"); > > +struct cxl_feat_entry *cxl_get_feature_entry(struct cxl_memdev *cxlmd, > + const uuid_t *feat_uuid) > +{ > + struct cxl_features_state *cxlfs = cxlmd->cxlfs; > + struct cxl_feat_entry *feat_entry; > + int count; > + > + /* > + * Retrieve the feature entry from the supported features list, > + * if the feature is supported. > + */ > + feat_entry = cxlfs->entries; > + for (count = 0; count < cxlfs->num_features; count++, feat_entry++) { > + if (uuid_equal(&feat_entry->uuid, feat_uuid)) > + return feat_entry; > + } > + > + return ERR_PTR(-ENOENT); > +} > +EXPORT_SYMBOL_NS_GPL(cxl_get_feature_entry, "CXL"); You probably don't need this if the memfeature code are in CXL core. DJ > + > size_t cxl_get_feature(struct cxl_mailbox *cxl_mbox, const uuid_t *feat_uuid, > enum cxl_get_feat_selection selection, > void *feat_out, size_t feat_out_size, u16 offset, > diff --git a/include/cxl/features.h b/include/cxl/features.h > index e52d0573f504..563d966beee5 100644 > --- a/include/cxl/features.h > +++ b/include/cxl/features.h > @@ -68,6 +68,8 @@ struct cxl_features_state { > }; > > struct cxl_mailbox; > +struct cxl_feat_entry *cxl_get_feature_entry(struct cxl_memdev *cxlmd, > + const uuid_t *feat_uuid); > size_t cxl_get_feature(struct cxl_mailbox *cxl_mbox, const uuid_t *feat_uuid, > enum cxl_get_feat_selection selection, > void *feat_out, size_t feat_out_size, u16 offset,