From: Buddy Lumpkin <buddy.lumpkin@oracle.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
hannes@cmpxchg.org, riel@surriel.com, mgorman@suse.de,
willy@infradead.org, akpm@linux-foundation.org
Subject: Re: [RFC PATCH 1/1 v2] vmscan: Support multiple kswapd threads per node
Date: Thu, 5 Apr 2018 23:25:14 -0700 [thread overview]
Message-ID: <99DC1801-1ADC-488B-BA8D-736BCE4BA372@oracle.com> (raw)
In-Reply-To: <20180405061015.GU6312@dhcp22.suse.cz>
> On Apr 4, 2018, at 11:10 PM, Michal Hocko <mhocko@kernel.org> wrote:
>
> On Wed 04-04-18 21:49:54, Buddy Lumpkin wrote:
>> v2:
>> - Make update_kswapd_threads_node less racy
>> - Handle locking for case where CONFIG_MEMORY_HOTPLUG=n
>
> Please do not repost with such a small changes. It is much more
> important to sort out the big picture first and only then deal with
> minor implementation details. The more versions you post the more
> fragmented and messy the discussion will become.
>
> You will have to be patient because this is a rather big change and it
> will take _quite_ some time to get sorted.
>
> Thanks!
> --
> Michal Hocko
> SUSE Labs
>
Sorry about that, I actually had three people review my code internally,
then I managed to send out an old version. 100% guilty of submitting
code when I needed sleep. As for the change, that was in response
to a request from Andrew to make the update function less racy.
Should I resend a correct v2 now that the thread exists?
—Buddy
next prev parent reply other threads:[~2018-04-06 6:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 21:49 Buddy Lumpkin
2018-04-05 6:10 ` Michal Hocko
2018-04-06 6:25 ` Buddy Lumpkin [this message]
2018-04-06 7:38 ` Michal Hocko
2018-04-10 21:37 ` Buddy Lumpkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99DC1801-1ADC-488B-BA8D-736BCE4BA372@oracle.com \
--to=buddy.lumpkin@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=riel@surriel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox