From: Neil Conway <nconway.list@ukaea.org.uk>
To: Andrea Arcangeli <andrea@suse.de>
Cc: linux-mm@kvack.org
Subject: Re: [patch] care about the age of the pte even if we are low on memory
Date: Mon, 9 Aug 1999 11:42:26 +0100 [thread overview]
Message-ID: <99Aug9.113711gmt+0100.66305@gateway.ukaea.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.10.9908082020250.29734-100000@laser.random>
Andrea Arcangeli wrote:
> @@ -54,7 +54,7 @@
> * Dont be too eager to get aging right if
> * memory is dangerously low.
> */
> - if (!low_on_memory && pte_young(pte)) {
> + if (pte_young(pte)) {
Ouch - let's try to keep those comments up to date folks. Good comments
are better than
none, but out-of-date ones...
Neil
(ps: I realise of course that this is only your v1 patch Andrea;
undoubtedly we can expect another half a dozen versions over the next 48
hours, one of which will contain updated comments ;-)))
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://humbolt.geo.uu.nl/Linux-MM/
next prev parent reply other threads:[~1999-08-09 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-08-08 18:38 Andrea Arcangeli
1999-08-09 10:42 ` Neil Conway [this message]
1999-08-09 10:46 ` Andrea Arcangeli
1999-08-17 0:29 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=99Aug9.113711gmt+0100.66305@gateway.ukaea.org.uk \
--to=nconway.list@ukaea.org.uk \
--cc=andrea@suse.de \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox