From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4813C19F32 for ; Wed, 5 Mar 2025 03:18:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C3C56B0082; Tue, 4 Mar 2025 22:18:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1744A6B0083; Tue, 4 Mar 2025 22:18:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0620E6B0085; Tue, 4 Mar 2025 22:18:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DC5226B0082 for ; Tue, 4 Mar 2025 22:18:46 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 404E1120A7E for ; Wed, 5 Mar 2025 03:18:46 +0000 (UTC) X-FDA: 83186040252.06.743F4AB Received: from out-184.mta1.migadu.com (out-184.mta1.migadu.com [95.215.58.184]) by imf09.hostedemail.com (Postfix) with ESMTP id 59298140005 for ; Wed, 5 Mar 2025 03:18:44 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=KP+rbTv7; spf=pass (imf09.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741144724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aw3iDT/PkuvbilfEibwylx5xq+5vaoH00LShFW/cxdY=; b=tt3ugbK7fLY3FIagDQwwIsidWY0YAhfVeUgSVUhnz7fiPbB3x9b1wd1u92uLIMOqpkuOC+ 6yk4r+hpmVyKaoavqSM+ZySK1Gm02SSSADuqtJGqvOhgCc4rzXSnax+xeFMe8ZxDimdI4B e7g32oxEjJL7Q4fOJUBBNdoft2hzoEQ= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=KP+rbTv7; spf=pass (imf09.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.184 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741144724; a=rsa-sha256; cv=none; b=DzJ56zntU6wOPvW8mgJq8ZiXJfIUkzZlHG266yRn+kr2CBIEgILUfA9G6WnMahF9hdmiIu tBpd2CQqbToNl/OpjwGCcVG1gihddmqhKuxql5+5aI7ysk/L4abY6UIukCDZ9OwlVHsnqC YUC6yJNb+4D/R6UX4hHfw53J+WOpmZA= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1741144722; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aw3iDT/PkuvbilfEibwylx5xq+5vaoH00LShFW/cxdY=; b=KP+rbTv7YlmSKajvTg9ibpLiBycvjkoWYS6EPpl0pbmcSlWRSNLaoGNW8Q7a4JKulUbf7D udxOxQ2F/Dc7tebAb2sRVPnubSqBNb/+QfHztrOmNNMZUD8hZsJF/8ZJ+Y8GLEJ5fyNbI1 CR2LObZCy7SmMzMlT5xR7+b43ZhqH9M= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.400.131.1.6\)) Subject: Re: [PATCH] mm/shrinker_debug: Fix possible memory leak in shrinker_debugfs_rename function. X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20250305020123.605496-1-liuye@kylinos.cn> Date: Wed, 5 Mar 2025 11:17:48 +0800 Cc: akpm@linux-foundation.org, david@fromorbit.com, zhengqi.arch@bytedance.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <99A7645C-B8FB-4F28-B4B8-D5372F4C001E@linux.dev> References: <20250305020123.605496-1-liuye@kylinos.cn> To: Liu Ye X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: hcds71dkopykogggiixfg94n67w39mxg X-Rspamd-Queue-Id: 59298140005 X-Rspamd-Server: rspam07 X-HE-Tag: 1741144724-81798 X-HE-Meta: U2FsdGVkX1/VLkRmYJUbUnFGzuzR1Oho/kq8cOeNfvJy3S8WCZWJkyxmmdM70bsKDXTYOs6XfLs5zO0l2SOxejxpK7lCFHRyePZOctydAxXvfkpUGN7kYbv4GoOvhm78hBtlpLirKtps2w0SzNfC5hJVr6JmMWz4ZmIO2ib1tVV28hCwzkVlUrl8efuH2nL8o/ML7pKWCTutN/ZbHqtlEOrMqu0NZubY5mTMgoAaru7o5zomzeABrf/id46ON+c8bZrfe44LZrEtrH5aEQZfL5ZpTCx/Tq2W/N4BfoX1vuJAm+5qkNV8dzjGNebk/bKTdB3Zavw3gM7XOQjS59N6R4X+F8y/9g4bySJ+29w2WQ3Mt2OQaa1unJgxBKQ7g9E5JHbVORsnQmFH7ArbMVxWskjMHleIHGEZUVUnJyGwb5LWz6N9a/Ii9wjF7saUtWC0AUzIfbugf6w/fouGDWj17d5n3ZTFsx08Y/PaMmAP69+4WPk5fkvCDoOMxBLt2xIiyhyrHFAWcDClzPz4T1IhLx6eZBCMBKeiSx4YOpgmKEXkO5F2R8fOrf4ZUp7EFzDo9L9T0uytm+iqZnOKkyCpY6UHgHaExHIJmcbHopMDp03D5RLbT5ONiQpyr5HIOdR2t2JcROMPMzXXNurTTE0++QZdtSiLc80L69Ie7V+PnYrE9GDigLX8AU0UnbAuz18t9JWvbLK6jezp5ZvuIyIuuAZ8qERI2OfMWnJi720AoJoQseDWl0G4kcDsENM8iisuhFyTO8OI/Ra4mhW0TI1/oULBhcAH910d8gr+Qu72Xu2xiRKLMvoZSw7GoU5PpbbCblhylLrZQCgy25+PgIZsimQrHD3GBWwar8QkjnUgL6JUzdgx6Ur9bLaGZbMatK/OjnKKwguG6t3hEmF0kSD30HOuCqP7PkNpyDskG8cIO5VRNp0XjkrIVq35H/3NHtsSBKLIaOXB7Ir6Yst4N9i vP6MTfcD fn0AY6URr0qXAZMV9iN0t1qCrjTRAb6aUK8y7BKXt8/dip/ged0EEbEE/eBPoT05NqPa2V1jr5lYQ52FzD/Mb5ufKBbwAjPVeb5njRcpkK0tJ/EzJ8EvpelV737siWKXu/TyyDhd98c4TLclBduO0ideaKYxVQme0n/FgdBrEIWrLcbblLvI8dxeIoV4XAwoBV7qfIKAwTl1ktv9J4WmJr0+A0WXiDmLZahxfPrVrstfl3qIxFcBHQ9sTK2C9hZ/s7JVQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Mar 5, 2025, at 10:01, Liu Ye wrote: >=20 > After calling debugfs_change_name function, the return value should be > checked and the old name restored. If debugfs_change_name fails, the = new > name memory should be freed. Seems it is not a big problem, no memory leak at least. The effect is = that the shrinker->name is not consistent with the name displayed in debugfs. Right? But the improvement LGTM. So: Reviewed-by: Muchun Song Thanks. >=20 > Signed-off-by: Liu Ye > --- > mm/shrinker_debug.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) >=20 > diff --git a/mm/shrinker_debug.c b/mm/shrinker_debug.c > index 794bd433cce0..20eaee3e97f7 100644 > --- a/mm/shrinker_debug.c > +++ b/mm/shrinker_debug.c > @@ -214,10 +214,14 @@ int shrinker_debugfs_rename(struct shrinker = *shrinker, const char *fmt, ...) > ret =3D debugfs_change_name(shrinker->debugfs_entry, "%s-%d", > shrinker->name, shrinker->debugfs_id); >=20 > + if (ret) { > + shrinker->name =3D old; > + kfree_const(new); > + } else { > + kfree_const(old); > + } > mutex_unlock(&shrinker_mutex); >=20 > - kfree_const(old); > - > return ret; > } > EXPORT_SYMBOL(shrinker_debugfs_rename); > --=20 > 2.25.1 >=20