From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19638D60D09 for ; Tue, 19 Nov 2024 01:44:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5831D6B0089; Mon, 18 Nov 2024 20:44:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5328E6B008A; Mon, 18 Nov 2024 20:44:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35D906B008C; Mon, 18 Nov 2024 20:44:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 16CFF6B0089 for ; Mon, 18 Nov 2024 20:44:17 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B2CF0C0132 for ; Tue, 19 Nov 2024 01:44:16 +0000 (UTC) X-FDA: 82801148850.28.C044CB8 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf21.hostedemail.com (Postfix) with ESMTP id 99EBB1C000A for ; Tue, 19 Nov 2024 01:42:40 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h5g2ndvp; spf=pass (imf21.hostedemail.com: domain of zhangwarden@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhangwarden@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731980411; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6TLGZPhgwiSdTuoKO9EIOhX+7x+wgHfPfCEdlENWql4=; b=uWRJD7TAmRX7QEj+h9lL3UOoqVFJzEWQm9TlkeMPCUkiE+uZj+iqlsAUp8nvQdsCisH/Ni A8v8E4cbwSBP3cnxqIdPcEFZmpv0iiQRM85uvlwosIXSOGg8GZdIY8wRAj7iDMoRTSiMLD AgfTOKlHg8HKoVri2fZFlVLTSK6OxLU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=h5g2ndvp; spf=pass (imf21.hostedemail.com: domain of zhangwarden@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhangwarden@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731980411; a=rsa-sha256; cv=none; b=GgIA4Juqrt9b86ipAGezxWgo2gnuRSRX5eAM8SS2SbPFKdC/F29SlojOObej8oYqZJzBpG +hnbiEWl8NAdg600eKYZ984VXxKKTaMAIWbMH8nnQB+e2otky2rugVO2hitGM7G9sU+3pG mqwYC965N+Xu9B62XSJBvqLJxs/IAEw= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2124ccf03edso2878005ad.2 for ; Mon, 18 Nov 2024 17:44:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731980653; x=1732585453; darn=kvack.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6TLGZPhgwiSdTuoKO9EIOhX+7x+wgHfPfCEdlENWql4=; b=h5g2ndvpugLGAR61ywEKOjO6pOYc1xpHDXCwUHTGseUo3Osi/UKfH3e56dK1n6pn49 kUp9Poy6F7KCbijAaXcTJUrDr/WIDerg/TuQy2Cd1cNeZ9IE1iiJqzyDNzOi+PYsiI82 8He++uCJMTNCQWmLkBZ5IqLkeW5I4QjmatQNQtJ+7qkReMPgsU4kDfu7TkqCpiiEemDP LG2BDsIgk/obJ+Oo3CUhftmtjZJeze2qYcFuyI2l7/STGvK3JSye3U9DMAWUQ/wi2SOJ CpaEjDh0YmFexBLNaqnRwy+OSOQA8zxWzF3pGy4nVxmcOYNX9r2FWUYQwRTUOux1VkoB FDsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731980653; x=1732585453; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6TLGZPhgwiSdTuoKO9EIOhX+7x+wgHfPfCEdlENWql4=; b=nU2mvhJfkQY0QbZFrPyQwlT5ZLRnPIx6LljzCZI3tO3/KnkT3cZ6zcYcx0jcAltFB3 OSAXluarL97G3SOq2hkU0/6cDG9lBTNGV9G+qwVtndjeWcSVfBtsISFi2w9mlQ/2lFL6 zVbBNIGbys33ZwXr/ZgPEp0zmD9HIvz1RQcpFuvXzSQBleqoR5Z/AB/CTIO7bLd/Qbm1 +57OphwKwGhADI18WwrMDc9cG2Vfz5TmI+Tv8oSYqlFywg10s3MmrrT7J1I34nooFjy1 Gb2KcLfEKFD0OFt1F9zulvKIwxVUni3vg7TLjrdgnOkgFt3bZAsfzjdYMklFxwjCChn1 75AA== X-Forwarded-Encrypted: i=1; AJvYcCVK3+7ZY5j73TG03Xf5VzieMLHbVQg6EjWxifMVJXLRAAZrHUU7ckyoaffcW/P2eoyRqyE7+zh9/Q==@kvack.org X-Gm-Message-State: AOJu0Yw3sdr/TLMexYqj9fNA9y89pFyXllYqM2cgB3c+DIK7z1MefXOM 5E1UlrNXMPrQrw5TIhJ3vAz7R8PuS4tJW+XnQZnSJajo3duzUU4f X-Google-Smtp-Source: AGHT+IGKOuuVyAvdbfIttKIxJSv7PNCbNBMgaHYEIodVhJO4YNPmnFai9XI15Qs6QZqqMPXdK5RTjA== X-Received: by 2002:a17:903:186:b0:212:46c2:632e with SMTP id d9443c01a7336-21246c26707mr25423135ad.15.1731980653295; Mon, 18 Nov 2024 17:44:13 -0800 (PST) Received: from smtpclient.apple ([198.11.178.15]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211d0f6182bsm62977715ad.277.2024.11.18.17.43.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Nov 2024 17:44:12 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\)) Subject: Re: [PATCH v2 19/21] livepatch: Convert timeouts to secs_to_jiffies() From: zhang warden In-Reply-To: <96f3b51b-c28c-4ea8-b61e-a4982196215f@linux.microsoft.com> Date: Tue, 19 Nov 2024 09:43:32 +0800 Cc: Petr Mladek , Christophe Leroy , Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?utf-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?utf-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Content-Transfer-Encoding: quoted-printable Message-Id: <99755FD2-270C-4122-8A22-6C73A81028F6@gmail.com> References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-19-911fb7595e79@linux.microsoft.com> <718febc4-59ee-4701-ad62-8b7a8fa7a910@csgroup.eu> <96f3b51b-c28c-4ea8-b61e-a4982196215f@linux.microsoft.com> To: Easwar Hariharan X-Mailer: Apple Mail (2.3774.500.171.1.1) X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 99EBB1C000A X-Stat-Signature: sc5wifnokukcn7ta1sf7q4xfqt3nkzen X-Rspam-User: X-HE-Tag: 1731980560-389432 X-HE-Meta: U2FsdGVkX1+F3xt/BuWgLWIFkyPveo9b6JJvG3Wp2SRvpGsgnQHwTQyDUFQNBqVijY9dtiBhYrBfbJtYo/gutSEBH+mJvx5TTv+XqFxdmDFhFZL5SEg+nb5VkxbPQKk6FYy3Guhy6ZMUdLrEMAVEFGt+/6PnIPQIdrethAmuJSx1YjdZ3LPCEL4sQcI/Th+vCtXTg7T5Oerl7hM4k9ctYaoyJ9ok58Z/AztJbpzY6H/Y8Y7UPJpbSjtT9oZwmEkPrrIjyZtgqEFiPzarxzK32NLIiDBSPUuNvy+75TtEUoorshwqVFQKgZ9by5a9L1+jOlkPYzTTqNan4eA64ciKVJqMPthUP3tqXhqr1vIUMssw0c0RVwygsl/LwsjRHn2XKVz0F/2gOHtLlTbIR8xjlZErW9iLGcPsmWmz0k+MUy6+XacBrIalFhcy9CA386agTCZ6Y+deyuucuXC3Qu9xdJFVj7doAbMr0Vhy5rjid6W8jvKq3OxpodKPPXlYiyaBTFWPX+DnvRRpqSv4/l7Z3izo1nF0s+JqjXo1cELwfsNvBbMGrPifNHnJFAC/uLhbIZi4nKh5fQduxawj0tixbtMwE+iJ7W0ajVXL8xTUtzyKd4Pem9HSjcH6Ucxr1klGZ1dM0cygp9PE4ucFcy6mWPQpZuzQTYeXcwmL7gBt0ORp/ANZ6iS5jaRG0mep5DrBRCCmSOGkvgtrje3ePF32Flp3HPfByeGDHklxSk5Vzlxtfer5JiLmlZQP3ziVPBzEdCL3I2EdK80T0/dW/sSEF1C12PF1jDxXNy1hg+ONxHrmibvuIqKs6qENXhb0CpzgvJTX75+V+E2p7ejYZinAdJtKgMqCyqksb4m5sBKyuDyiBEguMBT8ZcRBXacoH1aX5/Du2bWHNrgyXbGYYV0Sup6yFF2Bj/cpaYJucp+3pM5MYADKMzFBtWwC9N2NyesU+JpPOJDDm4CPq7NS4+d ttg3b+JA sNV5620p+VOSUDtoSd/tBNjk/Y95aGy66D5l1jeJpyWNlJJCsPiFLaZQ9yvBwNMu5g/6kIaw2+XatSezWqrtEl1oYqnaleitlcxKhw6wnf351k/qYTcIJf8CeXf8APSOxo0zn1HGK6yffuvq9rkx8B7LBdOy/ph1DpcItgjL2KLab7IL38JansVLb0FOqU7JSwmDbrEyhsL8BEATMLF/LsjVwaWqwCzkiKxUGoCFKzWP4t/9V1YEhVhMrBdl/9+UVa67Sxvto645Eoimsq5Ttd1LblX11EMLfUVzMR2crEQKa5Nb8OnRfoRzppW8d2HU9B41j1YiwSC+b56VZNhERlxrWgLAhBLLuYxxF1wypdArFlSQAM0t+5NXgX1ivxaMLfsf/O0LJ3EW/awjtQVCTKu2Ka8NDP19nHnCdsPKmDRNCPYlD8IcQiylL7qNvXjCvV7iCaxEAiqPTHjY9FTRWprxyOXSJBSMqUaJ6V6bktHP+xNwutO3994rEQ7m2JyIUDsPAgzB5Q8D7JfUUJONie/gTnATOxXHjHaxWLnVSpc4sPjVHq6j3V9pcFb7L/Wd+wx/t X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Nov 19, 2024, at 02:18, Easwar Hariharan = wrote: >=20 > On 11/18/2024 3:06 AM, Petr Mladek wrote: >> On Sat 2024-11-16 11:10:52, Christophe Leroy wrote: >>>=20 >>>=20 >>> Le 15/11/2024 =C3=A0 22:26, Easwar Hariharan a =C3=A9crit : >>>> [Vous ne recevez pas souvent de courriers de = eahariha@linux.microsoft.com. D=C3=A9couvrez pourquoi ceci est important = =C3=A0 https://aka.ms/LearnAboutSenderIdentification ] >>>>=20 >>>> Changes made with the following Coccinelle rules: >>>>=20 >>>> @@ constant C; @@ >>>>=20 >>>> - msecs_to_jiffies(C * 1000) >>>> + secs_to_jiffies(C) >>>>=20 >>>> @@ constant C; @@ >>>>=20 >>>> - msecs_to_jiffies(C * MSEC_PER_SEC) >>>> + secs_to_jiffies(C) >>>>=20 >>>> Signed-off-by: Easwar Hariharan >>>> --- >>>> samples/livepatch/livepatch-callbacks-busymod.c | 2 +- >>>> samples/livepatch/livepatch-shadow-fix1.c | 2 +- >>>> samples/livepatch/livepatch-shadow-mod.c | 10 +++++----- >>>> 3 files changed, 7 insertions(+), 7 deletions(-) >>>>=20 >>>> diff --git a/samples/livepatch/livepatch-callbacks-busymod.c = b/samples/livepatch/livepatch-callbacks-busymod.c >>>> index = 378e2d40271a9717d09eff51d3d3612c679736fc..d0fd801a7c21b7d7939c29d83f9d993b= adcc9aba 100644 >>>> --- a/samples/livepatch/livepatch-callbacks-busymod.c >>>> +++ b/samples/livepatch/livepatch-callbacks-busymod.c >>>> @@ -45,7 +45,7 @@ static int livepatch_callbacks_mod_init(void) >>>> { >>>> pr_info("%s\n", __func__); >>>> schedule_delayed_work(&work, >>>> - msecs_to_jiffies(1000 * 0)); >>>> + secs_to_jiffies(0)); >>>=20 >>> Using secs_to_jiffies() is pointless, 0 is universal, should become >>> schedule_delayed_work(&work, 0); >>=20 >> Yes, schedule_delayed_work(&work, 0) looks like the right solution. >>=20 >> Or even better, it seems that the delayed work might get replaced by >> a normal workqueue work. >>=20 >> Anyway, I am working on a patchset which would remove this sample >> module. There is no need to put much effort into the clean up >> of this particular module. Do whatever is easiest for you. >>=20 >> Best Regards, >> Petr >=20 > If we're removing the module, I'll drop it from the series. Just to > clarify, do you mean to remove all of samples/livepatch/* or some > particular file(s)? >=20 > Thanks, > Easwar >=20 Hi Easwar! I think Petr is going to remove just this module away. Anyway, I don't = think removing all of them is a good idea. Thanks. Wardenjohn.=20