From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 261FFC38145 for ; Tue, 6 Sep 2022 21:34:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DB318D0009; Tue, 6 Sep 2022 17:34:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 964068D0002; Tue, 6 Sep 2022 17:34:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7DE3C8D0009; Tue, 6 Sep 2022 17:34:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 700128D0002 for ; Tue, 6 Sep 2022 17:34:04 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 4CCD6AB4CA for ; Tue, 6 Sep 2022 21:34:04 +0000 (UTC) X-FDA: 79882963608.06.91A1B82 Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf17.hostedemail.com (Postfix) with ESMTP id EF5914006D for ; Tue, 6 Sep 2022 21:34:03 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id fs14so7822382pjb.5 for ; Tue, 06 Sep 2022 14:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date; bh=IKhYcRnVpBMUy44Ky+OSn3unUvUJA/cx1qEki2e9zns=; b=aFdBWucaLdZEwZJ6WLrXWIoc4kVWR2vkVsDGZVeMbOQBPDDaWTB4yceHuwQB5jAOMK wIC+hC8xCsXUQzYyMl45qUbevm+f+Qvn3EsykPGsVUKT8mtYSe2d74FHpskmHtO4abe6 SYd0EZuFi6TyVjTE+JCmqLeDq7cVweTo2/xc+4+rl6Esl5btQ8cgLy2avwdOgQ9u6783 +MTl7act3MHNDxnAGjrQsjl+TZAyzM8D8xrbnjqBqkdKlHmd0b6K1OgohrNJCVFl17f6 uwRNHdxkmdu5h4g8WbNh5QUfNVddLoPT3MAVaKjelVBHASDU1mbvSpoUXgp4ePr1Z6Cl dQjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date; bh=IKhYcRnVpBMUy44Ky+OSn3unUvUJA/cx1qEki2e9zns=; b=40xjxAVqG7qG6V9+RJAkhZjmP+HEodVOD1odgCnHeV7TBSMo94N7EQn+z36mtwjlFG SNnLoPkqh6yI4giI0F4Is0SI2C6xFlt5TAIeS/En/L4Wf5Su10MuXQuXJbNnWy/ylBcL 1v+AUxpBHRRPPp2htTh3Ga5oYbB/KbCJcmu5ZMqrqFo0a2T2pKA52DkoHA1AKzcLbAKc y1XuGqRrFVriilQ8FduXjNQ83Ymf5LLzQGN6Ex53htavElaaQ/nP9OcVtYnE/ggATd8e uY29+BrAJMUMJq4kDjwVH59I60NTx4FPL/aC5k9oTcQRWwP0q0Yljke/BUFWciODNVJa wawg== X-Gm-Message-State: ACgBeo2vT3cZeFmFRue+DbDV2l9yfECwgPpMzrbNeWUbcBfQT10/+8x2 mPxD0ZddyHO1N0k62NWm+2ZCjA== X-Google-Smtp-Source: AA6agR6wn83aAjSf0Y1qQOvYqA6bFaDA4t15O18lyRUAhJZFqVIuzshuuA2LhtTdC7TFKV2qwRz9lw== X-Received: by 2002:a17:902:8f8a:b0:16f:975e:7c6e with SMTP id z10-20020a1709028f8a00b0016f975e7c6emr486509plo.136.1662500042888; Tue, 06 Sep 2022 14:34:02 -0700 (PDT) Received: from [2620:15c:29:203:9177:d472:6043:99cf] ([2620:15c:29:203:9177:d472:6043:99cf]) by smtp.gmail.com with ESMTPSA id x12-20020a170902ec8c00b0017543086eb3sm10510787plg.274.2022.09.06.14.34.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Sep 2022 14:34:01 -0700 (PDT) Date: Tue, 6 Sep 2022 14:34:01 -0700 (PDT) From: David Rientjes To: Chao Yu cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, jaegeuk@kernel.org, Chao Yu , stable@kernel.org, syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com, Muchun Song , Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: Re: [PATCH v2] mm/slub: fix to return errno if kmalloc() fails In-Reply-To: <20220831145454.858200-1-chao@kernel.org> Message-ID: <996c5407-711e-18e5-79e1-995afbd6c151@google.com> References: <20220831145454.858200-1-chao@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662500043; a=rsa-sha256; cv=none; b=wSmKKrPu01aH4c2alJdazXfER2cZhKXmsl2Lv3ejphT8LnPNkxjkRYQyoOyiZ+9yDr/1NX uKLfnzVoHKBOdnBC3o8Rlo/HwO00yR8xVAWA/bU4LjiJFneog88z/GEnLbph8YHcjA8pUS soqA1YeJbfP19QwIV4wArRAKDI2aOk0= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=aFdBWuca; spf=pass (imf17.hostedemail.com: domain of rientjes@google.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662500043; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IKhYcRnVpBMUy44Ky+OSn3unUvUJA/cx1qEki2e9zns=; b=2UnxWuU9pobGC795+3laR0+33I3YXvuxLWTTHacdLcccGCwHHLZws+jOIL0BnRpagE/xDz 6tn0vwJ0R+bJmxjSPUStXrroBMr7SJOUvxSYdDO7vWaoD/l/Ow4umfuak8MCA6zXyDmN5y QYRnCbVdAH0TLvM3X/58U44Zh2NFIjY= X-Rspamd-Queue-Id: EF5914006D Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=aFdBWuca; spf=pass (imf17.hostedemail.com: domain of rientjes@google.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: eepeg9nghhz8or1pjtkbr4shsp7hna4s X-HE-Tag: 1662500043-539150 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 31 Aug 2022, Chao Yu wrote: > From: Chao Yu > > In create_unique_id(), kmalloc(, GFP_KERNEL) can fail due to > out-of-memory, if it fails, return errno correctly rather than > triggering panic via BUG_ON(); > > kernel BUG at mm/slub.c:5893! > Internal error: Oops - BUG: 0 [#1] PREEMPT SMP > > Call trace: > sysfs_slab_add+0x258/0x260 mm/slub.c:5973 > __kmem_cache_create+0x60/0x118 mm/slub.c:4899 > create_cache mm/slab_common.c:229 [inline] > kmem_cache_create_usercopy+0x19c/0x31c mm/slab_common.c:335 > kmem_cache_create+0x1c/0x28 mm/slab_common.c:390 > f2fs_kmem_cache_create fs/f2fs/f2fs.h:2766 [inline] > f2fs_init_xattr_caches+0x78/0xb4 fs/f2fs/xattr.c:808 > f2fs_fill_super+0x1050/0x1e0c fs/f2fs/super.c:4149 > mount_bdev+0x1b8/0x210 fs/super.c:1400 > f2fs_mount+0x44/0x58 fs/f2fs/super.c:4512 > legacy_get_tree+0x30/0x74 fs/fs_context.c:610 > vfs_get_tree+0x40/0x140 fs/super.c:1530 > do_new_mount+0x1dc/0x4e4 fs/namespace.c:3040 > path_mount+0x358/0x914 fs/namespace.c:3370 > do_mount fs/namespace.c:3383 [inline] > __do_sys_mount fs/namespace.c:3591 [inline] > __se_sys_mount fs/namespace.c:3568 [inline] > __arm64_sys_mount+0x2f8/0x408 fs/namespace.c:3568 > > Cc: > Fixes: 81819f0fc8285 ("SLUB core") > Reported-by: syzbot+81684812ea68216e08c5@syzkaller.appspotmail.com > Reviewed-by: Muchun Song > Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Signed-off-by: Chao Yu Acked-by: David Rientjes