From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B83C4332F for ; Thu, 2 Nov 2023 06:00:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A28E80014; Thu, 2 Nov 2023 02:00:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 353058D0026; Thu, 2 Nov 2023 02:00:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21ABC80014; Thu, 2 Nov 2023 02:00:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 12BCC8D0026 for ; Thu, 2 Nov 2023 02:00:11 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DED8DB60D6 for ; Thu, 2 Nov 2023 06:00:10 +0000 (UTC) X-FDA: 81411963780.29.C294488 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by imf20.hostedemail.com (Postfix) with ESMTP id 4013C1C001D for ; Thu, 2 Nov 2023 06:00:07 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZzljaypS; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf20.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 192.198.163.7) smtp.mailfrom=binbin.wu@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698904808; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oR97yPYlrGAYI4MEB3INBwckQ/ErHV9EtrMLwwPmQQA=; b=x+Ft6A6q6fgqgJf0xJSfQWF+KM9Fwvk+xi3AM9K17jZcFnjabvI8kwJ5gesU9WeodvGqCb hSww/yyITHilhdPyfvo5VMtNzYXS9oMcL8miUkjzbTK+y78DqnblH0/x6vf4qUcEmmWEw9 29xVCxnpfiGvScei/bYIcpdHE6dJhFE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZzljaypS; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf20.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 192.198.163.7) smtp.mailfrom=binbin.wu@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698904808; a=rsa-sha256; cv=none; b=6WOjOgMz5TmGbF3Xk+Yks8MhuAOH7A9BdRcdjrP8c4lwZ6az+xrLXs+jQfy0hAIk5BJ/b0 hb0k1AIH18d3MJWtU5TwCXzfcj4+OYfSTyGrL/GKFWOQ8gHa7ZITQhWusLRM4uhhQDBswL RD6gDAUytkmk/MWRqYjdkSm0fCWnBwY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698904808; x=1730440808; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=ou5/8bq0/RVZthvT/yQo+QsMVA9om+MCO0TErMQh5Kw=; b=ZzljaypSzdh4+cYB/HH6VOCYV4shgzSlwdmH/J1Hfb2kY8zhRVRps1h9 dDnUarP/Y3E0+kOoe4jdVWTwwZQb/MtsCwcAS6CztrYLQlAkBaL8xo4CH o447BJN9s3TE6ULO06MiD/hyllY9JrSa0zb+EG/uA7+JJVZhh5Om7L5ju izjrgnmrikCezLf5uDGBEu7U1UGTvc7mrH68AbWNLAjs9soACxCsjvSWu 6ZaxOSH3LhSdso7YBjV4P/O4iZq+qTosHWgCvMBjgGqcrQmX18Jebb+Yj nfmrx9TcW0+i9J3esqtekLAdJiye880Q3xguGyXUR69iwDa+44w7eAKJj Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="10174668" X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="10174668" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 23:00:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10881"; a="884777553" X-IronPort-AV: E=Sophos;i="6.03,270,1694761200"; d="scan'208";a="884777553" Received: from binbinwu-mobl.ccr.corp.intel.com (HELO [10.238.2.253]) ([10.238.2.253]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2023 22:59:55 -0700 Message-ID: <9963b77c-3a38-4f89-b21e-48d0fdda8f53@linux.intel.com> Date: Thu, 2 Nov 2023 13:59:53 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 12/35] KVM: Prepare for handling only shared mappings in mmu_notifier events To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-13-seanjc@google.com> From: Binbin Wu In-Reply-To: <20231027182217.3615211-13-seanjc@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Stat-Signature: t53jpiag7ft1gk3ytgszyykjgr4s8bo4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4013C1C001D X-HE-Tag: 1698904807-332175 X-HE-Meta: U2FsdGVkX18NEtTmEK1kA8Gc0CPHFCfQgL8Wni/EG7XVFD6CmcX0GpEhPDMzmKmQbpa03WFb+89oLPZX4HJRcfQ1vOKgoKr8lPGF229z0lJRno8HzIQb+CFTK2mISJ2OVDSEkOpMvcrRARdob9kEroq3FSN59aoJDcI/TGL4cykd8cLlfldruEg3tDqNABDzsc3a2SFLSBFo7vnOIRBrItNLAvAhUMn6oGVwEOGelwqfMeNby1V8Ds/moj4IiFRcIn/vMzymleLkzPlhCygv7B9Ro3ptu9C1RqebpZPvfCdcaRNHwWLNnyX6rM+ciGU4lUBQuTreDw0uT/NABzvFrlEq8B5kr80I8r8zuQO8UZsJ/6HzARPzzydORkGUfNye6+cQC04pNB14IeCEGEzSY1z8CAi6G18Pkapq6zbjhYeZAWG1YdVfRgHLKyD7/orCICD7at0fXv9VhozMTgP82o4BIs4p1c7pxz+Dq9XSCdqJZDardLQjBwCfafjLxLct4Qxqf/cKiphRJ1370nPI9imLq+21wY1KN1nb6rbjRAYO5Ln+UFarY12MUIPCHMQpqkqV1wuhu+MS2ztwRsARF7N94rZPYqTivAqYdySBItT2DqMnNC1ubHHacpJQFNMd9yMduh3XQsUB9nw6V7TZ7EkU6mw5SsNfO+QfQIZ7Kb8UmybhMQwoPTZ0hCuQO4O+TGAwl6wlJaSorhWhTFct+GijHmEqh62QP/qT8cJtl9mpw5XQ6t6YIYoDQ9gWQ8rSHhDQt1chJnDTnYL0iKqe76/fjvIPSvQY+ObLB7okVlBJJutpyI0eL9up4NVmgZXm6WH8hrMpBtG5DKRp/ekGlfrZnYqb/vWHTAvaTwltj/s3c8klNHycNm9TB4Hywf8np5q0iFrQN2ms+MN6MwMh4g4WBKX5fLoC9Hyyxw7P/6DFHocK7fTmNQfH1XuHOntVabhWvX7paVMLOgAOsXE BhRdIKcc eeU6PfsMSxGf99eWanwAxx6MZfq1UKGf+4zk5661pltalCaQqP3/CVfF7Z25nr9RO74r91ofFcQTGlLZnb0rXHDpGJImmGUbBTXpETMHTSxy38QzethNf3CvuMivl47+XgUjiYKFByIL1XIeapiDmHwjttQAr8qfQ15Bi6WPU0FbwQMmerntEy1sziyQoHc/DR81ymZPt8GoLwu4VDTYMqSIz6kKpIRmHiHLfuOvp1UJCf3yqm0Ggz85XAano0QwqDZHGIRd8FogB6PUzDawmUtcEJi27qHrxpBKAHr0fbkc7x5Fz9gQFmmNtGMzqCsfDUgum4LGPQKaGPfNTYRZQWKzDE4Tc+KrP2b+qeljhJS0RFQ8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/28/2023 2:21 AM, Sean Christopherson wrote: > Add flags to "struct kvm_gfn_range" to let notifier events target only > shared and only private mappings, and write up the existing mmu_notifier > events to be shared-only (private memory is never associated with a > userspace virtual address, i.e. can't be reached via mmu_notifiers). > > Add two flags so that KVM can handle the three possibilities (shared, > private, and shared+private) without needing something like a tri-state > enum. I see the two flags are set/cleared in __kvm_handle_hva_range() in this patch and kvm_handle_gfn_range() from the later patch 13/35, but I didn't see they are used/read in this patch series if I didn't miss anything.  How are they supposed to be used in KVM? > > Link: https://lore.kernel.org/all/ZJX0hk+KpQP0KUyB@google.com > Signed-off-by: Sean Christopherson > --- > include/linux/kvm_host.h | 2 ++ > virt/kvm/kvm_main.c | 7 +++++++ > 2 files changed, 9 insertions(+) > > diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h > index 96aa930536b1..89c1a991a3b8 100644 > --- a/include/linux/kvm_host.h > +++ b/include/linux/kvm_host.h > @@ -263,6 +263,8 @@ struct kvm_gfn_range { > gfn_t start; > gfn_t end; > union kvm_mmu_notifier_arg arg; > + bool only_private; > + bool only_shared; > bool may_block; > }; > bool kvm_unmap_gfn_range(struct kvm *kvm, struct kvm_gfn_range *range); > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index cb9376833c18..302ccb87b4c1 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -635,6 +635,13 @@ static __always_inline kvm_mn_ret_t __kvm_handle_hva_range(struct kvm *kvm, > * the second or later invocation of the handler). > */ > gfn_range.arg = range->arg; > + > + /* > + * HVA-based notifications aren't relevant to private > + * mappings as they don't have a userspace mapping. > + */ > + gfn_range.only_private = false; > + gfn_range.only_shared = true; > gfn_range.may_block = range->may_block; > > /*