From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 251BFC352A3 for ; Tue, 11 Feb 2020 11:32:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E3FBB206D7 for ; Tue, 11 Feb 2020 11:32:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E3FBB206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 516D86B02AE; Tue, 11 Feb 2020 06:32:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C8106B02AF; Tue, 11 Feb 2020 06:32:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B8716B02B0; Tue, 11 Feb 2020 06:32:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 2117D6B02AE for ; Tue, 11 Feb 2020 06:32:33 -0500 (EST) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C3E02181AEF00 for ; Tue, 11 Feb 2020 11:32:32 +0000 (UTC) X-FDA: 76477633344.28.bears90_6d671a4ba942a X-HE-Tag: bears90_6d671a4ba942a X-Filterd-Recvd-Size: 2168 Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Tue, 11 Feb 2020 11:32:31 +0000 (UTC) Received: from dhcp-172-16-24-104.sw.ru ([172.16.24.104]) by relay.sw.ru with esmtp (Exim 4.92.3) (envelope-from ) id 1j1Tlz-0007Lf-8u; Tue, 11 Feb 2020 14:32:11 +0300 Subject: Re: [PATCH] memcg: lost css_put in memcg_expand_shrinker_maps() To: Vasily Averin , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org References: From: Kirill Tkhai Message-ID: <995ffe9f-14c6-39ea-31b9-52194fa1da54@virtuozzo.com> Date: Tue, 11 Feb 2020 14:32:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.02.2020 14:20, Vasily Averin wrote: > for_each_mem_cgroup() increases css reference counter for memory cgroup > and requires to use mem_cgroup_iter_break() if the walk is cancelled. > > Cc: stable@vger.kernel.org > Fixes commit 0a4465d34028("mm, memcg: assign memcg-aware shrinkers bitmap to memcg") > > Signed-off-by: Vasily Averin Acked-by: Kirill Tkhai Thanks! > --- > mm/memcontrol.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 6c83cf4..e2da615 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -409,8 +409,10 @@ int memcg_expand_shrinker_maps(int new_id) > if (mem_cgroup_is_root(memcg)) > continue; > ret = memcg_expand_one_shrinker_map(memcg, size, old_size); > - if (ret) > + if (ret) { > + mem_cgroup_iter_break(NULL, memcg); > goto unlock; > + } > } > unlock: > if (!ret) >