From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 342D0C32789 for ; Sat, 20 Aug 2022 01:48:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7345E6B0075; Fri, 19 Aug 2022 21:48:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BD4B6B0078; Fri, 19 Aug 2022 21:48:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E88F8D0002; Fri, 19 Aug 2022 21:48:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 3A2086B0075 for ; Fri, 19 Aug 2022 21:48:58 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 069BAC03A5 for ; Sat, 20 Aug 2022 01:48:58 +0000 (UTC) X-FDA: 79818287556.23.96EAE8C Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf08.hostedemail.com (Postfix) with ESMTP id BE360160015 for ; Sat, 20 Aug 2022 01:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660960136; x=1692496136; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=XZQMGUxSqIaoAO8nYevZJhN/Qme0knzCS8tmK+U9qCw=; b=LSTQIpCGEWevBqj420QxXmcA2DdeLZVtLw6uO/B4lU4Lg0e+aV2c9sQo NJQ5XUNHiBifFMfhTJCxB05cx2YqgjaqFbcG8KLcjCcJR2Milr7DYE82b jFgzDAtSE8bueeDZX6X+a5QEP0wcD3YNyXoZN8tES2qc9bhuHOmjNrs4U uOjgx+KOM5koWgav7/Rtm2LA0KfHPGxw+kMve0zBgxYCwIVnc26m+gEu7 R6Bs4L2iZKLv1MP1XV2LgLZpHF/thcryaQEyGemIuK97/SuQVgpiFztPD vVTynDxtXbvP7c0WTzRUZbGZn7IF4lr/C6g3B5UlE9RdqDLbwK8BDHuyo A==; X-IronPort-AV: E=McAfee;i="6500,9779,10444"; a="293925734" X-IronPort-AV: E=Sophos;i="5.93,249,1654585200"; d="scan'208";a="293925734" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2022 18:48:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,249,1654585200"; d="scan'208";a="584861576" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga006.jf.intel.com with ESMTP; 19 Aug 2022 18:48:54 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 19 Aug 2022 18:48:54 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 19 Aug 2022 18:48:54 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Fri, 19 Aug 2022 18:48:54 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jAhDMN5WJ9kgKOQ2cnqKYE6sDNRZ7q0OlvgP9pc+LBPfFg57kqMo/q2IsHaNAvTysLYNW8wbIzQXdDoI3v5PqrYjUx6yscXEdLnUUqqNUYFL9VfSWy9kZVzW+W2wsJg4r0dyO908v+MIzLjM3Ux5ifPNDqNo0kiRwgnSktyPl/5dOqxl44x8V0qw2DQrfWgB3jle0AGU1y8SJ8Op12FH1mWp8WP3Cvl0Q8hsejQZNy7B7kWZa2DifJI46kHRn4mhih6omJ5b9Kc7vQgLKnLlfY7eAGS+/gpSSlTfiY4Y9on1OBApHxvVK6mE6a32tldnDjN3NERwVc3CyJdNMXo+bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SPOd/QeSUjVt6pDmm6wNk5ebNhDjs2iDCq+KjiDkrAk=; b=mg9RKQQS5qJOsdm0lGfTA4D+CXoSJr/8vmfS4JYZA6NQbKnK7wNgUf8VJGasQDO/ErnRGn9Rs2K1zVtQVuWcHYkoaGahXfyUXrztUl+1nGPF02Kw+Haxvyy0l9NlUCgwB3PrqIbKlEn7wMZYQUnRKdSwAqhLA4drBgSAW22mWOozaHk7Id/7fIfEoZSFeXxyVSC2bshc0WLv7kWZRxKC4GD1o7hAmRTGhvTK65uqH3sauZQI0hDQmkMeyMtF2aLDw6BiLs7IOK+c3xCy0p0mVOR4MTC4mzotK2MX9nXEEm4CrKiXFwYZFJ2aoplO7gsaTO0/6JsKN9GO6Yq2EDBLiA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by SA2PR11MB5115.namprd11.prod.outlook.com (2603:10b6:806:118::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.16; Sat, 20 Aug 2022 01:48:52 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::fcda:4c77:5786:209c]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::fcda:4c77:5786:209c%4]) with mapi id 15.20.5546.018; Sat, 20 Aug 2022 01:48:52 +0000 Message-ID: <995e7a06-3f83-4ca5-ac68-a848722dd63d@intel.com> Date: Sat, 20 Aug 2022 09:48:43 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.12.0 Subject: Re: [PATCH v3] mm: release private data before split THP Content-Language: en-US To: Andrew Morton CC: , , , , , , , References: <20220810064907.582899-1-fengwei.yin@intel.com> <20220819174539.c66a67c3f2cdc5604fcbd244@linux-foundation.org> From: "Yin, Fengwei" In-Reply-To: <20220819174539.c66a67c3f2cdc5604fcbd244@linux-foundation.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: TY2PR0101CA0039.apcprd01.prod.exchangelabs.com (2603:1096:404:8000::25) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d82b8e6a-1155-4607-ee5a-08da824e224b X-MS-TrafficTypeDiagnostic: SA2PR11MB5115:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wAXPIoGemTurrTGe+fSPGP+71I30nEQsTjht9juFrKhgDfEjH/qMHWtLaI50G/W2Yxnx0lcCfRuB1Jlp5a7kVFPFjs0clECvBgFIoYTeBzn0xPTCbblmTedMol8cWar5b7z5KH2BtB+nNf5vYSAzp4ENj8GKSpjCE6B7oxytdz8EsAlXq6+LsrPRHdxvDtGT0VAA8cWT4nocrFrlTsbRdpPjni4vTvnEU4rNm2FxTpD/wuYw22DkVurI3E67wNRub0W8wTre4KBCTO0KDvyFYVztnm1A4uxOBqziEoSXFwVj+8dsHUgsMUR0JeWGczhXKDrpIQ7sYrZliPif+mTxSSmRYY5VhA/Ibf/JkBaDBtyj8tu3zzoFPBEhtm1inKF1DSbsuMUhTeMwXl0Z/ewEp8rQhknRIKO/Gmi3OAhJ1tZQ6Fh48vz/+9zI7mNSsAnGf5xvBdNiz24+aO5B8aP8BCfb6WAc7a7lTFF0eR9OYybCeZPD8anumtqg6rNve1jAp05ztipiXCJrVpoTtc97vnxISjyyJkr2o2/LWPTM23fTUkLd1UnT8F97Fu+SuoDMU29K/cfFH69sbshdIHjm7l4DKks1XH8xI6RPzLLLAVdx9x5joKp1eTR79RZOu1+JBsrGl5Gq3vcHkkOVKYiqdT6R0koaQMBK7eyXR9IGUPPS8IulocidKjcY6spNGwR/SDJlsGjAglzj8X09FyEcuvX28u3GRexJlcXbK/P23+VmITcdQUJXMR0oD6fsSkPk+N9LSsqukHU7wRzZUWSMRqqcvaYwaJUHDBnnmg0zsw8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(346002)(376002)(396003)(136003)(39860400002)(366004)(82960400001)(2906002)(41300700001)(8676002)(66476007)(4326008)(66556008)(66946007)(316002)(31686004)(6666004)(6486002)(478600001)(6512007)(53546011)(107886003)(6506007)(26005)(6916009)(31696002)(86362001)(5660300002)(83380400001)(2616005)(36756003)(8936002)(186003)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?amhZNDNyR3NjY0JGYi93dDliaFY5VHRCazZVVlhheUZVdTRPSHptWU9kQS9R?= =?utf-8?B?VmRtbEU3dlVEa1h2Q3pVVytnT0FRc3dCSmNWWEJIUmY5b3ZvYVN1THJybE1k?= =?utf-8?B?VDR2SU1FV3BEWUdJMXVwWU5lbFIyaEUxekZoeFJTNkN4NjRlc2Q1U0tTWDNt?= =?utf-8?B?QXpXdHpLRXJJenhCa0czVUFNSlUraGxsdHRDeENFV05kUG5NY1JXMnFhTHpG?= =?utf-8?B?N0VRWVFueDdOTXh3Y2o5U1V5bUE4STlqZzRhV3BQMHZQcjBNbWpjN3ExWkxh?= =?utf-8?B?U0xYWUc2b3dYOFVzSG9aRzRNYVdxUVg0THRkZjRWUzJITnUzSk12eWtQbmQ1?= =?utf-8?B?TzJiSDZDa21xZGwzKzBXeHZKR2l2eEI4UDBLc0dtNjcxcllvSk1EWG94VG9J?= =?utf-8?B?ZXVxK2dvSktMbW8wRXVTSUMzZ0lQMDMzdHM3MytVZWt5bktucXhqVUVraWtp?= =?utf-8?B?TkFHNStvWFlidDJuWW50SWY3b2RGdEhpY2M5MVhPQm41RXZ4RGpia29zcmFk?= =?utf-8?B?WmpSYVNLODhycnJTUmtJaGJKQk1HOUE1MkZGd0JieTdWWGUycEloYktIOHpK?= =?utf-8?B?VFllQ29OeDJ3S2JZSm1IdlJJNVV2enlRVyt6bFhVTGV1d0pQRFZoVnUwZG9u?= =?utf-8?B?dFE2SzM2VS8xY0RXS1doNU4zdFgxdUlYZGxDbnFMWTVROEQxeXVMV1h1UExF?= =?utf-8?B?OENodDVKdkNkNFplajBKQnd0Z21BMWdVODFXemtGR3ZlY21iUVhFbjdQNmdR?= =?utf-8?B?SHNFL1lITFM3eGp5dThNbGpBU2U4UWFvVGUxcXRhOGJlNDA2eThLVkJscU1n?= =?utf-8?B?SmU4NWVCMmp6SUhOSzIyWC9xTnYrS0wyL3JvQWpYMXZNRFI1YW9XeFBFNmxn?= =?utf-8?B?QTZQM1EwdkdXb29qcExkeUtBYURWZ3ZIVzZNN2cwblJhRnczUjRkS0FnS0Vn?= =?utf-8?B?US9ENEROQkF1VUdiM1UyVVowZ0FORG9Ja3U4cXJyVEN6d1pJem13RU9qeDFp?= =?utf-8?B?QTNWNVBwajJHOEZ1c2pnMTRzSHBoT2VGSDB6bnlsc1pwWDdrQ0V0Q0FXQzlO?= =?utf-8?B?OWIxNXlnTXM0ZlNaNXpNeW8xZkhGL0J3TS94T2puYXNMVGtROW02eFB4SSty?= =?utf-8?B?MnJuUk55dVNvMGMwT1lNS2N4Q0lQcmQ4UlMzZW1mL2ZxRW9Tc1lxaS9RT0RU?= =?utf-8?B?Ym16WVJlaXIwR29oU2dLNnJDTGlBV3BUZFhjdytzaUFGSFExQVNlNHNBSGpy?= =?utf-8?B?bEhQVzJkUHU2THVZOTVUc0ptWVNVelpNeWpOVmowV3AwcVhzTjduVmtlaVQ1?= =?utf-8?B?Q29ORDhCdmxqNjVIbVZKendVRHlHdzFNN1grVFBReEJnNFlJT2lMQk4xUWNC?= =?utf-8?B?QU92Rmp1dk1mdk1KU1Z5RUEySmhlVHF5L3BSb0daZitSMGx1Q0FsWTdtSUI2?= =?utf-8?B?ZXBpK2NXTEsrQ2dMYndjclVCZmxKdnJkZUhpbHV6OHA0RElEU0V6STk4Q01h?= =?utf-8?B?dEhVd3g1NDBEdHlIVzVQb3RHTlVJaGFrMlBZMHZiWVRqUzd3b2lnWEhGQlAr?= =?utf-8?B?dWQvQ0trMDJ4SEh4bFVXYTBRSEJlNnpWbW92SVhXOWYwSkp3NjhRaFdEcjd1?= =?utf-8?B?eEFFcDUrb1FidlZodnRTSmxaQi9xSUtnOW5ldnQvYjljT05pYTl6QzMzRkh3?= =?utf-8?B?enJMTDhsQ0NJcFRCdU5qR1VxSnoxNUF2SVdWTEN1WFdNN0tMK1dxc0lFYTd2?= =?utf-8?B?TnBvejgvaG9hWDl1NXdiWFU5aWt2ejNOVkVPRnc4KzBIUzREVHB6MENvb05J?= =?utf-8?B?aWsxcWJrK0RGdTZWb1lwaitaU2lEQmt6M3Byd0FMdzd2dmY4U3AxS2J3VW9M?= =?utf-8?B?WlgxUTNzRldsdjdGZDNtdFVKN0RGODBMcUxJOXRiVWdOTTd3b2laTjJ3UTRm?= =?utf-8?B?TU1kTnhjNFRaUjBzcXNMbHpmbWRQUStxNlh6eWFsblNpdU1HTDAzQkN2WHI5?= =?utf-8?B?dlVUNUxVdENIeTFlZnJTUnlTZVcxWElOazFqZnBmcVNBZitoU3Rwdm8xcTI4?= =?utf-8?B?dy8zRFpTTVZBajAwbDA0ZVlFUEQzbVVodFFBZUtsZG1ZcTcvWjk4aHo3ajJ2?= =?utf-8?B?cUI3SnM5UEJlZEh3dThQVEROYW0wOGpZeXJIRU84b3E1c2l5N1kyWUpNQzFz?= =?utf-8?B?WEE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: d82b8e6a-1155-4607-ee5a-08da824e224b X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Aug 2022 01:48:52.3464 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Bknb+QQiOY5dTtxJ86L/Cxy54R0N/QhMQoHnUPL/2fuSPEPnR90GQUqsNPiITwYPW5wWIeaiG4iJxfSP92h7MA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5115 X-OriginatorOrg: intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1660960137; a=rsa-sha256; cv=fail; b=AgEW0BheMs47d4HhGmmxZ+vNzfKah8MjMzXPCpndHxrYmL7YRqwf/uqDlBXJnFrBF81AeO s97D4DQU2Cy+falRxkR0kcnoCrau+06gUQo/rugDmXz0k7+kLcLfczf7oZDSuyORznqSKQ q3UhogdJa3khGhAB1tSSgrjovSewpdw= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=LSTQIpCG; spf=pass (imf08.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660960137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SPOd/QeSUjVt6pDmm6wNk5ebNhDjs2iDCq+KjiDkrAk=; b=EQjLbllWvHnIyn1zZS6ERRHg0l0bviNZexQ2q+xhCRMBAvxtjGr8IRcM5WY7E09j8v4HjG +FcN5Oia8EPS77XgE6mDCJ4vEgLLiN4reQSf1XnX9ExYVE7mbTXGMhHn0BQUHcYdsE2ZLF mZ2J3Thn2LLEXlP7azB8VC9BPzH3g0s= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: BE360160015 X-Rspam-User: X-Stat-Signature: h7xdpdo9mb17oh198b5ywnuwojgokfm3 Authentication-Results: imf08.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=LSTQIpCG; spf=pass (imf08.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com X-HE-Tag: 1660960136-182549 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, On 8/20/2022 8:45 AM, Andrew Morton wrote: > On Wed, 10 Aug 2022 14:49:07 +0800 Yin Fengwei wrote: > >> If there is private data attached to THP, the refcount of >> THP will be increased and block the THP split. Release >> private data attached to THP before split it to increase >> the chance of splitting THP successfully. >> >> There was a memory failure issue hit during HW error >> injection testing with 5.18 kernel + xfs as rootfs. Test >> got killed and system reboot was required to re-run the >> test. >> >> The issue was tracked down to THP split failure caused the >> memory failure not being handled. The page dump showed: >> >> [ 1785.433075] page:0000000025f9530b refcount:18 mapcount:0 mapping:000000008162eea7 index:0xa10 pfn:0x2f0200 >> [ 1785.443954] head:0000000025f9530b order:4 compound_mapcount:0 compound_pincount:0 >> [ 1785.452408] memcg:ff4247f2d28e9000 >> [ 1785.456304] aops:xfs_address_space_operations ino:8555182 dentry name:"baseos-filenames.solvx" >> [ 1785.466612] flags: 0x1000000000012036(referenced|uptodate|lru|active|private|head|node=0|zone=2) >> [ 1785.476514] raw: 1000000000012036 ffb9460f8bc07c08 ffb9460f8bc08408 ff4247f22e6299f8 >> [ 1785.485268] raw: 0000000000000a10 ff4247f194ade900 00000012ffffffff ff4247f2d28e9000 >> >> It was like the error was injected to a large folio for xfs >> with private data attached. >> >> With private data released before split THP, the test case >> could be run successfully many times without reboot system. > > I did a bit of editorial work on the changelog. Please check, Note my > addition of "attempt to" to the second sentence. Thanks a lot for the update. Looks good to me. > > : If there is private data attached to a THP, the refcount of THP will be > : increased and will prevent the THP from being split. Attempt to release > : any private data attached to the THP before attempting the split to > : increase the chance of splitting successfully. > : > : There was a memory failure issue hit during HW error injection testing > : with 5.18 kernel + xfs as rootfs. The test was killed and a system reboot > : was required to re-run the test. > : > : The issue was tracked down to a THP split failure caused by the memory > : failure not being handled. The page dump showed: > : > : [ 1785.433075] page:0000000025f9530b refcount:18 mapcount:0 mapping:000000008162eea7 index:0xa10 pfn:0x2f0200 > : [ 1785.443954] head:0000000025f9530b order:4 compound_mapcount:0 compound_pincount:0 > : [ 1785.452408] memcg:ff4247f2d28e9000 > : [ 1785.456304] aops:xfs_address_space_operations ino:8555182 dentry name:"baseos-filenames.solvx" > : [ 1785.466612] flags: 0x1000000000012036(referenced|uptodate|lru|active|private|head|node=0|zone=2) > : [ 1785.476514] raw: 1000000000012036 ffb9460f8bc07c08 ffb9460f8bc08408 ff4247f22e6299f8 > : [ 1785.485268] raw: 0000000000000a10 ff4247f194ade900 00000012ffffffff ff4247f2d28e9000 > : > : It was like the error was injected to a large folio for xfs with private > : data attached. > : > : With private data released before splitting the THP, the test case could > : be run successfully many times without rebooting the system. > >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> >> ... >> >> @@ -2635,8 +2637,16 @@ int split_huge_page_to_list(struct page *page, struct list_head *list) >> goto out; >> } >> >> - xas_split_alloc(&xas, head, compound_order(head), >> - mapping_gfp_mask(mapping) & GFP_RECLAIM_MASK); >> + gfp = current_gfp_context(mapping_gfp_mask(mapping) & >> + GFP_RECLAIM_MASK); >> + >> + if (folio_test_private(folio) && >> + !filemap_release_folio(folio, gfp)) { >> + ret = -EBUSY; >> + goto out; >> + } >> + >> + xas_split_alloc(&xas, head, compound_order(head), gfp); > > Because I assume we run into the same problem if > filemap_release_folio() fails? Yes. You are right. Thanks. Regards Yin, Fengwei