From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D68F1C25B08 for ; Wed, 17 Aug 2022 07:17:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 026498D0001; Wed, 17 Aug 2022 03:17:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F17E56B0074; Wed, 17 Aug 2022 03:17:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E06EA8D0001; Wed, 17 Aug 2022 03:17:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D24356B0073 for ; Wed, 17 Aug 2022 03:17:05 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B292A1C5B34 for ; Wed, 17 Aug 2022 07:17:05 +0000 (UTC) X-FDA: 79808228010.08.702FE62 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf10.hostedemail.com (Postfix) with ESMTP id 2C45DC0014 for ; Wed, 17 Aug 2022 07:17:04 +0000 (UTC) Received: from dggpemm500020.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4M6zlS3S6XzcfgL; Wed, 17 Aug 2022 15:13:56 +0800 (CST) Received: from dggpemm500001.china.huawei.com (7.185.36.107) by dggpemm500020.china.huawei.com (7.185.36.49) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 17 Aug 2022 15:17:00 +0800 Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 17 Aug 2022 15:16:59 +0800 Message-ID: <99556483-9f22-4597-8270-b4414cc97e64@huawei.com> Date: Wed, 17 Aug 2022 15:16:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH RFC] mm, proc: add PcpFree to meminfo Content-Language: en-US To: Andrew Morton , Greg Kroah-Hartman , , Aaron Lu , Michal Hocko , Jesper Dangaard Brouer , Vlastimil Babka , Dave Hansen , Kemi Wang CC: , Liu Shixin References: <20220816084426.135528-1-wangkefeng.wang@huawei.com> From: Kefeng Wang In-Reply-To: <20220816084426.135528-1-wangkefeng.wang@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660720625; a=rsa-sha256; cv=none; b=4kXGYVpNUnxlXVtZsjP7CT4NxHGD3OlVsjAgsV5Ou9xRwipVANyAYaCCziP1dS1PKJC1yP 3XIMn5PoOiOTpjIFi6dGGnVd4HOSK+oGNf44ZisdFK8yn+mrXfPA14d2yk97p2CY/u5xWx 9QoXlZzrOXmZFBo9p+Lt1uRpfkZfDp4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660720625; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jy9kPZVDJ92ZRimljXUy2Av5ACYDX5d1wsHAj+ihXm4=; b=HD1E07Ir1NiMP45GOblu4+IN/vpeIQ63SUDo2HZWd4n36DaGoRInslXCdJyJrGUma1hBuH vrZhE9/96mKov0jv358h9smMTbgLLyKzOnYSRdBL4v+G/cOHMP/v86x1mvA0UYj/bV4CHB P9ziCZ2XTUgNnfOR1rr83hZQA1raMyk= X-Stat-Signature: hebffi4ezba5ttaadbss8xag5mudzm38 X-Rspamd-Queue-Id: 2C45DC0014 X-Rspamd-Server: rspam08 Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Rspam-User: X-HE-Tag: 1660720624-28887 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/8/16 16:44, Kefeng Wang wrote: > From: Liu Shixin > > The page on pcplist could be used, but not counted into memory free or > avaliable, and pcp_free is only showed by show_mem(). Since commit > d8a759b57035 ("mm, page_alloc: double zone's batchsize"), there is a > significant decrease in the display of free memory, with a large number > of cpus and nodes, the number of pages in the percpu list can be very > large, so it is better to let user to know the pcp count. Add more experts according to commit d8a759b57035， any advice would be much appreciated，thanks. > Signed-off-by: Liu Shixin > Signed-off-by: Kefeng Wang > --- > drivers/base/node.c | 14 +++++++++++++- > fs/proc/meminfo.c | 9 +++++++++ > 2 files changed, 22 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/node.c b/drivers/base/node.c > index eb0f43784c2b..846864e45db6 100644 > --- a/drivers/base/node.c > +++ b/drivers/base/node.c > @@ -375,6 +375,9 @@ static ssize_t node_read_meminfo(struct device *dev, > struct sysinfo i; > unsigned long sreclaimable, sunreclaimable; > unsigned long swapcached = 0; > + unsigned long free_pcp = 0; > + struct zone *zone; > + int cpu; > > si_meminfo_node(&i, nid); > sreclaimable = node_page_state_pages(pgdat, NR_SLAB_RECLAIMABLE_B); > @@ -382,9 +385,17 @@ static ssize_t node_read_meminfo(struct device *dev, > #ifdef CONFIG_SWAP > swapcached = node_page_state_pages(pgdat, NR_SWAPCACHE); > #endif > + for_each_populated_zone(zone) { > + if (zone_to_nid(zone) != nid) > + continue; > + for_each_online_cpu(cpu) > + free_pcp += per_cpu_ptr(zone->per_cpu_pageset, cpu)->count; > + } > + > len = sysfs_emit_at(buf, len, > "Node %d MemTotal: %8lu kB\n" > "Node %d MemFree: %8lu kB\n" > + "Node %d PcpFree: %8lu kB\n" > "Node %d MemUsed: %8lu kB\n" > "Node %d SwapCached: %8lu kB\n" > "Node %d Active: %8lu kB\n" > @@ -397,7 +408,8 @@ static ssize_t node_read_meminfo(struct device *dev, > "Node %d Mlocked: %8lu kB\n", > nid, K(i.totalram), > nid, K(i.freeram), > - nid, K(i.totalram - i.freeram), > + nid, K(free_pcp), > + nid, K(i.totalram - i.freeram - free_pcp), > nid, K(swapcached), > nid, K(node_page_state(pgdat, NR_ACTIVE_ANON) + > node_page_state(pgdat, NR_ACTIVE_FILE)), > diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c > index 6e89f0e2fd20..672c784dfc8a 100644 > --- a/fs/proc/meminfo.c > +++ b/fs/proc/meminfo.c > @@ -38,6 +38,9 @@ static int meminfo_proc_show(struct seq_file *m, void *v) > unsigned long pages[NR_LRU_LISTS]; > unsigned long sreclaimable, sunreclaim; > int lru; > + unsigned long free_pcp = 0; > + struct zone *zone; > + int cpu; > > si_meminfo(&i); > si_swapinfo(&i); > @@ -55,8 +58,14 @@ static int meminfo_proc_show(struct seq_file *m, void *v) > sreclaimable = global_node_page_state_pages(NR_SLAB_RECLAIMABLE_B); > sunreclaim = global_node_page_state_pages(NR_SLAB_UNRECLAIMABLE_B); > > + for_each_populated_zone(zone) { > + for_each_online_cpu(cpu) > + free_pcp += per_cpu_ptr(zone->per_cpu_pageset, cpu)->count; > + } > + > show_val_kb(m, "MemTotal: ", i.totalram); > show_val_kb(m, "MemFree: ", i.freeram); > + show_val_kb(m, "PcpFree: ", free_pcp); > show_val_kb(m, "MemAvailable: ", available); > show_val_kb(m, "Buffers: ", i.bufferram); > show_val_kb(m, "Cached: ", cached);