From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05C73C52D7C for ; Thu, 15 Aug 2024 18:19:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 970066B013A; Thu, 15 Aug 2024 14:19:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91FF36B0151; Thu, 15 Aug 2024 14:19:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E7E46B0150; Thu, 15 Aug 2024 14:19:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5B77C6B01A2 for ; Thu, 15 Aug 2024 14:19:41 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DF1C4A9054 for ; Thu, 15 Aug 2024 18:19:40 +0000 (UTC) X-FDA: 82455292920.28.CEAF72A Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id 6C3012000F for ; Thu, 15 Aug 2024 18:19:38 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jmAPusW9; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723745906; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7FLABihkjXNkDYFGA6uKGnoChrjpjhFhJl6++mXjNQw=; b=22Wd3t/SLmL/5hI8XFxjERPyf/m4zLXne42q9uGoeMaGqyo/hYqKo4czOl4T1SHyyF7Hoe abIO0ppPaA83vp4Ox0Tpcm3CHJ7K7wbuInsVFpCLpjw76pgFBQG/qtQhZwTlUvXv72wMcz yTsxnrxRgHXGHfn/d7q62aIJmvxA1PY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723745906; a=rsa-sha256; cv=none; b=MMPQeRhlUk3B5KATjtZqR6s87g7q7kIAED6yraxlrxw8PfKhVSPBCfXIw0r0Wg1EkH5JIt ieJz5Ptfq0JP7qv++klCZta5BJwL5bO/ScOLNBiMevT+HB1q2Tn4mPc1JYRNSFeqSknm46 PK9C1TO5c9xQAyLoNa3lL1l9msTt+8s= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=jmAPusW9; spf=pass (imf13.hostedemail.com: domain of broonie@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=broonie@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 3DBB3CE1D14; Thu, 15 Aug 2024 18:19:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0BDE0C32786; Thu, 15 Aug 2024 18:19:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723745973; bh=gvOHdCK9aUdR7DPVLDdBmQ4rCqBdWg1NiIKC9n0vn/s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jmAPusW9RWevvrm7Hg88q9xewbIsd/N/8xTtQyDPWPc982vMFTh7r29JlLa6aHf0o 8io0uPtO83IiC/fkk0GKoQNNWuDUbOcvZAodgohYE/SjWTMQpUBTSbad1t64GFmGyS iVChoroyACoTlO+/w+ZVPqDVFAt/hYnGedb6MWnURMr/r772xCwXH9niKnJdXYUqJX ljF+fG3keMrMEmAZlQBZgeB5qVBYqMTd2O22DXiRYL9ul8f7b5FVTiy0/sBLHu0Gpw 9wAE4WmxHy9lFZGd0S9lYGKcP1IFTR4cDZzHAlueePqA4AxAzNcZtdqHVh8a0mF8BL 9fI1RwFnauAuw== Date: Thu, 15 Aug 2024 19:19:24 +0100 From: Mark Brown To: "Edgecombe, Rick P" Cc: "linux-arch@vger.kernel.org" , "ross.burton@arm.com" , "suzuki.poulose@arm.com" , "Szabolcs.Nagy@arm.com" , "linux-fsdevel@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "catalin.marinas@arm.com" , "corbet@lwn.net" , "linux-kernel@vger.kernel.org" , "kvmarm@lists.linux.dev" , "kees@kernel.org" , "oliver.upton@linux.dev" , "palmer@dabbelt.com" , "debug@rivosinc.com" , "aou@eecs.berkeley.edu" , "shuah@kernel.org" , "arnd@arndb.de" , "maz@kernel.org" , "oleg@redhat.com" , "fweimer@redhat.com" , "thiago.bauermann@linaro.org" , "james.morse@arm.com" , "ebiederm@xmission.com" , "brauner@kernel.org" , "will@kernel.org" , "hjl.tools@gmail.com" , "linux-kselftest@vger.kernel.org" , "paul.walmsley@sifive.com" , "ardb@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "linux-doc@vger.kernel.org" Subject: Re: [PATCH v10 12/40] mm: Define VM_SHADOW_STACK for arm64 when we support GCS Message-ID: <9949a344-be8e-40ed-b483-02ff95175072@sirena.org.uk> References: <20240801-arm64-gcs-v10-0-699e2bd2190b@kernel.org> <20240801-arm64-gcs-v10-12-699e2bd2190b@kernel.org> <34f7a5378447b1a8d5a9561594b37cfeaa6bd2b1.camel@intel.com> <3a7d9b69-e9df-4271-a3f0-8e8683c2654f@sirena.org.uk> <68ec09da-fb4a-4d59-9c8c-6fae4c48ea68@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="U12vN05f82sjc1Kd" Content-Disposition: inline In-Reply-To: X-Cookie: -- Owen Meredith X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6C3012000F X-Stat-Signature: eg5154jzcne8eaiawdi8r79dsp88cm4a X-HE-Tag: 1723745978-99381 X-HE-Meta: U2FsdGVkX1+GM9D5OK2T2WBIIijvGn/pNa06ShzZ4dTi//gbPmmcIoXI6O8bVKmw0tWNehDqcpk0wqTpGg4+yxx9SpYC9QebXVTY69aXJFJ7+0Bzn5Wm2HQUI6mrt+x8g/UvVHObXrVGqbJyKotT2s+45wJjzyiCPn/jU1f019VIxEqeOhQmlTjxGHD7gP01hDn9rSR7ZUmzGNE7V8GL2BD7icwfBZCH9PNEBKElifwwPOFPQ1PcjrCNiWF3/wM2ZsXZ15EkpYE5mUOK4q95t4IyI/LvfXzHLhvYGoid2jFFJokVxitGF4YGd2Vpyuj2aDnbNH5cyN5QfR8CxgfoAJrNx6zd4sj+dZ27rLKkdY8rV4Lpzgsuz9gBV2ATo8wAJHOLSyNeGX+Ax4jMjZUuPlLUMg8KgRIdWwE1DZaBxrvoAfAsS3VZEYCz/o4LINGnEv2OCs9eQLzfSgobEpdPwDUKK9bsv4V/RU3ZTLZSmsTCBlyJO3wSTZB/oSc4OHuBsmjjPxWvKo5ZqNFivPwN1ZVDgpHQ2dkXRW529QnzvpMmKJJFAJ3KOeAWiqnf39Mk7Zo8UzRlMh4DApBw5Ejq/jWbJfXbdmmW0PZlhYDzU4VR/vzbiSzhKxUx/LsEfhT9lf7xZScT/rG4/jO5aTPm4tYh859P/xgNa1B7Lk5+XdaOh4jV1PLTqI0STueHarNfsbvmwk50BEHJEuRv00Juy7ME7kSm67FinPJiVMbJoGmPRx2O2HKGf+s8IoKKe6RSTWuTdYnKUhk2xtfpYw8ekSPRUAReMhIDtEMkION4vjTJXyoFbiouU/YEkBQKxZijaxrmSZCPpcbE2jsxhSud6eKK6QZ7rso2bQi0trp5ECTta2gyXY/X6NwCvcyOrdHg5NU6uzEVC1YoFSckV8AxSVgfjVyuLEPslHM47cVJnNbu317f6qkZKPkEZMQiSZqaGBMFhguHfRE5c5l2lV8 KMunMgbw cbsFqGeINyObgjTFijbDpCvDFPLOT053M/ZjMWVNWMpo0ZyAwyHtgEZegItuNk7XdwYPakCJYN/NJ/MSi02r0c+Cr9OZJFVybO+R9JSA+ZIqo18CfT9Z9m5xaXyOTNvjEioNGAPLhP0WiviDjP6HACk9GgIfgdCgIqzrDfZrciwWEtEs+6SaNRIP/uTICL4Y/iqKUuSRDsIKJsSyCxFw2AA50KAKjdY+GTORoK35a+iACueYJ4OdV5qobONhHCWRN/uelQ52uvr1fdxYJCqa5KPoCwsvRTDgYbLewQnklGg2epbeX2EV13lJVwDK86M4C7x9cAWv0C1pksvvuUtOwnSiPuQnnRrND94kyf90vzlo9hTe+ISUGVG6GmYSdICFjrP1WmL5dljultmxo9SywTk03JXzVXtiYk1iYtjeaLom8/TBTDJpHzVhWLw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --U12vN05f82sjc1Kd Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 15, 2024 at 05:53:19PM +0000, Edgecombe, Rick P wrote: > On Thu, 2024-08-15 at 17:39 +0100, Mark Brown wrote: > > > Oh, thanks for the heads up - I'd missed that. > > Looking at this I think it makes sense to do as was done for x86 and > > split this out into a separate series (part of why I'd missed it), > > updating the generic implementation to do this by default.=A0 That'll > > touch a bunch of architectures and the series is already quite big, > > it's not really an ABI impact. > The series is already upstream. You just need to add an arm version of th= at > linked patch. But up to you. Your series modified the existing x86 custom arch_get_unmapped_area*() functions, arm64 uses the generic implementation of those so I'd have to either add custom implementations (which I can't imagine would be met with great enthusiasm) or update the generic ones. A generic implementation seems reasonable and it looks like RISC-V would also end up using it so while it's a bit invasive it does seem more sensible to do the change there. --U12vN05f82sjc1Kd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAma+RqsACgkQJNaLcl1U h9C2ogf/ZUz9M5cZLraiijYr3jTrEMdCaa6D0jRDGoL0IP3BclPhluw29VOQVf4x aJ10O4eGMRHl32XL0oWXQlmSmjiHfXTvVmeAnPrKkq6Sx8BDI7tOW1f4b64Iyouq aGNPYw1YjXPdazXxXLbaQVZZOrq5BE2dbXw6ocHaombvt/oG6sAGc4F4KFXwb6+A OR+jpoND8CbzSxh4EO89eoixTKgqvVZTLfQ3zZBdyjrrk1jyp6Q/63wMC325Bmam FebFR/NFJlNNAGpnhBbZhme21z1oZ+1h9K6G37zJUsXqqkOnH56fbsfKJ3wGW37B VjXIsdlILKUDIICvYmo5rxepKRyUqQ== =DIrs -----END PGP SIGNATURE----- --U12vN05f82sjc1Kd--