From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9325C433F5 for ; Tue, 1 Mar 2022 00:26:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 04C0B8D0002; Mon, 28 Feb 2022 19:26:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F3D5E8D0001; Mon, 28 Feb 2022 19:26:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8FA18D0002; Mon, 28 Feb 2022 19:26:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id CB1718D0001 for ; Mon, 28 Feb 2022 19:26:31 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 8036492EA5 for ; Tue, 1 Mar 2022 00:26:31 +0000 (UTC) X-FDA: 79193926182.31.4561E82 Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf14.hostedemail.com (Postfix) with ESMTP id A2CE2100005 for ; Tue, 1 Mar 2022 00:26:30 +0000 (UTC) Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 21SLZTet025510; Tue, 1 Mar 2022 00:26:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=corp-2021-07-09; bh=V8QgLHI231FoUgwrTG25X6f65QF2gotlYrDacAx2NcU=; b=MHgypzrRMBEUfK6CTVDtAlWbS3dVWY6kXk9I+wxGJTUT68MaFHtBgpbMV5KLpH7bn2Fc QmZLsxgpPYrJtVqyEVnqqYB1eCE0hHVoGwmJ5zfE33WUy1MihafJ0Jy24pG22+j9Azv0 XwC86sb81+sDfbF1wTaw98pVbTcLPQEUU9o2EHZgtu5c3bb+b0e40F0hB7SckUyoQCme tU3sxMX6Pbt/PrEroNPm8uN7fd+d6g64EKKNeiSXPxXgmQGZySRoFuTO45heNCKcYzJ4 gqgq5WW8d5e4KOWbh94weNkII9dL81WNCVl7vBqS/uw5An2qCnR3rw7U+oK0xFb3oFv6 +g== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3efb02nwxb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Mar 2022 00:26:23 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 2210Bv8t184432; Tue, 1 Mar 2022 00:26:22 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2175.outbound.protection.outlook.com [104.47.58.175]) by userp3030.oracle.com with ESMTP id 3ef9aw996g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 01 Mar 2022 00:26:22 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m9bZJCP7DYI8UntN8gkZLyv5gtJNcQaIdjs0/J3LHmBAGvZ986SNvmcOmUiSMCA1NUs0My7jWtkDtzSamVXeWaoOB21B6T6Aj0kbnzDMTQGyR01OceW6vV4sx7JQ8QVqt+P8VN+rWXMDprKuYoeSj+CWD/UdHUw/O1AmoPDuvQyFBhAj78ua2DiiFQ6fwv34SFZ3IlsAYkZ2KbVvtw6W2iAVrAVLdR7iArkIXDX13qvo0RkabI+KvIYwPOxQe6QTazOYZ9PyCMI9fEDEHBxPHklCoSstveUH37dRbe7vjB/I0/52udbJAEoEUjrRTuSzkgTmQdi3ueuxfhjg3W4S2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V8QgLHI231FoUgwrTG25X6f65QF2gotlYrDacAx2NcU=; b=mxa//iBnubd+YlKT4uhkuPUkY3wJrb2R7M4vN3zHYv60McTYFROawz12XWf4DdQFnKZKsMD3VWSnNlqe7RRJJ6ZoVR8T5JKpRqY2WmD7RHakIrRWOIh6FZuvRnbhc9skM9BAFBfVuQ4BxdV6hpoff1I2L11AzUGuKihRxwftoiya1vXA5+lMbNq7ipQ2WvgdW5dShqCOOaXClfOYYtNJ9kgklVc4IC5pfHiYIEBG2koI6fOAxD7n53cCBSXCk3SOmZvCmejC+uV0Ky9hpqNXvYR5HCHZ19j5+9BmzT5QJSk/IWZMk+pgXmbkK/J2+jjXiHPnMwBXC/+eQGSKR4kLrg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V8QgLHI231FoUgwrTG25X6f65QF2gotlYrDacAx2NcU=; b=hYoKJw8gfxX18r91vuqfqoCizB7vuTya20osR7MBBsAmOo9QDRSpDNAdnWKtZcTy4sz7UG3bCcP0EmIEeIhqoFypx3WFBUjdnRIbItFVWopb3+yyp085tSUa2EsuZ0r6K6iXv2H48JeDViE6K4VE0cwk2PR3CaaWNgiUl4pppWI= Received: from BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) by MWHPR1001MB2397.namprd10.prod.outlook.com (2603:10b6:301:32::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.22; Tue, 1 Mar 2022 00:26:17 +0000 Received: from BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::11f6:860e:575a:e6f1]) by BY5PR10MB4196.namprd10.prod.outlook.com ([fe80::11f6:860e:575a:e6f1%6]) with mapi id 15.20.5017.027; Tue, 1 Mar 2022 00:26:17 +0000 Message-ID: <993f1258-6550-e5d7-1e6f-72e2a24b60f0@oracle.com> Date: Mon, 28 Feb 2022 16:26:15 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: VM_BUG_ON(!tlb->end) on munmap() with CONT hugetlb pages Content-Language: en-US To: David Hildenbrand , "linux-mm@kvack.org" Cc: anshuman.khandual@arm.com, Will Deacon References: <811c5c8e-b3a2-85d2-049c-717f17c3a03a@redhat.com> From: Mike Kravetz In-Reply-To: <811c5c8e-b3a2-85d2-049c-717f17c3a03a@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: MWHPR01CA0042.prod.exchangelabs.com (2603:10b6:300:101::28) To BY5PR10MB4196.namprd10.prod.outlook.com (2603:10b6:a03:20d::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e58f924-5232-463c-b7d5-08d9fb1a19ef X-MS-TrafficTypeDiagnostic: MWHPR1001MB2397:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MTFN01ugg/dUHvz6mxZWmh27JfDSwt7cldngdFz/vtM5FzPuzenwXrxHJi38I+FVka3JWE/I1Y+TJ2PB+wvGLkZ6l6i3y3RULeK8OvGUeDj2ZgXp/Bido7ti+T+m6z2DJoHe3ZTsCzbNMNMV8e0C5FLwgfYYCzOMGivdFFMJBNJh0VP/H3T3KUVSL/dKMEwhNmbmke11dojIUmYr8IpIRIOAkL2qsps6G3jUExhHj5oKYqZd9RpwxwCNitdbVESezRw74SF8wu1akYKcQ+xrdVgI1KetleQWNLBiWNMNMAoSDm9xQEzQ66N+XPDKpClIFA9wGhfJPX45tphgG225fgGD0tzBLmwnvLqRuXgy7XnBcr6MYSZ5R8/kOnitdchVdFZRSRse5kdUJYpDBVeaDfm0ltb94//XGUmpDlFYW8pxeTPq+uotvjHuWivyNQnzvsMuqOwLQAXra0LUmBtMYlnulH+hlSPcEpggP8FW5jwxJ8BebxSKJvl16SrHhkxYu1855QDdNd6/GRkf0vMnUml1GFew7ELRgwkRBgGlgabycMFIPJ8gHu673lTUHy0hkLa4hqPxmgOXrRcSIkfShFkmeruBEy4cxsgZBjb7yT9MBwhag46Y/wqB/5KX43BMsCD+7P8oXI5QrUEevvcjOmgytp/bOGBTjiWVaDWZKwwhmpO07Zvsez82JSA3Yg+I1jL0ZV66HdTJnuPSP8Wyl3O6cp/EXM9Q3VbR52JKx6VkPeImmkaCkLO01CmYOMcotPhlwdEf4bza6GWk3er2yQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR10MB4196.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(45080400002)(6486002)(508600001)(38350700002)(38100700002)(31686004)(86362001)(36756003)(66556008)(110136005)(66946007)(66476007)(8676002)(4326008)(316002)(31696002)(53546011)(83380400001)(6512007)(2616005)(26005)(186003)(5660300002)(2906002)(44832011)(8936002)(52116002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cUlMb3duYVNQbkpoa1RZbVk1eDJXS2lkTElzalY2T2Jld2tGVk1GK0VQdnVh?= =?utf-8?B?MjNiWmN4a3Z2UXVQSmxmSG1sS3B4cUkxUDI1VXFqRzRHTHZwaHNXKzhXcE9Z?= =?utf-8?B?cHgwcHpiUWUrU0RiM0tzcFg4ZGRjMjRiMU5IQmRjTnNuYWF5U204cWFoWFc1?= =?utf-8?B?VXgxK0toNi8zU0FWTERibzZqK29sZDVoRWRWYmlSbjNFdG84TmpESWhOL3Ix?= =?utf-8?B?WTdyNmJrdlN0bnprU3J4RjJxa2xGVWxEY0JNVFZXdE93akoxcmZZVG83UEVj?= =?utf-8?B?alRHTDVWb1hxVG1GL3VpblUrK05MS01sMXBNUmZYK1RwcU13SGtPUXhBLzEr?= =?utf-8?B?eUl4RDBaYlRRZkY1a1AzQ21JZVNBU2JzRS9qcVE1VUcvWWJkUzFqamd1aHpk?= =?utf-8?B?MGdmd0dhS3NDV1FucEp2ek1EbDRjUUppcVBINXFBZzZUcnJCTXA4Z0tkY2xv?= =?utf-8?B?Z0pjTE16emxLVmhKK01PdjZmNUJCVDlWQVZMMDBKUjNoV2JVYVNJcTJmSmNH?= =?utf-8?B?QnJMZkF0WnU1SHVlVjFhSUh2NHN6V0pqZDFOdWdtdlI5aGNuSmtpMnZjZkVT?= =?utf-8?B?RjlQT29QSExjbG5SQklhanlRVDF0aXFnMU8vSWZyM3JaOXdscU56RDVyU1Mw?= =?utf-8?B?N2RUZ0FwVXh2Z0k2QkNqaUZEd3lTM3dtVTM2bTI3Q1hUeDlITzU1V0hwWExK?= =?utf-8?B?cXVXMktpMWZFUVc1V2I3YzRNWklUQU1HM29kaEp5WFBQWml4SkNjZmE4SEJQ?= =?utf-8?B?OWo3OGlseDRjYmZlZ21jQVlONWhKRjgxZUZFNEdsWjhOV2t2cU1FSFBSNHBK?= =?utf-8?B?ZW1YSUI2cTJGWXVabklQSUtmdjcwU1RWbEZCWkovK05ldzFqTE9QbEpJVmlH?= =?utf-8?B?Uk9WdnZxRncyWUM5bndtVURjZGIxMjhRcEVGeU4xcTQvOEUveGJneFhrWkVV?= =?utf-8?B?VFBPU3ZrZno0amZNbVFmVmlLcjdHcDhreldRWUowMCtoUW1JSFhTWXVGWmtR?= =?utf-8?B?bml3OHZUTHpIeW53TFFudi9ydkdqUnRCMHp5NGlxdlpJalp2a2RtYWRBeTBF?= =?utf-8?B?RWhHdnRNYkVla3Vzc1A0SzRSNUVGQUFmb0t3eGNxc091S0hQNUF4MDlvdzZq?= =?utf-8?B?MnNZbCt3bUxYZEY4V3REL2U0VEQrU2l0SktMWFBTK0oyemVuRzU5aU9jMlhL?= =?utf-8?B?UEhsQUNINVdqNzJyNnQwclpaNkozN2JobStXZ3kycUdmaGJFUGhZMXdsTVFE?= =?utf-8?B?OTROVEpRM3oyZUQxRjIyUzIrMGhjVUdsMkpwSE1iOWdjamEvSkRrdnJPY3FO?= =?utf-8?B?OXNWR2hWQ3JER1pqU2Vxd3o5Z3hzbGt3bUVvbmtxTEh0Ums0Z09yeGFNem9q?= =?utf-8?B?U0lYd3VHbk1QRmkvNGljT0R1RjJ3QTBOYlVEVkxJVWFGRFRDTjRHUWYvN09y?= =?utf-8?B?dTFzdjk4UEE2NVJ5SHhpV0NWZ05NWVhCN1F0dW5ueHlUNmprWDZIZi9LY0JH?= =?utf-8?B?RmRXcnVDcFdkRVVkSXRhRFh2NmgxSmtlN1NETmd5ZWY4YzF4MTlTNlMydm0x?= =?utf-8?B?M1BaUndtZ3pBV1lHSHV6Njc1S1lEU2V2Mk9OQWxyUkJoUnJzQkdJY24zWE9M?= =?utf-8?B?Q0x6d2E2dWU3R1ArUjFRVkkzV2Nhb3J1MExDS2F5TVpRcGJ5MG5pN1RVaEo1?= =?utf-8?B?QjlHcXdqNFlOamw2OGE3N3RrWURvWHJsaXVvM2pLTGtTUWFxYlVPRzdsczdJ?= =?utf-8?B?M1hSUkZ0Y3loMC92RzdXd0t6R1F5S1pvWFQrWEJMT2krQnh2Zi82U3R0ejFM?= =?utf-8?B?QTFRclQvZ21Jc3NKRy9SUmhBb1VlOVdSZEJadmwrSVNFYTJ1MmFBd01jblh3?= =?utf-8?B?OVNqUVdNVkVVUjJuMklMRmE3M3hYUFE1NjRGL1pnVTg4eEowRjVBRGlBMnIx?= =?utf-8?B?eTJDMW5ZNFhWYjlJeDR3QVRtdVNtNllUb2d4TFdhN0ZySUlTektuY3Z4VnZz?= =?utf-8?B?cG5QUDBrdU1YME9JMjlTTUpwRmUxR2VKK3prMXFqNkEyVUN3S1NNMWc2bXRI?= =?utf-8?B?NkwyYWJNRkxBTFdoWFRmVmZKdTBSU3RiT1ZRYno3VUNBVTBsTDNTNUlndjFj?= =?utf-8?B?THJlN3NwTzF6L2FweGRURVBRQ0JiVEV1dzhFMExwVTUvRUFURDFjKzRQaWE3?= =?utf-8?Q?8EjeYFfagPtSb/1USaR1kLo=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6e58f924-5232-463c-b7d5-08d9fb1a19ef X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2022 00:26:17.3903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qiFruIv8FMqg/kDw/v1zmPANQ02dNEKdYxF87tQZ28m/Ii1v5Z6YsD306xzEAlz5NOzVbKwek2oSqAO3S8oLOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2397 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10272 signatures=684655 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 bulkscore=0 malwarescore=0 mlxscore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=617 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2203010000 X-Proofpoint-GUID: AfgSmnEVANkTZVhC-qD8V6w_0xrWPy3u X-Proofpoint-ORIG-GUID: AfgSmnEVANkTZVhC-qD8V6w_0xrWPy3u X-Rspamd-Queue-Id: A2CE2100005 X-Stat-Signature: g1urrqu9pb4qjwzj9imry35hz9s96mrt Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2021-07-09 header.b=MHgypzrR; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=hYoKJw8g; spf=none (imf14.hostedemail.com: domain of mike.kravetz@oracle.com has no SPF policy when checking 205.220.177.32) smtp.mailfrom=mike.kravetz@oracle.com; dmarc=pass (policy=none) header.from=oracle.com X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1646094390-520561 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/28/22 07:39, David Hildenbrand wrote: > Hi, > > playing with anonymous CONT hugetlb pages on aarch64, I stumbled over the following VM_BUG_ON: > > [ 124.770288] ------------[ cut here ]------------ > [ 124.774899] kernel BUG at mm/mmu_gather.c:70! > [ 124.779244] Internal error: Oops - BUG: 0 [#1] SMP > [ 124.784022] Modules linked in: mlx4_ib ib_uverbs ib_core mlx4_en rfkill vfat fat acpi_ipmi joydev ipmi_ssif igb mlx4_core ipmi_devintf ipmi_msghandler cppc_cpufreq fuse zram ip_tables xfs uas usb_storage dwc3 ulpi ast udc_core i2c_algo_bit drm_vram_helper drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec drm_ttm_helper ttm crct10dif_ce drm ghash_ce sbsa_gwdt i2c_xgene_slimpro xgene_hwmon ahci_platform gpio_dwapb xhci_plat_hcd > [ 124.823045] CPU: 16 PID: 1160 Comm: test Not tainted 5.16.11-200.fc35.aarch64 #1 > [ 124.830428] Hardware name: Lenovo HR350A 7X35CTO1WW /HR350A , BIOS hve104r-1.15 02/26/2021 > [ 124.840240] pstate: 40400005 (nZcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > [ 124.847189] pc : __tlb_remove_page_size+0x88/0xe4 > [ 124.851885] lr : __unmap_hugepage_range+0x260/0x504 > [ 124.856751] sp : ffff80000f6f3ae0 > [ 124.860053] x29: ffff80000f6f3ae0 x28: ffff00080b639d24 x27: ffff000802504080 > [ 124.867176] x26: fffffc00210f8000 x25: 0000000000000000 x24: ffff80000a9e8750 > [ 124.874299] x23: 0000ffff8da20000 x22: ffff000804f0c190 x21: 0000000000010000 > [ 124.881423] x20: ffff80000f6f3cb0 x19: ffff80000f6f3cb0 x18: 0000000000000000 > [ 124.888545] x17: 0000000000000000 x16: 0000000000000000 x15: 0000000000000000 > [ 124.895668] x14: 0000000000000000 x13: 0008000000000000 x12: 0008000000000080 > [ 124.902791] x11: 0008000000000000 x10: 00f80008c3e00f43 x9 : ffff800008404e60 > [ 124.909914] x8 : 0846000000000000 x7 : 0000000000000000 x6 : ffff80000a8a4000 > [ 124.917038] x5 : 0000000000000040 x4 : 0000000000000000 x3 : 0000000000001000 > [ 124.924161] x2 : 0000000000010000 x1 : fffffc00210f8000 x0 : 0000000000000000 > [ 124.931284] Call trace: > [ 124.933718] __tlb_remove_page_size+0x88/0xe4 > [ 124.938062] __unmap_hugepage_range+0x260/0x504 > [ 124.942580] __unmap_hugepage_range_final+0x24/0x40 > [ 124.947445] unmap_single_vma+0x100/0x11c > [ 124.951443] unmap_vmas+0x7c/0xf4 > [ 124.954746] unmap_region+0xa4/0xf0 > [ 124.958222] __do_munmap+0x1b8/0x50c > [ 124.961785] __vm_munmap+0x74/0x120 > [ 124.965261] __arm64_sys_munmap+0x40/0x54 > [ 124.969257] invoke_syscall+0x50/0x120 > [ 124.972995] el0_svc_common.constprop.0+0x4c/0x100 > [ 124.977774] do_el0_svc+0x34/0xa0 > [ 124.981077] el0_svc+0x30/0xd0 > [ 124.984120] el0t_64_sync_handler+0xa4/0x130 > [ 124.988377] el0t_64_sync+0x1a4/0x1a8 > [ 124.992028] Code: b4000140 f9001660 29410402 17fffff4 (d4210000) > [ 124.998109] ---[ end trace a74a76b89c9f2d88 ]--- > [ 125.002900] ------------[ cut here ]------------ > > > I'm running with 64k hugetlb on 4k aarch64. Reproducer: > > #define _GNU_SOURCE > #include > #include > #include > #include > > void main(void) > { > const size_t size = 64*1024; > unsigned long cur; > char *area; > int fd; > > fd = memfd_create("test", MFD_HUGETLB | MFD_HUGE_64KB); > ftruncate(fd, size); > area = mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_PRIVATE, fd, 0); > > memset(area, 0, size); > > munmap(area, size); > } > > > > I assume __unmap_hugepage_range() does a > > a) tlb_remove_huge_tlb_entry() > > -> for sz != PMD_SIZE and sz != PUD_SIZE, this calls __tlb_remove_tlb_entry() > > -> __tlb_remove_tlb_entry() is a NOP on aarch64. __tlb_adjust_range() isn't called. > > b) tlb_remove_page_size() > > -> __tlb_remove_page_size() runs into VM_BUG_ON(!tlb->end); > > > Not sure if this is just "ok" and we don't have to adjust the range or if there is > some tlb range adjustment missing. > To me, it looks like we are missing range adjustment in the case where hugetlb page size != PMD_SIZE and != PUD_SIZE. Not sure how those ranges are being flushed because as you note tlb_remove_huge_tlb_entry is pretty much a NOP in this case on aarch64. Cc'ing Will and Peter as they most recently changed this code. Commit 2631ed00b049 "tlb: mmu_gather: add tlb_flush_*_range APIs" removed an unconditional call to __tlb_adjust_range() in tlb_remove_huge_tlb_entry. That might have taken care of range adjustments in earlier versions of the code. Not exactly sure what is needed now. -- Mike Kravetz