From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D380C6FD1D for ; Mon, 20 Mar 2023 10:37:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AC1C6B0078; Mon, 20 Mar 2023 06:37:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 05DFA6B007B; Mon, 20 Mar 2023 06:37:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E67386B007D; Mon, 20 Mar 2023 06:37:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D88066B0078 for ; Mon, 20 Mar 2023 06:37:49 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A6F56120575 for ; Mon, 20 Mar 2023 10:37:49 +0000 (UTC) X-FDA: 80588925858.24.074A448 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 3A8F440013 for ; Mon, 20 Mar 2023 10:37:46 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="cOt3/HGh"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679308667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z3q/VrYNqGMx2nbuJd3OpHcyuerGqYFRs5YEB6SDNJQ=; b=q6nq6k24qrZLacV1EVx24IvicSYbZwDEzaSMWFwP14c0XiaAlLZRktBUsDwARCfrnKa5PH 4iKyikHTlYFFLR8LTAjHZChfa9LT1whIg30aI3yxOVVokrXf+L8coO+ns3V/7XacHg3+7J ZB+la/vYHItKvzTo4vl+PQGM5GAnLQw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="cOt3/HGh"; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679308667; a=rsa-sha256; cv=none; b=PIb+ZxKXrEchFb8/RVXDJbZrBryc5bgLLOB0OsBqFCzW2rZyW2jMTMUNpBTSPWPt64wQZx lIU+5/kRmBW0VAc68kpzQ3BJxIVi0/+6/jj84yp1neqUmS5gBIwemloalsKUH1ymnR4Hfq FDxGrCAGwvQkyf4HWjJfbqQAvAijPto= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679308666; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z3q/VrYNqGMx2nbuJd3OpHcyuerGqYFRs5YEB6SDNJQ=; b=cOt3/HGhxeCWKbSpzQfyN6gbnOl3tUPzZObW7xg2v+iQhP/Em8z9Ijk2iinxoSqTkzJJqR 4U82vRvFUOKZswZyan9JjjIf2TZdMEFQ96rA/gVO3JdePIEPMG66yIvIT4s9RhcLLbisCw FhEzDbm6EfKRbkKGZ30021Kbb9sVU4I= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-gmEkQuKTMj6d2skcPj72PQ-1; Mon, 20 Mar 2023 06:37:45 -0400 X-MC-Unique: gmEkQuKTMj6d2skcPj72PQ-1 Received: by mail-wm1-f72.google.com with SMTP id o42-20020a05600c512a00b003ed26fa6ebdso4229812wms.7 for ; Mon, 20 Mar 2023 03:37:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679308664; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=z3q/VrYNqGMx2nbuJd3OpHcyuerGqYFRs5YEB6SDNJQ=; b=HOW/hlw+FcR4A11WHIhcivtIYWnmpdRUiUPeohNCZoIoaoXpxkQuYywT/NN9Iqkjfd kU8EKN6qWbS1kwup6KuP6XWSSAhp19ods4ZydZspyvJ0NWi69sSwWGAr//6aB1YEKqwl 3AH7MXWdPt+iCDW5+S+a3rSqcZutSNN4UHeA94J2k8bMjrW/drGXiD5Ea9ZLnCbm6lRY i7NZREVe7OfyhxtjXKF+Xscgki9H1RYSOOm7f2shp5S0n5CQiyucbLN9+fZ5lDEQUlwP 4K1FunhcDBNQyWuPEZ9UJ827MqzN6kQVSmGgDvuueroQX8o/avwbyqwQXp8flxPZlExR fU7g== X-Gm-Message-State: AO0yUKUZ6rmmWDKKZqNDOkYUoBietPx5inE0PDu4Og1q/XuEeAlLMWHk LoqdrOLd2WOY8C/s+nCl3tSvFQBkv579PRiUHAVa/sTXnj+Fms62YTGklqkx0gVqSsyrB6xwsis uoVrd5tGZa+w= X-Received: by 2002:a05:600c:2193:b0:3ed:af6b:7fb3 with SMTP id e19-20020a05600c219300b003edaf6b7fb3mr6429631wme.2.1679308664208; Mon, 20 Mar 2023 03:37:44 -0700 (PDT) X-Google-Smtp-Source: AK7set9nu9AUM11EMOey9gw9s7r1RxvuKD2hoESr3zs9Dn3KEhaTkAv9L39m+Xqo0Tr0kNa2Gefx7A== X-Received: by 2002:a05:600c:2193:b0:3ed:af6b:7fb3 with SMTP id e19-20020a05600c219300b003edaf6b7fb3mr6429607wme.2.1679308663897; Mon, 20 Mar 2023 03:37:43 -0700 (PDT) Received: from ?IPV6:2003:cb:c702:4100:a064:1ded:25ec:cf2f? (p200300cbc7024100a0641ded25eccf2f.dip0.t-ipconnect.de. [2003:cb:c702:4100:a064:1ded:25ec:cf2f]) by smtp.gmail.com with ESMTPSA id f1-20020a1c6a01000000b003edcc2223c6sm5338002wmc.28.2023.03.20.03.37.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Mar 2023 03:37:43 -0700 (PDT) Message-ID: <99391ca1-a9b8-401d-0042-c8b7d1cfab9c@redhat.com> Date: Mon, 20 Mar 2023 11:37:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 09/15] mm: move pgtable_init() to mm/mm_init.c and make it static To: Mike Rapoport , Andrew Morton Cc: Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230319220008.2138576-1-rppt@kernel.org> <20230319220008.2138576-10-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230319220008.2138576-10-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: nsqi7ta1r6fy4so6j17n1jx4eiszr1gt X-Rspam-User: X-Rspamd-Queue-Id: 3A8F440013 X-Rspamd-Server: rspam06 X-HE-Tag: 1679308666-825628 X-HE-Meta: U2FsdGVkX1+GwytvMtH31mmsRucIlCkJGCQfZwY9py1cO3ebRGWX9mJHC7rCgoZL8DqPB19YbS5KMZBmuiSEa/NALYJx3umUp1UadXTyh5fC7ZVkBLWyAAvhd+YgxG48TvMKZZ538z1Ow8s/0ixFpb2szMTxuC3GlvG/kjC/m50cKrn4HUHzkpSMst3KVDU/vHPLdQPEO0s6M8PbXy6Z7MAORrZ0zojnCbaUtHwxwDiVezKkVyIpm+wIOHWLwRhO/G1zNl0Bzs5kSrLTb3zWlD9zmjdXudGPJ35qB+vvwJGMrUYmx0xxKltewWdI9Gq/lhVIwSrITrfWT4kGrn1XCKhmUzG/xrxigqYIw4MhwBmAtzkBKCC4o8dRv8xtK36cHG4LkrGj0ZjYCFxfpRR0Bbb3ElCxBXPb4vui+GY457wRhD/AsGaysmv4qpbaLCvdRCSZuDDea1qZsZGkCmRNVYoEvXJ8wPMXvU+kClwBbjm45rinCeYFYT4tzpkz9EXt6ANLlPIkINbyP7qKGAVSBeVITL8A+BQmrxjCnt8CFSsXbcS2fk9iD8cY59YIhrT4uMi44BEt0L6rPnhlCo3qdRSGKtTBWLst6fkbm6csCS/kV+lNWDpedvxdgrIce+OQr8PAUXbBiph0QH+liQvZrAbT4bDObTKs78sD9kMdIzdaK5+PLhgCrOmYt6PpqcwzRJE8Btzt8+j9owRqNT66+LbPabstYlASMK+kvhA11IQI/JSe0QRvFJYEffZ0jqsvdh+PzrVS5IPjGx5bqoSDdnVFjNrrwdWottQQYIoMG8Au+cVNP3pPD46XQJG58JA0pbPtaU2/740/TqhYve8t6mMUS8xD0gGs1OKP0/NQHwK3Dzt4Mn7/h5+D9nLEKXjvDDd2yVvYru5QqLCvXFqUSdCqIATV4uWd98j7yl+HyA5UR4FuHNfeUEpPB2ke6UmBAP7gXVB+o+oL0LRHnA9 YuJa74XA p75Mxufqe3GR4AiuxK4DhnQCAKlk1ROEulZy769GxJpzcIoTq0rm2lnB7aU1Zka051pE9Dz8tNmZ3NiJYChFj+QClfjmW/FnsHNI0ZZ1zYahMHC29SyrjRTpg2hzD9cC3D0ZWrhN17AclnzubVaGo4vFm+8UPLNasIUBdLB2dB57AoP+ybVjI4Qe9eSMZME8ihOzieEFuoI9q9GfSD/fShE0WI9NkHFr2CtHJyBrH/5VpdAkOYgRQvhh5fK45gOHD5i8+ECEANE1/NaazjLrCYmn20wWeTQwJytvgP/eRvLX1yrVLze69RzQukQheLrWjnpLjCm3wkTs1Y9OJvEkvtQUL605qVHTTFUEXlYZgiEHBiqKUUKRrhoB4LF96AFHdideSXdualRMW7RGFPsYk+B0Zz4naTdp5zGDA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19.03.23 23:00, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > pgtable_init() is only called from mm_core_init(). > > Move it close to the caller and make it static. Why not inline it completely into the single caller? I don't see too much value of this indirection. -- Thanks, David / dhildenb