From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1A5CC47DD9 for ; Wed, 28 Feb 2024 10:30:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31F766B0092; Wed, 28 Feb 2024 05:30:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CEA46B0093; Wed, 28 Feb 2024 05:30:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 122866B0095; Wed, 28 Feb 2024 05:30:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EF7D76B0092 for ; Wed, 28 Feb 2024 05:30:48 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 781DFC0FA6 for ; Wed, 28 Feb 2024 10:30:48 +0000 (UTC) X-FDA: 81840844176.08.FEF6615 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 2379F40017 for ; Wed, 28 Feb 2024 10:30:45 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=itDSc0H9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709116246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jdbkSk0LjVq2u7NIA4ONGJrWqYHxBGfhrpQIAAn5klQ=; b=TGwZcbRm41m8bjwm1SZSl7mZY47lI1kV+XeKFuFQ4GvKMYAUyWr70e8DRA+LqmqhLGrySy 5mBImFS6XI0Xo/w9F+K2B6kxlKMurK6VfI1lFbvuD97p3/KdQakOsiz8jvEKjzaK9VVFFr 8mPSlg/+pVTFPorU2DiVdwwGN4Ufg/I= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=itDSc0H9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709116246; a=rsa-sha256; cv=none; b=neMPm2GzjwwPzqjhyM7IgRhq/DJVj2SClxVqTuQ+l2hJGZSexiYhB6T8kot8QnmJdPUsMm kIOF2QjXifsLrC1cZljAiLUk6dXuCY8973Y1cesxJdhdML9LeWftj/KEZmLStDCf2Y2N/y oXUqHDyHeS7SRq7+JKVO4x6ynV7VDeQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709116245; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jdbkSk0LjVq2u7NIA4ONGJrWqYHxBGfhrpQIAAn5klQ=; b=itDSc0H9FejrufNu611JfQu3PAWOp++Demun20RW+0eDOhmyjE8r/3oggVUN6dZS/Rw6+Q D6oXC+Dcg2sCZtrQ4P8zTzvIHOcMaLU4tMxchwWMrNBSf37geccyf0A5cQ/qYx8pS2/TK/ 1m6h/SN6WvTUoyqWFH5xMq8MAW/xtSo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-650-0XM6b5ApOtuXqN3p9LktZg-1; Wed, 28 Feb 2024 05:30:43 -0500 X-MC-Unique: 0XM6b5ApOtuXqN3p9LktZg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33de2d9bc74so1371441f8f.1 for ; Wed, 28 Feb 2024 02:30:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709116242; x=1709721042; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=jdbkSk0LjVq2u7NIA4ONGJrWqYHxBGfhrpQIAAn5klQ=; b=pdbA+fr/8t2KSFTSSylFZbTbQNJarLJXqOyeB+cQOkyaG1kQ2lWQF7kU9nZN9T7JmJ HyKif3aWXdTysUXZo4dF5Y+wRftMaXQlA621FITcr/5W+UF84ohF9d12MAn8UrYdS9MN 1V+bYDC/ncioN22Yr+98SS9h/wPZMti+VQLblihe+PIh96rh4Mf6oqb0jZlgqeEeEuAW VjoH6RGteCMpGhxwbscZYiMnm25LGJScAe287lFyY3MSQm/+jB0XP4l2ZWofZq7rDvnt BTHW3S9KVAT7JjNdDpT4NTT1+ZnZCqS/KwyK31iQbpk9Wj+KVkIAjdA14H8ErjUp2jia UvdA== X-Forwarded-Encrypted: i=1; AJvYcCXmnUzk7Kpnczzr6vbwAcTc6qq33LpUIO5YHahn1NLCfiFEdp2HvZtfK7Bb+FUbT0L9mNpvOyVdjTHSEjUGuw4HbR4= X-Gm-Message-State: AOJu0Yw59aBqDUap2qHlJDGgFz7zEwHbGpKQQobvuFJuV3EKPo7aV+sA 7HOVG6JGzBPAusTA01FcFm15dZV2jUo3p3gSLnliryTbJZFUkGMSjFCII5DpOb1qH0rxo51kETL 5hzdRS7FzlUdZPvFDqymSgn8TR3RdW5fWMzU8N/mvQkm0r/7a X-Received: by 2002:a5d:6d85:0:b0:33d:da6e:b7db with SMTP id l5-20020a5d6d85000000b0033dda6eb7dbmr6532083wrs.62.1709116242553; Wed, 28 Feb 2024 02:30:42 -0800 (PST) X-Google-Smtp-Source: AGHT+IEc2EAWuWyfnxVEgc8Ht7N8N6Ye/ajb25XECbyU6LWrKiciqqDbMVixvLU8CVyV9UAyeB6Wrg== X-Received: by 2002:a5d:6d85:0:b0:33d:da6e:b7db with SMTP id l5-20020a5d6d85000000b0033dda6eb7dbmr6532043wrs.62.1709116242084; Wed, 28 Feb 2024 02:30:42 -0800 (PST) Received: from [10.32.64.237] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id c2-20020a5d4142000000b0033cf453f2bbsm14023061wrq.35.2024.02.28.02.30.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Feb 2024 02:30:41 -0800 (PST) Message-ID: <99334898-0f5d-4ba1-af38-a510fae473a5@redhat.com> Date: Wed, 28 Feb 2024 11:30:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/8] mm/huge_memory: only split PMD mapping when necessary in unmap_folio() To: Zi Yan , "Pankaj Raghav (Samsung)" , linux-mm@kvack.org Cc: "Matthew Wilcox (Oracle)" , Yang Shi , Yu Zhao , "Kirill A . Shutemov" , Ryan Roberts , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Roman Gushchin , Zach O'Keefe , Hugh Dickins , Luis Chamberlain , Andrew Morton , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org References: <20240226205534.1603748-1-zi.yan@sent.com> <20240226205534.1603748-2-zi.yan@sent.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240226205534.1603748-2-zi.yan@sent.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2379F40017 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: drofgkdtggem3iq9364uyoko1ejtqjpg X-HE-Tag: 1709116245-277564 X-HE-Meta: U2FsdGVkX18u9AFLddDstXVgZ4BCN07CwczQMnwjnNh9DYS4OnNrP9xTKZjuNNdcYedskEEKbcvmv0UJ7/5STpVC6LaD/sG33rWg6lyOGYOkII1QvmewoUXf/48gxUpbRhBAnxZd8N/Cl3JQ5hxgDXNU6xqGOBk5F8GTMkAKs67FEBMjiX9jRQlXWQmf7mYtzILaNGXkPSWHwIQlg0FiuqcNtOqNo806NvXwGJIbmBTbF/lJAF91NDHuSFTPf7FBF6w4l4+6Jj4VU6Lt8/+hMHyRHb7RHbRdw7bU4NLjdzIEiMdnI4RgxBTy1xw87WlTzdpUdSmY6EPaM3c/y/Wy0zeXfuCmgf3rcVWlLF068zERc3zJHe/2wJC8nkN8XyMejJsq6KrPV5zjSClXlktcKz7JyHRRACJFblIHbgy11z/OY8qwsz5fDcURkyqC6lQS/XvpJGFhjDZwpmuFhVie4VInHS8eiRjCpG4+Qw/ek5pbnhUW2WfaWHK1nVM4VWtkubxcIvzkmrKB08/VcNdUjc0RD3FtK7EDE2sP08oQj0dx5yr5KjXHlvcuFFo757vWx8Y0LQ0UPVjLaIIRegIUoEZWvAtbc725/8CKvpC3+Xivah48/j1nD3i5KFq8IDvmdqLKdzNx0r4OwO4YLEz8NPxHt1Chj6/evKIOCLwZxS6MMtmcwaUdjO6lwUv6Fmw/VIlPEArBOMf3kyNZhF7Uwq9ooE2g6ylmHQosHIzKoPoj5wS7w7ewScbrECxVXiogRC+v9U5DtZ/D9ehikkTJTq/6IT8xl2jTWUggr9F0nb0f9enoYyhhLBOd55SD6wrWmQ46KDaPUE9P939gosphl+qDz3Yk3O9PBlAIGn8b4B+zdIeE2vK2XzPWO4vk1Nt/LASBZF6FKX1/hBvpYTjDO7nGbEQax0R+JPKE949qpzppb04e3IzzyVg406F0QgXhX4jk+23brudFDnFRr8m rX4JLmzE D4AjsxvFNxY7TNhhQlKAQNSaYZt3xwKrGdWHhJWFTyLiQjn+3UBL1dgjAf+pPNot1/I0q1ihrYP/fHJbU+KDJooP/b7XixkKagEasVdGt55+nx4DSvUTMf+ELJgXxDfIvSZyyDEj7wphwwAdPbSb6QObba1exbtu3zwbBmE1N46WibQzbuzyFjJFT/tn7rW6fSMoKazjOkfpyEzZW6+bXGVJrPvAYSjcHgfHAtxj4x5T/onu/53G7pgtHs0BaFq7VkP9OBFKE0wfu0j2FBORvL1LLc1vggtrBYx5LuUJIcB8fhI8DbP99DSGe5DjmLZqBz3bLy5I9cvwch0sWo91Nor28yljyJvZbdcu3KQXpUkwcJKqTRqjTE4D0g90dqTrA1xclb2cpMgZl/NYdZhlBswVekmUcs/2N4zNZEn+2hbtRRpXOe4Vix5wLXSgEJqpBUkl2P8KC54ldoajK3nj0NjWazpYGAaHT3MfhEVasas8yeKZbN1cx9Rthm7kf/d2xZaMJKEa6JBVXPkDEUwjUHC2qJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.02.24 21:55, Zi Yan wrote: > From: Zi Yan > > As multi-size THP support is added, not all THPs are PMD-mapped, thus > during a huge page split, there is no need to always split PMD mapping > in unmap_folio(). Make it conditional. > > Signed-off-by: Zi Yan > --- > mm/huge_memory.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index 28341a5067fb..b20e535e874c 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -2727,11 +2727,14 @@ void vma_adjust_trans_huge(struct vm_area_struct *vma, > > static void unmap_folio(struct folio *folio) > { > - enum ttu_flags ttu_flags = TTU_RMAP_LOCKED | TTU_SPLIT_HUGE_PMD | > - TTU_SYNC | TTU_BATCH_FLUSH; > + enum ttu_flags ttu_flags = TTU_RMAP_LOCKED | TTU_SYNC | > + TTU_BATCH_FLUSH; > > VM_BUG_ON_FOLIO(!folio_test_large(folio), folio); > > + if (folio_test_pmd_mappable(folio)) > + ttu_flags |= TTU_SPLIT_HUGE_PMD; > + > /* > * Anon pages need migration entries to preserve them, but file > * pages can simply be left unmapped, then faulted back on demand. Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb