From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A820ECDB474 for ; Tue, 17 Oct 2023 08:07:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26B418D00F8; Tue, 17 Oct 2023 04:07:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F4928D0007; Tue, 17 Oct 2023 04:07:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 095CD8D00F8; Tue, 17 Oct 2023 04:07:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EE1058D0007 for ; Tue, 17 Oct 2023 04:07:09 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id BD0CAB6315 for ; Tue, 17 Oct 2023 08:07:09 +0000 (UTC) X-FDA: 81354222978.06.97C4B0E Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf10.hostedemail.com (Postfix) with ESMTP id 5661BC0008 for ; Tue, 17 Oct 2023 08:07:07 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="CqT5/EdL"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jo40IeJU; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697530027; a=rsa-sha256; cv=none; b=AMDJfiwBLNjbslHkHtFz4y33JU/3TvD4ZKV53jwyAm9EXaJgqJXQ0I36yHWe42QWR8Fll5 +VTv0c/BuPH6e9z+moQRKGolaZsYLxpE/DiwfNmXZzW0A4U+gtcMmUAnRBVCZAkwJsh3P6 U9HFkpY7MtZ8uGUTgwXFkVSldIOVx00= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="CqT5/EdL"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=jo40IeJU; spf=pass (imf10.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697530027; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9/CSsmsk8NkBoaQCYM0w1pxloTpa4pHSwaQeLlLtPko=; b=cFCpEn/OyufjWIRBsYRmSZm68AevfGY4xdvpZnXWy3mUF8diLv9RZlM0ekYV9naEl1cJyc HD7mELH2mSoBFG6zaUhv7iwofDVJY+9xr18HFQwV7w17Bl5JipGwHFfXSZ8czXuy6JmnIJ JSV/kgq3pg6JYZA9TDhZimyTh9YvPOM= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F3E5D1FF03; Tue, 17 Oct 2023 08:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1697530025; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9/CSsmsk8NkBoaQCYM0w1pxloTpa4pHSwaQeLlLtPko=; b=CqT5/EdL7YAR+axoMfQWnUdoiKNdN90c0ZpgpNpH76qNn7qII3eJEJXQ3n00ogxaGCz/Zt ZkpQ9nt+4YPbQOn3wgtums0J1GAdcX/Mg6omE4nAxPhFU9LQKMlBT1vREtVGXvgI3x6AGy cDKLPU5FwXNYF8Z68w44ta1sFiI+O4A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1697530025; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9/CSsmsk8NkBoaQCYM0w1pxloTpa4pHSwaQeLlLtPko=; b=jo40IeJUnzTOr6HqWPg9kologq4Y/8GuNP4oIe32KM0WMM0LfnJzzSEhbH9mlV4ZvaWeKC RzA/ScHKfbYWPyCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D5A6513597; Tue, 17 Oct 2023 08:07:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NbpTM6hALmXDQQAAMHmgww (envelope-from ); Tue, 17 Oct 2023 08:07:04 +0000 Message-ID: <993173fc-5d03-a715-64a8-d69893dc163c@suse.cz> Date: Tue, 17 Oct 2023 10:07:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 1/5] mm/page_owner: Remove free_ts from page_owner output Content-Language: en-US To: Audra Mitchell , linux-mm@kvack.org Cc: raquini@redhat.com, akpm@linux-foundation.org, djakov@kernel.org, linux-kernel@vger.kernel.org References: <20231013190350.579407-1-audra@redhat.com> <20231013190350.579407-2-audra@redhat.com> From: Vlastimil Babka In-Reply-To: <20231013190350.579407-2-audra@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 5661BC0008 X-Stat-Signature: 4ywnco1zg6aceueb9kx3sefuuscdyyso X-Rspam-User: X-HE-Tag: 1697530027-63806 X-HE-Meta: U2FsdGVkX1/FzB82W4bCZ6bkGUlaL0w59EaYf8yQQGyLHhJ10A23xT4U+TO9UkSkvNkzfTohwrBg9sHZ1tP/nZgPV/M4rSDpElfahDb6SqA4fpmuRZsXe2Rhk1qeYd9Ol28oNOg8QSCFkBoLQ7PYUkx9TvTxcQaymhPd/8tzV7NaVOYkt/jcPaWnmPwNQsJdoCphkvNDMxoUf6y14WPXrL3jzQVxav3A/9xRK4/VGw9s7+q8jnk4jYb7aC1twuNt/q18c1QkAXlx201hhGClWSpcpMaacJzoZt6BeXaGYZ1rPnrImLW0u0QStza45kIeLHTJevpx+l3Ir8yPxVDkZsfDk3IFjjNJiqMCDwZc9OolvDeZzki7GKeNzoQoGQsieLdDCkdb/Vf4MsesvuxwhgDD3etPUDCRFrY4tQLc6imP+/1EHdo05ZRDJHAXMN3Hs0HtzKP6I8UWwG2cRfmfbP7Rhf8wGd8HAj049nyK8Jiwlj9fFt5TvtpOATh0JKhkPXuBcip3PlQnCT5BTOdQ8twtfWsN/VhQgcNjVv4uDDuH4CDDm3RmnQ/zursCSbAymLDaiICdiZM382LBjkzPLgX5uSHyb8niaM0V1nBCn0c/a8cx30qPxLUixQNs7inSmTlHseuCvBeFf0lJLZTBUxDNeXAlvmxs1zpbEHwy8m7mht3h7G5gPrOd+JyHcHhurXst6Xv3NHYqUW4ZU56p6ew0PIzML9XQ2fjHu+ExpOzbsgk7v4AS3Ng0SK3yrKSZ0cnB/ZpJRBlrUrMeGvn1IubNAV7zgv4vqBWdBovKOeb+4wsAyLWDH624/UanBVuzlPPccXc/E8ZX/mybzt1P1gO+m+GhYngBqO1JiAaLRpNEvLGsPirHu+Rhe8faTMNYBrDFtphaneZwO2CR93xcg4jtg3ao9fP9Zf6Zg0lRAsWbZ35XHVbgbF14KDSQPioH1aTzFn1R1mDO5zeTLm1 A81MhRVA sVzw5iY0lb3jvtvnmXs0UoX2hI8vx2URDUBNaM55BgSLdgTJ/pRLfH6HyMnNlUI/xYLByTanfh238D/PtOWdoBsVK5HZsv4eoZmQVPZX4Ju7RX7I8I0jnd8XWVL3hP90Fa67dYcW8I3S1MQLfqhK3ZmgCy7WH0w3XS6ya64eVlTcgjnDCsdqPataqL/c4Dj4iujmO3l5ryqLQiP/vTutl0e4D0i0iEEnfdljDwOpt6BfINSMebcxk+/nyOAivxl9TOZlT54jrrmg4NF8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/13/23 21:03, Audra Mitchell wrote: > When printing page_owner data via the sysfs interface, no free pages will > ever be dumped due to the series of checks in read_page_owner(): > > /* > * Although we do have the info about past allocation of free > * pages, it's not relevant for current memory usage. > */ > if (!test_bit(PAGE_EXT_OWNER_ALLOCATED, &page_ext->flags)) > > The free_ts values are still used when dump_page_owner() is called, so > keeping the field for other use cases but removing them for the typical > page_owner case. > > Fixes: 866b48526217 ("mm/page_owner: record the timestamp of all pages during free") > Signed-off-by: Audra Mitchell Reviewed-by: Vlastimil Babka > --- > mm/page_owner.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/page_owner.c b/mm/page_owner.c > index 4e2723e1b300..4f13ce7d2452 100644 > --- a/mm/page_owner.c > +++ b/mm/page_owner.c > @@ -408,11 +408,11 @@ print_page_owner(char __user *buf, size_t count, unsigned long pfn, > return -ENOMEM; > > ret = scnprintf(kbuf, count, > - "Page allocated via order %u, mask %#x(%pGg), pid %d, tgid %d (%s), ts %llu ns, free_ts %llu ns\n", > + "Page allocated via order %u, mask %#x(%pGg), pid %d, tgid %d (%s), ts %llu ns\n", > page_owner->order, page_owner->gfp_mask, > &page_owner->gfp_mask, page_owner->pid, > page_owner->tgid, page_owner->comm, > - page_owner->ts_nsec, page_owner->free_ts_nsec); > + page_owner->ts_nsec); > > /* Print information relevant to grouping pages by mobility */ > pageblock_mt = get_pageblock_migratetype(page);