From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D2FCEACF3 for ; Wed, 2 Oct 2024 17:35:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B5AA6B039A; Wed, 2 Oct 2024 13:35:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43E946B039D; Wed, 2 Oct 2024 13:35:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B8726B039B; Wed, 2 Oct 2024 13:35:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E77B36B02C5 for ; Wed, 2 Oct 2024 13:35:31 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 63B5EABFC6 for ; Wed, 2 Oct 2024 17:35:31 +0000 (UTC) X-FDA: 82629364062.02.966E12D Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) by imf24.hostedemail.com (Postfix) with ESMTP id 0CCC718001F for ; Wed, 2 Oct 2024 17:35:28 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lDFOtGKJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf24.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727890489; a=rsa-sha256; cv=none; b=aqS1eoZ0x1sCZHRyjNIcHZJIfTtiOOcAAjhuxhZXMaSQqSBwF8O36IiD+AxDZrE6mSRAVV 5RjmK/90cW+kbSUM0csiVlzLei7KjyepIUpaZw0NCj4JCTcE4W5IBoUrFQZKOVMNr6kXO7 mQEiLdChtnOQXwgondEKw6LY7DV3WG8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=lDFOtGKJ; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf24.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.17 as permitted sender) smtp.mailfrom=dave.hansen@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727890489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UXP9W1bXRndCyi24iYmtfeJxSlRHMTv6Q5U2Jvhke4Q=; b=WBaSknZDdWhViYxjs6UxpvRRQEbwBV/MVj1gl7mBALLaS2z3OAXfa6/9ah2v+ss4cMgSBC RefE6AoPnd1o8l6H7YyfRDef+nZ2nfl/9vEfQQpay7viFo+5yys5MClbRedRSmejFVpoOw 6/v4dt4s5lkRZyjBmrIANRozl6WH9oI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1727890529; x=1759426529; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=EFVn75l/eD1YbUixcJlGMEk4qCsYPu3vr1bemtQMDmY=; b=lDFOtGKJjw1FLe9SXPRvI3d1K1pjApmpRKyFyN7Vi8JHSXKYoS6JDo9l aQhT6Nv4zLH5qKjQ7p5GqIR+uNH+6APgHs4zWs5UwfrJe2FvFxqilMiYW IoWx4AQwWRwDnfi3CYGOHyL5WKR5DUufCXproS8NhutRD2RRhDUsrqySV D5kPoTKYBITqW0uel+BySs828KNgjjjL/HBlbm2P1L3TM/Jyzb4zVM+wQ cvG2J2Vi3eYvTz5TfJt4MMR7mCJH8US9UZ0CoIqujlEVotcIT94HPsEc0 eLSnDBQRdF4WZK93K/0ycC1k5QdwoS6ZdAtFIQQI4np0CpTufrFPXifCP g==; X-CSE-ConnectionGUID: 4diLAOVlTpqze+UDfoi6Fg== X-CSE-MsgGUID: 4208SEGTQ1S+9dguf25CQQ== X-IronPort-AV: E=McAfee;i="6700,10204,11213"; a="27194833" X-IronPort-AV: E=Sophos;i="6.11,172,1725346800"; d="scan'208";a="27194833" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2024 10:35:27 -0700 X-CSE-ConnectionGUID: vbnG5hz0REq5wQ+Wd4XfjA== X-CSE-MsgGUID: PnN7zqd3TT+vu6BiCf3lcA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,172,1725346800"; d="scan'208";a="73746170" Received: from auryshaf-mobl.amr.corp.intel.com (HELO [10.124.220.104]) ([10.124.220.104]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2024 10:35:26 -0700 Message-ID: <9927f9a3-efba-4053-8384-cc69c7949ea6@intel.com> Date: Wed, 2 Oct 2024 10:35:24 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v3 00/10] Add support for shared PTEs across processes To: Anthony Yznaga , akpm@linux-foundation.org, willy@infradead.org, markhemm@googlemail.com, viro@zeniv.linux.org.uk, david@redhat.com, khalid@kernel.org Cc: andreyknvl@gmail.com, luto@kernel.org, brauner@kernel.org, arnd@arndb.de, ebiederm@xmission.com, catalin.marinas@arm.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhiramat@kernel.org, rostedt@goodmis.org, vasily.averin@linux.dev, xhao@linux.alibaba.com, pcc@google.com, neilb@suse.de, maz@kernel.org, David Rientjes References: <20240903232241.43995-1-anthony.yznaga@oracle.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240903232241.43995-1-anthony.yznaga@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 0CCC718001F X-Rspamd-Server: rspam01 X-Stat-Signature: e3byw8c3aa64rokrk4meypagg3nxntkc X-HE-Tag: 1727890528-180392 X-HE-Meta: U2FsdGVkX1/FewYtewFr11Gj6RW+0LTisJ/+bb7BNM6MlmfeXzSQU1VvA1EbdWWQfikkD1Jy1GhN6pvOo6D9Tvb91Un26714zpP4lbI8HX5+fIkFT+8IV6w2hCmIl3zBocUMw2snTcPxItJ8KBDh2nOT6fN76nharot4kYZgR9rbsBtral3uV2G/7LYXkLVFd4//CpJOYNVAim50Uc80dWubi4WTnypPLNx2JTtLQd7qqd9ChuGX93tKueNdEmK3IPrB4atk3l7GjUvpDXlWD50t2drAh7HpjaBSW7TZRWO3fLKln2APHZcwgNBZGcRS4YyZYfUfeMHckZzH4yBiAUDLSFf7bOxZQJ6WNwWwRClZxBOWISNUTGdvhJu9MWn5Mq1uLUmpTvL0GiwThhKPMIzJ1+LWwwphIY3khrlfHds7vb4m6MR2UEwMxAa0hYNHWeh7msxLRlToqtfoybLw2yB3qEkUOdAWh8iYUsnYK7z9678IX6etv6Pteqe6vl6+l6QLhqumEjKZl/DepbpzX/3+6pAsyvWi/GxgMg+ypZkLPo0ivl7mYtsnBZvmIMNb6uRm/enmAfKd3G2vYns/qcjGNK9RELSSG3nPncu8SnN1g+g7n9S7EntF9S7/dj1723OJzP3qMq7DsHym+Ude7vjsuUN+bGx7ZAA+0C/WYHcvUF8KdqX7526JNmor7Mt6aM/+nTsrPVdRQB63pe39pzDUukOTA8RBwPr6YdFh40mkQ04eAur51hOqefomzZIhWs9bAq/zjxQoIZB3resgxuFxp4rzauBsAY8GhL+NcYm+O+3SpTAk/YQa0ehqsOOr69XEClFrqJaiTXEmqoOiTVRZgA9VrcJ8Zez/B2656oaLRbr638BS6x8klTmlL/8i6iHkDwCTH48ouPwoc9WzMA9vSj38bKs9op7dIbCgYQoLMxD7P6REzcs7YqPGvBz7Q/1Tym5xHZV9yQgnovq Js6HiGnM ZLk3d8WLguAqkKsFPXLBxi1NE9jRmeEp9PTe6HVOL9Z0VE3bcnRFOe9/2YGrErWCQ5vcbHJH1jG3xSEUMwr7QoefghA7Z1G9lLwzB9xCbbxVGBQ9CnV9fRyvDpUSaCWhduhd4Gq3LrVTHd508n0angjlsQoM7/B5auj4Nd5OhbqE1AL342hlYLqoqBtEJiUM+UA6lveXyDrTuWGc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: We were just chatting about this on David Rientjes's MM alignment call. I thought I'd try to give a little brain Let's start by thinking about KVM and secondary MMUs. KVM has a primary mm: the QEMU (or whatever) process mm. The virtualization (EPT/NPT) tables get entries that effectively mirror the primary mm page tables and constitute a secondary MMU. If the primary page tables change, mmu_notifiers ensure that the changes get reflected into the virtualization tables and also that the virtualization paging structure caches are flushed. msharefs is doing something very similar. But, in the msharefs case, the secondary MMUs are actually normal CPU MMUs. The page tables are normal old page tables and the caches are the normal old TLB. That's what makes it so confusing: we have lots of infrastructure for dealing with that "stuff" (CPU page tables and TLB), but msharefs has short-circuited the infrastructure and it doesn't work any more. Basically, I think it makes a lot of sense to check what KVM (or another mmu_notifier user) is doing and make sure that msharefs is following its lead. For instance, KVM _should_ have the exact same "page free" flushing issue where it gets the MMU notifier call but the page may still be in the secondary MMU. I _think_ KVM fixes it with an extra page refcount that it takes when it first walks the primary page tables. But the short of it is that the msharefs host mm represents a "secondary MMU". I don't think it is really that special of an MMU other than the fact that it has an mm_struct.