From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09FC2C54E64 for ; Thu, 28 Mar 2024 11:30:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6784A6B0083; Thu, 28 Mar 2024 07:30:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 627216B0085; Thu, 28 Mar 2024 07:30:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A0D66B0088; Thu, 28 Mar 2024 07:30:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2C9D86B0083 for ; Thu, 28 Mar 2024 07:30:43 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D5DC81610CF for ; Thu, 28 Mar 2024 11:30:42 +0000 (UTC) X-FDA: 81946230324.16.29DF2EE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf13.hostedemail.com (Postfix) with ESMTP id D6A5020023 for ; Thu, 28 Mar 2024 11:30:40 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KfNxnPcM; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711625440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JKHZLDupsf8fpmlXERDu5eE2P2zkUPorl64RlavClJE=; b=UXIS7mCb5qlN7/zzmbArjYdOl/xWxcTRr4nJXPB5lUXNO8oqQbqJRIT1JaErRV8SC3Xav1 w4EuETuVr5KF/pV3f+u8L7ZUcC6ERZxIrOeunVv6eVqFVM7Ricqqf8ZgIdYZK00Fk+588p s38QBPPmvKhENGkbCcFKEAEjIZiW39g= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711625440; a=rsa-sha256; cv=none; b=zQwZFRMwrXmyQqSrDGR9d2P+mVZyxpKSHnml+GYMiTxUVoGj8mkjNXu8WZpW/tO/bEy7vn e4PeNdXOY/l+aIYzzm1jnKG8OHjMXztB7Lgvm+143A9zfHmDPfJo6iXqoNs1ljStF1mZop j1EGyELuqAPpqdJ3HmNZka8XzwprKp4= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=KfNxnPcM; spf=pass (imf13.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711625440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JKHZLDupsf8fpmlXERDu5eE2P2zkUPorl64RlavClJE=; b=KfNxnPcMxkLJtcXssdI9iSOQC5Z5wFQmFOKvBu75gbu2EcVyRvCWNHqqGoEgD06106y+FR 36m2FR5hcxsBy/gpi/IEEDL91cj8C93ZXmyiQq5WpJ4tYYrGOpsF6897WzzUYzjIFpbIZl 0GPl2VAFa5YDWI+eqrkc9uyDePebkJY= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-564-uDJ_6AqKMUug4HbPpXEI2A-1; Thu, 28 Mar 2024 07:30:39 -0400 X-MC-Unique: uDJ_6AqKMUug4HbPpXEI2A-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d499513d62so7212131fa.0 for ; Thu, 28 Mar 2024 04:30:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711625436; x=1712230236; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JKHZLDupsf8fpmlXERDu5eE2P2zkUPorl64RlavClJE=; b=AKjKpq4JUGTOliVKsaKwmzkZ9fRfzBPa7LPuN11vGx7JbP4jAEP4GtWcYuGVxYqM9/ 6W46NhSYMZ5YhTFXVdwYYdpmFoOjGegB1/SB4prIDzTfo2UWw3IaHuCQPRHdjpNpcYfv 1s1/0VwjB3P+W3JQELqr2i39TMawn0pdJFmpflrXXzW6kNl4yHqwJbCJ686fHXr4uE0m mA+yrIcOHU2Dv3gBI83H3K39qymn974q3EGhEtT6CKBE1a9s1Mzyx9dAfcmawdBTyQPg 7eocjGQGtMMxckv4iVrKAerARYUC7neZJX/qdlaBLulbZfmFUqbH+lBkr1DhIVeGDrH7 48Og== X-Forwarded-Encrypted: i=1; AJvYcCXFCXB0rANZSym4Vi9ucejpIy0ZMbK0fFqNW8FJK22OfAeydAw+LDvzimnfbdgDuUtfLveVzMgPT5c55UVA/nbaGCo= X-Gm-Message-State: AOJu0YyBM2fvOC/e4gjYLzMDcMfxNWI4CSzIArwrJHsdmX9yxstWdmwg kwNRmSAWHK6MQ6OCX07Ah2u8mmQR2KSi2WmrOgJk9Bg8wsv3Pi/UVuv3xl0CF3jnuPDKag8YVLu rlBimHE/le9UXRrLhoRgxzrIMuMlNvDR/oeu33aaSchl3Sa05 X-Received: by 2002:a2e:9951:0:b0:2d6:bb8d:d3ad with SMTP id r17-20020a2e9951000000b002d6bb8dd3admr2224018ljj.3.1711625436473; Thu, 28 Mar 2024 04:30:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHgjNRohenfZNazxJLa7iMe6o7w40jqiY8aHWdUCMEcd0PatuEP7IE15M+aAUiIW8TIZLwqUw== X-Received: by 2002:a2e:9951:0:b0:2d6:bb8d:d3ad with SMTP id r17-20020a2e9951000000b002d6bb8dd3admr2223998ljj.3.1711625436071; Thu, 28 Mar 2024 04:30:36 -0700 (PDT) Received: from ?IPV6:2003:cb:c714:3600:8033:4189:6bd4:ea29? (p200300cbc7143600803341896bd4ea29.dip0.t-ipconnect.de. [2003:cb:c714:3600:8033:4189:6bd4:ea29]) by smtp.gmail.com with ESMTPSA id u15-20020a05600c00cf00b00414041032casm4337976wmm.1.2024.03.28.04.30.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Mar 2024 04:30:35 -0700 (PDT) Message-ID: <991d58c0-8003-4d8a-b616-434b3ce46932@redhat.com> Date: Thu, 28 Mar 2024 12:30:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/3] selftest/mm: ksm_functional_tests: refactor mmap_and_merge_range() To: Jinjiang Tu , akpm@linux-foundation.org, shr@devkernel.io, hannes@cmpxchg.org, riel@surriel.com, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, linux-mm@kvack.org References: <20240328111010.1502191-1-tujinjiang@huawei.com> <20240328111010.1502191-3-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240328111010.1502191-3-tujinjiang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: bis8ebo1tp8dc6h7e4kp69h3swef14yj X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D6A5020023 X-Rspam-User: X-HE-Tag: 1711625440-922480 X-HE-Meta: U2FsdGVkX1+3jM0Ztibi2JIJgyy9+OmiyjZA1MS4hrM3bllZUmw9KDONeEaupjFP2LBbWza1rzrHV71xwfc6mLuZHvN87+UylVDIkBvIWalwUNdXHXsl0FtWfDdbFYsligD3UXHGdFyK4rTHXpur/EbEnj0Bk7A3jieN8bH/FNIKiYC2c9ThoP8JL08ZHbzpAPNe9BkjZE6H1MFqviOAlza2/ENrUYO3s+Yv8F6+XOTkj4TPs1SnhBKRvwS0xjhMx8jW9jt7JcXYKEAYsbn09CY5/syeSvFg1asWnc45dxVPep+bkMSrsF+il2s+eCZmPRjzGiIfrSjmIDq9rFYITx3+V8t7diqeoSoOrAhWxBhyc3sqBsn9Nd+jHmN2gMd7P7y0IhwNmUV8DqnrSFlNEH3nN9qjb9x4+YTmSByqib8lwJpnRNW2sF+hhls+NJEIToOGCCh/ftXUwib2UbhiJIBh/tIjnyvgqS5pEoxIclKJxUAgiRSF9R5tUHwkLhdeZupBpGA53v3EA7+bx/Opxvg0QUs1Oh3OJAHYYIq6LEG9KSGpSjqAPoKdRSrxn/aQg0F98ueI2DmA4xEnLjyyNkY3MhxEitRkT3gZmy+y5GnkvhjFiOoRMyBB4wnfEbqzSf/yc4c5A/e0TJjxCoEMJF9Ca1gcnBrqmEic03LxTkHmztR7eG0Mimp+iIf/vcD5OWM02W4qyuWk9wtYp8gXuGMOdDJU5SYkcnhUeKTgpecGQmUQdAbWre/gMEeNt4jIYBLtuRG1U1w8n0H77EDjhKSucwOXPRfeI1vQsO7wBkM400GfbS2QjS4wNBkyhHqXz1cAzLpZdUzguQBh7eWCzgzXaCVCAfimhbw0qbGsXyDfXyUh8rkVqNEFeS3HDQxLgULuGIodUi/kG4yPrjRG227tBuw/1g7cTG+7vZYEc9AjeU+mQ1s119QNUWi/qel9G/EO7xieDkDB1+szsFB HSS0zLFx AW1HMJlKNCyFrS+7Ujs9ZPGU3VJPkzJu6muAKvrutjIcsxRlPwRL+ektKhU8+k21qoqkmqq+RtyuJbGPxZP9vi4gVqjt50AIRXL8aqh4I2AYPFSYCxCqa81I/Z+hh3qEhPeL1848XoBy+ysR/XwrOafWQnvdZE2YnIjASg7mWbDj4dPHbO4MXovMDZvXeuQ+2VTa9ZovkTH24e12BFgkHtFgMWQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.03.24 12:10, Jinjiang Tu wrote: > In order to extend test_prctl_fork() and test_prctl_fork_exec() to make > sure that deduplication really happens, mmap_and_merge_range() needs to be > refactored. > > Firstly, mmap_and_merge_range() will be called with no need to call enable > KSM by madvise or prctl. So, switch the 'bool use_prctl' parameter to enum > ksm_merge_mode. > > Secondly, mmap_and_merge_range() will be called in child process in the > two testcases, it isn't appropriate to call ksft_test_result_{fail, skip}, > because the global variables ksft_{fail, skip} aren't consistent with the > parent process. Thus, convert calls of ksft_test_result_{fail, skip} to > ksft_print_msg(), return differrent error according to the two cases, and > rename mmap_and_merge_range() to __mmap_and_merge_range(). For existing > callers, introduce new mmap_and_merge_range() to handle different return > values of __mmap_and_merge_range(). > > Suggested-by: David Hildenbrand > Signed-off-by: Jinjiang Tu > --- Thanks! Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb