From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACF45C4332D for ; Thu, 19 Mar 2020 12:32:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 829BE2071C for ; Thu, 19 Mar 2020 12:32:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 829BE2071C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D9B716B0003; Thu, 19 Mar 2020 08:32:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4CFA6B0005; Thu, 19 Mar 2020 08:32:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C61B86B0006; Thu, 19 Mar 2020 08:32:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id AAFF36B0003 for ; Thu, 19 Mar 2020 08:32:55 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 62AA5180AD807 for ; Thu, 19 Mar 2020 12:32:55 +0000 (UTC) X-FDA: 76612051110.08.silk44_1976780968426 X-HE-Tag: silk44_1976780968426 X-Filterd-Recvd-Size: 2188 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Thu, 19 Mar 2020 12:32:54 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 97411AAB8; Thu, 19 Mar 2020 12:32:53 +0000 (UTC) Subject: Re: [PATCH v2 2/2] mm/page_alloc: integrate classzone_idx and high_zoneidx To: js1304@gmail.com, Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Minchan Kim , Mel Gorman , kernel-team@lge.com, Ye Xiaolong , Joonsoo Kim References: <1584502378-12609-1-git-send-email-iamjoonsoo.kim@lge.com> <1584502378-12609-3-git-send-email-iamjoonsoo.kim@lge.com> From: Vlastimil Babka Message-ID: <99196b17-24fb-8990-2d21-c459d2321747@suse.cz> Date: Thu, 19 Mar 2020 13:32:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <1584502378-12609-3-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/18/20 4:32 AM, js1304@gmail.com wrote: > From: Joonsoo Kim > > classzone_idx is just different name for high_zoneidx now. > So, integrate them and add some comment to struct alloc_context > in order to reduce future confusion about the meaning of this variable. > > In addition to integration, this patch also renames high_zoneidx > to highest_zoneidx since it represents more precise meaning. 2 years ago I suggested max_zone_idx. Not insisting, but perhaps max_zoneidx would simply be shorter than highest_zoneidx, while saying the same thing? Also I wonder if we still need the accessor ac_classzone_idx() (before rename), or just replace it with ac->highest_zoneidx (or whatever the final name is) instead of renaming it? Thanks! Vlastimil