From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 858C1C10DC1 for ; Fri, 8 Dec 2023 15:22:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2B3F6B0080; Fri, 8 Dec 2023 10:22:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DDAB96B0085; Fri, 8 Dec 2023 10:22:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7BB26B0088; Fri, 8 Dec 2023 10:22:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B961F6B0080 for ; Fri, 8 Dec 2023 10:22:07 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 818D91401FD for ; Fri, 8 Dec 2023 15:22:07 +0000 (UTC) X-FDA: 81544016694.03.B380431 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 21C7A40025 for ; Fri, 8 Dec 2023 15:22:04 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FZ9p7OyS; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702048925; a=rsa-sha256; cv=none; b=jXbgN24/Doqd0Uw0v/3oRrs1vbjFSUuFkHpQF4Onu6k/RjZ9ZwfEXY5FnVMXXm7E1Sk+ub A2RtMQd+hXdkAN9LG7WoDI7iTJtDG6dXshy8vzEDqmcH2YIU54O7AkpiI0AKIq1n00pAsn oNJIwG780C/5JZxFMQF5+EnNij5o9Xs= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FZ9p7OyS; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702048925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v3raiss2uEo+4B2/2jWD3SM9eLFdIuye7z5fprUfGEs=; b=rTyFVZZ1/ErHiY93BSD1MeAltmOdKpIox6I60Y5GZupnIlnj7WJkTXxKRABABAc1go7Wix wDQ9wL0iQmyZaylR1WiQXbk8ZYU4XrgCtmxxvfNjZlT14tiAmc5mqEoFrAjmJDd1Dlj5Y0 RXLZN1Bdf2mNeyS22i4ng4deZ5vNRHw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702048924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=v3raiss2uEo+4B2/2jWD3SM9eLFdIuye7z5fprUfGEs=; b=FZ9p7OySHyCEVwLdIWd5krOkGvefQalnbxmWWlYcO0fPu3SOcx2nrlixe6OcFPlKVsgrsY W9WrUuV0JTVOjSpH0y2wTSKPFht8F5f9y3gfxppLylR41oBOPYbgvgytZ0K4eAB0lV3XSS eWgtz/c5FMe24A3Gwm10e7LN7xIV6Zs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-306-KZ07XvNtMgWb2NBfr4rcLA-1; Fri, 08 Dec 2023 10:22:00 -0500 X-MC-Unique: KZ07XvNtMgWb2NBfr4rcLA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33343bb5dc2so1854083f8f.0 for ; Fri, 08 Dec 2023 07:22:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702048919; x=1702653719; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=v3raiss2uEo+4B2/2jWD3SM9eLFdIuye7z5fprUfGEs=; b=aEbSxXVuxlgK55b1IYUJpLRKRu3LwRLHZXsQ6jncxsNLWAA6IM1ipf0F+pLdv7vTiW xX9AZR9GxI/PmWU6nmzUxEa7jWdeivzHNBeUJSjUBD1iNCkmXc6job9jKwyvcBdUKrgv JkLPnOPN5lLeb/rY10tyi5ZBZ7PQ8LOFQnd7sLy6HKdcnI17XNOSfLi38J1PYFvUYSAq 8GwuW+C8TyLnwIKa2FcOJDPoOE3lu9gyt6ZKjFkTbVtyAlAwlqCEACYdMKgpuKAeVzRG S0V1kQvyv85I4OG0+yztI0cUkXdvBsbEOrenxwgbahT7GkngMzRwgIIjeR8JTq83aRsp A8Tg== X-Gm-Message-State: AOJu0YxZki9GVHx7ehzZUdIbGT2o9EYKBD9VauWJ1lhu5G/s0/+2Czq7 cwbwxzCr46aaMgMfg76txkKLW4R81zZDsBJ5AHS+1gWeY7PTKbjS8AWbqmUwOte5YVn6r83dflv qqUKHbYpqzG0= X-Received: by 2002:a5d:614a:0:b0:336:9f9:6df with SMTP id y10-20020a5d614a000000b0033609f906dfmr113816wrt.5.1702048919689; Fri, 08 Dec 2023 07:21:59 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLgS9qWolessYaG5VTrLIbiadoOzWmYkVXdKEnOILyuEU1JX1wnx9G0HGW3zxhU/vRrSJ6Kw== X-Received: by 2002:a5d:614a:0:b0:336:9f9:6df with SMTP id y10-20020a5d614a000000b0033609f906dfmr113808wrt.5.1702048919186; Fri, 08 Dec 2023 07:21:59 -0800 (PST) Received: from ?IPV6:2003:cb:c724:2100:3826:4f41:d72c:dc1b? (p200300cbc724210038264f41d72cdc1b.dip0.t-ipconnect.de. [2003:cb:c724:2100:3826:4f41:d72c:dc1b]) by smtp.gmail.com with ESMTPSA id w6-20020a5d6806000000b00336103442d2sm830895wru.76.2023.12.08.07.21.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Dec 2023 07:21:58 -0800 (PST) Message-ID: <990feea2-c7a8-4cd9-8a6a-bc4bc1c2ffab@redhat.com> Date: Fri, 8 Dec 2023 16:21:57 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 11/11] selftests: error out if kernel header files are not yet built To: Peter Zijlstra Cc: John Hubbard , Linus Torvalds , Andrew Morton , Peter Xu , Shuah Khan , Nathan Chancellor , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, LKML , Muhammad Usama Anjum , Jonathan Corbet , linux-doc@vger.kernel.org References: <20230606071637.267103-1-jhubbard@nvidia.com> <20230606071637.267103-12-jhubbard@nvidia.com> <20231103121652.GA6217@noisy.programming.kicks-ass.net> <20231208151401.GG28727@noisy.programming.kicks-ass.net> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20231208151401.GG28727@noisy.programming.kicks-ass.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 21C7A40025 X-Stat-Signature: crgcqcxumqj9za1jyf7pgcjq1ndzqr1r X-Rspam-User: X-HE-Tag: 1702048924-560878 X-HE-Meta: U2FsdGVkX193cZWNxrSU+X+Jm1+xzW6FvUlwzusWAmCyslFns5TA9SOdYY48+J9MaQCAYAgr9FhnKeC/ohS+rZh817qMsv69/z/JhvGq7C0qRCkGdP/v9/cgEePl4wubF/9TLmRR997Z3oAT/Qr7uEijiKm4pW3EqtxeFQLPMSt7R8go3IfOQ5oSPe81KQiEwIFFZMBf2FIz2zguDY4r2D4fVCBd28cg75JI7iEBBWMLMaJTaJMs2waQ+szLlsJYSWuehYBxbCgurdVdLYvldVeciTJ9YTuoAyGVMsJllMlNSqiaqmobr9Ix2VTFk6yKCCiYa10qgX8UPZUPxeMiKozmRtZaVvJ7JSeuaExnbfIsjLCY5mUq5wPSEo+2+X2Qqu0vJ0a/vdstpVBM0N0FBjyP3JXPVveay9Vwy5SdCaXLP5YuPZaaYLYru9vfrEHoreZAjDLZvLRGEAqshk0pAHMK3NU2vUyIl/kaGRkm0OVQ3bzSzwUZS712auy2fHMZDI3hk7tKn4l5fPeNaLyPCaADGwNNe/JWSix0V7lLNrUnUm2BdnhGupSze63c4EmAHs/viudu/PvKAJzhfQA4tmNZAzRl4lHYEiNNQxsx3ulICVzrPc7Ex95QCgUHXiqu+MjmAbuxx6JS/rjP1W7+TFYbwiEiF+pMHw9mNJmx8mMvAbqUZQHAbJvTFk4vM9gUFhm5Mtufrj0+pHuqvpJxcfgYLx5iE1MLDcM1ljX80Ch6nBpyGN8a8O5q0Jx8G9p6HR78FVGr9D9RLvFgJOeqD8Mx7I3Ae2SRN1CL0BeDT9qHZ10AImX/hPvkP05Ho62ZEw7KM8L4xlqKdGj3HWQnuoCCPB80NGWi24dQ9qc93QaPqB/LERa018Gptmx7UiLPH+Tz7KUCr0pg00CM+7mMmcyZL/cwjJH8sa++4sbe1FuY1JAtMwDA4w6FwB0ytME+OHOW/aSNdz1JzroP8rD OQeg/xjS U4uDLkKh1xUkI82cs3ateuqRQ5y+l/tsaiVCC0ii7UNda+DnAk14APnw0V6Va0PTQIdRMiucWEm+v/Q9y7va15gtI/bsAtxpEbnkZereVw+5dMOnZLNhicakkwxb28+7ECbcFAC7/BFu7X7EB0vKIGlWVLdtfyEdcdCo/TEqFwCTWe8NFJQBlMtpHxY3ZqqrKePmOlIENzwSmXmCjrZm6tCoxR4887ImSyMjAoyHy1xe1iB3Xg8TAPjReHiwdg4r23g2dd6YkY4wlUr2ZCUfLVDJTsOLSgd4VaWhiTRFhyj7tPpbtjr8Oez3/dTtF3UFRBlenmCHoifn1QmuAeadtX+BGPUTv63QslNNR/XZ1x6amcG3+R0C/YiGtYfsmzN0r7hfZ1PV+4LAJxSot7dlvb9jsfFmxhQAgMrXbIWjYRsQD0Lw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.12.23 16:14, Peter Zijlstra wrote: > On Fri, Nov 03, 2023 at 01:22:54PM +0100, David Hildenbrand wrote: >> On 03.11.23 13:16, Peter Zijlstra wrote: >>> On Tue, Jun 06, 2023 at 12:16:37AM -0700, John Hubbard wrote: >>>> As per a discussion with Muhammad Usama Anjum [1], the following is how >>>> one is supposed to build selftests: >>>> >>>> make headers && make -C tools/testing/selftests/mm >>>> >>>> Change the selftest build system's lib.mk to fail out with a helpful >>>> message if that prerequisite "make headers" has not been done yet. >>>> >>> >>> NAK NAK NAK >>> >>> This now means I can no longer run selftests, I thank you very much! :-/ >>> >>> root@spr:/usr/src/linux-2.6# make O=defconfig-build/ -j64 >>> make[1]: Entering directory '/usr/src/linux-2.6/defconfig-build' >>> *** >>> *** The source tree is not clean, please run 'make mrproper' >>> *** in /usr/src/linux-2.6 >>> >>> >>> I've always done: >>> >>> cd tools/testing/selftests/x86; make >>> >>> and that has always worked >>> >>> Now I can't bloody well build *any* selftest or risk not being able to >>> do builds. >> >> This change landed in 6.5, no? And 6.6 was just released. Just curious why >> you notice that now. > > And I hit it again (different box etc..) > > Can we please get this garbage fixed already? I'd suggest to either revert or turn into a warning. @John? -- Cheers, David / dhildenb