From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1429EC8303C for ; Fri, 11 Jul 2025 08:05:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A04F76B0099; Fri, 11 Jul 2025 04:05:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9DC9E6B009E; Fri, 11 Jul 2025 04:05:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8F2E36B00A0; Fri, 11 Jul 2025 04:05:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7F8306B0099 for ; Fri, 11 Jul 2025 04:05:55 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2F9DB1A2A15 for ; Fri, 11 Jul 2025 08:05:55 +0000 (UTC) X-FDA: 83651250270.02.43C50D9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id B01351C0011 for ; Fri, 11 Jul 2025 08:05:52 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d4p+SBFd; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752221152; a=rsa-sha256; cv=none; b=FH+eMuUz27XT3Y9xHrNGLMuglANTsoFfd8MJg9kNM4YLt9R0AWgHwFyyQeP3HXhaQmMCuo LbyyzOKq6M02g2e3xWjMXVqEzOeSdQXqoEUO1vAcFKRCOLOJIV/lWzTnhENUMZ5BZSB/Pm VQCr+c+9UvquINaRbySZl1ihg5ojruA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=d4p+SBFd; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752221152; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZgB4DwHkI9xjW3XR0t/uXHhY8IoxohxC8W6rpDUlN3g=; b=nhWe/b51OaxKS8ErLywfwqT0KfXMwDOU+uES0OwAVJbFO+tNGxIIIFgQNfsDn74i+Dm1nr R9urjFWn5PDWrENTqE27WhpHC2Z9QecNiplNJ1uslYgK3nnbHKoDUxSPrDTshgCDguLBDL 2zgopZwwshRNLqazleEaaV8CRMtosIU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752221152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ZgB4DwHkI9xjW3XR0t/uXHhY8IoxohxC8W6rpDUlN3g=; b=d4p+SBFd3LZJjD0PfkgBCg1I08FG3P8dzpT6mrh1uD4s56GbfDnnwtq/Jusgq14g9zMtBt Rg+j8DP8I6VU5dR1iT7CE4tMpA8RTZ+p08VAckVsNT6SSTHzQQTJWwGJB2WqX30PDiFqju G5HF/H3TATtJo2KftjcOba2ws3DZABE= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-84-Zbj2lfA8OB2p12MBQ15pmA-1; Fri, 11 Jul 2025 04:05:48 -0400 X-MC-Unique: Zbj2lfA8OB2p12MBQ15pmA-1 X-Mimecast-MFC-AGG-ID: Zbj2lfA8OB2p12MBQ15pmA_1752221147 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-451d30992bcso13801935e9.2 for ; Fri, 11 Jul 2025 01:05:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752221147; x=1752825947; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZgB4DwHkI9xjW3XR0t/uXHhY8IoxohxC8W6rpDUlN3g=; b=jJ2GII6zFFkLOPjnE6joL5pDuYXKPGcsq5cR3n3xOeIpku47x3cAsPsYtTRH4spGpR JXqiLXt8KzPkDygFrsouMfVbYZPbaTpFs9I1nPlGG7GCU5Eq/i3KpiDbJavXxau8/YmQ F/svdL1C6sk+72RU+aGmsuhmgXcmEk3JnSafhMnNfuxsgmRCW+JRVRX5ygXwjLELMQ8J ekwK7Ck0UCB2Y51V6rS8w/P4GUDRps5XgwcNKY9FKfW2/gwxg3HhqnZ2v2W05xCKAI6I BCCtQj1XFzO1WRTsIYGXt+bvj+flJZxMEPgPysBqW2F95dMgAYtaKvSRa+3TPGWnJJh3 2XJg== X-Gm-Message-State: AOJu0YzvnqR3TG3ykjAWDZ+LDz+ZZrJrMDQW4b6VxPXMIv5Apx8qvK99 Za9zSN2AjOXUit4qw16SHHPoFNQp9hoxkf+om2gWwJriu821GjeakV4ChkaV7C7b2ksMb2ZPMEf tNlRXIH0Mywkvvne/KRtRaQ42PFxan7827UPZbCx1aYQOlMRyoyqc X-Gm-Gg: ASbGncskGei8zhHXJnXdW64aLdXhUGyOaoqeBa8viKK0iv9Zg9xTKNDhLAGuMLHN8IA qbVPUwdXnmu7VuQxRJreo560Aqx1AXl9zZGhEcjfE+TrHd3OhqBxkrdxPfbocf1aJw06L5D4Xky JYYgWDrmJ/CFVcOX88eos59PBRUPsrfQSAZdAmXVifAiWTNbp68t1HXe+XrZjjLfrgvHMSNkJf5 QhBRm4lcZ9w3XWbO4ZtiQ+wyc/L4jqHtidoraS622KFxujBVCrzQSVmscD3O8YTFhnhBCd0EQYG OPPT/cz6G3PQ+Wm6DWpUAyB7hBh93hZMXVXH2FRLbuoG7aBfoeO+mWBX8XtGBB4JL7XNQhsOqb1 jAM8PgGpk+pBuhE49VImk/Sbpu2HpJX0tXy5AbwbhtwdJ/xnPcJ834NxZhIukjYeO X-Received: by 2002:a05:600c:8b13:b0:442:e109:3027 with SMTP id 5b1f17b1804b1-454f4261ed6mr14996125e9.24.1752221147238; Fri, 11 Jul 2025 01:05:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGBOTz69pr0Xqf/zjvnrYjYK+0HzAoZKIKiU3duoTP7Wapu+9/attNqXs1kw4ieBWWGJ2XYMw== X-Received: by 2002:a05:600c:8b13:b0:442:e109:3027 with SMTP id 5b1f17b1804b1-454f4261ed6mr14995735e9.24.1752221146736; Fri, 11 Jul 2025 01:05:46 -0700 (PDT) Received: from ?IPV6:2003:d8:2f23:a200:bee7:8245:bf4:2c78? (p200300d82f23a200bee782450bf42c78.dip0.t-ipconnect.de. [2003:d8:2f23:a200:bee7:8245:bf4:2c78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-455e6d57013sm6286915e9.32.2025.07.11.01.05.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Jul 2025 01:05:46 -0700 (PDT) Message-ID: <990715ed-f660-4b88-b850-57d6aee6ee59@redhat.com> Date: Fri, 11 Jul 2025 10:05:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm/vmscan: fix hwpoisoned large folio handling in shrink_folio_list To: Jinjiang Tu , akpm@linux-foundation.org, linmiaohe@huawei.com, osalvador@suse.de, mhocko@kernel.org, ziy@nvidia.com Cc: linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <20250711021734.2362044-1-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250711021734.2362044-1-tujinjiang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3kfyj82LN85LkFbvBN3VZKH7CqPq7Gf-O85J7h50Upg_1752221147 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspam-User: X-Stat-Signature: yar8xwwuoyqtqjt78yjgf94eg51x5h63 X-Rspamd-Queue-Id: B01351C0011 X-HE-Tag: 1752221152-598357 X-HE-Meta: U2FsdGVkX18VcVCwT+FNfs356BZ3/VnZQFgRjOWGczxAtihKJqGuZ1CHB2Y0YkdlC9PzvdPES2CRBZbNrN4ev30X/xaGYHLBv6BI0/D96kGOBgAbwTC0WFtIG7UegRg+kZ+rkuvW7iNr6hChIayw/mJ2z8h7IiuD3BgvdSgRm/yoSR0cP70wBvviBfB4fASsN44TGgpJrFil0HIQC2Aj4d7+8B8ly/zioI+/2/6+2imVP6Lj22YP5nZqSPsdR+IbO0dFbhzy6H2qPrKpgHHjSYE1HdSE6AiDOt1Q+6T+/IErIxG5w9NVcZHewu5M5LTKwMsi0kH255xl5aI3QzGTvVcfvrghHfDqP+3GE+I1aPZjhguwpA1HX93oRl0zGPcbXrx7CdH0QFB6fhq4JyWwCaheopJy4rRY71YeuG2np0kmghODMKl+JOv/z3V2xKLUA83TSUDK+XbISX98y4bVNC103ihot+agTczYORTcAgJy1bntTiMul+tfzc4eIGNLrF6t+6R2Y0xQlf71gg0pIh/Iqkw1OfsGXMHf38BsuBQmPWsHYrBqnrdVqjfc29Fihw5oMpKBzlQSgoZz4L0snHs1aWR6sLY4L5eFHc58SBKwjbnS+EqGNfcwBZfC4n6mvfes60pHVLozQXMcvYFiESxVZq0IoLKz33Rdsy0PVcGODJDdssoN7VhYYi+0dzi9JRbwZa2+Ft6d4N/c88OmZcl9OHZkJIFuanD8l4pFA4RBbF+UAmoIyHu3RBq99qFwBawNYm12TVaRNtMWbzcM2mK/9Ey0MHbmsiFVcxNHrU5YA0kVPRZ1eMvMEemPeQU1zwDcPF3z1B1oCvscQkcGLnBOX88wj6AKxb/QINygpqXQKDgzC4VuHcVdCYNUsXLOPq3JHVkmPNpaH0JatiLw50hDpgbfoARWVpVduSYx6cAxlf58Q5iwUUCKwBh+28CULR/ji3P2vK0oDtKBIgR zCNI4K92 KXzBAExOkGaz5ICeeZN5lKKCtIeGOvkAvG1C6QBRdyGVkvlApQpjry0ywogdzMEagvY9SuKpBAmXDMr2KBJAFE5d8MKswEdd9K1ZWmPOpjpahCyinXAg4HnaoenOLi/F2YA6ZmJ14jQzvUQsQ+QkecYvJ0WwpNYSNznTwHhgpdpTu9QWL29ftznSiGuAff9YfHPZ11BYc9jMwfk7biLI/cDrU/gFO9yQcHDAEhG7dDnUVvY0SzCkdoI5f6nNy9QXLCntRovxt3YyeoNoHhHcka7YZb2I3sGk7IFDZpTUWTlkHL4TwgFoUwejdpmWHbq47xvWvE8E4/AxIvNrRAPHasJGcHECvoe4avvr17Og5l2sF2K8s8CLv1fo5qegCmgNzZ+81ufV40AlIc3tEU8vbO706ffJkuvNzxwdNbtwGpvOMgJES+fosofRaEXW0BslFad4LQtwKZgiKuVa4W1YYgyJEKh4a8M+voTm1UPtF6qkaIqe0PZ7r+E7dcbJhVRNE49lsY33Y/ubOR2eCvrkLtDPLMPyIoaDbwjtPekaFSVpQibRuKShMiOY8Cswu50O+3UZah2Wfp9JpsVnTOo9WOEdwSQkYcivi/aTnI5WiUnwIjZIDBJ6mnGXKoA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.07.25 04:17, Jinjiang Tu wrote: > In shrink_folio_list(), the hwpoisoned folio may be large folio, which > can't be handled by unmap_poisoned_folio(). For THP, try_to_unmap_one() > must be passed with TTU_SPLIT_HUGE_PMD to split huge PMD first and then > retry. Without TTU_SPLIT_HUGE_PMD, we will trigger null-ptr deref of > pvmw.pte. Even we passed TTU_SPLIT_HUGE_PMD, we will trigger a WARN_ON_ONCE > due to the page isn't in swapcache. > > Since UCE is rare in real world, and race with reclaimation is more rare, > just skipping the hwpoisoned large folio is enough. memory_failure() will > handle it if the UCE is triggered again. > > Fixes: 1b0449544c64 ("mm/vmscan: don't try to reclaim hwpoison folio") > Reported-by: syzbot+3b220254df55d8ca8a61@syzkaller.appspotmail.com > Closes: https://lore.kernel.org/all/68412d57.050a0220.2461cf.000e.GAE@google.com/ > Acked-by: David Hildenbrand > Reviewed-by: Miaohe Lin > Signed-off-by: Jinjiang Tu > --- > v3: > * collect Acked-by and Reviewed-by > * update commit message and commemts, sugguested by Oscar Salvador. > > mm/memory-failure.c | 4 ++++ > mm/vmscan.c | 8 ++++++++ > 2 files changed, 12 insertions(+) > > diff --git a/mm/memory-failure.c b/mm/memory-failure.c > index b91a33fb6c69..9ee176fcc949 100644 > --- a/mm/memory-failure.c > +++ b/mm/memory-failure.c > @@ -1561,6 +1561,10 @@ static int get_hwpoison_page(struct page *p, unsigned long flags) > return ret; > } > > +/* > + * The caller must guarantee the folio isn't large folio. try_to_unmap() > + * can't handle it. Not completely accurate: it may be a hugetlb folios, that is also large, but supported. "isn't a large folio, except hugetlb." -- Cheers, David / dhildenb