From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B9DC00140 for ; Wed, 24 Aug 2022 06:44:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 739DE6B0073; Wed, 24 Aug 2022 02:44:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E94B940007; Wed, 24 Aug 2022 02:44:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5D6C26B0075; Wed, 24 Aug 2022 02:44:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4DB416B0073 for ; Wed, 24 Aug 2022 02:44:40 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 24AFD1C5EFA for ; Wed, 24 Aug 2022 06:44:40 +0000 (UTC) X-FDA: 79833547920.07.A67CD46 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf01.hostedemail.com (Postfix) with ESMTP id 096E94003B for ; Wed, 24 Aug 2022 06:44:33 +0000 (UTC) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4MCGg16b93zXdVC; Wed, 24 Aug 2022 14:39:57 +0800 (CST) Received: from kwepemm600017.china.huawei.com (7.193.23.234) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 24 Aug 2022 14:44:11 +0800 Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 24 Aug 2022 14:44:09 +0800 Message-ID: <98f73fd6-1fe7-0760-167b-fd958154c91f@huawei.com> Date: Wed, 24 Aug 2022 14:44:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH -next v7 0/4]arm64: add machine check safe support To: Mark Rutland , James Morse , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Robin Murphy , Dave Hansen , Catalin Marinas , Will Deacon , Alexander Viro , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , , "H . Peter Anvin" CC: , , , , Kefeng Wang , Xie XiuQi , Guohanjun References: <20220812070557.1028499-1-tongtiangen@huawei.com> From: Tong Tiangen In-Reply-To: <20220812070557.1028499-1-tongtiangen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600017.china.huawei.com (7.193.23.234) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661323479; a=rsa-sha256; cv=none; b=oMv3jk+Ix9gKtW9WGBBcVzNOPKYK6ooRUYKx0/0e9zDmkHUfxZNmTCK5TIYybu353hKtbq a0PWC5i9WDRIF+eD0GJfYhEaVUPSfdi5vCMzfzWBwL8Mu/vBuPXe53Qgr24JyX+LPxKvMU 5z3th6NJRua6VmKql34CrkONWsxu7fY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661323479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Xz+IXvW7eBjNH6PaTJqtvdF8z25VxW8VleFvIwhF3OA=; b=Snmz5rgpUwhFvw24atxqsJGQKRlefOQ/JTduH0Efm5bSTwUoYKOC43/mh1PLhkBH+qqw4S AAXGVIHZbDHGtItVCSNKBwWgqXtEAiuI4e4+tdti4S2+I0NDCSybzr3v1IJcdeQNg6Qp44 Zp/FIJmUcyjtdZVBzY/pjcDqU9CYXMs= X-Stat-Signature: gnjmn8fpjf187is1bjrb68gxjrnfkr1g X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 096E94003B Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com X-HE-Tag: 1661323473-837430 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mark & Catalin & Will: Kindly ping... Thanks, Tong. 在 2022/8/12 15:05, Tong Tiangen 写道: > With the increase of memory capacity and density, the probability of > memory error increases. The increasing size and density of server RAM > in the data center and cloud have shown increased uncorrectable memory > errors. > > Currently, the kernel has a mechanism to recover from hardware memory > errors. This patchset provides an new recovery mechanism. > > For arm64, the hardware memory error handling is do_sea() which divided > into two cases: > 1. The user state consumed the memory errors, the solution is kill the > user process and isolate the error page. > 2. The kernel state consumed the memory errors, the solution is panic. > > For case 2, Undifferentiated panic maybe not the optimal choice, it can be > handled better, in some scenarios, we can avoid panic, such as uaccess, if the > uaccess fails due to memory error, only the user process will be affected, > kill the user process and isolate the user page with hardware memory errors > is a better choice. > > Since V6: > Resend patches that are not merged into the mainline in V6. > > Since V5: > 1. Add patch2/3 to add uaccess assembly helpers. > 2. Optimize the implementation logic of arm64_do_kernel_sea() in patch8. > 3. Remove kernel access fixup in patch9. > All suggestion are from Mark. > > Since V4: > 1. According Michael's suggestion, add patch5. > 2. According Mark's suggestiog, do some restructuring to arm64 > extable, then a new adaptation of machine check safe support is made based > on this. > 3. According Mark's suggestion, support machine check safe in do_mte() in > cow scene. > 4. In V4, two patches have been merged into -next, so V5 not send these > two patches. > > Since V3: > 1. According to Robin's suggestion, direct modify user_ldst and > user_ldp in asm-uaccess.h and modify mte.S. > 2. Add new macro USER_MC in asm-uaccess.h, used in copy_from_user.S > and copy_to_user.S. > 3. According to Robin's suggestion, using micro in copy_page_mc.S to > simplify code. > 4. According to KeFeng's suggestion, modify powerpc code in patch1. > 5. According to KeFeng's suggestion, modify mm/extable.c and some code > optimization. > > Since V2: > 1. According to Mark's suggestion, all uaccess can be recovered due to > memory error. > 2. Scenario pagecache reading is also supported as part of uaccess > (copy_to_user()) and duplication code problem is also solved. > Thanks for Robin's suggestion. > 3. According Mark's suggestion, update commit message of patch 2/5. > 4. According Borisllav's suggestion, update commit message of patch 1/5. > > Since V1: > 1.Consistent with PPC/x86, Using CONFIG_ARCH_HAS_COPY_MC instead of > ARM64_UCE_KERNEL_RECOVERY. > 2.Add two new scenes, cow and pagecache reading. > 3.Fix two small bug(the first two patch). > > V1 in here: > https://lore.kernel.org/lkml/20220323033705.3966643-1-tongtiangen@huawei.com/ > > Tong Tiangen (4): > uaccess: add generic fallback version of copy_mc_to_user() > arm64: add support for machine check error safe > arm64: add uaccess to machine check safe > arm64: add cow to machine check safe > > arch/arm64/Kconfig | 1 + > arch/arm64/include/asm/asm-extable.h | 5 ++ > arch/arm64/include/asm/assembler.h | 4 ++ > arch/arm64/include/asm/extable.h | 1 + > arch/arm64/include/asm/mte.h | 4 ++ > arch/arm64/include/asm/page.h | 10 ++++ > arch/arm64/lib/Makefile | 2 + > arch/arm64/lib/copy_page_mc.S | 82 ++++++++++++++++++++++++++++ > arch/arm64/lib/mte.S | 19 +++++++ > arch/arm64/mm/copypage.c | 37 +++++++++++-- > arch/arm64/mm/extable.c | 25 +++++++++ > arch/arm64/mm/fault.c | 29 +++++++++- > arch/powerpc/include/asm/uaccess.h | 1 + > arch/x86/include/asm/uaccess.h | 1 + > include/linux/highmem.h | 8 +++ > include/linux/uaccess.h | 9 +++ > mm/memory.c | 2 +- > 17 files changed, 233 insertions(+), 7 deletions(-) > create mode 100644 arch/arm64/lib/copy_page_mc.S >