From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C809BECE57A for ; Tue, 10 Sep 2024 15:05:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2BF848D0082; Tue, 10 Sep 2024 11:05:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26F7C8D0002; Tue, 10 Sep 2024 11:05:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 110378D0082; Tue, 10 Sep 2024 11:05:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EA2E38D0002 for ; Tue, 10 Sep 2024 11:05:47 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9A223A0619 for ; Tue, 10 Sep 2024 15:05:47 +0000 (UTC) X-FDA: 82549153134.23.ECEEE10 Received: from fout7-smtp.messagingengine.com (fout7-smtp.messagingengine.com [103.168.172.150]) by imf27.hostedemail.com (Postfix) with ESMTP id 3738540010 for ; Tue, 10 Sep 2024 15:05:44 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=TKIeRcGx; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="f 5weAyx"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf27.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.150 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725980740; a=rsa-sha256; cv=none; b=38bIngNMnnQdLhY2tCJLHs7cJORzwNLzUv6M7AouP8u79X8OFPwd4GCMbrL/PMWExYdocg mYinybE5O2l/ncoDaevgVfIaQxXbk6U3BxyNgmakPJC3I+yENQhi8uyFABekWYFGHySAfc VY3gpA3xnYSU6e4euXPyIJfjCLynri0= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=TKIeRcGx; dkim=pass header.d=messagingengine.com header.s=fm1 header.b="f 5weAyx"; dmarc=pass (policy=none) header.from=arndb.de; spf=pass (imf27.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.150 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725980740; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aIIu0Ly+LTke4nYzPkOGL+CoGg+fBzxtuvII4tt0pFA=; b=vGsEQhD1rh/fTJZoJGDO7JrHxFyqQtPBHK0gq6vsZpr0koOYv+6r+Qcj3rgw9Xq8kkgvgy GUDAvnyLISjSKQa0yALqT2NBDxjlOvzQ9cc9KA4lOs7VrFGRMsP5vgLe8JxW1hqbcet2gY ZezeT84VFZpLPgr/m0B4DosHiZ0eQUA= Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id 67FE71380176; Tue, 10 Sep 2024 11:05:43 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Tue, 10 Sep 2024 11:05:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1725980743; x=1726067143; bh=aIIu0Ly+LTke4nYzPkOGL+CoGg+fBzxtuvII4tt0pFA=; b= TKIeRcGxxxA5he/dnRdZ2te+hc5hNuBtTezAW1wsDFstqgzrqRzBZ+j8mVs3rr4Z KDMluqtZS+TdvbDXROzWloJBDniq/hvCl8b4JGFF6Jw4njH/K6Ov4l1ZQN6BMB+y jW7zu0CgYHTOJjfzxnFSpEOVNhW3Bifbw25iMAl9MthAuK17yVIVMvQC2zApQ8Sq bbCnKFmbsngz/Q/QS5l1XLnltk39wGT2RiIRzO10P1EZMCa8hIG/vaxTK32OF32j 94j0+qhdMSDJBzaPF7FT/9j4ZENHSbCpvEjp9bG2WrrnR5FhkCcOAdN0jkEzlwtJ PmFp4M7Z1xxdMyFDo+soeQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1725980743; x= 1726067143; bh=aIIu0Ly+LTke4nYzPkOGL+CoGg+fBzxtuvII4tt0pFA=; b=f 5weAyxrqHFDeYpd9yydOntLn30r5UxkIx2/59Ft+qU0+C238PZ71DabjaCBE5qQz o0IzAHP6ZNhQCo/MMkqSHN/IEa2UV29Rq7nvy8ua7wL1aOgHl6eBwn5JGiMxg/kt Mmi2IGQCyL4B2eUfLynL/THTvBNvQIckjsfEBq5rkMV0MMyovslD9K4kuuleG8tl lpF0BR+VsFRkhVZj43f4rA8t/R9/O41sfizdgVNOlWdDP6SCUc/nTrYaooCw2fev L3Y2/tlLJY42Ucqz1oSHV9MVXvDZxZQou5zOA0Nhmsbm5QXpm8zrSGwFZ2ZSt3c6 vx0Z5ydNskyzQlc7ToRVA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudeiledgjeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvfevkfgjfhfutgfgsehtqhertdertdej necuhfhrohhmpedftehrnhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrd guvgeqnecuggftrfgrthhtvghrnhepvdfhvdekueduveffffetgfdvveefvdelhedvvdeg jedvfeehtdeggeevheefleejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomheprghrnhgusegrrhhnuggsrdguvgdpnhgspghrtghpthhtohepvddt pdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegsphesrghlihgvnhekrdguvgdprh gtphhtthhopehvihhntggvnhiiohdrfhhrrghstghinhhosegrrhhmrdgtohhmpdhrtghp thhtoheptghhrhhishhtohhphhgvrdhlvghrohihsegtshhgrhhouhhprdgvuhdprhgtph htthhopehmrghthhhivghurdguvghsnhhohigvrhhssegvfhhfihgtihhoshdrtghomhdp rhgtphhtthhopehmphgvsegvlhhlvghrmhgrnhdrihgurdgruhdprhgtphhtthhopehnph highhgihhnsehgmhgrihhlrdgtohhmpdhrtghpthhtoheprhhoshhtvgguthesghhoohgu mhhishdrohhrghdprhgtphhtthhopehluhhtoheskhgvrhhnvghlrdhorhhgpdhrtghpth htohepmhhhihhrrghmrghtsehkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 22561222006F; Tue, 10 Sep 2024 11:05:42 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Tue, 10 Sep 2024 15:05:16 +0000 From: "Arnd Bergmann" To: "Christophe Leroy" , "Vincenzo Frascino" , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: "Andy Lutomirski" , "Thomas Gleixner" , "Jason A . Donenfeld" , "Michael Ellerman" , "Nicholas Piggin" , "Naveen N Rao" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , "H. Peter Anvin" , "Theodore Ts'o" , "Andrew Morton" , "Steven Rostedt" , "Masami Hiramatsu" , "Mathieu Desnoyers" Message-Id: <98dc5b85-fdf4-4664-8cca-e6c9e1f8eb14@app.fastmail.com> In-Reply-To: <2234a5e1-5926-4b2d-a8f2-c780bf374a27@csgroup.eu> References: <20240903151437.1002990-1-vincenzo.frascino@arm.com> <20240903151437.1002990-4-vincenzo.frascino@arm.com> <11527a80-7453-4624-b406-e88c5692b015@app.fastmail.com> <8868ef2c-6bfb-4ab7-ac5e-640e05658ee1@app.fastmail.com> <2234a5e1-5926-4b2d-a8f2-c780bf374a27@csgroup.eu> Subject: Re: [PATCH 3/9] x86: vdso: Introduce asm/vdso/page.h Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: ymb9fr7ns5wbcum8exuohewsp4mxuab6 X-Rspamd-Queue-Id: 3738540010 X-Rspamd-Server: rspam02 X-HE-Tag: 1725980744-650555 X-HE-Meta: U2FsdGVkX18sYkNBAoS9+YUKJDXgrjdlfsTMZBh/eGUTVzHTGV0sjtYKoM4PweEUV8xKXsQVknZcr6/04sI9V95c90Ww6ykk5rqKNoSu6Ec9m3PU295WpAoJORYJsfhAn7WdtP+DRvwaeMhwOTNevCgUponoEV2uXOPLY55xgEnKKAO40oy2GnSchkTnMy3jzakYQYC/kwKhyW9n1Yt2c8j6w5yZ7b3ZvxLgLO90/XhG511CLrZ5lWPgcgVGhR/+KGculIbrr02LNxevhq6/7XOSUItmiqOLj9OPTz6ur/JS2tp+MsDKUgzcvK4Bahe83DIR1oOx5mMGZe2T8s6wpGAPbrhVBQLHFfMcHHd66cNmR92u/hhgrrARI7pkiCszBwqmu/anCodNQywmGcGhldIiPBMEmWaOySPCOxy+5rdGiAy9f8DJNYCTbj8hQRBOARLFhnupm0YyZVqq6pwo67JkiZ2BRx/wjhYOP/hJgX/Ql1jm3E3H3fqMitVYJ+UmexoSDEE3GnTAm0OeTOpNojmAEGsUnwTfu8DIkNu75el9dMmiTjiLVAPNM8WP4G9PPkrPr3iPrMo3lHhr2Yf6fMfKPufX4tOc0FCzGs9iADqbjVJ5aEwjBZ0bNiVRdLQifjokCYgPQKZIu45Qq3pZU50jbPe4HjVfXVDBp0kinAebdiGAdfuBw6SAOdh7zY/ipQ93ULyyLE0stnOr2eUNXRA7dBGZY4qOb/Wx8FPOmH6ixTDEarYWtYrg0nQAOPVXF15qq5lo7uk4KXhw0cJs/UTUo2n4lM4qOQqJ2GgTaVwZVJoC0g40Y1h/GcNdPZeHCOIkbIa/UaFsOqTUYc5qU0u9D1rUDcvMINViZ+cO564bykcxPCS7x7xUvnlJPF4kqNbwiHuf2jxje+2rlpu8uwrMz7vFCBCYEbFU7JfrqxzQUhqzhppDEBsVqCHrNRBhwdQZDSHU/3jwof59pC4 RnE62pEA GLY0/GzYT4XGpiRviaduOXsW1Wzb/eKMuQJRSAetwB4g7HuPuBwZ4PCrNTA76p579M0KcyssmvzSm6CElLP9Z8L03RJQy4urpNw4OPHgqYib6lSAGonakmFzsSRGS5N+S4OcMJTMVeIlmroUKkwQlfDvV+Gqfkzj/Xmf+aIMQMdUlkpm5QuRzl4mw7jFN91oTLJBGJ+n8WJ5TumGegWcHvIFeU/naCwj8qDwO7DefYXHKxd0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 10, 2024, at 12:28, Christophe Leroy wrote: > Le 08/09/2024 =C3=A0 22:48, Arnd Bergmann a =C3=A9crit=C2=A0: >> On Fri, Sep 6, 2024, at 18:40, Christophe Leroy wrote: > > uiomem->addr is a phys_addr_t > r->start is a ressource_size_t hence a phys_addr_t > > And phys_addr_t is defined as: > > #ifdef CONFIG_PHYS_ADDR_T_64BIT > typedef u64 phys_addr_t; > #else > typedef u32 phys_addr_t; > #endif > > On a 32 bits platform, UL is unsigned 32 bits, so the r->start &=20 > PAGE_MASK will and r->start with 0x00000000fffff000 > > That is wrong. Right, I see. So out of the five 32-bit architectures with a 64-bit phys_addr_t, arc seems to ignore this problem, x86 has a separate PHYSICAL_PAGE_MASK for its internal uses and the other three have the definition you mention as > (~((1 << PAGE_SHIFT) - 1)) And this is only documented properly on powerpc. How about making the common definition this? #ifdef CONFIG_PHYS_ADDR_T_64BIT #define PAGE_MASK (~((1 << PAGE_SHIFT) - 1)) #else #define PAGE_MASK (~(PAGE_SIZE-1)) #endif That keeps it unchanged for everything other than arc and x86-32, and hopefully fixes the currently behavior on those two. Arnd